103634 2012-11-29 06:52:48 -0800 [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI 2012-11-30 01:46:46 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 778974 0 naginenis 2012-11-29 06:52:48 -0800 Add support for PlatformWebView::simulateRightClick() and enable WebKit2 unit test that uses it. 778988 1 176726 naginenis 2012-11-29 07:14:24 -0800 Created attachment 176726 Patch 779926 2 176726 gyuyoung.kim 2012-11-30 01:17:18 -0800 Comment on attachment 176726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105 > +void PlatformWebView::simulateRightClick(unsigned x, unsigned y) Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function. void mouseClick(int x, int y, int button = 1 /*Left*/); 779932 3 176726 naginenis 2012-11-30 01:35:05 -0800 Comment on attachment 176726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review >> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105 >> +void PlatformWebView::simulateRightClick(unsigned x, unsigned y) > > Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function. > > void mouseClick(int x, int y, int button = 1 /*Left*/); Left click is not required. API test expects only the right click. 779939 4 176726 webkit.review.bot 2012-11-30 01:46:42 -0800 Comment on attachment 176726 Patch Clearing flags on attachment: 176726 Committed r136217: <http://trac.webkit.org/changeset/136217> 779940 5 webkit.review.bot 2012-11-30 01:46:46 -0800 All reviewed patches have been landed. Closing bug. 176726 2012-11-29 07:14:24 -0800 2012-11-30 01:46:42 -0800 Patch 103634.patch text/plain 2399 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0MGJl NWRlLi5kNjE1NTE5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTItMTEtMjkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CiAKKyAgICAgICAgW0VGTF1bV0syXSBBZGQg c3VwcG9ydCBmb3IgUGxhdGZvcm1XZWJWaWV3OjpzaW11bGF0ZVJpZ2h0Q2xpY2soKSBpbiBUZXN0 V2ViS2l0QVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDM2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgUGxhdGZvcm1XZWJWaWV3OjpzaW11bGF0ZVJpZ2h0Q2xpY2soKSBh bmQgZW5hYmxlCisgICAgICAgIFdlYktpdDIgQVBJIHRlc3QgSGl0VGVzdFJlc3VsdE5vZGVIYW5k bGUuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNtYWtlOgorICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvZWZsL1BsYXRmb3JtV2ViVmlldy5jcHA6CisgICAgICAgIChUZXN0 V2ViS2l0QVBJOjpQbGF0Zm9ybVdlYlZpZXc6OnNpbXVsYXRlUmlnaHRDbGljayk6CisgICAgICAg IChUZXN0V2ViS2l0QVBJKToKKworMjAxMi0xMS0yOSAgU3VkYXJzYW5hIE5hZ2luZW5pICA8c3Vk YXJzYW5hLm5hZ2luZW5pQGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIEFkZCBzdXBw b3J0IGZvciBQbGF0Zm9ybVdlYlZpZXc6OnNpbXVsYXRlTW91c2VNb3ZlKCkgaW4gVGVzdFdlYktp dEFQSQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz MjUyCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2Ug Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGUzMDE5NjguLmIx YWE1NzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1FZmwuY21ha2UK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtNTUsNiArNTUs NyBAQCBTRVQodGVzdF93ZWJraXQyX2FwaV9CSU5BUklFUwogICAgIEZyYW1lTUlNRVR5cGVIVE1M CiAgICAgRnJhbWVNSU1FVHlwZVBORwogICAgIEdldEluamVjdGVkQnVuZGxlSW5pdGlhbGl6YXRp b25Vc2VyRGF0YUNhbGxiYWNrCisgICAgSGl0VGVzdFJlc3VsdE5vZGVIYW5kbGUKICAgICBJbmpl Y3RlZEJ1bmRsZUJhc2ljCiAgICAgSW5qZWN0ZWRCdW5kbGVJbml0aWFsaXphdGlvblVzZXJEYXRh Q2FsbGJhY2tXaW5zCiAgICAgTG9hZEFsdGVybmF0ZUhUTUxTdHJpbmdXaXRoTm9uRGlyZWN0b3J5 VVJMCkBAIC05MCw3ICs5MSw2IEBAIEFERF9ERUZJTklUSU9OUygtRFRIRU1FX0RJUj0iJHtUSEVN RV9CSU5BUllfRElSfSIpCiAKICMgVGVzdHMgZGlzYWJsZWQgYmVjYXVzZSBvZiBtaXNzaW5nIGZl YXR1cmVzIG9uIHRoZSB0ZXN0IGhhcm5lc3M6CiAjCi0jICAgSGl0VGVzdFJlc3VsdE5vZGVIYW5k bGUKICMgICBSZXNwb25zaXZlbmVzc1RpbWVyRG9lc250RmlyZUVhcmx5CiAjICAgU3BhY2ViYXJT Y3JvbGxpbmcKICMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZWZsL1BsYXRmb3Jt V2ViVmlldy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2VmbC9QbGF0Zm9ybVdlYlZpZXcuY3Bw CmluZGV4IGNkYzk3YmQuLjA4NDA3YzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv ZWZsL1BsYXRmb3JtV2ViVmlldy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9lZmwvUGxh dGZvcm1XZWJWaWV3LmNwcApAQCAtMTAyLDQgKzEwMiwxMyBAQCB2b2lkIFBsYXRmb3JtV2ViVmll dzo6c2ltdWxhdGVNb3VzZU1vdmUodW5zaWduZWQgeCwgdW5zaWduZWQgeSkKICAgICBldmFzX2V2 ZW50X2ZlZWRfbW91c2VfbW92ZShldmFzLCB4LCB5LCAwLCAwKTsKIH0KIAordm9pZCBQbGF0Zm9y bVdlYlZpZXc6OnNpbXVsYXRlUmlnaHRDbGljayh1bnNpZ25lZCB4LCB1bnNpZ25lZCB5KQorewor ICAgIEV2YXMqIGV2YXMgPSBlY29yZV9ldmFzX2dldChtX3dpbmRvdyk7CisgICAgZXZhc19vYmpl Y3Rfc2hvdyhtX3ZpZXcpOworICAgIGV2YXNfZXZlbnRfZmVlZF9tb3VzZV9tb3ZlKGV2YXMsIHgs IHksIDAsIDApOworICAgIGV2YXNfZXZlbnRfZmVlZF9tb3VzZV9kb3duKGV2YXMsIDMsIEVWQVNf QlVUVE9OX05PTkUsIDAsIDApOworICAgIGV2YXNfZXZlbnRfZmVlZF9tb3VzZV91cChldmFzLCAz LCBFVkFTX0JVVFRPTl9OT05FLCAwLCAwKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktp dEFQSQo=