103630 2012-11-29 06:02:01 -0800 [Qt] Remove an unnecessary masking from swapBgrToRgb() 2012-12-03 02:16:13 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned dino hausmann noam webkit.review.bot zherczeg oldest_to_newest 778954 0 rgabor 2012-11-29 06:02:01 -0800 Now swapBgrToRgb() make two masking to get R and B components to the right place: return ((pixel << 16) & 0xff0000) | ((pixel >> 16) & 0xff) | (pixel & 0xff00ff00); We can get the same result with just one: return (((pixel << 16) | (pixel >> 16)) & 0x00ff00ff) | (pixel & 0xff00ff00); 778957 1 176713 rgabor 2012-11-29 06:12:45 -0800 Created attachment 176713 proposed patch 781233 2 176713 zherczeg 2012-12-03 01:50:51 -0800 Comment on attachment 176713 proposed patch r=me 781248 3 176713 webkit.review.bot 2012-12-03 02:16:09 -0800 Comment on attachment 176713 proposed patch Clearing flags on attachment: 176713 Committed r136375: <http://trac.webkit.org/changeset/136375> 781249 4 webkit.review.bot 2012-12-03 02:16:13 -0800 All reviewed patches have been landed. Closing bug. 176713 2012-11-29 06:12:45 -0800 2012-12-03 02:16:09 -0800 proposed patch swapBgrToRgb.patch text/plain 1321 rgabor SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjEyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTI5ICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFJlbW92ZSBhbiB1 bm5lY2Vzc2FyeSBtYXNraW5nIGZyb20gc3dhcEJnclRvUmdiKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCByaWQgb2YgYSBtYXNraW5nIGNvbW1h bmQgaW4gc3dhcEJnclRvUmdiKCkgdG8gc3BlZWQgdXAgYSBsaXR0bGUgYml0LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpzd2FwQmdyVG9SZ2IpOgorCiAyMDEyLTExLTI5ICBTaGVyaWZmIEJvdCAgPHdl YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTM2MTExLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv R3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAJKHJldmlzaW9uIDEzNjEy MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsNyArMjA0LDcgQEAgR3JhcGhpY3NDb250 ZXh0M0RQcml2YXRlOjp+R3JhcGhpY3NDb250ZQogCiBzdGF0aWMgaW5saW5lIHF1aW50MzIgc3dh cEJnclRvUmdiKHF1aW50MzIgcGl4ZWwpCiB7Ci0gICAgcmV0dXJuICgocGl4ZWwgPDwgMTYpICYg MHhmZjAwMDApIHwgKChwaXhlbCA+PiAxNikgJiAweGZmKSB8IChwaXhlbCAmIDB4ZmYwMGZmMDAp OworICAgIHJldHVybiAoKChwaXhlbCA8PCAxNikgfCAocGl4ZWwgPj4gMTYpKSAmIDB4MDBmZjAw ZmYpIHwgKHBpeGVsICYgMHhmZjAwZmYwMCk7CiB9CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCg==