103629 2012-11-29 04:30:17 -0800 Fix the build after r136095 2012-11-29 10:23:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abucur abucur ap mrowe sam webkit.review.bot oldest_to_newest 778911 0 abucur 2012-11-29 04:30:17 -0800 WebKit doesn't compile due to a type error. 778913 1 176701 abucur 2012-11-29 04:39:38 -0800 Created attachment 176701 Patch 778927 2 176701 jochen 2012-11-29 05:00:04 -0800 Comment on attachment 176701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176701&action=review > Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97 > + [NSException raise:NSInvalidArgumentException format:@"Can not encode objects of class type '%@'", static_cast<NSString *>(NSStringFromClass([m_root class]))]; that's most certainly the wrong fix. I think instead, this file should #import <Foundation/Foundation.h> 778943 3 abucur 2012-11-29 05:30:27 -0800 (In reply to comment #2) > (From update of attachment 176701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176701&action=review > > > Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97 > > + [NSException raise:NSInvalidArgumentException format:@"Can not encode objects of class type '%@'", static_cast<NSString *>(NSStringFromClass([m_root class]))]; > > that's most certainly the wrong fix. I think instead, this file should #import <Foundation/Foundation.h> Tried it and this is not the issue. You can put the NSStringFromClass return value in a NSString variable and then pass that to the formatter and it will work. I like this fix more though. 779124 4 176701 ap 2012-11-29 10:04:56 -0800 Comment on attachment 176701 Patch Failing on Lion and Mountain Lion bots. I can't reproduce locally, and have no idea why this fails, but we have to get it building again. /Volumes/Data/slave/mountainlion-debug/build/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97:107: error: format specifies type 'id' but the argument has type '<dependent type>' [-Werror,-Wformat] 779142 5 176701 webkit.review.bot 2012-11-29 10:23:20 -0800 Comment on attachment 176701 Patch Clearing flags on attachment: 176701 Committed r136141: <http://trac.webkit.org/changeset/136141> 779143 6 webkit.review.bot 2012-11-29 10:23:23 -0800 All reviewed patches have been landed. Closing bug. 176701 2012-11-29 04:39:38 -0800 2012-11-29 10:23:20 -0800 Patch bug-103629-20121129143711.patch text/plain 1508 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI3ZDBiZTllYThhYzNh NzIwOWMxZTI2ZDk4MzY1NTYyOWNhMDkyOC4uZDUyOTVlZDNiOWJiMDVhZDI1NGEyZmIwYmMyNGYw ZjcxN2IwMzkwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTI5ICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIEZpeCB0aGUgYnVpbGQgYWZ0 ZXIgcjEzNjA5NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTAzNjI5CisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICBBZGQgYSBzdGF0aWNf Y2FzdCB0byBmaXggdGhlIGJ1aWxkLgorCisgICAgICAgICogU2hhcmVkL21hYy9PYmpDT2JqZWN0 R3JhcGhDb2RlcnMubW06CisgICAgICAgIChXZWJLaXQ6Ok9iakNPYmplY3RHcmFwaEVuY29kZXI6 OmJhc2VFbmNvZGUpOgorCiAyMDEyLTExLTI5ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lA ZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gRml4IGluc3RhbGxhdGlvbiBvZiBRdFdlYlByb2Nl c3MgYmluYXJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL09iakNPYmpl Y3RHcmFwaENvZGVycy5tbSBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVjdEdy YXBoQ29kZXJzLm1tCmluZGV4IGQxOWU5ODFhNWMyNzgwZjVjZTU2ZjI1OTgxYmM3NjNkMjY5MGEx OTEuLmQzMGU3ZTFhMWNlNWYzZmI3MGQxZTc3M2U3ZWRiOTRjZWUyNDBlOWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVjdEdyYXBoQ29kZXJzLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVjdEdyYXBoQ29kZXJzLm1tCkBAIC05 NCw3ICs5NCw3IEBAIHB1YmxpYzoKIAogICAgICAgICB0eXBlID0gdHlwZUZyb21PYmplY3QobV9y b290KTsKICAgICAgICAgaWYgKHR5cGUgPT0gVW5rbm93blR5cGUpIHsKLSAgICAgICAgICAgIFtO U0V4Y2VwdGlvbiByYWlzZTpOU0ludmFsaWRBcmd1bWVudEV4Y2VwdGlvbiBmb3JtYXQ6QCJDYW4g bm90IGVuY29kZSBvYmplY3RzIG9mIGNsYXNzIHR5cGUgJyVAJyIsIE5TU3RyaW5nRnJvbUNsYXNz KFttX3Jvb3QgY2xhc3NdKV07CisgICAgICAgICAgICBbTlNFeGNlcHRpb24gcmFpc2U6TlNJbnZh bGlkQXJndW1lbnRFeGNlcHRpb24gZm9ybWF0OkAiQ2FuIG5vdCBlbmNvZGUgb2JqZWN0cyBvZiBj bGFzcyB0eXBlICclQCciLCBzdGF0aWNfY2FzdDxOU1N0cmluZyAqPihOU1N0cmluZ0Zyb21DbGFz cyhbbV9yb290IGNsYXNzXSkpXTsKICAgICAgICAgfQogCiAgICAgICAgIGVuY29kZXIgPDwgc3Rh dGljX2Nhc3Q8dWludDMyX3Q+KHR5cGUpOwo=