103622 2012-11-29 02:32:48 -0800 Fix typo in description of openDateTimeChooser documentation 2012-11-29 03:06:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 miguelg miguelg tkent webkit.review.bot oldest_to_newest 778852 0 miguelg 2012-11-29 02:32:48 -0800 Fix typo in description of openDateTimeChooser documentation 778853 1 176682 miguelg 2012-11-29 02:33:18 -0800 Created attachment 176682 Patch 778854 2 miguelg 2012-11-29 02:34:18 -0800 Something I noticed while working on the android implementation 778855 3 176682 tkent 2012-11-29 02:35:34 -0800 Comment on attachment 176682 Patch ok 778857 4 176682 peter 2012-11-29 02:38:49 -0800 Comment on attachment 176682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176682&action=review Setting cq+ as I'm sure you want someone to do that anyway :-). > Source/WebKit/chromium/ChangeLog:3 > + Fix typo in description of openDateTimeChooser documentation nit for next time: Since this only touches Chromium code (in Source/WebKit/chromium), it generally is a good idea to prefix it with [Chromium] so other vendors know they don't have to care. 778878 5 176682 webkit.review.bot 2012-11-29 03:06:22 -0800 Comment on attachment 176682 Patch Clearing flags on attachment: 176682 Committed r136118: <http://trac.webkit.org/changeset/136118> 778879 6 webkit.review.bot 2012-11-29 03:06:26 -0800 All reviewed patches have been landed. Closing bug. 176682 2012-11-29 02:33:18 -0800 2012-11-29 03:06:22 -0800 Patch bug-103622-20121129103051.patch text/plain 1591 miguelg U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFjNjNlODE2ZDc5NGY2NDY2ZGE0ZjVlM2FiZTFiNjViYWQ0ZDk0MmYuLjY1ZjhjMDNkN2JmYThm NWQyODYwNDFmN2NlYzgyMWUxN2Y5OThkNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMjkgIE1pZ3VlbCBHYXJjaWEgIDxtaWd1ZWxnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBGaXggdHlwbyBpbiBkZXNjcmlwdGlvbiBvZiBvcGVuRGF0ZVRp bWVDaG9vc2VyIGRvY3VtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2Vi Vmlld0NsaWVudCk6CisKIDIwMTItMTEtMjggIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCB1bml0IHRlc3RzIGZvciBDaHJvbWVDbGll bnRJbXBsOjpnZXROYXZpZ2F0aW9uUG9saWN5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJWaWV3Q2xpZW50LmgKaW5kZXggNWIzY2JjMGIxNzAzZjQ1ZjY3YmE3N2ExNDIyNjZl ODZhNGE5OTA5Ny4uYzZlMTc1ZGJhZGU5YzU1YWU5NmVkNThlNDcyNzM4NTIwZGRhOTI3MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMjI1 LDcgKzIyNSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2Vi RmlsZUNob29zZXJDb21wbGV0aW9uKikgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIC8vIEFzayB1 c2VycyB0byBjaG9vc2UgZGF0ZS90aW1lIGZvciB0aGUgc3BlY2lmaWVkIHBhcmFtZXRlcnMuIFdo ZW4gYSB1c2VyCi0gICAgLy8gY2hvb3NlcyBhIHZhbHVlLCBhbiBpbXBsZW1lbmF0dGlvbiBvZiB0 aGlzIGZ1bmN0aW9uIHNob3VsZCBjYWxsCisgICAgLy8gY2hvb3NlcyBhIHZhbHVlLCBhbiBpbXBs ZW1lbnRhdGlvbiBvZiB0aGlzIGZ1bmN0aW9uIHNob3VsZCBjYWxsCiAgICAgLy8gV2ViRGF0ZVRp bWVDaG9vc2VyQ29tcGxldGlvbjo6ZGlkQ2hvb3NlVmFsdWUgb3IgZGlkQ2FuY2VsQ2hvb3Nlci4g SWYgdGhlCiAgICAgLy8gaW1wbGVtZW50YXRpb24gb3BlbmVkIGRhdGUvdGltZSBjaG9vc2VyIFVJ IHN1Y2Nlc3NmdWxseSwgaXQgc2hvdWxkIHJldHVybgogICAgIC8vIHRydWUuIFRoaXMgZnVuY3Rp b24gaXMgdXNlZCBvbmx5IGlmIEV4dGVybmFsRGF0ZVRpbWVDaG9vc2VyIGlzIHVzZWQuCg==