103588 2012-11-28 18:33:29 -0800 Change Bytecompiler s_dumpsGeneratedCode to an Options value 2012-11-29 10:23:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff roger_fong thorton webkit.review.bot oldest_to_newest 778593 0 msaboff 2012-11-28 18:33:29 -0800 The diagnostic dumping of bytecodes at compile time is controlled bu the static s_dumpsGeneratedCode in BytecodeGenerator.cpp. It has a setter and getter. This should all be changed to use the Options class to be consistent with other similar optional behavior. 778597 1 176624 msaboff 2012-11-28 18:36:17 -0800 Created attachment 176624 Patch 778606 2 176624 webkit.review.bot 2012-11-28 19:16:59 -0800 Comment on attachment 176624 Patch Clearing flags on attachment: 176624 Committed r136086: <http://trac.webkit.org/changeset/136086> 778607 3 webkit.review.bot 2012-11-28 19:17:02 -0800 All reviewed patches have been landed. Closing bug. 778623 4 thorton 2012-11-28 20:03:21 -0800 I think this broke Windows: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/58714/steps/compile-webkit/logs/stdio 779145 5 msaboff 2012-11-29 10:23:57 -0800 (In reply to comment #4) > I think this broke Windows: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/58714/steps/compile-webkit/logs/stdio Landed speculative build fix in r136140 <http://trac.webkit.org/changeset/136140>. 176624 2012-11-28 18:36:17 -0800 2012-11-28 19:16:59 -0800 Patch 103588.patch text/plain 4265 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM2MDg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEyLTExLTI4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENoYW5nZSBCeXRlY29tcGlsZXIgc19kdW1wc0dlbmVyYXRlZENvZGUgdG8gYW4gT3B0aW9u cyB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzNTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TW92ZWQgdGhlIGNvbnRyb2wgb2YgZHVtcGluZyBieXRlY29kZXMgdG8gT3B0aW9uczo6ZHVtcEdl bmVyYXRlZEJ5dGVjb2Rlcy4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6Cisg ICAgICAgIChKU0M6OkNvZGVCbG9jazo6Q29kZUJsb2NrKToKKyAgICAgICAgKiBieXRlY29tcGls ZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5oOgorICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgIChydW5XaXRoU2NyaXB0 cyk6CisgICAgICAgICogcnVudGltZS9PcHRpb25zLmg6CisKIDIwMTItMTEtMjggIE1hcmsgSGFo bmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBDb3B5aW5nIHBoYXNl IHNob3VsZCB1c2Ugd29yayBsaXN0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9u IDEzNjA2NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01NDAsNyArNTQwLDcgQEAgc3RhdGljIGJvb2wgcnVuV2l0aFNjcmlwdHMoR2xvYmFsT2Jq ZWN0KgogICAgIFZlY3RvcjxjaGFyPiBzY3JpcHRCdWZmZXI7CiAKICAgICBpZiAoZHVtcCkKLSAg ICAgICAgQnl0ZWNvZGVHZW5lcmF0b3I6OnNldER1bXBzR2VuZXJhdGVkQ29kZSh0cnVlKTsKKyAg ICAgICAgSlNDOjpPcHRpb25zOjpkdW1wR2VuZXJhdGVkQnl0ZWNvZGVzKCkgPSB0cnVlOwogCiAg ICAgSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhID0gZ2xvYmFsT2JqZWN0LT5nbG9iYWxEYXRhKCk7 CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3Bw CShyZXZpc2lvbiAxMzYwNjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg5MSw3ICsxODkxLDcgQEAgQ29kZUJsb2Nr OjpDb2RlQmxvY2soU2NyaXB0RXhlY3V0YWJsZSogbwogICAgIH0KICAgICBtX2luc3RydWN0aW9u cyA9IFdURjo6UmVmQ291bnRlZEFycmF5PEluc3RydWN0aW9uPihpbnN0cnVjdGlvbnMpOwogCi0g ICAgaWYgKEJ5dGVjb2RlR2VuZXJhdG9yOjpkdW1wc0dlbmVyYXRlZENvZGUoKSkKKyAgICBpZiAo T3B0aW9uczo6ZHVtcEdlbmVyYXRlZEJ5dGVjb2RlcygpKQogICAgICAgICBkdW1wKCk7CiAgICAg bV9nbG9iYWxEYXRhLT5maW5pc2hlZENvbXBpbGluZyh0aGlzKTsKIH0KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0 b3IuY3BwCShyZXZpc2lvbiAxMzYwNjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv bXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgs NyBAQAogI2luY2x1ZGUgIkpTRnVuY3Rpb24uaCIKICNpbmNsdWRlICJKU05hbWVTY29wZS5oIgog I2luY2x1ZGUgIkxvd0xldmVsSW50ZXJwcmV0ZXIuaCIKKyNpbmNsdWRlICJPcHRpb25zLmgiCiAj aW5jbHVkZSAiU3Ryb25nSW5saW5lcy5oIgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5o PgogCkBAIC0xNDYsMTggKzE0Nyw2IEBAIHZvaWQgUmVzb2x2ZVJlc3VsdDo6Y2hlY2tWYWxpZGl0 eSgpCiB9CiAjZW5kaWYKIAotc3RhdGljIGJvb2wgc19kdW1wc0dlbmVyYXRlZENvZGUgPSBmYWxz ZTsKLQotdm9pZCBCeXRlY29kZUdlbmVyYXRvcjo6c2V0RHVtcHNHZW5lcmF0ZWRDb2RlKGJvb2wg ZHVtcHNHZW5lcmF0ZWRDb2RlKQotewotICAgIHNfZHVtcHNHZW5lcmF0ZWRDb2RlID0gZHVtcHNH ZW5lcmF0ZWRDb2RlOwotfQotCi1ib29sIEJ5dGVjb2RlR2VuZXJhdG9yOjpkdW1wc0dlbmVyYXRl ZENvZGUoKQotewotICAgIHJldHVybiBzX2R1bXBzR2VuZXJhdGVkQ29kZTsKLX0KLQogUGFyc2Vy RXJyb3IgQnl0ZWNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlKCkKIHsKICAgICBTYW1wbGluZ1JlZ2lv biBzYW1wbGluZ1JlZ2lvbigiQnl0ZWNvZGUgR2VuZXJhdGlvbiIpOwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu aAkocmV2aXNpb24gMTM2MDY3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMDksOSArMjA5LDYgQEAg bmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHR5cGVkZWYgRGVjbGFyYXRpb25TdGFja3M6OlZhclN0 YWNrIFZhclN0YWNrOwogICAgICAgICB0eXBlZGVmIERlY2xhcmF0aW9uU3RhY2tzOjpGdW5jdGlv blN0YWNrIEZ1bmN0aW9uU3RhY2s7CiAKLSAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGlj IHZvaWQgc2V0RHVtcHNHZW5lcmF0ZWRDb2RlKGJvb2wgZHVtcHNHZW5lcmF0ZWRDb2RlKTsKLSAg ICAgICAgc3RhdGljIGJvb2wgZHVtcHNHZW5lcmF0ZWRDb2RlKCk7Ci0KICAgICAgICAgQnl0ZWNv ZGVHZW5lcmF0b3IoSlNHbG9iYWxEYXRhJiwgUHJvZ3JhbU5vZGUqLCBVbmxpbmtlZFByb2dyYW1D b2RlQmxvY2sqLCBEZWJ1Z2dlck1vZGUsIFByb2ZpbGVyTW9kZSk7CiAgICAgICAgIEJ5dGVjb2Rl R2VuZXJhdG9yKEpTR2xvYmFsRGF0YSYsIEZ1bmN0aW9uQm9keU5vZGUqLCBVbmxpbmtlZEZ1bmN0 aW9uQ29kZUJsb2NrKiwgRGVidWdnZXJNb2RlLCBQcm9maWxlck1vZGUpOwogICAgICAgICBCeXRl Y29kZUdlbmVyYXRvcihKU0dsb2JhbERhdGEmLCBFdmFsTm9kZSosIFVubGlua2VkRXZhbENvZGVC bG9jayosIERlYnVnZ2VyTW9kZSwgUHJvZmlsZXJNb2RlKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zLmgJKHJldmlzaW9uIDEzNjA2NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgs OCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICBcCiAgICAgdihib29sLCBmb3JjZURGR0NvZGVCbG9j a0xpdmVuZXNzLCBmYWxzZSkgXAogICAgIFwKKyAgICB2KGJvb2wsIGR1bXBHZW5lcmF0ZWRCeXRl Y29kZXMsIGZhbHNlKSBcCisgICAgXAogICAgIC8qIHNob3dEaXNhc3NlbWJseSBpbXBsaWVzIHNo b3dERkdEaXNhc3NlbWJseS4gKi8gXAogICAgIHYoYm9vbCwgc2hvd0Rpc2Fzc2VtYmx5LCBmYWxz ZSkgXAogICAgIHYoYm9vbCwgc2hvd0RGR0Rpc2Fzc2VtYmx5LCBmYWxzZSkgXAo=