103583 2012-11-28 17:35:08 -0800 Update String Stats for recent dataLog changes and add summary 2012-11-28 18:22:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin ojan webkit.review.bot oldest_to_newest 778537 0 msaboff 2012-11-28 17:35:08 -0800 Change set r135469 from https://bugs.webkit.org/show_bug.cgi?id=103001 renamed the dataLog functions by adding an 'F' (for file) to the name. The String Stats code in StringImpl.cpp did not get updated with that change. I also added a summary of savings in bytes and percent of memory to the total statistics to a local copy of StringImpl.cpp 778548 1 176616 msaboff 2012-11-28 17:45:03 -0800 Created attachment 176616 Patch 778584 2 176616 webkit.review.bot 2012-11-28 18:22:45 -0800 Comment on attachment 176616 Patch Clearing flags on attachment: 176616 Committed r136082: <http://trac.webkit.org/changeset/136082> 778585 3 webkit.review.bot 2012-11-28 18:22:48 -0800 All reviewed patches have been landed. Closing bug. 176616 2012-11-28 17:45:03 -0800 2012-11-28 18:22:45 -0800 Patch 103583.patch text/plain 4295 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzYwNzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI4ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBTdHJpbmcgU3RhdHMgZm9yIHJlY2Vu dCBkYXRhTG9nIGNoYW5nZXMgYW5kIGFkZCBzdW1tYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1ODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIGNhbGxzIHRvIGRhdGFMb2coKSB0byBk YXRhTG9nRigpIGFzIGEgcmVzdWx0cyBvZiByMTM1NDY5LgorICAgICAgICBBZGRlZCB0b3RhbCBz YXZpbmdzIGZyb20gOCBiaXQgc3RyaW5ncyBpbiBieXRlcyBhbmQgYXMgYSBwZXJjZW50YWdlLgor CisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6OlN0cmlu Z1N0YXRzOjpwcmludFN0YXRzKToKKwogMjAxMi0xMS0yOCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2Zv bmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgRGF0YUxvZyB3b3JrL2NvbXBpbGUgcHJvcGVy bHkgb24gV2luZG93cy4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAkocmV2aXNp b24gMTM2MDY3KQorKysgU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rl ck5hbWVzLmg+CiAKICNpZmRlZiBTVFJJTkdfU1RBVFMKKyNpbmNsdWRlIDx1bmlzdGQuaD4KICNp bmNsdWRlIDx3dGYvRGF0YUxvZy5oPgogI2VuZGlmCiAKQEAgLTgwLDIzICs4MSwyNyBAQCB2b2lk IFN0cmluZ1N0YXRzOjpyZW1vdmVTdHJpbmcoU3RyaW5nSW1wCiAKIHZvaWQgU3RyaW5nU3RhdHM6 OnByaW50U3RhdHMoKQogewotICAgIGRhdGFMb2coIlN0cmluZyBzdGF0cyBmb3IgcHJvY2VzcyBp ZCAlZDpcbiIsIGdldHBpZCgpKTsKKyAgICBkYXRhTG9nRigiU3RyaW5nIHN0YXRzIGZvciBwcm9j ZXNzIGlkICVkOlxuIiwgZ2V0cGlkKCkpOwogCiAgICAgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFs TnVtYmVyQ2hhcmFjdGVycyA9IG1fdG90YWw4Qml0RGF0YSArIG1fdG90YWwxNkJpdERhdGE7CiAg ICAgZG91YmxlIHBlcmNlbnQ4Qml0ID0gbV90b3RhbE51bWJlclN0cmluZ3MgPyAoKGRvdWJsZSlt X251bWJlcjhCaXRTdHJpbmdzICogMTAwKSAvIChkb3VibGUpbV90b3RhbE51bWJlclN0cmluZ3Mg OiAwLjA7CiAgICAgZG91YmxlIGF2ZXJhZ2U4Yml0TGVuZ3RoID0gbV9udW1iZXI4Qml0U3RyaW5n cyA/IChkb3VibGUpbV90b3RhbDhCaXREYXRhIC8gKGRvdWJsZSltX251bWJlcjhCaXRTdHJpbmdz IDogMC4wOwotICAgIGRhdGFMb2coIiU4dSAoJTUuMmYlJSkgOCBiaXQgICAgICAgICUxMmxsdSBj aGFycyAgJTEybGx1IGJ5dGVzICBhdmcgbGVuZ3RoICU2LjFmXG4iLCBtX251bWJlcjhCaXRTdHJp bmdzLCBwZXJjZW50OEJpdCwgbV90b3RhbDhCaXREYXRhLCBtX3RvdGFsOEJpdERhdGEsIGF2ZXJh Z2U4Yml0TGVuZ3RoKTsKKyAgICBkYXRhTG9nRigiJTh1ICglNS4yZiUlKSA4IGJpdCAgICAgICAg JTEybGx1IGNoYXJzICAlMTJsbHUgYnl0ZXMgIGF2ZyBsZW5ndGggJTYuMWZcbiIsIG1fbnVtYmVy OEJpdFN0cmluZ3MsIHBlcmNlbnQ4Qml0LCBtX3RvdGFsOEJpdERhdGEsIG1fdG90YWw4Qml0RGF0 YSwgYXZlcmFnZThiaXRMZW5ndGgpOwogCiAgICAgZG91YmxlIHBlcmNlbnQxNkJpdCA9IG1fdG90 YWxOdW1iZXJTdHJpbmdzID8gKChkb3VibGUpbV9udW1iZXIxNkJpdFN0cmluZ3MgKiAxMDApIC8g KGRvdWJsZSltX3RvdGFsTnVtYmVyU3RyaW5ncyA6IDAuMDsKICAgICBkb3VibGUgYXZlcmFnZTE2 Yml0TGVuZ3RoID0gbV9udW1iZXIxNkJpdFN0cmluZ3MgPyAoZG91YmxlKW1fdG90YWwxNkJpdERh dGEgLyAoZG91YmxlKW1fbnVtYmVyMTZCaXRTdHJpbmdzIDogMC4wOwotICAgIGRhdGFMb2coIiU4 dSAoJTUuMmYlJSkgMTYgYml0ICAgICAgICUxMmxsdSBjaGFycyAgJTEybGx1IGJ5dGVzICBhdmcg bGVuZ3RoICU2LjFmXG4iLCBtX251bWJlcjE2Qml0U3RyaW5ncywgcGVyY2VudDE2Qml0LCBtX3Rv dGFsMTZCaXREYXRhLCBtX3RvdGFsMTZCaXREYXRhICogMiwgYXZlcmFnZTE2Yml0TGVuZ3RoKTsK KyAgICBkYXRhTG9nRigiJTh1ICglNS4yZiUlKSAxNiBiaXQgICAgICAgJTEybGx1IGNoYXJzICAl MTJsbHUgYnl0ZXMgIGF2ZyBsZW5ndGggJTYuMWZcbiIsIG1fbnVtYmVyMTZCaXRTdHJpbmdzLCBw ZXJjZW50MTZCaXQsIG1fdG90YWwxNkJpdERhdGEsIG1fdG90YWwxNkJpdERhdGEgKiAyLCBhdmVy YWdlMTZiaXRMZW5ndGgpOwogCiAgICAgZG91YmxlIHBlcmNlbnRVcGNvbnZlcnRlZCA9IG1fdG90 YWxOdW1iZXJTdHJpbmdzID8gKChkb3VibGUpbV9udW1iZXJVcGNvbnZlcnRlZFN0cmluZ3MgKiAx MDApIC8gKGRvdWJsZSltX251bWJlcjhCaXRTdHJpbmdzIDogMC4wOwogICAgIGRvdWJsZSBhdmVy YWdlVXBjb252ZXJ0ZWRMZW5ndGggPSBtX251bWJlclVwY29udmVydGVkU3RyaW5ncyA/IChkb3Vi bGUpbV90b3RhbFVwY29udmVydGVkRGF0YSAvIChkb3VibGUpbV9udW1iZXJVcGNvbnZlcnRlZFN0 cmluZ3MgOiAwLjA7Ci0gICAgZGF0YUxvZygiJTh1ICglNS4yZiUlKSB1cGNvbnZlcnRlZCAgJTEy bGx1IGNoYXJzICAlMTJsbHUgYnl0ZXMgIGF2ZyBsZW5ndGggJTYuMWZcbiIsIG1fbnVtYmVyVXBj b252ZXJ0ZWRTdHJpbmdzLCBwZXJjZW50VXBjb252ZXJ0ZWQsIG1fdG90YWxVcGNvbnZlcnRlZERh dGEsIG1fdG90YWxVcGNvbnZlcnRlZERhdGEgKiAyLCBhdmVyYWdlVXBjb252ZXJ0ZWRMZW5ndGgp OworICAgIGRhdGFMb2dGKCIlOHUgKCU1LjJmJSUpIHVwY29udmVydGVkICAlMTJsbHUgY2hhcnMg ICUxMmxsdSBieXRlcyAgYXZnIGxlbmd0aCAlNi4xZlxuIiwgbV9udW1iZXJVcGNvbnZlcnRlZFN0 cmluZ3MsIHBlcmNlbnRVcGNvbnZlcnRlZCwgbV90b3RhbFVwY29udmVydGVkRGF0YSwgbV90b3Rh bFVwY29udmVydGVkRGF0YSAqIDIsIGF2ZXJhZ2VVcGNvbnZlcnRlZExlbmd0aCk7CiAKICAgICBk b3VibGUgYXZlcmFnZUxlbmd0aCA9IG1fdG90YWxOdW1iZXJTdHJpbmdzID8gKGRvdWJsZSl0b3Rh bE51bWJlckNoYXJhY3RlcnMgLyAoZG91YmxlKW1fdG90YWxOdW1iZXJTdHJpbmdzIDogMC4wOwot ICAgIGRhdGFMb2coIiU4dSBUb3RhbCAgICAgICAgICAgICAgICAgJTEybGx1IGNoYXJzICAlMTJs bHUgYnl0ZXMgIGF2ZyBsZW5ndGggJTYuMWZcbiIsIG1fdG90YWxOdW1iZXJTdHJpbmdzLCB0b3Rh bE51bWJlckNoYXJhY3RlcnMsIG1fdG90YWw4Qml0RGF0YSArIChtX3RvdGFsMTZCaXREYXRhICsg bV90b3RhbFVwY29udmVydGVkRGF0YSkgKiAyLCBhdmVyYWdlTGVuZ3RoKTsKKyAgICB1bnNpZ25l ZCBsb25nIGxvbmcgdG90YWxEYXRhQnl0ZXMgPSBtX3RvdGFsOEJpdERhdGEgKyAobV90b3RhbDE2 Qml0RGF0YSArIG1fdG90YWxVcGNvbnZlcnRlZERhdGEpICogMjsKKyAgICBkYXRhTG9nRigiJTh1 IFRvdGFsICAgICAgICAgICAgICAgICAlMTJsbHUgY2hhcnMgICUxMmxsdSBieXRlcyAgYXZnIGxl bmd0aCAlNi4xZlxuIiwgbV90b3RhbE51bWJlclN0cmluZ3MsIHRvdGFsTnVtYmVyQ2hhcmFjdGVy cywgdG90YWxEYXRhQnl0ZXMsIGF2ZXJhZ2VMZW5ndGgpOworICAgIHVuc2lnbmVkIGxvbmcgbG9u ZyB0b3RhbFNhdmVkQnl0ZXMgPSBtX3RvdGFsOEJpdERhdGEgLSBtX3RvdGFsVXBjb252ZXJ0ZWRE YXRhOworICAgIGRvdWJsZSBwZXJjZW50U2F2aW5ncyA9IHRvdGFsU2F2ZWRCeXRlcyA/ICgoZG91 YmxlKXRvdGFsU2F2ZWRCeXRlcyAqIDEwMCkgLyAoZG91YmxlKSh0b3RhbERhdGFCeXRlcyArIHRv dGFsU2F2ZWRCeXRlcykgOiAwLjA7CisgICAgZGF0YUxvZ0YoIiAgICAgICAgIFRvdGFsIHNhdmlu Z3MgJTEybGx1IGJ5dGVzICglNS4yZiUlKVxuIiwgdG90YWxTYXZlZEJ5dGVzLCBwZXJjZW50U2F2 aW5ncyk7CiB9CiAjZW5kaWYKIAo=