103568 2012-11-28 15:42:22 -0800 [mac] WebHTMLConverter should maintain font size even when there is no related NSFont 2012-11-28 16:15:42 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103496 1 thorton thorton ap enrica mitz rniwa oldest_to_newest 778422 0 thorton 2012-11-28 15:42:22 -0800 If WebHTMLConverter is faced with a Web font within a range in editingAttributedStringFromRange, it drops the style on the floor. It should instead substitute a default font of the appropriate size. 778430 1 176592 thorton 2012-11-28 15:44:33 -0800 Created attachment 176592 patch Looking into how to test, but it seems potentially quite tricky. 778440 2 176592 ap 2012-11-28 15:55:48 -0800 Comment on attachment 176592 patch View in context: https://bugs.webkit.org/attachment.cgi?id=176592&action=review > Source/WebCore/ChangeLog:12 > + (+[WebHTMLConverter editingAttributedStringFromRange:]): Do we have the same issue in non-editing version? 778451 3 thorton 2012-11-28 16:07:10 -0800 (In reply to comment #2) > (From update of attachment 176592 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176592&action=review > > > Source/WebCore/ChangeLog:12 > > + (+[WebHTMLConverter editingAttributedStringFromRange:]): > > Do we have the same issue in non-editing version? From code inspection it looks to me like the non-editing path does the right thing, actually! 778460 4 thorton 2012-11-28 16:15:42 -0800 http://trac.webkit.org/changeset/136073 176592 2012-11-28 15:44:33 -0800 2012-11-28 15:55:48 -0800 patch webhtmlconverter.diff text/plain 2322 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYTg2ZDY0Li4zYTg2YmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTEtMjggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW21hY10gV2ViSFRNTENvbnZlcnRlciBzaG91bGQgbWFpbnRhaW4gZm9udCBzaXpl IGV2ZW4gd2hlbiB0aGVyZSBpcyBubyByZWxhdGVkIE5TRm9udAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNTY4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViSFRNTENvbnZlcnRlciBzaG91bGQgdXNl IHRoZSBkZWZhdWx0IGZvbnQgYXQgdGhlIGNvcnJlY3Qgc2l6ZSB3aGVuIGl0CisgICAgICAgIGVu Y291bnRlcnMgYSBmb250IHRoYXQgY2Fubm90IGJlIGJhY2tlZCBieSBhbiBOU0ZvbnQgKGUuZy4g YSBXZWJGb250KS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9IVE1MQ29udmVydGVyLm1tOgor ICAgICAgICAoK1tXZWJIVE1MQ29udmVydGVyIGVkaXRpbmdBdHRyaWJ1dGVkU3RyaW5nRnJvbVJh bmdlOl0pOgorCiAyMDEyLTExLTI3ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgSW5kZXhlZERCOiBTaW1wbGlmeSB0cmFuc2FjdGlvbiB0aW1lcnMgYW5kIGV2 ZW50IHRyYWNraW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSFRN TENvbnZlcnRlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9IVE1MQ29udmVydGVy Lm1tCmluZGV4IDY1MTZhMmQuLjIxOTNiMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9IVE1MQ29udmVydGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9IVE1MQ29udmVydGVyLm1tCkBAIC0xNjY3LDYgKzE2NjcsNyBAQCBzdGF0aWMgTlNJbnRl Z2VyIF9jb2xDb21wYXJlKGlkIGJsb2NrMSwgaWQgYmxvY2syLCB2b2lkICopCiAvLyBUaGlzIGZ1 bmN0aW9uIHVzZXMgVGV4dEl0ZXJhdG9yLCB3aGljaCBtYWtlcyBvZmZzZXRzIGluIGl0cyByZXN1 bHQgY29tcGF0aWJsZSB3aXRoIEhUTUwgZWRpdGluZy4KICsgKE5TQXR0cmlidXRlZFN0cmluZyAq KWVkaXRpbmdBdHRyaWJ1dGVkU3RyaW5nRnJvbVJhbmdlOihSYW5nZSopcmFuZ2UKIHsKKyAgICBO U0ZvbnRNYW5hZ2VyICpmb250TWFuYWdlciA9IFtOU0ZvbnRNYW5hZ2VyIHNoYXJlZEZvbnRNYW5h Z2VyXTsKICAgICBOU011dGFibGVBdHRyaWJ1dGVkU3RyaW5nICpzdHJpbmcgPSBbW05TTXV0YWJs ZUF0dHJpYnV0ZWRTdHJpbmcgYWxsb2NdIGluaXRdOwogICAgIE5TVUludGVnZXIgc3RyaW5nTGVu Z3RoID0gMDsKICAgICBSZXRhaW5QdHI8TlNNdXRhYmxlRGljdGlvbmFyeT4gYXR0cnMoQWRvcHRO UywgW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XSk7CkBAIC0xNzAyLDYgKzE3MDMs OCBAQCBzdGF0aWMgTlNJbnRlZ2VyIF9jb2xDb21wYXJlKGlkIGJsb2NrMSwgaWQgYmxvY2syLCB2 b2lkICopCiAgICAgICAgICAgICBbYXR0cnMuZ2V0KCkgc2V0T2JqZWN0OltOU051bWJlciBudW1i ZXJXaXRoSW50ZWdlcjpOU1VuZGVybGluZVN0eWxlU2luZ2xlXSBmb3JLZXk6TlNVbmRlcmxpbmVT dHlsZUF0dHJpYnV0ZU5hbWVdOwogICAgICAgICBpZiAoTlNGb250ICpmb250ID0gc3R5bGUtPmZv bnQoKS5wcmltYXJ5Rm9udCgpLT5nZXROU0ZvbnQoKSkKICAgICAgICAgICAgIFthdHRycy5nZXQo KSBzZXRPYmplY3Q6Zm9udCBmb3JLZXk6TlNGb250QXR0cmlidXRlTmFtZV07CisgICAgICAgIGVs c2UKKyAgICAgICAgICAgIFthdHRycy5nZXQoKSBzZXRPYmplY3Q6W2ZvbnRNYW5hZ2VyIGNvbnZl cnRGb250OldlYkRlZmF1bHRGb250KCkgdG9TaXplOnN0eWxlLT5mb250KCkucHJpbWFyeUZvbnQo KS0+cGxhdGZvcm1EYXRhKCkuc2l6ZSgpXSBmb3JLZXk6TlNGb250QXR0cmlidXRlTmFtZV07CiAg ICAgICAgIGlmIChzdHlsZS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5Q29sb3Ip LmFscGhhKCkpCiAgICAgICAgICAgICBbYXR0cnMuZ2V0KCkgc2V0T2JqZWN0Om5zQ29sb3Ioc3R5 bGUtPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUNvbG9yKSkgZm9yS2V5Ok5TRm9y ZWdyb3VuZENvbG9yQXR0cmlidXRlTmFtZV07CiAgICAgICAgIGVsc2UK