103551 2012-11-28 12:38:14 -0800 [chromium] make sourceDevice available to more WebGestureEvent subtypes 2012-12-02 02:43:14 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rjkroege rjkroege abarth aelias dglazkov fishd jamesr tkent+wkapi webkit.review.bot yusufo oldest_to_newest 778206 0 rjkroege 2012-11-28 12:38:14 -0800 Chrome sends gesture events from both the touchpad and the touchscreen. In particular: GestureScrollBegin, GestureScrollEnd, GestureFlingStart and GestureFlingCancel can all be sent from both devices. Currently, only GestureFlingStart sub-types are tagged with their device source. But it is also necessary to know the source device for the remaining three sub-types. Add a new payload for these sub-types. 778230 1 176554 rjkroege 2012-11-28 12:52:52 -0800 Created attachment 176554 Patch 778240 2 webkit.review.bot 2012-11-28 12:58:53 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 778243 3 aelias 2012-11-28 13:01:43 -0800 Should we just add it outside the union? The property could be useful for other event types as well (ScrollUpdate, pinch, etc). 778254 4 jamesr 2012-11-28 13:09:29 -0800 (In reply to comment #3) > Should we just add it outside the union? The property could be useful for other event types as well (ScrollUpdate, pinch, etc). I like this idea. 780130 5 176972 rjkroege 2012-11-30 08:15:56 -0800 Created attachment 176972 Patch 780132 6 176972 rjkroege 2012-11-30 08:17:07 -0800 Comment on attachment 176972 Patch Sounds good to me. This is step one of having the flag be for all WebGestureEvent instances. Please take a look. 780144 7 176972 webkit.review.bot 2012-11-30 08:46:03 -0800 Comment on attachment 176972 Patch Attachment 176972 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15062385 780179 8 176983 rjkroege 2012-11-30 09:47:22 -0800 Created attachment 176983 Patch 780249 9 aelias 2012-11-30 11:17:07 -0800 LGTM 780895 10 176983 webkit.review.bot 2012-12-02 02:43:11 -0800 Comment on attachment 176983 Patch Clearing flags on attachment: 176983 Committed r136325: <http://trac.webkit.org/changeset/136325> 780896 11 webkit.review.bot 2012-12-02 02:43:14 -0800 All reviewed patches have been landed. Closing bug. 176554 2012-11-28 12:52:52 -0800 2012-11-30 08:15:53 -0800 Patch bug-103551-20121128155027.patch text/plain 1540 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI0ZTEwNzZkNDRmYTVkODI5MDVmMDFmYzI1ZTk5Y2Y3YTNkNjViZWEuLjQ3ZWEzMzk2ZWI4Yjg5 MmNjNzFjYjRmMDBmMGE4NGUzYmQzYjljOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMjggIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gbWFrZSBzb3VyY2VEZXZpY2UgYXZhaWxh YmxlIHRvIG1vcmUgV2ViR2VzdHVyZUV2ZW50IHN1YnR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1NTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhbiBhZGRpdGlvbmFsIGRhdGEgcGF5 bG9hZCB0byB0aGUgV2ViR2VzdHVyZUV2ZW50IHVuaW9uIHRoYXQgY2FuCisgICAgICAgIGNvbnRh aW4gdGhlIHNvdXJjZSBkZXZpY2UgKHRvdWNocGFkIG9yIHRvdWNoc2NyZWVuKSBmb3IgR2VzdHVy ZUZsaW5nQ2FuY2VsLAorICAgICAgICBHZXN0dXJlU2Nyb2xsQmVnaW4gYW5kIEdlc3R1cmVTY3Jv bGxTdGFydCBzdWJ0eXBlcy4KKworICAgICAgICAqIHB1YmxpYy9XZWJJbnB1dEV2ZW50Lmg6CisK IDIwMTItMTEtMjggIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIEluZGV4ZWREQjogUmVtb3ZlIHNldFZlcnNpb24gZnJvbSBXSyBBUEkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAzYzlmNzcwOTAzMjgz NDVlNWM3MTYxNWYxYjEyMGFhZTRlNDZiYjE2Li40MDk3MTYxMGNkOTdiZGQ2OTM3Y2JiNDc0Yjcw OGFhOTE3MmE3NDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJJbnB1dEV2ZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5w dXRFdmVudC5oCkBAIC00MTgsNiArNDE4LDExIEBAIHB1YmxpYzoKICAgICAgICAgc3RydWN0IHsK ICAgICAgICAgICAgIGZsb2F0IHNjYWxlOwogICAgICAgICB9IHBpbmNoVXBkYXRlOworCisgICAg ICAgIC8vIEdlc3R1cmVTY3JvbGxCZWdpbiBHZXN0dXJlU2Nyb2xsRW5kIEdlc3R1cmVGbGluZ0Nh bmNlbAorICAgICAgICBzdHJ1Y3QgeworICAgICAgICAgICAgU291cmNlRGV2aWNlIHNvdXJjZURl dmljZTsKKyAgICAgICAgfSBzY3JvbGxHZXN0dXJlOwogICAgIH0gZGF0YTsgCiAKICAgICBXZWJH ZXN0dXJlRXZlbnQodW5zaWduZWQgc2l6ZVBhcmFtID0gc2l6ZW9mKFdlYkdlc3R1cmVFdmVudCkp Cg== 176972 2012-11-30 08:15:56 -0800 2012-11-30 09:47:18 -0800 Patch bug-103551-20121130111328.patch text/plain 1511 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ0MjBhYmIwM2I5YTE4NTAzMGU4ZDEwZmU3NDAyNmNmNTk5ZGQwNDAuLjRiZWM2N2JmNWE4ZTEz ZDBiNDdkMzhjYmQ5YWFhM2Q0MTg1NGM1MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMjggIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gbWFrZSBzb3VyY2VEZXZpY2UgYXZhaWxh YmxlIHRvIG1vcmUgV2ViR2VzdHVyZUV2ZW50IHN1YnR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1NTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhbiBhZGRpdGlvbmFsIGRhdGEgcGF5 bG9hZCB0byBXZWJHZXN0dXJlRXZlbnQgdGhhdCBjYW4KKyAgICAgICAgY29udGFpbiB0aGUgc291 cmNlIGRldmljZSAodG91Y2hwYWQgb3IgdG91Y2hzY3JlZW4pLgorCisgICAgICAgICogcHVibGlj L1dlYklucHV0RXZlbnQuaDoKKwogMjAxMi0xMS0yOSAgRmxvcmluIE1hbGl0YSAgPGZtYWxpdGFA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtTa2lhXSBBZGQgbWlzc2luZyBPcGFxdWVSZWdpb25T a2lhIG5vdGlmaWVyIGNhbGxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJ bnB1dEV2ZW50LmgKaW5kZXggM2M5Zjc3MDkwMzI4MzQ1ZTVjNzE2MTVmMWIxMjBhYWU0ZTQ2YmIx Ni4uZmJkZWUxZDZlYjYzNzc2ZTczOTNmMWY4YjZiYmEyYmJiNzYxZWRhYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaApAQCAtMzc5LDYgKzM3OSw3 IEBAIHB1YmxpYzoKICAgICBpbnQgeTsKICAgICBpbnQgZ2xvYmFsWDsKICAgICBpbnQgZ2xvYmFs WTsKKyAgICBTb3VyY2VEZXZpY2Ugc291cmNlRGV2aWNlOwogCiAgICAgdW5pb24gewogICAgICAg ICBzdHJ1Y3QgewpAQCAtNDEyLDYgKzQxMyw3IEBAIHB1YmxpYzoKICAgICAgICAgc3RydWN0IHsK ICAgICAgICAgICAgIGZsb2F0IHZlbG9jaXR5WDsKICAgICAgICAgICAgIGZsb2F0IHZlbG9jaXR5 WTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyB3aGVuIENocm9taXVtIHVzZXMg dGhlIHRvcC1sZXZlbCBmaWVsZC4KICAgICAgICAgICAgIFNvdXJjZURldmljZSBzb3VyY2VEZXZp Y2U7CiAgICAgICAgIH0gZmxpbmdTdGFydDsKIAo= 176983 2012-11-30 09:47:22 -0800 2012-12-02 02:43:10 -0800 Patch bug-103551-20121130124453.patch text/plain 2173 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ0MjBhYmIwM2I5YTE4NTAzMGU4ZDEwZmU3NDAyNmNmNTk5ZGQwNDAuLjJmZjRhM2YzNDk1YWEx MjQ3ZDhkMmM3MThhY2E2NTE4ODU2ZmExOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMTEtMjggIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gbWFrZSBzb3VyY2VEZXZpY2UgYXZhaWxh YmxlIHRvIG1vcmUgV2ViR2VzdHVyZUV2ZW50IHN1YnR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1NTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhbiBhZGRpdGlvbmFsIGRhdGEgcGF5 bG9hZCB0byBXZWJHZXN0dXJlRXZlbnQgdGhhdCBjYW4KKyAgICAgICAgY29udGFpbiB0aGUgc291 cmNlIGRldmljZSAodG91Y2hwYWQgb3IgdG91Y2hzY3JlZW4pLgorCisgICAgICAgICogcHVibGlj L1dlYklucHV0RXZlbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFdmVudC5jcHA6CisgICAg ICAgIChTYW1lU2l6ZUFzV2ViR2VzdHVyZUV2ZW50KToKKwogMjAxMi0xMS0yOSAgRmxvcmluIE1h bGl0YSAgPGZtYWxpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtTa2lhXSBBZGQgbWlzc2lu ZyBPcGFxdWVSZWdpb25Ta2lhIG5vdGlmaWVyIGNhbGxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKaW5kZXggM2M5Zjc3MDkwMzI4MzQ1ZTVjNzE2MTVm MWIxMjBhYWU0ZTQ2YmIxNi4uZmJkZWUxZDZlYjYzNzc2ZTczOTNmMWY4YjZiYmEyYmJiNzYxZWRh YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaApA QCAtMzc5LDYgKzM3OSw3IEBAIHB1YmxpYzoKICAgICBpbnQgeTsKICAgICBpbnQgZ2xvYmFsWDsK ICAgICBpbnQgZ2xvYmFsWTsKKyAgICBTb3VyY2VEZXZpY2Ugc291cmNlRGV2aWNlOwogCiAgICAg dW5pb24gewogICAgICAgICBzdHJ1Y3QgewpAQCAtNDEyLDYgKzQxMyw3IEBAIHB1YmxpYzoKICAg ICAgICAgc3RydWN0IHsKICAgICAgICAgICAgIGZsb2F0IHZlbG9jaXR5WDsKICAgICAgICAgICAg IGZsb2F0IHZlbG9jaXR5WTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyB3aGVu IENocm9taXVtIHVzZXMgdGhlIHRvcC1sZXZlbCBmaWVsZC4KICAgICAgICAgICAgIFNvdXJjZURl dmljZSBzb3VyY2VEZXZpY2U7CiAgICAgICAgIH0gZmxpbmdTdGFydDsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAppbmRleCAxMGQxZjIxMDdhODA5ZjEx M2ZhN2Q4MzZhMzYwODU1NjdhNjkxZDE2Li5hMGQwMzgwZTVkN2UwMTJiOGZiMWQ4NTNjN2U1ZWQ1 NDM2YWI5MTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1 dEV2ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50 LmNwcApAQCAtNjAsNyArNjAsNyBAQCBzdHJ1Y3QgU2FtZVNpemVBc1dlYk1vdXNlV2hlZWxFdmVu dCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViTW91c2VFdmVudCB7CiB9OwogCiBzdHJ1Y3QgU2FtZVNp emVBc1dlYkdlc3R1cmVFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViSW5wdXRFdmVudCB7Ci0g ICAgaW50IGdlc3R1cmVEYXRhWzhdOworICAgIGludCBnZXN0dXJlRGF0YVs5XTsKIH07CiAKIHN0 cnVjdCBTYW1lU2l6ZUFzV2ViVG91Y2hFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViSW5wdXRF dmVudCB7Cg==