103545 2012-11-28 12:00:47 -0800 Web Inspector: introduce fast case for within-chunk edit 2012-11-30 13:55:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 103762 1 pfeldman pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 778147 0 pfeldman 2012-11-28 12:00:47 -0800 Otherwise we rebuild entire chunk upon any input event. 778310 1 176570 pfeldman 2012-11-28 13:59:32 -0800 Created attachment 176570 Patch 779150 2 176570 vsevik 2012-11-29 10:24:30 -0800 Comment on attachment 176570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176570&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2424 > + var lastUndamagedLineRow = lastDamagedChunk.expandedLineRow(oldRange.startLine - 1); s/lastDamagedChunk/firstDamagedChunk/ for consistency > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2434 > + firstDamagedChunk.updateCollapsedLineRow(); This could be done lazily, do you intend change that later? 779243 3 pfeldman 2012-11-29 11:34:38 -0800 > This could be done lazily, do you intend change that later? Yep 779289 4 176570 webkit.review.bot 2012-11-29 12:07:28 -0800 Comment on attachment 176570 Patch Clearing flags on attachment: 176570 Committed r136145: <http://trac.webkit.org/changeset/136145> 779290 5 webkit.review.bot 2012-11-29 12:07:31 -0800 All reviewed patches have been landed. Closing bug. 780307 6 webkit.review.bot 2012-11-30 12:26:24 -0800 Re-opened since this is blocked by bug 103762 176570 2012-11-28 13:59:32 -0800 2012-11-29 12:07:28 -0800 Patch bug-103545-20121129015707.patch text/plain 4139 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI3MmI5NjE3MGMyZTg5 ODVkMTNhYzY3NjYwNDRkN2E0MDI1NmU0Ny4uZmJiYjlmZjM1ZDQ4ZTg1ODVhZTQ3MzNlZGE3YmY2 NTQzNWEwNWI0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTI4ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGludHJvZHVjZSBmYXN0IGNhc2UgZm9yIHdpdGhpbi1jaHVuayBlZGl0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1NDUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjaWFsLWNhc2luZyBlZGl0 cyB3aXRoaW4gdGhlIGNodW5rIGZvciBmYXN0ZXIgb3BlcmF0aW9uLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9ET01FeHRlbnNpb24uanM6CisgICAgICAgIChyZW1vdmVTdWJzZXF1 ZW50Tm9kZXMpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0 b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5 cGUuX3VwZGF0ZUNodW5rc0ZvclJhbmdlcyk6CisKIDIwMTItMTEtMjcgIEtlbnQgVGFtdXJhICA8 dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBlcnJvcnMgYnkgcjEzNTk1 NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NRXh0 ZW5zaW9uLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01FeHRlbnNp b24uanMKaW5kZXggMTYyZmE5NjRkODZhZmZmMWNlMWVjYTA0ODI3YzgzMGNjMTM2YjY4Ny4uNWJm Y2QyMjMzYzg4ODM1OTE4OGMyOGIwNzc5ZWY1YTkzYTQ1NmJhNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01FeHRlbnNpb24uanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01FeHRlbnNpb24uanMKQEAgLTE5NSw2ICsx OTUsMTggQEAgRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlID0gZnVuY3Rpb24oKQogICAgICAgICB0 aGlzLnBhcmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQodGhpcyk7CiB9CiAKKy8qKgorICogQHBhcmFt IHtOb2RlfSBmcm9tTm9kZQorICogQHBhcmFtIHtOb2RlfSB0b05vZGUKKyAqLworZnVuY3Rpb24g cmVtb3ZlU3Vic2VxdWVudE5vZGVzKGZyb21Ob2RlLCB0b05vZGUpCit7CisgICAgZm9yICh2YXIg bm9kZSA9IGZyb21Ob2RlOyBub2RlICYmIG5vZGUgIT09IHRvTm9kZTsgKSB7CisgICAgICAgIHZh ciBub2RlVG9SZW1vdmUgPSBub2RlOworICAgICAgICBub2RlID0gbm9kZS5uZXh0U2libGluZzsK KyAgICAgICAgbm9kZVRvUmVtb3ZlLnJlbW92ZSgpOworICAgIH0KK30KIAogLyoqCiAgKiBAY29u c3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RGVmYXVsdFRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RlZmF1bHRUZXh0RWRpdG9yLmpzCmluZGV4IDA4ZjQ4ZTA4ZmUwMjBiZWZiMzY1MmE3MzAyM2Vk NGIxMmMwYmEzNzUuLjQ1OGU1NDU1MmE5YWE5NDdkMjY0MmRkN2VlMmM1MTQxYjJiZGZhY2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRF ZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0 VGV4dEVkaXRvci5qcwpAQCAtMjQxNSwxMyArMjQxNSwyOCBAQCBXZWJJbnNwZWN0b3IuVGV4dEVk aXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIC8vIFJlbW92ZSBkYW1hZ2VkIGNo dW5rcyBmcm9tIERPTSBhbmQgZnJvbSB0ZXh0Q2h1bmtzIG1vZGVsLgogICAgICAgICB2YXIgbGFz dFVuZGFtYWdlZENodW5rID0gZmlyc3REYW1hZ2VkQ2h1bmtOdW1iZXIgPiAwID8gdGhpcy5fdGV4 dENodW5rc1tmaXJzdERhbWFnZWRDaHVua051bWJlciAtIDFdIDogbnVsbDsKICAgICAgICAgdmFy IGZpcnN0VW5kYW1hZ2VkQ2h1bmsgPSBsYXN0RGFtYWdlZENodW5rTnVtYmVyICsgMSA8IHRoaXMu X3RleHRDaHVua3MubGVuZ3RoID8gdGhpcy5fdGV4dENodW5rc1tsYXN0RGFtYWdlZENodW5rTnVt YmVyICsgMV0gOiBudWxsOworCiAgICAgICAgIHZhciByZW1vdmVET01Gcm9tTm9kZSA9IGxhc3RV bmRhbWFnZWRDaHVuayA/IGxhc3RVbmRhbWFnZWRDaHVuay5sYXN0RWxlbWVudCgpLm5leHRTaWJs aW5nIDogdGhpcy5fY29udGFpbmVyLmZpcnN0Q2hpbGQ7CiAgICAgICAgIHZhciByZW1vdmVET01U b05vZGUgPSBmaXJzdFVuZGFtYWdlZENodW5rID8gZmlyc3RVbmRhbWFnZWRDaHVuay5maXJzdEVs ZW1lbnQoKSA6IG51bGw7Ci0gICAgICAgIGZvciAodmFyIG5vZGUgPSByZW1vdmVET01Gcm9tTm9k ZTsgbm9kZSAmJiBub2RlICE9PSByZW1vdmVET01Ub05vZGU7ICkgewotICAgICAgICAgICAgdmFy IG5vZGVUb1JlbW92ZSA9IG5vZGU7Ci0gICAgICAgICAgICBub2RlID0gbm9kZS5uZXh0U2libGlu ZzsKLSAgICAgICAgICAgIG5vZGVUb1JlbW92ZS5yZW1vdmUoKTsKKworICAgICAgICAvLyBGYXN0 IGNhc2UgLSBwYXRjaCBzaW5nbGUgZXhwYW5kZWQgY2h1bmsgdGhhdCBkaWQgbm90IGdyb3cgLyBz aHJpbmsgZHVyaW5nIGVkaXQuCisgICAgICAgIGlmICghbGluZXNEaWZmICYmIGZpcnN0RGFtYWdl ZENodW5rID09PSBsYXN0RGFtYWdlZENodW5rICYmIGZpcnN0RGFtYWdlZENodW5rLl9leHBhbmRl ZExpbmVSb3dzKSB7CisgICAgICAgICAgICB2YXIgbGFzdFVuZGFtYWdlZExpbmVSb3cgPSBsYXN0 RGFtYWdlZENodW5rLmV4cGFuZGVkTGluZVJvdyhvbGRSYW5nZS5zdGFydExpbmUgLSAxKTsKKyAg ICAgICAgICAgIHZhciBmaXJzdFVuZGFtYWdlZExpbmVSb3cgPSBmaXJzdERhbWFnZWRDaHVuay5l eHBhbmRlZExpbmVSb3cob2xkUmFuZ2UuZW5kTGluZSArIDEpOworICAgICAgICAgICAgdmFyIGxv Y2FsUmVtb3ZlRE9NRnJvbU5vZGUgPSBsYXN0VW5kYW1hZ2VkTGluZVJvdyA/IGxhc3RVbmRhbWFn ZWRMaW5lUm93Lm5leHRTaWJsaW5nIDogcmVtb3ZlRE9NRnJvbU5vZGU7CisgICAgICAgICAgICB2 YXIgbG9jYWxSZW1vdmVET01Ub05vZGUgPSBmaXJzdFVuZGFtYWdlZExpbmVSb3cgfHwgcmVtb3Zl RE9NVG9Ob2RlOworICAgICAgICAgICAgcmVtb3ZlU3Vic2VxdWVudE5vZGVzKGxvY2FsUmVtb3Zl RE9NRnJvbU5vZGUsIGxvY2FsUmVtb3ZlRE9NVG9Ob2RlKTsKKyAgICAgICAgICAgIGZvciAodmFy IGkgPSBuZXdSYW5nZS5zdGFydExpbmU7IGkgPCBuZXdSYW5nZS5lbmRMaW5lICsgMTsgKytpKSB7 CisgICAgICAgICAgICAgICAgdmFyIHJvdyA9IGZpcnN0RGFtYWdlZENodW5rLl9jcmVhdGVSb3co aSk7CisgICAgICAgICAgICAgICAgZmlyc3REYW1hZ2VkQ2h1bmsuX2V4cGFuZGVkTGluZVJvd3Nb aSAtIGZpcnN0RGFtYWdlZENodW5rLnN0YXJ0TGluZV0gPSByb3c7CisgICAgICAgICAgICAgICAg dGhpcy5fY29udGFpbmVyLmluc2VydEJlZm9yZShyb3csIGxvY2FsUmVtb3ZlRE9NVG9Ob2RlKTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGZpcnN0RGFtYWdlZENodW5rLnVwZGF0ZUNvbGxh cHNlZExpbmVSb3coKTsKKyAgICAgICAgICAgIHRoaXMuX2Fzc2VydERPTU1hdGNoZXNUZXh0TW9k ZWwoKTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQorCisgICAgICAgIHJlbW92ZVN1 YnNlcXVlbnROb2RlcyhyZW1vdmVET01Gcm9tTm9kZSwgcmVtb3ZlRE9NVG9Ob2RlKTsKICAgICAg ICAgdGhpcy5fdGV4dENodW5rcy5zcGxpY2UoZmlyc3REYW1hZ2VkQ2h1bmtOdW1iZXIsIGxhc3RE YW1hZ2VkQ2h1bmtOdW1iZXIgLSBmaXJzdERhbWFnZWRDaHVua051bWJlciArIDEpOwogCiAgICAg ICAgIC8vIENvbXB1dGUgZGFtYWdlZCBjaHVua3Mgc3Bhbgo=