103544 2012-11-28 11:53:16 -0800 Make DataLog work on Windows 2012-11-28 17:09:58 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned benjamin fpizlo ojan thorton webkit.review.bot oldest_to_newest 778138 0 roger_fong 2012-11-28 11:53:16 -0800 Datalog doesn't work on Windows (also doesn't compile). 778222 1 176552 roger_fong 2012-11-28 12:46:05 -0800 Created attachment 176552 patch 778228 2 176552 roger_fong 2012-11-28 12:51:03 -0800 Comment on attachment 176552 patch Should be currentCurrentProcessId not ThreadId 778234 3 176557 roger_fong 2012-11-28 12:53:55 -0800 Created attachment 176557 patch 778421 4 roger_fong 2012-11-28 15:41:07 -0800 http://trac.webkit.org/changeset/136070 778479 5 176557 thorton 2012-11-28 16:33:47 -0800 Comment on attachment 176557 patch View in context: https://bugs.webkit.org/attachment.cgi?id=176557&action=review > Source/WTF/wtf/DataLog.cpp:49 > +// This path won't work on Windows, make sure to change to something like C:\\Users\\<more path>\\log.txt. > #define DATA_LOG_FILENAME "/tmp/WTFLog" Why is this not #if PLATFORM(WIN)'d so it works out of the box? 778508 6 roger_fong 2012-11-28 17:06:52 -0800 My impression of the DATA_LOG_FILE is that whoever wants to use the logging will probably change the path anyways to somewhere a little more easier to access than say /tmp/log. If they're going to be changing it anyways then I think it makes sense to only have one place where the file name is specified. 778511 7 fpizlo 2012-11-28 17:09:58 -0800 (In reply to comment #6) > My impression of the DATA_LOG_FILE is that whoever wants to use the logging will probably change the path anyways to somewhere a little more easier to access than say /tmp/log. That's my thinking as well. > > If they're going to be changing it anyways then I think it makes sense to only have one place where the file name is specified. 176552 2012-11-28 12:46:05 -0800 2012-11-28 12:51:03 -0800 patch datalog_patch.txt text/plain 1685 roger_fong SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzYwMzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTI4ICBSb2dlciBGb25nICA8cm9nZXJf Zm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBEYXRhTG9nIHdvcmsvY29tcGlsZSBwcm9w ZXJseSBvbiBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAzNTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvRGF0YUxvZy5jcHA6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVMb2dG aWxlT25jZSk6CisKIDIwMTItMTEtMjcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBDb252ZXJ0IHNvbWUgcmVtYWluaW5nIHVzZXMgb2YgRklMRSogdG8gUHJpbnRT dHJlYW0mLgpJbmRleDogU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAJKHJldmlzaW9uIDEzNTg4OSkKKysrIFNvdXJjZS9X VEYvd3RmL0RhdGFMb2cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCwxMCArNDAsMTIgQEAKICNl bmRpZgogI2VuZGlmCiAKLSNkZWZpbmUgREFUQV9MT0dfVE9fRklMRSAwCisjZGVmaW5lIERBVEFf TE9HX1RPX0ZJTEUgMQogCiAvLyBVbmNvbW1lbnQgdG8gZm9yY2UgbG9nZ2luZyB0byB0aGUgZ2l2 ZW4gZmlsZSByZWdhcmRsZXNzIG9mIHdoYXQgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIHNheXMu IE5vdGUgdGhhdAogLy8gd2Ugd2lsbCBhcHBlbmQgIi48cGlkPi50eHQiIHdoZXJlIDxwaWQ+IGlz IHRoZSBQSUQuCisKKy8vIFRoaXMgcGF0aCB3b24ndCB3b3JrIG9uIFdpbmRvd3MsIG1ha2Ugc3Vy ZSB0byBjaGFuZ2UgdG8gc29tZXRoaW5nIGxpa2UgQzpcXFVzZXJzXFw8bW9yZSBwYXRoPlxcbG9n LnR4dC4KICNkZWZpbmUgREFUQV9MT0dfRklMRU5BTUUgIi90bXAvV1RGTG9nIgogCiBuYW1lc3Bh Y2UgV1RGIHsKQEAgLTYzLDcgKzY1LDEzIEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVMb2dGaWxl T25jZSgpCiAgICAgY29uc3QgY2hhciogZmlsZW5hbWUgPSBnZXRlbnYoIldURl9EQVRBX0xPR19G SUxFTkFNRSIpOwogI2VuZGlmCiAgICAgY2hhciBhY3R1YWxGaWxlbmFtZVsxMDI0XTsKKworI2lm IFBMQVRGT1JNKFdJTikKKyAgICBfc25wcmludGYoYWN0dWFsRmlsZW5hbWUsIHNpemVvZihhY3R1 YWxGaWxlbmFtZSksICIlcy4lZC50eHQiLCBmaWxlbmFtZSwgR2V0Q3VycmVudFRocmVhZElkKCkp OworI2Vsc2UKICAgICBzbnByaW50ZihhY3R1YWxGaWxlbmFtZSwgc2l6ZW9mKGFjdHVhbEZpbGVu YW1lKSwgIiVzLiVkLnR4dCIsIGZpbGVuYW1lLCBnZXRwaWQoKSk7CisjZW5kaWYKKwogICAgIGlm IChmaWxlbmFtZSkgewogICAgICAgICBGSUxFKiByYXdGaWxlID0gZm9wZW4oYWN0dWFsRmlsZW5h bWUsICJ3Iik7CiAgICAgICAgIGlmIChyYXdGaWxlKQo= 176557 2012-11-28 12:53:55 -0800 2012-11-28 16:33:47 -0800 patch datalog_patch.txt text/plain 1610 roger_fong SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzYwMzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTI4ICBSb2dlciBGb25nICA8cm9nZXJf Zm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBEYXRhTG9nIHdvcmsvY29tcGlsZSBwcm9w ZXJseSBvbiBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAzNTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvRGF0YUxvZy5jcHA6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVMb2dG aWxlT25jZSk6CisKIDIwMTItMTEtMjcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBDb252ZXJ0IHNvbWUgcmVtYWluaW5nIHVzZXMgb2YgRklMRSogdG8gUHJpbnRT dHJlYW0mLgpJbmRleDogU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAJKHJldmlzaW9uIDEzNTg4OSkKKysrIFNvdXJjZS9X VEYvd3RmL0RhdGFMb2cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw4IEBACiAKIC8v IFVuY29tbWVudCB0byBmb3JjZSBsb2dnaW5nIHRvIHRoZSBnaXZlbiBmaWxlIHJlZ2FyZGxlc3Mg b2Ygd2hhdCB0aGUgZW52aXJvbm1lbnQgdmFyaWFibGUgc2F5cy4gTm90ZSB0aGF0CiAvLyB3ZSB3 aWxsIGFwcGVuZCAiLjxwaWQ+LnR4dCIgd2hlcmUgPHBpZD4gaXMgdGhlIFBJRC4KKworLy8gVGhp cyBwYXRoIHdvbid0IHdvcmsgb24gV2luZG93cywgbWFrZSBzdXJlIHRvIGNoYW5nZSB0byBzb21l dGhpbmcgbGlrZSBDOlxcVXNlcnNcXDxtb3JlIHBhdGg+XFxsb2cudHh0LgogI2RlZmluZSBEQVRB X0xPR19GSUxFTkFNRSAiL3RtcC9XVEZMb2ciCiAKIG5hbWVzcGFjZSBXVEYgewpAQCAtNjMsNyAr NjUsMTMgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZUxvZ0ZpbGVPbmNlKCkKICAgICBjb25zdCBj aGFyKiBmaWxlbmFtZSA9IGdldGVudigiV1RGX0RBVEFfTE9HX0ZJTEVOQU1FIik7CiAjZW5kaWYK ICAgICBjaGFyIGFjdHVhbEZpbGVuYW1lWzEwMjRdOworCisjaWYgUExBVEZPUk0oV0lOKQorICAg IF9zbnByaW50ZihhY3R1YWxGaWxlbmFtZSwgc2l6ZW9mKGFjdHVhbEZpbGVuYW1lKSwgIiVzLiVk LnR4dCIsIGZpbGVuYW1lLCBHZXRDdXJyZW50UHJvY2Vzc0lkKCkpOworI2Vsc2UKICAgICBzbnBy aW50ZihhY3R1YWxGaWxlbmFtZSwgc2l6ZW9mKGFjdHVhbEZpbGVuYW1lKSwgIiVzLiVkLnR4dCIs IGZpbGVuYW1lLCBnZXRwaWQoKSk7CisjZW5kaWYKKwogICAgIGlmIChmaWxlbmFtZSkgewogICAg ICAgICBGSUxFKiByYXdGaWxlID0gZm9wZW4oYWN0dWFsRmlsZW5hbWUsICJ3Iik7CiAgICAgICAg IGlmIChyYXdGaWxlKQo=