103543 2012-11-28 11:45:13 -0800 Address coding style review comments from bug 103355 2012-11-29 10:50:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sadrul sadrul darin tonikitoo webkit.review.bot oldest_to_newest 778131 0 sadrul 2012-11-28 11:45:13 -0800 cleanup: Change some code to be cleaner, more readable and style conforming 778132 1 176535 sadrul 2012-11-28 11:47:26 -0800 Created attachment 176535 Patch 778134 2 sadrul 2012-11-28 11:48:52 -0800 Hi! This patch addresses the comments from https://bugs.webkit.org/show_bug.cgi?id=103355#c16 778187 3 176535 sadrul 2012-11-28 12:25:50 -0800 Comment on attachment 176535 Patch Requesting cq 778241 4 176535 webkit.review.bot 2012-11-28 12:59:57 -0800 Comment on attachment 176535 Patch Clearing flags on attachment: 176535 Committed r136046: <http://trac.webkit.org/changeset/136046> 778242 5 webkit.review.bot 2012-11-28 13:00:01 -0800 All reviewed patches have been landed. Closing bug. 176535 2012-11-28 11:47:26 -0800 2012-11-28 12:59:57 -0800 Patch bug-103543-20121128144501.patch text/plain 2844 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ0MmU2NmZjYWU2YTU0 NjBhZWM4MzU1MDVmMTc1NmYyMDQxYzI4Ni4uYWJhY2YzOWM1OTU0OTRmNGUzMzZhNTNmNDFiMzdl NGVjYjM4OTU0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTExLTI4ICBTYWRy dWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KIAorICAgICAgICBjbGVh bnVwOiBDaGFuZ2Ugc29tZSBjb2RlIHRvIGJlIGNsZWFuZXIsIG1vcmUgcmVhZGFibGUgYW5kIHN0 eWxlIGNvbmZvcm1pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMzU0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVzZSBtb3JlIGFwcHJvcHJpYXRlIGZ1bmN0aW9uIG5hbWUgYW5kIG1vcmUgbWVhbmlu Z2Z1bCB2YXJpYWJsZSBuYW1lcyB0byBtYWtlIHRoZSBjb2RlIGNsZWFuZXIuCisgICAgICAgIFRo aXMgaXMgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4gVGhpcyBkb2VzIG5vdCBtYWtlIGFueSBi ZWhhdmlvdXJhbCBjaGFuZ2VzLCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0V2 ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjbG9zZXN0U2Nyb2xsYWJsZU5vZGVJ bkRvY3VtZW50SWZQb3NzaWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6Omhh bmRsZVdoZWVsRXZlbnQpOgorCisyMDEyLTExLTI4ICBTYWRydWwgSGFiaWIgQ2hvd2RodXJ5ICA8 c2FkcnVsQGNocm9taXVtLm9yZz4KKwogICAgICAgICBGaXggZ2VzdHVyZSBzY3JvbGxpbmcgd2hl biB0aGUgdGFyZ2V0LWVsZW1lbnQgb2Ygc2Nyb2xsLWJlZ2luIGlzIHJlbW92ZWQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzM1NQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggZGI3YjE0MzUyMGEwMDIzYzk1YmE5ODI1NGY4 OGQ0OWY2ZjdkYjgwNS4uZmQ0Yzc4YjcxMThmOTk2NGQ2YjY4ZDU3NWMxZTM5YTcwZWU3NDhhZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjc5LDE4ICsyNzksMTYgQEAg c3RhdGljIGlubGluZSBib29sIHNjcm9sbE5vZGUoZmxvYXQgZGVsdGEsIFNjcm9sbEdyYW51bGFy aXR5IGdyYW51bGFyaXR5LCBTY3JvbGwKICAgICByZXR1cm4gZW5jbG9zaW5nQm94LT5zY3JvbGwo ZGVsdGEgPCAwID8gbmVnYXRpdmVEaXJlY3Rpb24gOiBwb3NpdGl2ZURpcmVjdGlvbiwgZ3JhbnVs YXJpdHksIGFic0RlbHRhLCBzdG9wTm9kZSk7CiB9CiAKLXN0YXRpYyBOb2RlKiBnZXRDbG9zZXN0 U2Nyb2xsYWJsZU5vZGVJbkRvY3VtZW50SWZQb3NzaWJsZShOb2RlKiBub2RlKQorc3RhdGljIE5v ZGUqIGNsb3Nlc3RTY3JvbGxhYmxlTm9kZUluRG9jdW1lbnRJZlBvc3NpYmxlKE5vZGUqIG5vZGUp CiB7Ci0gICAgTm9kZSogZmlyc3ROb2RlID0gbm9kZTsKLSAgICB3aGlsZSAobm9kZSkgewotICAg ICAgICBpZiAobm9kZS0+aXNEb2N1bWVudE5vZGUoKSkKLSAgICAgICAgICAgIHJldHVybiBmaXJz dE5vZGU7Ci0gICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigp OworICAgIGZvciAoTm9kZSogc2Nyb2xsYWJsZU5vZGUgPSBub2RlOyBzY3JvbGxhYmxlTm9kZTsg c2Nyb2xsYWJsZU5vZGUgPSBzY3JvbGxhYmxlTm9kZS0+cGFyZW50Tm9kZSgpKSB7CisgICAgICAg IGlmIChzY3JvbGxhYmxlTm9kZS0+aXNEb2N1bWVudE5vZGUoKSkKKyAgICAgICAgICAgIGJyZWFr OworICAgICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gc2Nyb2xsYWJsZU5vZGUtPnJlbmRl cmVyKCk7CiAgICAgICAgIGlmIChyZW5kZXJlciAmJiByZW5kZXJlci0+aXNCb3goKSAmJiB0b1Jl bmRlckJveChyZW5kZXJlciktPmNhbkJlU2Nyb2xsZWRBbmRIYXNTY3JvbGxhYmxlQXJlYSgpKQot ICAgICAgICAgICAgcmV0dXJuIG5vZGU7Ci0gICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnROb2Rl KCk7CisgICAgICAgICAgICByZXR1cm4gc2Nyb2xsYWJsZU5vZGU7CiAgICAgfQotICAgIHJldHVy biBmaXJzdE5vZGU7CisgICAgcmV0dXJuIG5vZGU7CiB9CiAKICNpZiBFTkFCTEUoR0VTVFVSRV9F VkVOVFMpCkBAIC0yNDQ3LDcgKzI0NDUsNyBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlV2hl ZWxFdmVudChjb25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmIGUpCiAKICAgICBpZiAodXNlTGF0Y2hl ZFdoZWVsRXZlbnROb2RlKSB7CiAgICAgICAgIGlmICghbV9sYXRjaGVkV2hlZWxFdmVudE5vZGUp IHsKLSAgICAgICAgICAgIG1fbGF0Y2hlZFdoZWVsRXZlbnROb2RlID0gZ2V0Q2xvc2VzdFNjcm9s bGFibGVOb2RlSW5Eb2N1bWVudElmUG9zc2libGUocmVzdWx0LmlubmVyTm9kZSgpKTsKKyAgICAg ICAgICAgIG1fbGF0Y2hlZFdoZWVsRXZlbnROb2RlID0gY2xvc2VzdFNjcm9sbGFibGVOb2RlSW5E b2N1bWVudElmUG9zc2libGUocmVzdWx0LmlubmVyTm9kZSgpKTsKICAgICAgICAgICAgIG1fd2lk Z2V0SXNMYXRjaGVkID0gcmVzdWx0LmlzT3ZlcldpZGdldCgpOwogICAgICAgICB9CiAK