103532 2012-11-28 09:19:46 -0800 Remove deprecated logging usage from QueueEngine 2012-11-28 12:19:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103537 1 zan zan abarth dpranke webkit.review.bot oldest_to_newest 777972 0 zan 2012-11-28 09:19:46 -0800 Remove deprecated logging usage from QueueEngine 777987 1 176497 zan 2012-11-28 09:40:06 -0800 Created attachment 176497 Patch 777991 2 176497 abarth 2012-11-28 09:45:19 -0800 Comment on attachment 176497 Patch Looks reasonable to me, but I'll let someone know knowledgeable in logging do the final review. 778140 3 176497 webkit.review.bot 2012-11-28 11:55:15 -0800 Comment on attachment 176497 Patch Clearing flags on attachment: 176497 Committed r136036: <http://trac.webkit.org/changeset/136036> 778141 4 webkit.review.bot 2012-11-28 11:55:18 -0800 All reviewed patches have been landed. Closing bug. 778179 5 abarth 2012-11-28 12:19:14 -0800 Thanks for removing deprecated logging from webkitpy. We've wanted to do that for a long time! 176497 2012-11-28 09:40:06 -0800 2012-11-28 11:55:15 -0800 Patch bug-103532-20121128183740.patch text/plain 4607 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGUxOWRlMTQwODRkOTRjYWNkMmExOGViNTdjNTM0Nzdh YzIyZTU2OC4uZmJjM2ZjNWUzNDZmODc1ZGI1ZjIzNzRjZTAyMmExZjRiNTMyNmJhZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDEyLTExLTI4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgUmVtb3ZlIGRlcHJlY2F0ZWQgbG9nZ2luZyB1c2FnZSBmcm9tIFF1ZXVlRW5naW5l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1MzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNl IHVzYWdlIG9mIGRlcHJlY2F0ZWQgbG9nZ2luZyBpbiB3ZWJraXRweS50b29sLmJvdC5xdWV1ZWVu Z2luZSB3aXRoCisgICAgICAgIGxvZ2dpbmcgdGhyb3VnaCB0aGUgTG9nZ2VyIG9iamVjdC4gVGhl IHVuaXQgdGVzdCBpcyBtb2RpZmllZCB0byByZWZsZWN0CisgICAgICAgIHRoZXNlIGNoYW5nZXMu CisKKyAgICAgICAgQWZ0ZXIgdGhlc2UgY2hhbmdlcyB0aGUgZGVwcmVjYXRlZCBsb2dnaW5nIChp LmUuIGxvZ2dpbmcgdG8gc3RkZXJyKSBpcyBub3QKKyAgICAgICAgdXNlZCBhbnltb3JlIHRocm91 Z2ggd2Via2l0cHkgYW5kIGNhbiBiZSByZW1vdmVkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9xdWV1ZWVuZ2luZS5weToKKyAgICAgICAgKFF1ZXVlRW5naW5lLmV4aXRf YWZ0ZXJfaGFuZGxlZF9lcnJvcik6CisgICAgICAgIChRdWV1ZUVuZ2luZS5ydW4pOgorICAgICAg ICAoUXVldWVFbmdpbmUuX3N0b3BwaW5nKToKKyAgICAgICAgKFF1ZXVlRW5naW5lLl9zbGVlcCk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9xdWV1ZWVuZ2luZV91bml0dGVz dC5weToKKyAgICAgICAgKFF1ZXVlRW5naW5lVGVzdC5fcnVuX2VuZ2luZSk6CisKIDIwMTItMTEt MjggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgogCiAgICAgICAgIE1pbm9y IGNsZWFudXAgaW4gVGVzdEludm9jYXRpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9ib3QvcXVldWVlbmdpbmUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L3F1ZXVlZW5naW5lLnB5CmluZGV4IDFkNzUzNTk2N2ViNmM1ZDNiM2NkZmQzZWQ1YzY2 MDMwMmZlMThiMDkuLjBkMmM5NzgyMDE0NTUwMDJkNjU3ZGRmNWI4NWM2ODEwOGQ3NWE2YWEgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcXVldWVlbmdpbmUucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9xdWV1ZWVuZ2luZS5weQpAQCAt MjcsMTMgKzI3LDE2IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCitpbXBvcnQg bG9nZ2luZwogaW1wb3J0IHN5cwogaW1wb3J0IHRyYWNlYmFjawogCiBmcm9tIGRhdGV0aW1lIGlt cG9ydCBkYXRldGltZSwgdGltZWRlbHRhCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCi1mcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0u ZGVwcmVjYXRlZF9sb2dnaW5nIGltcG9ydCBsb2csIE91dHB1dFRlZQorZnJvbSB3ZWJraXRweS5j b21tb24uc3lzdGVtLmRlcHJlY2F0ZWRfbG9nZ2luZyBpbXBvcnQgT3V0cHV0VGVlCisKK19sb2cg PSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKIAogCiAjIEZJWE1FOiBUaGlzIHdpbGwgYmUg Y2F1Z2h0IGJ5ICJleGNlcHQgRXhjZXB0aW9uOiIgYmxvY2tzLCB3ZSBzaG91bGQgY29uc2lkZXIK QEAgLTgwLDcgKzgzLDcgQEAgY2xhc3MgUXVldWVFbmdpbmU6CiAgICAgIyBDaGlsZCBwcm9jZXNz ZXMgZXhpdCB3aXRoIGEgc3BlY2lhbCBjb2RlIHRvIHRoZSBwYXJlbnQgcXVldWUgcHJvY2VzcyBj YW4gZGV0ZWN0IHRoZSBlcnJvciB3YXMgaGFuZGxlZC4KICAgICBAY2xhc3NtZXRob2QKICAgICBk ZWYgZXhpdF9hZnRlcl9oYW5kbGVkX2Vycm9yKGNscywgZXJyb3IpOgotICAgICAgICBsb2coZXJy b3IpCisgICAgICAgIF9sb2cuZXJyb3IoZXJyb3IpCiAgICAgICAgIHN5cy5leGl0KGNscy5oYW5k bGVkX2Vycm9yX2NvZGUpCiAKICAgICBkZWYgcnVuKHNlbGYpOgpAQCAtMTAwLDcgKzEwMyw3IEBA IGNsYXNzIFF1ZXVlRW5naW5lOgogICAgICAgICAgICAgICAgIHNlbGYuX29wZW5fd29ya19sb2co d29ya19pdGVtKQogICAgICAgICAgICAgICAgIHRyeToKICAgICAgICAgICAgICAgICAgICAgaWYg bm90IHNlbGYuX2RlbGVnYXRlLnByb2Nlc3Nfd29ya19pdGVtKHdvcmtfaXRlbSk6Ci0gICAgICAg ICAgICAgICAgICAgICAgICBsb2coIlVuYWJsZSB0byBwcm9jZXNzIHdvcmsgaXRlbS4iKQorICAg ICAgICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCJVbmFibGUgdG8gcHJvY2VzcyB3b3Jr IGl0ZW0uIikKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICAg ICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgogICAgICAgICAgICAgICAgICAgICAjIFVzZSBhIHNw ZWNpYWwgZXhpdCBjb2RlIHRvIGluZGljYXRlIHRoYXQgdGhlIGVycm9yIHdhcyBhbHJlYWR5CkBA IC0xMjMsNyArMTI2LDcgQEAgY2xhc3MgUXVldWVFbmdpbmU6CiAgICAgICAgIHJldHVybiAwCiAK ICAgICBkZWYgX3N0b3BwaW5nKHNlbGYsIG1lc3NhZ2UpOgotICAgICAgICBsb2coIlxuJXMiICUg bWVzc2FnZSkKKyAgICAgICAgX2xvZy5pbmZvKCJcbiVzIiAlIG1lc3NhZ2UpCiAgICAgICAgIHNl bGYuX2RlbGVnYXRlLnN0b3Bfd29ya19xdWV1ZShtZXNzYWdlKQogICAgICAgICAjIEJlIGNhcmVm dWwgdG8gc2h1dCBkb3duIG91ciBPdXRwdXRUZWUgb3IgdGhlIHVuaXQgdGVzdHMgd2lsbCBiZSB1 bmhhcHB5LgogICAgICAgICBzZWxmLl9lbnN1cmVfd29ya19sb2dfY2xvc2VkKCkKQEAgLTE1NCw2 ICsxNTcsNiBAQCBjbGFzcyBRdWV1ZUVuZ2luZToKICAgICAgICAgcmV0dXJuICIlcyBTbGVlcGlu ZyB1bnRpbCAlcyAoJXMpLiIgJSAobWVzc2FnZSwgd2FrZV90aW1lLnN0cmZ0aW1lKHNlbGYubG9n X2RhdGVfZm9ybWF0KSwgc2VsZi5zbGVlcF9kdXJhdGlvbl90ZXh0KQogCiAgICAgZGVmIF9zbGVl cChzZWxmLCBtZXNzYWdlKToKLSAgICAgICAgbG9nKHNlbGYuX3NsZWVwX21lc3NhZ2UobWVzc2Fn ZSkpCisgICAgICAgIF9sb2cuaW5mbyhzZWxmLl9zbGVlcF9tZXNzYWdlKG1lc3NhZ2UpKQogICAg ICAgICBzZWxmLl93YWtldXBfZXZlbnQud2FpdChzZWxmLnNlY29uZHNfdG9fc2xlZXApCiAgICAg ICAgIHNlbGYuX3dha2V1cF9ldmVudC5jbGVhcigpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvYm90L3F1ZXVlZW5naW5lX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9xdWV1ZWVuZ2luZV91bml0dGVzdC5weQppbmRleCAyNjc4OWVm MDVlZDU2NmJmMzFjMjdmZGVlZDI2MTA0ZGJlZjFkMzU4Li4wZWU4YjVhZDhjNzM1YzVlNTljYmQ4 NTVmZWZkNTY5MjM2MjBmYmNlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L3F1ZXVlZW5naW5lX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9ib3QvcXVldWVlbmdpbmVfdW5pdHRlc3QucHkKQEAgLTE0NSw4ICsxNDUsOCBAQCBj bGFzcyBRdWV1ZUVuZ2luZVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgZW5n aW5lID0gUXVldWVFbmdpbmUoInRlc3QtcXVldWUiLCBkZWxlZ2F0ZSwgdGhyZWFkaW5nLkV2ZW50 KCkpCiAgICAgICAgIGlmIG5vdCB0ZXJtaW5hdGlvbl9tZXNzYWdlOgogICAgICAgICAgICAgdGVy bWluYXRpb25fbWVzc2FnZSA9ICJEZWxlZ2F0ZSB0ZXJtaW5hdGVkIHF1ZXVlLiIKLSAgICAgICAg ZXhwZWN0ZWRfc3RkZXJyID0gIlxuJXNcbiIgJSB0ZXJtaW5hdGlvbl9tZXNzYWdlCi0gICAgICAg IE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBlbmdpbmUucnVuLCBleHBlY3Rl ZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorICAgICAgICBleHBlY3RlZF9sb2dzID0gIlxuJXNc biIgJSB0ZXJtaW5hdGlvbl9tZXNzYWdlCisgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRf b3V0cHV0cyhzZWxmLCBlbmdpbmUucnVuLCBleHBlY3RlZF9sb2dzPWV4cGVjdGVkX2xvZ3MpCiAK ICAgICBkZWYgX3Rlc3RfdGVybWluYXRpbmdfcXVldWUoc2VsZiwgZXhjZXB0aW9uLCB0ZXJtaW5h dGlvbl9tZXNzYWdlKToKICAgICAgICAgd29ya19pdGVtX2luZGV4ID0gTG9nZ2luZ0RlbGVnYXRl LmV4cGVjdGVkX2NhbGxiYWNrcy5pbmRleCgncHJvY2Vzc193b3JrX2l0ZW0nKQo=