103512 2012-11-28 05:40:15 -0800 Minor cleanup in TestInvocation 2012-11-28 06:13:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned kenneth webkit.review.bot oldest_to_newest 777804 0 yael 2012-11-28 05:40:15 -0800 This is in regards to a comment I received offline while reviewing bug #102833. 777809 1 176466 yael 2012-11-28 05:44:18 -0800 Created attachment 176466 Patch 777843 2 176466 webkit.review.bot 2012-11-28 06:13:18 -0800 Comment on attachment 176466 Patch Clearing flags on attachment: 176466 Committed r136004: <http://trac.webkit.org/changeset/136004> 777844 3 webkit.review.bot 2012-11-28 06:13:22 -0800 All reviewed patches have been landed. Closing bug. 176466 2012-11-28 05:44:18 -0800 2012-11-28 06:13:18 -0800 Patch 103512.patch text/plain 4458 yael SW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdEludm9jYXRpb25RdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0SW52b2NhdGlvblF0LmNw cAkocmV2aXNpb24gMTM2MDAxKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0SW52 b2NhdGlvblF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODUsNyArODUsNyBAQAogICAgICAgICBl bHNlIHsKICAgICAgICAgICAgIG1fZXJyb3IgPSB0cnVlOwogICAgICAgICAgICAgbV9lcnJvck1l c3NhZ2UgPSAiVGltZWQgb3V0IHdhaXRpbmcgZm9yIHJlcGFpbnRcbiI7Ci0gICAgICAgICAgICBt X3dlYlByb2Nlc3NJc1VucmVuc3BvbnNpdmUgPSB0cnVlOworICAgICAgICAgICAgbV93ZWJQcm9j ZXNzSXNVbnJlc3BvbnNpdmUgPSB0cnVlOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAgICAgfSBlbHNlCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL2NhaXJvL1Rlc3RJbnZv Y2F0aW9uQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvY2Fp cm8vVGVzdEludm9jYXRpb25DYWlyby5jcHAJKHJldmlzaW9uIDEzNjAwMSkKKysrIFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvY2Fpcm8vVGVzdEludm9jYXRpb25DYWlyby5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEyOSw3ICsxMjksNyBAQAogICAgIGlmICghbV9nb3RSZXBhaW50KSB7CiAgICAgICAg IG1fZXJyb3IgPSB0cnVlOwogICAgICAgICBtX2Vycm9yTWVzc2FnZSA9ICJUaW1lZCBvdXQgd2Fp dGluZyBmb3IgcmVwYWludFxuIjsKLSAgICAgICAgbV93ZWJQcm9jZXNzSXNVbnJlbnNwb25zaXZl ID0gdHJ1ZTsKKyAgICAgICAgbV93ZWJQcm9jZXNzSXNVbnJlc3BvbnNpdmUgPSB0cnVlOwogICAg ICAgICByZXR1cm47CiAgICAgfQogCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJ bnZvY2F0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52 b2NhdGlvbi5oCShyZXZpc2lvbiAxMzYwMDEpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rl c3RJbnZvY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDYgQEAKIAogI2lmIFBM QVRGT1JNKFFUKSB8fCBQTEFURk9STShFRkwpCiAgICAgc3RhdGljIHZvaWQgZm9yY2VSZXBhaW50 RG9uZUNhbGxiYWNrKFdLRXJyb3JSZWYsIHZvaWQqIGNvbnRleHQpOwotICAgIHZvaWQgZm9yY2VS ZXBhaW50RG9uZSgpOwogI2VuZGlmCiAgICAgCiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IG1f dXJsOwpAQCAtNzIsNyArNzEsNyBAQAogICAgIFdLUmV0YWluUHRyPFdLSW1hZ2VSZWY+IG1fcGl4 ZWxSZXN1bHQ7CiAgICAgV0tSZXRhaW5QdHI8V0tBcnJheVJlZj4gbV9yZXBhaW50UmVjdHM7CiAg ICAgc3RkOjpzdHJpbmcgbV9lcnJvck1lc3NhZ2U7Ci0gICAgYm9vbCBtX3dlYlByb2Nlc3NJc1Vu cmVuc3BvbnNpdmU7CisgICAgYm9vbCBtX3dlYlByb2Nlc3NJc1VucmVzcG9uc2l2ZTsKIAogfTsK IApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAJKHJldmlz aW9uIDEzNjAwMSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMDUsNyArMTA1LDcgQEAKICAgICAsIG1fZ290RmluYWxNZXNz YWdlKGZhbHNlKQogICAgICwgbV9nb3RSZXBhaW50KGZhbHNlKQogICAgICwgbV9lcnJvcihmYWxz ZSkKLSAgICAsIG1fd2ViUHJvY2Vzc0lzVW5yZW5zcG9uc2l2ZShmYWxzZSkKKyAgICAsIG1fd2Vi UHJvY2Vzc0lzVW5yZXNwb25zaXZlKGZhbHNlKQogewogfQogCkBAIC0yMTMsNyArMjEzLDcgQEAK ICAgICBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkucnVuVW50aWwobV9nb3RJbml0aWFsUmVzcG9u c2UsIFRlc3RDb250cm9sbGVyOjpTaG9ydFRpbWVvdXQpOwogICAgIGlmICghbV9nb3RJbml0aWFs UmVzcG9uc2UpIHsKICAgICAgICAgbV9lcnJvck1lc3NhZ2UgPSAiVGltZWQgb3V0IHdhaXRpbmcg Zm9yIGluaXRpYWwgcmVzcG9uc2UgZnJvbSB3ZWIgcHJvY2Vzc1xuIjsKLSAgICAgICAgbV93ZWJQ cm9jZXNzSXNVbnJlbnNwb25zaXZlID0gdHJ1ZTsKKyAgICAgICAgbV93ZWJQcm9jZXNzSXNVbnJl c3BvbnNpdmUgPSB0cnVlOwogICAgICAgICBnb3RvIGVuZDsKICAgICB9CiAgICAgaWYgKG1fZXJy b3IpCkBAIC0yMjksNyArMjI5LDcgQEAKICAgICBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkucnVu VW50aWwobV9nb3RGaW5hbE1lc3NhZ2UsIFRlc3RDb250cm9sbGVyOjpzaGFyZWQoKS51c2VXYWl0 VG9EdW1wV2F0Y2hkb2dUaW1lcigpID8gVGVzdENvbnRyb2xsZXI6OkxvbmdUaW1lb3V0IDogVGVz dENvbnRyb2xsZXI6Ok5vVGltZW91dCk7CiAgICAgaWYgKCFtX2dvdEZpbmFsTWVzc2FnZSkgewog ICAgICAgICBtX2Vycm9yTWVzc2FnZSA9ICJUaW1lZCBvdXQgd2FpdGluZyBmb3IgZmluYWwgbWVz c2FnZSBmcm9tIHdlYiBwcm9jZXNzXG4iOwotICAgICAgICBtX3dlYlByb2Nlc3NJc1VucmVuc3Bv bnNpdmUgPSB0cnVlOworICAgICAgICBtX3dlYlByb2Nlc3NJc1VucmVzcG9uc2l2ZSA9IHRydWU7 CiAgICAgICAgIGdvdG8gZW5kOwogICAgIH0KICAgICBpZiAobV9lcnJvcikKQEAgLTI0Myw3ICsy NDMsNyBAQAogICAgICAgICBXS0luc3BlY3RvckNsb3NlKFdLUGFnZUdldEluc3BlY3RvcihUZXN0 Q29udHJvbGxlcjo6c2hhcmVkKCkubWFpbldlYlZpZXcoKS0+cGFnZSgpKSk7CiAjZW5kaWYgLy8g RU5BQkxFKElOU1BFQ1RPUikKIAotICAgIGlmIChtX3dlYlByb2Nlc3NJc1VucmVuc3BvbnNpdmUp CisgICAgaWYgKG1fd2ViUHJvY2Vzc0lzVW5yZXNwb25zaXZlKQogICAgICAgICBkdW1wV2ViUHJv Y2Vzc1VucmVzcG9uc2l2ZW5lc3MoKTsKICAgICBlbHNlIGlmICghVGVzdENvbnRyb2xsZXI6OnNo YXJlZCgpLnJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMoKSkgewogICAgICAgICBtX2Vycm9y TWVzc2FnZSA9ICJUaW1lZCBvdXQgbG9hZGluZyBhYm91dDpibGFuayBiZWZvcmUgdGhlIG5leHQg dGVzdCI7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAxMzYwMDEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMS0yOCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBp bnRlbC5jb20+CisKKyAgICAgICAgTWlub3IgY2xlYW51cCBpbiBUZXN0SW52b2NhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNTEyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGEgZnVu Y3Rpb24gZGVjbGFyYXRpb24gdGhhdCBpcyBub3QgZGVmaW5lZCBhbmQgbm90IHVzZWQuCisgICAg ICAgIEZpeCBzcGVsbGluZyBlcnJvciBpbiBtX3dlYlByb2Nlc3NJc1VucmVzcG9uc2l2ZS4KKwor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwOgorICAgICAgICAo V1RSOjpUZXN0SW52b2NhdGlvbjo6VGVzdEludm9jYXRpb24pOgorICAgICAgICAoV1RSOjpUZXN0 SW52b2NhdGlvbjo6aW52b2tlKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZv Y2F0aW9uLmg6CisgICAgICAgIChUZXN0SW52b2NhdGlvbik6CisgICAgICAgICogV2ViS2l0VGVz dFJ1bm5lci9jYWlyby9UZXN0SW52b2NhdGlvbkNhaXJvLmNwcDoKKyAgICAgICAgKFdUUjo6VGVz dEludm9jYXRpb246OmR1bXBQaXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKToKKyAgICAgICAg KiBXZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RJbnZvY2F0aW9uUXQuY3BwOgorICAgICAgICAoV1RS OjpUZXN0SW52b2NhdGlvbjo6ZHVtcFBpeGVsc0FuZENvbXBhcmVXaXRoRXhwZWN0ZWQpOgorCiAy MDEyLTExLTI4ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVzZSBteSBwZXJzb25hbCBlbWFpbCBhcyBidWd6 aWxsYSBlbWFpbC4K