103509 2012-11-28 05:25:57 -0800 .libs/libwebkitgtk-3.0.so: undefined reference to `WebCore::validationMessageBadInputForNumberText() 2012-11-28 08:08:30 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Blocker --- 0 obzhirov webkit-unassigned d.nomiyama pnormand webkit.review.bot oldest_to_newest 777786 0 obzhirov 2012-11-28 05:25:57 -0800 Will attach fix now. 777794 1 176462 obzhirov 2012-11-28 05:33:05 -0800 Created attachment 176462 Patch 777816 2 176462 pnormand 2012-11-28 05:52:20 -0800 Comment on attachment 176462 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176462&action=review > Source/WebCore/ChangeLog:8 > + Quick fix for build problem for WebKit/GTK. Usually build fixes mention which revision introduced the break. Like, "GTK build fix after r???????" 777847 3 obzhirov 2012-11-28 06:14:48 -0800 Release was 136001. Will take into account in the future.(In reply to comment #2) > (From update of attachment 176462 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176462&action=review > > > Source/WebCore/ChangeLog:8 > > + Quick fix for build problem for WebKit/GTK. > > Usually build fixes mention which revision introduced the break. Like, "GTK build fix after r???????" Release was 136001. Will take into account in the future. 777859 4 pnormand 2012-11-28 06:27:49 -0800 Are you uploading a new patch then? Also the GTK builders don't appear more broken than usual, apart from the 32-bit bot but for different reason I believe. 777869 5 176478 obzhirov 2012-11-28 06:41:14 -0800 Created attachment 176478 Patch 777870 6 obzhirov 2012-11-28 06:42:38 -0800 Done. I do have build problem as my colleague here as well. 777877 7 176478 pnormand 2012-11-28 06:49:36 -0800 Comment on attachment 176478 Patch Thanks! 777911 8 176478 pnormand 2012-11-28 08:05:21 -0800 Comment on attachment 176478 Patch Clearing flags on attachment: 176478 Committed r136010: <http://trac.webkit.org/changeset/136010> 777912 9 pnormand 2012-11-28 08:05:26 -0800 All reviewed patches have been landed. Closing bug. 777918 10 pnormand 2012-11-28 08:08:30 -0800 The cq went wild it seems. I landed manually. 176462 2012-11-28 05:33:05 -0800 2012-11-28 06:41:09 -0800 Patch bug-103509-20121128133116.patch text/plain 1309 obzhirov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjAwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI4ICBBbnRvbiBP YnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IC5saWJzL2xp YndlYmtpdGd0ay0zLjAuc286IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYFdlYkNvcmU6OnZhbGlk YXRpb25NZXNzYWdlQmFkSW5wdXRGb3JOdW1iZXJUZXh0KCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1MDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdWljayBmaXggZm9yIGJ1aWxkIHByb2JsZW0g Zm9yIFdlYktpdC9HVEsuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5n c0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2FnZUJhZElucHV0Rm9y TnVtYmVyVGV4dCk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0xMS0yOCAgQWxsYW4gU2Fu ZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAogICAgICAgICBNb3ZlIGNo aWxkcmVuQWZmZWN0ZWRCeSBiaXRzIGZyb20gUmVuZGVyU3R5bGUgdG8gRWxlbWVudApJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3Rr LmNwcAkocmV2aXNpb24gMTM1OTk0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xv Y2FsaXplZFN0cmluZ3NHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDEsNCArNzQxLDEwIEBA IFN0cmluZyBsb2NhbGl6ZWRTdHJpbmcoY29uc3QgY2hhcioga2V5KQogICAgIHJldHVybiBTdHJp bmc6OmZyb21VVEY4KGtleSwgc3RybGVuKGtleSkpOwogfQogCitTdHJpbmcgdmFsaWRhdGlvbk1l c3NhZ2VCYWRJbnB1dEZvck51bWJlclRleHQoKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgcmV0dXJuIHZhbGlkYXRpb25NZXNzYWdlVHlwZU1pc21hdGNoVGV4dCgpOworfQorCiB9Cg== 176478 2012-11-28 06:41:14 -0800 2012-11-28 08:05:20 -0800 Patch bug-103509-20121128143925.patch text/plain 1294 obzhirov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjAwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI4ICBBbnRvbiBP YnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IC5saWJzL2xp YndlYmtpdGd0ay0zLjAuc286IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYFdlYkNvcmU6OnZhbGlk YXRpb25NZXNzYWdlQmFkSW5wdXRGb3JOdW1iZXJUZXh0KCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM1MDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHVEsgYnVpbGQgZml4IGFmdGVyIHIxMzYwMDEu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2FnZUJhZElucHV0Rm9yTnVtYmVyVGV4dCk6Cisg ICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0xMS0yOCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8 YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAogICAgICAgICBNb3ZlIGNoaWxkcmVuQWZmZWN0ZWRC eSBiaXRzIGZyb20gUmVuZGVyU3R5bGUgdG8gRWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcAkocmV2aXNpb24g MTM1OTk0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NH dGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDEsNCArNzQxLDEwIEBAIFN0cmluZyBsb2NhbGl6 ZWRTdHJpbmcoY29uc3QgY2hhcioga2V5KQogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KGtl eSwgc3RybGVuKGtleSkpOwogfQogCitTdHJpbmcgdmFsaWRhdGlvbk1lc3NhZ2VCYWRJbnB1dEZv ck51bWJlclRleHQoKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIHZhbGlk YXRpb25NZXNzYWdlVHlwZU1pc21hdGNoVGV4dCgpOworfQorCiB9Cg==