103505 2012-11-28 04:21:15 -0800 [EFL][WK2][AC] No need to export GL properties from EwkViewImpl class 2012-11-28 04:57:19 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 777735 0 mikhail.pozdnyakov 2012-11-28 04:21:15 -0800 No need to export GL data members from EwkViewImpl, those are internal implementation objects not used by anyone outside the class. 777738 1 176453 mikhail.pozdnyakov 2012-11-28 04:24:44 -0800 Created attachment 176453 patch 777764 2 176453 webkit.review.bot 2012-11-28 04:57:14 -0800 Comment on attachment 176453 patch Clearing flags on attachment: 176453 Committed r135999: <http://trac.webkit.org/changeset/135999> 777765 3 webkit.review.bot 2012-11-28 04:57:19 -0800 All reviewed patches have been landed. Closing bug. 176453 2012-11-28 04:24:44 -0800 2012-11-28 04:57:14 -0800 patch bug103505 text/plain 4457 mikhail.pozdnyakov Y29tbWl0IDQwMTBkNDdiNDFjMDBhN2ZjZGUzZmRiY2Y3ZmE3ODdiZGI1NDE5OWEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIE5vdiAyOCAxNDoyMToxOCAyMDEyICswMjAwCgogICAgYnVnMTAzNTA1CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDNhZDYwZTQuLjA5Yzg4OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0x MS0yOCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdW0FDXSBObyBuZWVkIHRvIGV4cG9ydCBHTCBwcm9wZXJ0aWVz IGZyb20gRXdrVmlld0ltcGwgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzUwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5lZWQgdG8gZXhwb3J0IEdMIGRhdGEgbWVtYmVycyBmcm9tIEV3 a1ZpZXdJbXBsIGNsYXNzLCAKKyAgICAgICAgdGhvc2UgYXJlIGludGVybmFsIGltcGxlbWVudGF0 aW9uIG9iamVjdHMgbm90IHVzZWQgYnkgYW55b25lIG91dHNpZGUgdGhlIGNsYXNzLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwOgorICAgICAgICAoRXdrVmll d0ltcGw6OmRpc3BsYXlUaW1lckZpcmVkKToKKyAgICAgICAgKEV3a1ZpZXdJbXBsOjpjcmVhdGVH TFN1cmZhY2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6Cisg ICAgICAgIChFd2tWaWV3SW1wbCk6CisgICAgICAgIChFd2tWaWV3SW1wbDo6ZXZhc0dMQ29udGV4 dCk6CisgICAgICAgIChFd2tWaWV3SW1wbDo6ZXZhc0dMU3VyZmFjZSk6CisKIDIwMTItMTEtMjcg IEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxd W1dLMl0gRHVwbGljYXRlZCBXZWJQYWdlR3JvdXAgaW5pdGlhbGl6YXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAppbmRleCBjZTM4MjU0 Li5hNjA2MzRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9F d2tWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdr Vmlld0ltcGwuY3BwCkBAIC0zNjEsNyArMzYxLDcgQEAgdm9pZCBFd2tWaWV3SW1wbDo6ZGlzcGxh eVRpbWVyRmlyZWQoVGltZXI8RXdrVmlld0ltcGw+KikKICNpZiBVU0UoQ09PUkRJTkFURURfR1JB UEhJQ1MpCiAgICAgRXdrX1ZpZXdfU21hcnRfRGF0YSogc2QgPSBzbWFydERhdGEoKTsKIAotICAg IGV2YXNfZ2xfbWFrZV9jdXJyZW50KGV2YXNHTCgpLCBldmFzR0xTdXJmYWNlKCksIGV2YXNHTENv bnRleHQoKSk7CisgICAgZXZhc19nbF9tYWtlX2N1cnJlbnQobV9ldmFzR0wuZ2V0KCksIGV2YXNH TFN1cmZhY2UoKSwgZXZhc0dMQ29udGV4dCgpKTsKIAogICAgIC8vIFdlIGFyZSBzdXBwb3NlZCB0 byBjbGlwIHRvIHRoZSBhY3R1YWwgdmlld3BvcnQsIG5vdGhpbmcgbGVzcy4KICAgICBJbnRSZWN0 IHZpZXdwb3J0KHNkLT52aWV3LngsIHNkLT52aWV3LnksIHNkLT52aWV3LncsIHNkLT52aWV3Lmgp OwpAQCAtNjM1LDcgKzYzNSw3IEBAIGJvb2wgRXdrVmlld0ltcGw6OmNyZWF0ZUdMU3VyZmFjZShj b25zdCBJbnRTaXplJiB2aWV3U2l6ZSkKICAgICB9CiAKICAgICBpZiAoIW1fZXZhc0dMQ29udGV4 dCkgewotICAgICAgICBtX2V2YXNHTENvbnRleHQgPSBFdmFzR0xDb250ZXh0OjpjcmVhdGUoZXZh c0dMKCkpOworICAgICAgICBtX2V2YXNHTENvbnRleHQgPSBFdmFzR0xDb250ZXh0OjpjcmVhdGUo bV9ldmFzR0wuZ2V0KCkpOwogICAgICAgICBpZiAoIW1fZXZhc0dMQ29udGV4dCkgewogICAgICAg ICAgICAgV0FSTigiRmFpbGVkIHRvIGNyZWF0ZSBHTENvbnRleHQuIik7CiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CkBAIC02NTMsMTcgKzY1MywxNyBAQCBib29sIEV3a1ZpZXdJbXBsOjpjcmVh dGVHTFN1cmZhY2UoY29uc3QgSW50U2l6ZSYgdmlld1NpemUpCiAgICAgfTsKIAogICAgIC8vIFJl cGxhY2VzIGlmIG5vbi1udWxsLCBhbmQgZnJlZXMgZXhpc3Rpbmcgc3VyZmFjZSBhZnRlciAoT3du UHRyKS4KLSAgICBtX2V2YXNHTFN1cmZhY2UgPSBFdmFzR0xTdXJmYWNlOjpjcmVhdGUoZXZhc0dM KCksICZldmFzR0xDb25maWcsIHZpZXdTaXplKTsKKyAgICBtX2V2YXNHTFN1cmZhY2UgPSBFdmFz R0xTdXJmYWNlOjpjcmVhdGUobV9ldmFzR0wuZ2V0KCksICZldmFzR0xDb25maWcsIHZpZXdTaXpl KTsKICAgICBpZiAoIW1fZXZhc0dMU3VyZmFjZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAg ICAgRXZhc19OYXRpdmVfU3VyZmFjZSBuYXRpdmVTdXJmYWNlOwotICAgIGV2YXNfZ2xfbmF0aXZl X3N1cmZhY2VfZ2V0KGV2YXNHTCgpLCBldmFzR0xTdXJmYWNlKCksICZuYXRpdmVTdXJmYWNlKTsK KyAgICBldmFzX2dsX25hdGl2ZV9zdXJmYWNlX2dldChtX2V2YXNHTC5nZXQoKSwgZXZhc0dMU3Vy ZmFjZSgpLCAmbmF0aXZlU3VyZmFjZSk7CiAgICAgZXZhc19vYmplY3RfaW1hZ2VfbmF0aXZlX3N1 cmZhY2Vfc2V0KHNkLT5pbWFnZSwgJm5hdGl2ZVN1cmZhY2UpOwogCi0gICAgZXZhc19nbF9tYWtl X2N1cnJlbnQoZXZhc0dMKCksIGV2YXNHTFN1cmZhY2UoKSwgZXZhc0dMQ29udGV4dCgpKTsKKyAg ICBldmFzX2dsX21ha2VfY3VycmVudChtX2V2YXNHTC5nZXQoKSwgZXZhc0dMU3VyZmFjZSgpLCBl dmFzR0xDb250ZXh0KCkpOwogCi0gICAgRXZhc19HTF9BUEkqIGdsID0gZXZhc19nbF9hcGlfZ2V0 KGV2YXNHTCgpKTsKKyAgICBFdmFzX0dMX0FQSSogZ2wgPSBldmFzX2dsX2FwaV9nZXQobV9ldmFz R0wuZ2V0KCkpOwogICAgIGdsLT5nbFZpZXdwb3J0KDAsIDAsIHZpZXdTaXplLndpZHRoKCkgKyBz ZC0+dmlldy54LCB2aWV3U2l6ZS5oZWlnaHQoKSArIHNkLT52aWV3LnkpOwogCiAgICAgcmV0dXJu IHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tW aWV3SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwu aAppbmRleCBmMzJiZjQ3Li45ZGE3ZmY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgKQEAgLTIwMywxMSArMjAzLDYgQEAgcHVibGljOgogICAg IHZvaWQgc2V0U2Nyb2xsUG9zaXRpb24oV2ViQ29yZTo6SW50UG9pbnQgcG9zaXRpb24pIHsgbV9z Y3JvbGxQb3NpdGlvbiA9IHBvc2l0aW9uOyB9CiAgICAgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQg c2Nyb2xsUG9zaXRpb24oKSBjb25zdCB7IHJldHVybiBtX3Njcm9sbFBvc2l0aW9uOyB9CiAjZW5k aWYKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgRXZhc19HTCogZXZhc0dM KCkgeyByZXR1cm4gbV9ldmFzR0wuZ2V0KCk7IH0KLSAgICBFdmFzX0dMX0NvbnRleHQqIGV2YXNH TENvbnRleHQoKSB7IHJldHVybiBtX2V2YXNHTENvbnRleHQgPyBtX2V2YXNHTENvbnRleHQtPmNv bnRleHQoKSA6IDA7IH0KLSAgICBFdmFzX0dMX1N1cmZhY2UqIGV2YXNHTFN1cmZhY2UoKSB7IHJl dHVybiBtX2V2YXNHTFN1cmZhY2UgPyBtX2V2YXNHTFN1cmZhY2UtPnN1cmZhY2UoKSA6IDA7IH0K LSNlbmRpZgogCiAgICAgLy8gRklYTUU6IG5lZWRzIHJlZmFjdG9yaW5nIChzcGxpdCBjYWxsYmFj ayBpbnZva2UpCiAgICAgdm9pZCBpbmZvcm1VUkxDaGFuZ2UoKTsKQEAgLTIxOCw2ICsyMTMsMTEg QEAgcHVibGljOgogICAgIFdLSW1hZ2VSZWYgdGFrZVNuYXBzaG90KCk7CiAKIHByaXZhdGU6Cisj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIEV2YXNfR0xfQ29udGV4dCogZXZh c0dMQ29udGV4dCgpIHsgcmV0dXJuIG1fZXZhc0dMQ29udGV4dCA/IG1fZXZhc0dMQ29udGV4dC0+ Y29udGV4dCgpIDogMDsgfQorICAgIEV2YXNfR0xfU3VyZmFjZSogZXZhc0dMU3VyZmFjZSgpIHsg cmV0dXJuIG1fZXZhc0dMU3VyZmFjZSA/IG1fZXZhc0dMU3VyZmFjZS0+c3VyZmFjZSgpIDogMDsg fQorI2VuZGlmCisKICAgICBpbmxpbmUgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhKCkg Y29uc3Q7CiAgICAgdm9pZCBkaXNwbGF5VGltZXJGaXJlZChXZWJDb3JlOjpUaW1lcjxFd2tWaWV3 SW1wbD4qKTsKIAo=