103502 2012-11-28 04:01:51 -0800 Node::compareDocumentPosition returns wrong value for a node in the different shadow tree. 2012-11-28 20:56:40 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72352 1 hayato hayato ojan webcomponents-bugzilla webkit.review.bot oldest_to_newest 777723 0 hayato 2012-11-28 04:01:51 -0800 According to the spec (http://dom.spec.whatwg.org/#dom-node-comparedocumentposition), if two nodes are not in the same tree, we should return DOCUMENT_POSITION_DISCONNECTED, DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC. But the current implementation mays not return that for nodes which are in different shadow trees. 777814 1 176468 hayato 2012-11-28 05:49:46 -0800 Created attachment 176468 Fix Node::compareDocumentPosition for nodes in shadow tree. 778608 2 176468 webkit.review.bot 2012-11-28 19:18:40 -0800 Comment on attachment 176468 Fix Node::compareDocumentPosition for nodes in shadow tree. Clearing flags on attachment: 176468 Committed r136087: <http://trac.webkit.org/changeset/136087> 778609 3 webkit.review.bot 2012-11-28 19:18:43 -0800 All reviewed patches have been landed. Closing bug. 176468 2012-11-28 05:49:46 -0800 2012-11-28 19:18:40 -0800 Fix Node::compareDocumentPosition for nodes in shadow tree. bug-103502-20121128224721.patch text/plain 7219 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjgwYTJlMjc1YzJjNmJj ZGFkOGQ1YTRkNjc5MjIyMmFkYjJlYjZhOC4uZWEwYmJkZDcxODU2NjMwZjQ2MmNiODhkMzY5YTA2 MWFiOWU2YmZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTI4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBOb2RlOjpjb21wYXJlRG9j dW1lbnRQb3NpdGlvbiByZXR1cm5zIHdyb25nIHZhbHVlIGZvciBhIG5vZGUgaW4gdGhlIGRpZmZl cmVudCBzaGFkb3cgdHJlZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMzUwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1ha2UgTm9kZTo6Y29tcGFyZURvY3VtZW50UG9zaXRpb24oKSByZXR1cm4gdGhl IGNvcnJlY3QgdmFsdWUgd2hlbiB0d28gbm9kZXMgYXJlIGluIHRoZSBkaWZmZXJlbnQgc2hhZG93 IHRyZWVzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL3NoYWRvdy9jb21wYXJlLWRvY3VtZW50 LXBvc2l0aW9uLmh0bWwKKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok5vZGU6OmNvbXBhcmVEb2N1bWVudFBvc2l0aW9uKToKKwogMjAxMi0xMS0yNyAgSnVsaWVu IENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBTdXBwb3J0IHBy b3BlciA8cGVyY2VudD4gLyBjYWxjKCkgcmVzb2x1dGlvbiBmb3IgZ3JpZCBpdGVtcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05v ZGUuY3BwCmluZGV4IDk1ZjhmNWNjMTUzYWQ1ZGFiYWZmMDY1NDljYTljYWY0ZTU4MzIzMjkuLjIw MGNiZmUzNWJkOWM5M2MzYzk4NTE4YzIyMjM5NzU4MTdkZTIyNTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAK QEAgLTIwMDEsNyArMjAwMSw3IEBAIHVuc2lnbmVkIHNob3J0IE5vZGU6OmNvbXBhcmVEb2N1bWVu dFBvc2l0aW9uKE5vZGUqIG90aGVyTm9kZSkKICAgICAvLyBJZiB0aGUgbm9kZXMgaGF2ZSBkaWZm ZXJlbnQgb3duaW5nIGRvY3VtZW50cywgdGhleSBtdXN0IGJlIGRpc2Nvbm5lY3RlZC4gIE5vdGUg dGhhdCB3ZSBhdm9pZAogICAgIC8vIGNvbXBhcmluZyBBdHRyIG5vZGVzIGhlcmUsIHNpbmNlIHRo ZXkgcmV0dXJuIGZhbHNlIGZyb20gaW5Eb2N1bWVudCgpIGFsbCB0aGUgdGltZSAod2hpY2ggc2Vl bXMgbGlrZSBhIGJ1ZykuCiAgICAgaWYgKHN0YXJ0MS0+aW5Eb2N1bWVudCgpICE9IHN0YXJ0Mi0+ aW5Eb2N1bWVudCgpIHx8Ci0gICAgICAgIHN0YXJ0MS0+ZG9jdW1lbnQoKSAhPSBzdGFydDItPmRv Y3VtZW50KCkpCisgICAgICAgIHN0YXJ0MS0+dHJlZVNjb3BlKCkgIT0gc3RhcnQyLT50cmVlU2Nv cGUoKSkKICAgICAgICAgcmV0dXJuIERPQ1VNRU5UX1BPU0lUSU9OX0RJU0NPTk5FQ1RFRCB8IERP Q1VNRU5UX1BPU0lUSU9OX0lNUExFTUVOVEFUSU9OX1NQRUNJRklDOwogCiAgICAgLy8gV2UgbmVl ZCB0byBmaW5kIGEgY29tbW9uIGFuY2VzdG9yIGNvbnRhaW5lciwgYW5kIHRoZW4gY29tcGFyZSB0 aGUgaW5kaWNlcyBvZiB0aGUgdHdvIGltbWVkaWF0ZSBjaGlsZHJlbi4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMGY5MzNk YTgzNDYwOGRlZDA1ZWQyYzA5NDFjM2U2ZDhiZjc3MTM5Li42MjBmZTM1ZTM4MGZjMWIzM2I4Njgy NjI5MjIzOTI2NmQ0ZTMzMDlmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTEtMjggIEhh eWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5vZGU6OmNvbXBhcmVE b2N1bWVudFBvc2l0aW9uIHJldHVybnMgd3JvbmcgdmFsdWUgZm9yIGEgbm9kZSBpbiB0aGUgZGlm ZmVyZW50IHNoYWRvdyB0cmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAzNTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvY29tcGFyZS1kb2N1bWVudC1wb3NpdGlvbi1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9jb21wYXJlLWRv Y3VtZW50LXBvc2l0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDEyLTExLTI3ICBLZW50IFRhbXVyYSAg PHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVwZGF0ZSB0ZXN0IHJl c3VsdHMgZm9yIHJlY2VudCBmb3JtcyBjaGFuZ2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvY29tcGFyZS1kb2N1bWVudC1wb3NpdGlvbi1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29tcGFyZS1kb2N1bWVudC1wb3NpdGlvbi1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYTEzYmUzOWYyMzJlY2QwZTE0YjBmMzVlNDQ5YzUzYWM4ZTY3 OWNkYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9jb21w YXJlLWRvY3VtZW50LXBvc2l0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE3IEBACitUZXN0 cyBmb3IgTm9kZS5jb21wYXJlRG9jdW1lbnRQb3NpdGlvbigpIGZvciBub2RlcyBpbiBzaGFkb3cg dHJlZS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNz YWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgYTEuY29tcGFyZURv Y3VtZW50UG9zaXRpb24oYTIpIGlzIE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fQ09OVEFJTkVEX0JZ IHwgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9GT0xMT1dJTkcKK1BBU1MgYTIuY29tcGFyZURvY3Vt ZW50UG9zaXRpb24oYTEpIGlzIE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fQ09OVEFJTlMgfCBOb2Rl LkRPQ1VNRU5UX1BPU0lUSU9OX1BSRUNFRElORworUEFTUyBhMi5jb21wYXJlRG9jdW1lbnRQb3Np dGlvbihhMykgaXMgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9GT0xMT1dJTkcKK1BBU1MgYjEuY29t cGFyZURvY3VtZW50UG9zaXRpb24oYjIpIGlzIE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fQ09OVEFJ TkVEX0JZIHwgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9GT0xMT1dJTkcKK1BBU1MgYjIuY29tcGFy ZURvY3VtZW50UG9zaXRpb24oYjEpIGlzIE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fQ09OVEFJTlMg fCBOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX1BSRUNFRElORworUEFTUyBiMi5jb21wYXJlRG9jdW1l bnRQb3NpdGlvbihiMykgaXMgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9GT0xMT1dJTkcKK1BBU1Mg YTEuY29tcGFyZURvY3VtZW50UG9zaXRpb24oYjEpICYgKE5vZGUuRE9DVU1FTlRfUE9TSVRJT05f RElTQ09OTkVDVEVEIHwgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9JTVBMRU1FTlRBVElPTl9TUEVD SUZJQykgaXMgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9ESVNDT05ORUNURUQgfCBOb2RlLkRPQ1VN RU5UX1BPU0lUSU9OX0lNUExFTUVOVEFUSU9OX1NQRUNJRklDCitQQVNTIGIxLmNvbXBhcmVEb2N1 bWVudFBvc2l0aW9uKGMxKSAmIChOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0RJU0NPTk5FQ1RFRCB8 IE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fSU1QTEVNRU5UQVRJT05fU1BFQ0lGSUMpIGlzIE5vZGUu RE9DVU1FTlRfUE9TSVRJT05fRElTQ09OTkVDVEVEIHwgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9J TVBMRU1FTlRBVElPTl9TUEVDSUZJQworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRv dy9jb21wYXJlLWRvY3VtZW50LXBvc2l0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9z aGFkb3cvY29tcGFyZS1kb2N1bWVudC1wb3NpdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjAzNDc0ODYy YWJhNDg0ZjE1ZGE3ZmNhYjM2ODUwOTNiYzkzM2MzMjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29tcGFyZS1kb2N1bWVudC1wb3NpdGlvbi5odG1sCkBA IC0wLDAgKzEsNTkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQg c3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlw dCBzcmM9InJlc291cmNlcy9zaGFkb3ctZG9tLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8ZGl2IGlkPSJzYW5kYm94Ij48L2Rpdj4KKzxz Y3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgZm9yIE5vZGUuY29tcGFyZURvY3VtZW50UG9zaXRp b24oKSBmb3Igbm9kZXMgaW4gc2hhZG93IHRyZWUuIik7CisKK2lmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3NhbmRib3gnKS5hcHBlbmRDaGlsZCgKKyAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAn YTEnfSwKKyAgICAgICAgICAgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2EyJ30sCisgICAg ICAgICAgICAgICAgICAgICAgICBjcmVhdGVTaGFkb3dSb290KGNyZWF0ZURPTSgnZGl2Jywgeydp ZCc6ICdiMSd9LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2IyJ30pLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzog J2IzJ30pKSkpLAorICAgICAgICAgICAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAnYTMnfSwK KyAgICAgICAgICAgICAgICAgICAgICAgIGNyZWF0ZVNoYWRvd1Jvb3QoY3JlYXRlRE9NKCdkaXYn LCB7J2lkJzogJ2MxJ30pKSkpKTsKKwordmFyIGExLCBhMiwgYTMsIGIxLCBiMiwgYjMsIGMxOwor CitmdW5jdGlvbiB0ZXN0Q29tcGFyZURvY3VtZW50UG9zaXRpb24oKQoreworICAgIHZhciBzYW5k Ym94ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3NhbmRib3gnKTsKKyAgICBkb2N1bWVudC5i b2R5Lm9mZnNldExlZnQ7CisKKyAgICBhMSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhMScp OworICAgIGEyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2EyJyk7CisgICAgYTMgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnYTMnKTsKKyAgICBiMSA9IGdldE5vZGVJblNoYWRvd1RyZWVT dGFjaygnYTIvYjEnKTsKKyAgICBiMiA9IGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnYTIvYjIn KTsKKyAgICBiMyA9IGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnYTIvYjMnKTsKKyAgICBjMSA9 IGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnYTMvYzEnKTsKKworICAgIHNob3VsZEJlKCdhMS5j b21wYXJlRG9jdW1lbnRQb3NpdGlvbihhMiknLCAnTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9DT05U QUlORURfQlkgfCBOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0ZPTExPV0lORycpOworICAgIHNob3Vs ZEJlKCdhMi5jb21wYXJlRG9jdW1lbnRQb3NpdGlvbihhMSknLCAnTm9kZS5ET0NVTUVOVF9QT1NJ VElPTl9DT05UQUlOUyB8IE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fUFJFQ0VESU5HJyk7CisgICAg c2hvdWxkQmUoJ2EyLmNvbXBhcmVEb2N1bWVudFBvc2l0aW9uKGEzKScsICdOb2RlLkRPQ1VNRU5U X1BPU0lUSU9OX0ZPTExPV0lORycpOworCisgICAgc2hvdWxkQmUoJ2IxLmNvbXBhcmVEb2N1bWVu dFBvc2l0aW9uKGIyKScsICdOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0NPTlRBSU5FRF9CWSB8IE5v ZGUuRE9DVU1FTlRfUE9TSVRJT05fRk9MTE9XSU5HJyk7CisgICAgc2hvdWxkQmUoJ2IyLmNvbXBh cmVEb2N1bWVudFBvc2l0aW9uKGIxKScsICdOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0NPTlRBSU5T IHwgTm9kZS5ET0NVTUVOVF9QT1NJVElPTl9QUkVDRURJTkcnKTsKKyAgICBzaG91bGRCZSgnYjIu Y29tcGFyZURvY3VtZW50UG9zaXRpb24oYjMpJywgJ05vZGUuRE9DVU1FTlRfUE9TSVRJT05fRk9M TE9XSU5HJyk7CisKKyAgICAvLyBXZSBkbyBub3QgdGVzdCBGT0xMT1dJTkcgT1IgUFJFQ0VESU5H IGZsYWcgdW50aWwgd2UgaGF2ZSBhIHN0YWJsZSBpbXBsZW1lbnRhdGlvbiB3aGljaCBkZWNpZGVz IHRoZSB0b3RhbCBvcmRlciBiZXR3ZWVuIG5vZGVzIGluIGRpZmZlcmVudCBzaGFkb3cgdHJlZXMu CisgICAgc2hvdWxkQmUoJ2ExLmNvbXBhcmVEb2N1bWVudFBvc2l0aW9uKGIxKSAmIChOb2RlLkRP Q1VNRU5UX1BPU0lUSU9OX0RJU0NPTk5FQ1RFRCB8IE5vZGUuRE9DVU1FTlRfUE9TSVRJT05fSU1Q TEVNRU5UQVRJT05fU1BFQ0lGSUMpJywKKyAgICAgICAgICAgICAnTm9kZS5ET0NVTUVOVF9QT1NJ VElPTl9ESVNDT05ORUNURUQgfCBOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0lNUExFTUVOVEFUSU9O X1NQRUNJRklDJyk7CisgICAgc2hvdWxkQmUoJ2IxLmNvbXBhcmVEb2N1bWVudFBvc2l0aW9uKGMx KSAmIChOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0RJU0NPTk5FQ1RFRCB8IE5vZGUuRE9DVU1FTlRf UE9TSVRJT05fSU1QTEVNRU5UQVRJT05fU1BFQ0lGSUMpJywKKyAgICAgICAgICAgICAnTm9kZS5E T0NVTUVOVF9QT1NJVElPTl9ESVNDT05ORUNURUQgfCBOb2RlLkRPQ1VNRU5UX1BPU0lUSU9OX0lN UExFTUVOVEFUSU9OX1NQRUNJRklDJyk7Cit9CisKK3Rlc3RDb21wYXJlRG9jdW1lbnRQb3NpdGlv bigpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==