103495 2012-11-28 02:08:02 -0800 [EFL][WK2][AC] Clear the viewport with white color 2012-11-28 05:23:31 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joone joone cdumez d-r gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot yael oldest_to_newest 777657 0 joone 2012-11-28 02:08:02 -0800 When we run MiniBrowser, the default viewport color is black. We need to change the color with white. 777713 1 176448 joone 2012-11-28 03:48:33 -0800 Created attachment 176448 Patch 777719 2 176448 kenneth 2012-11-28 03:58:17 -0800 Comment on attachment 176448 Patch Wouldn't transparent not be better? 777745 3 joone 2012-11-28 04:34:55 -0800 (In reply to comment #2) > (From update of attachment 176448 [details]) > Wouldn't transparent not be better? Yes, maybe. I checked the gtk+ port. It also clears the buffer with white color like this. http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp#L300 777748 4 kenneth 2012-11-28 04:39:25 -0800 Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below. You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9. 777754 5 176448 webkit.review.bot 2012-11-28 04:46:41 -0800 Comment on attachment 176448 Patch Clearing flags on attachment: 176448 Committed r135997: <http://trac.webkit.org/changeset/135997> 777755 6 webkit.review.bot 2012-11-28 04:46:45 -0800 All reviewed patches have been landed. Closing bug. 777782 7 joone 2012-11-28 05:23:31 -0800 (In reply to comment #4) > Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below. > > You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9. I'm not sure if all mobile browsers should have the same effect. By the way, isn't this bounce effect an Apple patent? 176448 2012-11-28 03:48:33 -0800 2012-11-28 04:46:40 -0800 Patch bug-103495-20121128134528.patch text/plain 1498 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWVjMmRlYWM5ZGFjZTlh ZDg5N2FlNjQzZDNjMTdmNjBmMDMxY2M1OC4uZjBkMjMyMzc5OTlmNmNjYjBhMDk4OWI3ODhiZmQ2 NDI5NWFiNjhlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTI4ICBKb29u ZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl1bQUNdIENs ZWFyIHRoZSB2aWV3cG9ydCB3aXRoIHdoaXRlIGNvbG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM0OTUKKworICAgICAgICBXaGVuIGluaXRpYWxp emluZyBhIEdMIHN1cmZhY2UsIHdlIHNob3VsZCBjbGVhciB0aGUgYnVmZmVyIHdpdGggd2hpdGUg Y29sb3IuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tWaWV3SW1w bDo6Y3JlYXRlR0xTdXJmYWNlKToKKwogMjAxMi0xMS0yNyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0 ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMzU2MjApOiBBU1NF UlQobV9zdGF0ZS5kcmF3c0NvbnRlbnQgJiYgbV9zdGF0ZS5jb250ZW50c1Zpc2libGUgJiYgIW1f c2l6ZS5pc0VtcHR5KCkpIGhpdHMgaW4gVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGYoKS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBs LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcApp bmRleCBjZTM4MjU0ZWIwMmIwNmRmYzA0YTkzZmFkMWU5MGI3NDFmNTZiODFhLi5kZTQwYThmOGNk YzIwYmEzYmY0ODc4MmEzNDIyZGJlZDc4YWM0ZDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCkBAIC02NjUsNiArNjY1LDggQEAgYm9v bCBFd2tWaWV3SW1wbDo6Y3JlYXRlR0xTdXJmYWNlKGNvbnN0IEludFNpemUmIHZpZXdTaXplKQog CiAgICAgRXZhc19HTF9BUEkqIGdsID0gZXZhc19nbF9hcGlfZ2V0KGV2YXNHTCgpKTsKICAgICBn bC0+Z2xWaWV3cG9ydCgwLCAwLCB2aWV3U2l6ZS53aWR0aCgpICsgc2QtPnZpZXcueCwgdmlld1Np emUuaGVpZ2h0KCkgKyBzZC0+dmlldy55KTsKKyAgICBnbC0+Z2xDbGVhckNvbG9yKDEuMCwgMS4w LCAxLjAsIDApOworICAgIGdsLT5nbENsZWFyKEdMX0NPTE9SX0JVRkZFUl9CSVQpOwogCiAgICAg cmV0dXJuIHRydWU7CiB9Cg==