103486 2012-11-27 23:09:02 -0800 Web Inspector: [Timeline] JS error when clicking in Memory Statistics view 2012-11-30 02:53:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov yurys apavlov keishi loislo pfeldman pmuellr vivek.vg vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 777559 0 apavlov 2012-11-27 23:09:02 -0800 Open an empty Memory view in the Timeline panel and click somewhere in the grid. You will get: Uncaught TypeError: Cannot read property 'time' of undefined at MemoryStatistics.js:320 (this._timelinePanel.revealRecordAt(counter.time / 1000);) 779941 1 176924 sankeerth.vs 2012-11-30 01:47:01 -0800 Created attachment 176924 Patch 779946 2 176924 apavlov 2012-11-30 01:55:08 -0800 Comment on attachment 176924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review Looks good! > Source/WebCore/inspector/front-end/MemoryStatistics.js:317 > var x = event.x - event.target.offsetParent.offsetLeft can you please add the missing trailing semicolon while we are here? 779953 3 176924 sankeerth.vs 2012-11-30 02:06:55 -0800 Comment on attachment 176924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review >> Source/WebCore/inspector/front-end/MemoryStatistics.js:317 >> var x = event.x - event.target.offsetParent.offsetLeft > > can you please add the missing trailing semicolon while we are here? sure. Will add it and upload a new patch. 779957 4 176929 sankeerth.vs 2012-11-30 02:14:20 -0800 Created attachment 176929 Patch 779970 5 176929 webkit.review.bot 2012-11-30 02:53:16 -0800 Comment on attachment 176929 Patch Clearing flags on attachment: 176929 Committed r136220: <http://trac.webkit.org/changeset/136220> 779971 6 webkit.review.bot 2012-11-30 02:53:19 -0800 All reviewed patches have been landed. Closing bug. 176924 2012-11-30 01:47:01 -0800 2012-11-30 02:14:13 -0800 Patch bug-103486-20121130151554.patch text/plain 1718 sankeerth.vs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZiNTliYWQwYWVmNDMy MWJkY2E1Mzc3NzVlZjU0NmUzNjFkMGFhYy4uYmRjMTA5YTNiYzc5NjIwYjIwMTdiNjQzYjY3OTIz OWIzMjBiMDRhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTMwICBTYW5r ZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtUaW1lbGluZV0gSlMgZXJyb3Igd2hlbiBjbGlja2luZyBpbiBNZW1vcnkgU3RhdGlz dGljcyB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDM0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgY291bnRlciB2YWx1ZSBjYW4gYmUgbnVsbC91bmRlZmluZWQuIEhlbmNlIGEgY2hlY2sg aXMgbmVlZGVkCisgICAgICAgIGJlZm9yZSB3ZSBhY2Nlc3MgdGhlICJ0aW1lIiBwcm9wZXJ0eSBv biB0aGlzIGNvdW50ZXIgb2JqZWN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZCBh cyBVSSByZWxhdGVkIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTWVt b3J5U3RhdGlzdGljcy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5NZW1vcnlTdGF0aXN0aWNz LnByb3RvdHlwZS5fb25DbGljayk6CisKIDIwMTItMTEtMzAgIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB0eXBvcyBpbiBEYXRlVGltZU51bWVyaWNGaWVs ZEVsZW1lbnQuY3BwIGFuZCBEYXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50LmNwcApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1vcnlTdGF0aXN0aWNz LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1vcnlTdGF0aXN0aWNz LmpzCmluZGV4IGQ0NGNjNjVkMDg2ZmFlYmZkZmJkODdmY2ViOTBjYTcwMjVjODAyY2UuLmRiMjk5 YjZlMTM4MGZjNTRmMDJiZjg5MmNjZjYzYzhkZjJjM2QyYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMKQEAgLTMx Nyw3ICszMTcsOCBAQCBXZWJJbnNwZWN0b3IuTWVtb3J5U3RhdGlzdGljcy5wcm90b3R5cGUgPSB7 CiAgICAgICAgIHZhciB4ID0gZXZlbnQueCAtIGV2ZW50LnRhcmdldC5vZmZzZXRQYXJlbnQub2Zm c2V0TGVmdAogICAgICAgICB2YXIgaSA9IHRoaXMuX3JlY29yZEluZGV4QXQoeCk7CiAgICAgICAg IHZhciBjb3VudGVyID0gdGhpcy5fY291bnRlcnNbaV07Ci0gICAgICAgIHRoaXMuX3RpbWVsaW5l UGFuZWwucmV2ZWFsUmVjb3JkQXQoY291bnRlci50aW1lIC8gMTAwMCk7CisgICAgICAgIGlmIChj b3VudGVyKQorICAgICAgICAgICAgdGhpcy5fdGltZWxpbmVQYW5lbC5yZXZlYWxSZWNvcmRBdChj b3VudGVyLnRpbWUgLyAxMDAwKTsKICAgICB9LAogCiAgICAgX29uTW91c2VPdXQ6IGZ1bmN0aW9u KGV2ZW50KQo= 176929 2012-11-30 02:14:20 -0800 2012-11-30 02:53:15 -0800 Patch bug-103486-20121130154314.patch text/plain 1825 sankeerth.vs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZiNTliYWQwYWVmNDMy MWJkY2E1Mzc3NzVlZjU0NmUzNjFkMGFhYy4uYmRjMTA5YTNiYzc5NjIwYjIwMTdiNjQzYjY3OTIz OWIzMjBiMDRhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTMwICBTYW5r ZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtUaW1lbGluZV0gSlMgZXJyb3Igd2hlbiBjbGlja2luZyBpbiBNZW1vcnkgU3RhdGlz dGljcyB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDM0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgY291bnRlciB2YWx1ZSBjYW4gYmUgbnVsbC91bmRlZmluZWQuIEhlbmNlIGEgY2hlY2sg aXMgbmVlZGVkCisgICAgICAgIGJlZm9yZSB3ZSBhY2Nlc3MgdGhlICJ0aW1lIiBwcm9wZXJ0eSBv biB0aGlzIGNvdW50ZXIgb2JqZWN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZCBh cyBVSSByZWxhdGVkIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTWVt b3J5U3RhdGlzdGljcy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5NZW1vcnlTdGF0aXN0aWNz LnByb3RvdHlwZS5fb25DbGljayk6CisKIDIwMTItMTEtMzAgIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB0eXBvcyBpbiBEYXRlVGltZU51bWVyaWNGaWVs ZEVsZW1lbnQuY3BwIGFuZCBEYXRlVGltZVN5bWJvbGljRmllbGRFbGVtZW50LmNwcApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1vcnlTdGF0aXN0aWNz LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1vcnlTdGF0aXN0aWNz LmpzCmluZGV4IGQ0NGNjNjVkMDg2ZmFlYmZkZmJkODdmY2ViOTBjYTcwMjVjODAyY2UuLmFhODNi MWYwMTEyMWE1NTZjZmNjNTRkZDkyZTVhNWRmYjdmNTY0NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMKQEAgLTMx NCwxMCArMzE0LDExIEBAIFdlYkluc3BlY3Rvci5NZW1vcnlTdGF0aXN0aWNzLnByb3RvdHlwZSA9 IHsKIAogICAgIF9vbkNsaWNrOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAgIHZhciB4 ID0gZXZlbnQueCAtIGV2ZW50LnRhcmdldC5vZmZzZXRQYXJlbnQub2Zmc2V0TGVmdAorICAgICAg ICB2YXIgeCA9IGV2ZW50LnggLSBldmVudC50YXJnZXQub2Zmc2V0UGFyZW50Lm9mZnNldExlZnQ7 CiAgICAgICAgIHZhciBpID0gdGhpcy5fcmVjb3JkSW5kZXhBdCh4KTsKICAgICAgICAgdmFyIGNv dW50ZXIgPSB0aGlzLl9jb3VudGVyc1tpXTsKLSAgICAgICAgdGhpcy5fdGltZWxpbmVQYW5lbC5y ZXZlYWxSZWNvcmRBdChjb3VudGVyLnRpbWUgLyAxMDAwKTsKKyAgICAgICAgaWYgKGNvdW50ZXIp CisgICAgICAgICAgICB0aGlzLl90aW1lbGluZVBhbmVsLnJldmVhbFJlY29yZEF0KGNvdW50ZXIu dGltZSAvIDEwMDApOwogICAgIH0sCiAKICAgICBfb25Nb3VzZU91dDogZnVuY3Rpb24oZXZlbnQp Cg==