103476 2012-11-27 18:43:58 -0800 [GTK] [WebKit2] WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb 2012-11-29 22:42:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http:/inadvertently P2 Normal --- 1 mrobinson mrobinson cgarcia gustavo webkit.review.bot oldest_to_newest 777452 0 mrobinson 2012-11-27 18:43:58 -0800 WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb. This is a result of sharing the RedirectedXComposite window implementation between WebKit1 and WebKit2. In WebKit2, we should not create a GLXContext during resize events. 779328 1 176789 mrobinson 2012-11-29 12:32:33 -0800 Created attachment 176789 Patch 779337 2 webkit.review.bot 2012-11-29 12:38:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 779452 3 176789 alex 2012-11-29 14:44:22 -0800 Comment on attachment 176789 Patch LGTM 779468 4 176789 webkit.review.bot 2012-11-29 14:59:58 -0800 Comment on attachment 176789 Patch Rejecting attachment 176789 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 159. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15044467 779828 5 176789 mrobinson 2012-11-29 22:42:24 -0800 Comment on attachment 176789 Patch Clearing flags on attachment: 176789 Committed r136207: <http://trac.webkit.org/changeset/136207> 779829 6 mrobinson 2012-11-29 22:42:27 -0800 All reviewed patches have been landed. Closing bug. 176789 2012-11-29 12:32:33 -0800 2012-11-29 22:42:24 -0800 Patch bug-103476-20121129123006.patch text/plain 6705 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGEwMmQwNWEwNWQ1YjNh NWUxNWE5YWM4MjQzYzk2YTYyNjhhNjkwNC4uMDQwNGM1ODAxZDFhOWJmZjI4NTMzMTYxN2IzODM1 NTg4NTY1MTQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTI5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbV2Vi S2l0Ml0gV2ViS2l0V2ViVmlld0Jhc2UgY3JlYXRlcyBhIEdMIGNvbnRleHQgZm9yIHRoZSByZWRp cmVjdGVkIFhDb21wb3NpdGUgd2luZG93IGNyYXNoaW5nIFdlYktpdCBpbiBYdmZiCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM0NzYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyBjcmVhdGlvbiBv ZiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdyBpbiBhIG1vZGUgd2hpY2ggZG9lcyBub3QgaGF2 ZSBhIGJhY2tpbmcKKyAgICAgICAgR0xDb250ZXh0LiBGb3IgV2ViS2l0MiB0aGUgR0xDb250ZXh0 IGlzIGFsd2F5cyBpbiB0aGUgV2ViUHJvY2Vzcy4gQ3JlYXRpbmcgdGhlIEdMQ29udGV4dAorICAg ICAgICBpbiBib3RoIHByb2Nlc3NlcyBjYW4gY2F1c2UgY3Jhc2hlcyB3aGVuIGxpYnJhcnkgaXMg cnVuIGluIFh2ZmIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGZpeGVzIGEgY3Jhc2gg cnVubmluZyB0ZXN0cyBvbiBzb21lIHN5c3RlbXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3c6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KToKKyAgICAg ICAgKFdlYkNvcmU6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpyZXNpemUpOiBEbyBub3Qg Y3JlYXRlIHRoZSBHTENvbnRleHQgd2hlbgorICAgICAgICBpbiB0aGUgbmV3IG5vLUdMQ29udGV4 dCBtb2RlLgorICAgICAgICAoV2ViQ29yZTo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OmNv bnRleHQpOiBBU1NFUlQgdGhhdCB3ZSBhcmUgbm90IGluCisgICAgICAgIG5vLUdMQ29udGV4dCBt b2RlLgorCiAyMDEyLTExLTI2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBbV2ViS2l0Ml0gRW1iZWQgdGhlIEhUVFAgYXV0aGVudGljYXRp b24gZGlhbG9nIGludG8gdGhlIFdlYlZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1OGE2NzZmYjJiNTc1OTIz YTcwMjk1MzZmNzczNTU2Njk1OWIzYjFmLi45MDE2MjBhMmYzMzhlMTU1MTY1NTllNWM3Yzc3YTVl NmJlMTlkYWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMjkgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtXZWJL aXQyXSBXZWJLaXRXZWJWaWV3QmFzZSBjcmVhdGVzIGEgR0wgY29udGV4dCBmb3IgdGhlIHJlZGly ZWN0ZWQgWENvbXBvc2l0ZSB3aW5kb3cgY3Jhc2hpbmcgV2ViS2l0IGluIFh2ZmIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzQ3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSB0aGUgUmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3cgd2l0aCBhbiBhcmd1bWVudCBzcGVjaWZ5aW5nIHRoYXQgaXQK KyAgICAgICAgc2hvdWxkIG5ldmVyIGhhdmUgYSBHTENvbnRleHQgYmFja2luZyBpdC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAg KF9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGU6Ol9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUpOgor CiAyMDEyLTExLTI2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBbV2ViS2l0Ml0gRW1iZWQgdGhlIEhUVFAgYXV0aGVudGljYXRpb24gZGlh bG9nIGludG8gdGhlIFdlYlZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCmluZGV4IDkxMTA1ODEyODY4 ZTZmOGMxN2U5ZmJjZTEzM2M5YTgyZTYzMzgxYmUuLmEwMDg1MDJhNTg0YmVlMDhkN2U5MTc3ZWM1 OTFmOThiMWMzYTVlY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9S ZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcApAQCAtOTIsMTYgKzkyLDE3IEBA IHN0YXRpYyBib29sIHN1cHBvcnRzWERhbWFnZUFuZFhDb21wb3NpdGUoKQogICAgIHJldHVybiB0 cnVlOwogfQogCi1QYXNzT3duUHRyPFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93PiBSZWRpcmVj dGVkWENvbXBvc2l0ZVdpbmRvdzo6Y3JlYXRlKGNvbnN0IEludFNpemUmIHNpemUpCitQYXNzT3du UHRyPFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93PiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRv dzo6Y3JlYXRlKGNvbnN0IEludFNpemUmIHNpemUsIEdMQ29udGV4dE5lZWRlZCBuZWVkc0NvbnRl eHQpCiB7Ci0gICAgcmV0dXJuIHN1cHBvcnRzWERhbWFnZUFuZFhDb21wb3NpdGUoKSA/IGFkb3B0 UHRyKG5ldyBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdyhzaXplKSkgOiBudWxscHRyOworICAg IHJldHVybiBzdXBwb3J0c1hEYW1hZ2VBbmRYQ29tcG9zaXRlKCkgPyBhZG9wdFB0cihuZXcgUmVk aXJlY3RlZFhDb21wb3NpdGVXaW5kb3coc2l6ZSwgbmVlZHNDb250ZXh0KSkgOiBudWxscHRyOwog fQogCi1SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5k b3coY29uc3QgSW50U2l6ZSYgc2l6ZSkKK1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpSZWRp cmVjdGVkWENvbXBvc2l0ZVdpbmRvdyhjb25zdCBJbnRTaXplJiBzaXplLCBHTENvbnRleHROZWVk ZWQgbmVlZHNDb250ZXh0KQogICAgIDogbV9zaXplKHNpemUpCiAgICAgLCBtX3dpbmRvdygwKQog ICAgICwgbV9wYXJlbnRXaW5kb3coMCkKICAgICAsIG1fcGl4bWFwKDApCisgICAgLCBtX25lZWRz Q29udGV4dChuZWVkc0NvbnRleHQpCiAgICAgLCBtX3N1cmZhY2UoMCkKICAgICAsIG1fbmVlZHNO ZXdQaXhtYXBBZnRlclJlc2l6ZShmYWxzZSkKICAgICAsIG1fZGFtYWdlKDApCkBAIC0xNzYsMTIg KzE3NywxNCBAQCB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpyZXNpemUoY29uc3Qg SW50U2l6ZSYgc2l6ZSkKICAgICBYUmVzaXplV2luZG93KGRpc3BsYXksIG1fd2luZG93LCBzaXpl LndpZHRoKCksIHNpemUuaGVpZ2h0KCkpOwogCiAgICAgWEZsdXNoKGRpc3BsYXkpOwotICAgIGNv bnRleHQoKS0+d2FpdE5hdGl2ZSgpOwogCi0gICAgLy8gVGhpcyBzd2FwIGlzIGJhc2VkIG9uIGNv ZGUgaW4gQ2hyb21pdW0uIEl0IHRyaWVzIHRvIHdvcmstYXJvdW5kIGEgYnVnIGluIHRoZSBJbnRl bCBkcml2ZXJzCi0gICAgLy8gd2hlcmUgYSBzd2FwIGlzIG5lY2Vzc2FyeSB0byBlbnN1cmUgdGhl IGZyb250IGFuZCBiYWNrIGJ1ZmZlcnMgYXJlIHByb3Blcmx5IHJlc2l6ZWQuCi0gICAgaWYgKGNv bnRleHQoKSA9PSBHTENvbnRleHQ6OmdldEN1cnJlbnQoKSkKLSAgICAgICAgY29udGV4dCgpLT5z d2FwQnVmZmVycygpOworICAgIGlmIChtX25lZWRzQ29udGV4dCA9PSBDcmVhdGVHTENvbnRleHQp IHsKKyAgICAgICAgY29udGV4dCgpLT53YWl0TmF0aXZlKCk7CisgICAgICAgIC8vIFRoaXMgc3dh cCBpcyBiYXNlZCBvbiBjb2RlIGluIENocm9taXVtLiBJdCB0cmllcyB0byB3b3JrLWFyb3VuZCBh IGJ1ZyBpbiB0aGUgSW50ZWwgZHJpdmVycworICAgICAgICAvLyB3aGVyZSBhIHN3YXAgaXMgbmVj ZXNzYXJ5IHRvIGVuc3VyZSB0aGUgZnJvbnQgYW5kIGJhY2sgYnVmZmVycyBhcmUgcHJvcGVybHkg cmVzaXplZC4KKyAgICAgICAgaWYgKGNvbnRleHQoKSA9PSBHTENvbnRleHQ6OmdldEN1cnJlbnQo KSkKKyAgICAgICAgICAgIGNvbnRleHQoKS0+c3dhcEJ1ZmZlcnMoKTsKKyAgICB9CiAKICAgICBt X3NpemUgPSBzaXplOwogICAgIG1fbmVlZHNOZXdQaXhtYXBBZnRlclJlc2l6ZSA9IHRydWU7CkBA IC0xODksNiArMTkyLDggQEAgdm9pZCBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6cmVzaXpl KGNvbnN0IEludFNpemUmIHNpemUpCiAKIEdMQ29udGV4dCogUmVkaXJlY3RlZFhDb21wb3NpdGVX aW5kb3c6OmNvbnRleHQoKQogeworICAgIEFTU0VSVChtX25lZWRzQ29udGV4dCk7CisKICAgICBp ZiAobV9jb250ZXh0KQogICAgICAgICByZXR1cm4gbV9jb250ZXh0LmdldCgpOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5k b3cuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdp bmRvdy5oCmluZGV4IDdhOThjMzc2ODNmYzM4NjA2ZjllYWJkNTg2YzlkNjdlNThiZjE2YmMuLmQz YjJjYTI4OTRkY2ZiZjU5MTc1YTJhNWMzNzg2N2VlN2U0OTRmZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5o CkBAIC00Miw3ICs0Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVkaXJlY3Rl ZFhDb21wb3NpdGVXaW5kb3cgewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzT3duUHRyPFJlZGly ZWN0ZWRYQ29tcG9zaXRlV2luZG93PiBjcmVhdGUoY29uc3QgSW50U2l6ZSYpOworICAgIGVudW0g R0xDb250ZXh0TmVlZGVkIHsgQ3JlYXRlR0xDb250ZXh0LCBEb05vdENyZWF0ZUdMQ29udGV4dCB9 OworICAgIHN0YXRpYyBQYXNzT3duUHRyPFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93PiBjcmVh dGUoY29uc3QgSW50U2l6ZSYsIEdMQ29udGV4dE5lZWRlZCA9IENyZWF0ZUdMQ29udGV4dCk7CiAg ICAgdmlydHVhbCB+UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3coKTsKICAgICBjb25zdCBJbnRT aXplJiBzaXplKCkgeyByZXR1cm4gbV9zaXplOyB9CiAKQEAgLTU5LDEzICs2MCwxNCBAQCBwdWJs aWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KGNv bnN0IEludFNpemUmKTsKKyAgICBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdyhjb25zdCBJbnRT aXplJiwgR0xDb250ZXh0TmVlZGVkKTsKICAgICB2b2lkIGNsZWFudXBQaXhtYXBBbmRQaXhtYXBT dXJmYWNlKCk7CiAKICAgICBJbnRTaXplIG1fc2l6ZTsKICAgICBXaW5kb3cgbV93aW5kb3c7CiAg ICAgV2luZG93IG1fcGFyZW50V2luZG93OwogICAgIFBpeG1hcCBtX3BpeG1hcDsKKyAgICBHTENv bnRleHROZWVkZWQgbV9uZWVkc0NvbnRleHQ7CiAgICAgT3duUHRyPEdMQ29udGV4dD4gbV9jb250 ZXh0OwogICAgIFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+IG1fc3VyZmFjZTsKICAgICB1bnNpZ25l ZCBpbnQgbV9wZW5kaW5nUmVzaXplU291cmNlSWQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggZjlhZWU4MzFl ZmRmM2E4ZWJhNTg3M2UwMjdkNDNjYjVkMjQ1ZjgzYy4uYzQ2ZGViMjdhNzgxNzc3ZWViMjEyYzEy NzdiY2FhZWM5OGUwZGFiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtODMsNyArODMsNyBAQCBzdHJ1Y3Qg X1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSB7CiAgICAgX1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0 ZSgpCiAgICAgICAgIDogaW1Db250ZXh0KGFkb3B0R1JlZihndGtfaW1fbXVsdGljb250ZXh0X25l dygpKSkKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCi0gICAgICAgICwgcmVkaXJlY3RlZFdp bmRvdyhSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6Y3JlYXRlKEludFNpemUoMSwgMSkpKQor ICAgICAgICAsIHJlZGlyZWN0ZWRXaW5kb3coUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OmNy ZWF0ZShJbnRTaXplKDEsIDEpLCBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6RG9Ob3RDcmVh dGVHTENvbnRleHQpKQogI2VuZGlmCiAgICAgewogICAgIH0K