103453 2012-11-27 13:34:33 -0800 LayoutTests/fast/table/css-table-max-height.html failing on Qt Linux 2012-12-11 12:15:51 -0800 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87008 1 pravind.2k4 pravind.2k4 darin hausmann jchaffraix ossy webkit.review.bot oldest_to_newest 777174 0 pravind.2k4 2012-11-27 13:34:33 -0800 The test case LayoutTests/fast/table/css-table-max-height.html is failing on Qt linux. Diff http://build.webkit.org/results/Qt%20Linux%20Release/r135895%20%2854971%29/fast/table/css-table-max-height-pretty-diff.html The test passes on other platforms. 777202 1 jchaffraix 2012-11-27 14:00:34 -0800 Test disabled in http://trac.webkit.org/changeset/135917 Failures: This sub-test checks that when content height is greater than max-height, content height is applied to the table with auto layout. FILLER TEXT TO INCREASE CONTENT HEIGHT. FAIL: Expected 192 for height, but got 204. <div class="container"> <div class="child" style="max-height:100px;" data-expected-height="192"> This sub-test checks that when content height is greater than max-height, content height is applied to the table with auto layout. <br><br>FILLER TEXT TO INCREASE CONTENT HEIGHT. </div> </div> [snip] This sub-test checks that when content height is greater than max-height, content height is applied to a table with fixed layout. FILLER TEXT TO INCREASE CONTENT HEIGHT. FAIL: Expected 192 for height, but got 204. <div class="container"> <div class="child fixed-table" style="max-height:100px;" data-expected-height="192"> This sub-test checks that when content height is greater than max-height, content height is applied to a table with fixed layout. <br><br>FILLER TEXT TO INCREASE CONTENT HEIGHT. </div> </div> This test checks that when height of a fixed table is auto, there is are no asserts. No crash means the test passed. PASS 777606 2 176420 pravind.2k4 2012-11-28 00:59:02 -0800 Created attachment 176420 Patch 777611 3 pravind.2k4 2012-11-28 01:05:24 -0800 Patch https://bugs.webkit.org/attachment.cgi?id=176420 The default line-height used by Qt-linux is different from the other platforms. This was causing the height of the sub-test cases to be different from expected value. Have also fixed the font-size value, to be on a safer side. @Julien: thanks for the hunch :) 777643 4 hausmann 2012-11-28 01:52:04 -0800 Julien, can you review this patch? It looks sane to me, but I don't feel comfortable messing with the table tests that I don't know at all :) Thanks :) 778032 5 176420 jchaffraix 2012-11-28 10:27:28 -0800 Comment on attachment 176420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176420&action=review > LayoutTests/fast/table/css-table-max-height.html:11 > font-family:ahem; > + line-height:1; > + font-size:16px; You can use the shorthand here: font: 16px/1 Ahem; It's more compact thus better. 778094 6 176527 pravind.2k4 2012-11-28 11:12:12 -0800 Created attachment 176527 Patch 778096 7 pravind.2k4 2012-11-28 11:13:18 -0800 (In reply to comment #5) > (From update of attachment 176420 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176420&action=review > > > LayoutTests/fast/table/css-table-max-height.html:11 > > font-family:ahem; > > + line-height:1; > > + font-size:16px; > > You can use the shorthand here: > > font: 16px/1 Ahem; > > It's more compact thus better. > Done.. 778174 8 176527 webkit.review.bot 2012-11-28 12:14:46 -0800 Comment on attachment 176527 Patch Clearing flags on attachment: 176527 Committed r136041: <http://trac.webkit.org/changeset/136041> 778175 9 webkit.review.bot 2012-11-28 12:14:49 -0800 All reviewed patches have been landed. Closing bug. 778407 10 darin 2012-11-28 15:24:50 -0800 (In reply to comment #3) > The default line-height used by Qt-linux is different from the other platforms. Really? Why? 788658 11 jchaffraix 2012-12-11 12:15:51 -0800 (In reply to comment #10) > (In reply to comment #3) > > The default line-height used by Qt-linux is different from the other platforms. > > Really? Why? It seems to be a matter of used font which impacts the height of a line. I remember hitting this issue myself and bug 74219 confirms it too. Regardless of what I just said, it's always good to limit the test variation on the font / line-height selection as it reduces platform-specificity. 176420 2012-11-28 00:59:02 -0800 2012-11-28 11:12:07 -0800 Patch bug-103453-20121128143054.patch text/plain 2086 pravind.2k4 SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNTk4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTI4ICBQcmF2aW4gRCAgPHByYXZp bmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2Nzcy10 YWJsZS1tYXgtaGVpZ2h0Lmh0bWwgZmFpbGluZyBvbiBRdCBMaW51eAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDUzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3RjYXNlIGZhaWx1cmUgd2Fz IGR1ZSB0byB0aGUgZGlmZmVyZW5jZSBpbiB0aGUgZGVmYXVsdCBsaW5lLWhlaWdodCB2YWx1ZSAK KyAgICAgICAgdXNlZCBieSBRdC1saW51eCBwb3J0IGZyb20gb3RoZXIgcG9ydHMuCisKKyAgICAg ICAgKiBmYXN0L3RhYmxlL2Nzcy10YWJsZS1tYXgtaGVpZ2h0Lmh0bWw6CisgICAgICAgICAgICBM aW5lLWhlaWdodCBhbmQgZm9udC1zaXplIG5vdyB1c2UgYSBmaXhlZCB2YWx1ZSBhY3Jvc3MgYWxs IHBsYXRmb3Jtcy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnM6Cisg ICAgICAgICAgIFJlbW92ZWQgY3NzLXRhYmxlLW1heC1oZWlnaHQuaHRtbC4KKwogMjAxMi0xMS0y OCAgSmFlaHVuIExpbSAgPGxqYWVodW4ubGltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxd W1dLMV0gR2FyZGVuaW5nIEFDIHRlc3RjYXNlcyBpbiBlZmwtd2sxCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L3RhYmxlL2Nzcy10YWJsZS1tYXgtaGVpZ2h0Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC90YWJsZS9jc3MtdGFibGUtbWF4LWhlaWdodC5odG1sCShyZXZpc2lvbiAx MzU5NzApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2Nzcy10YWJsZS1tYXgtaGVpZ2h0Lmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw4IEBACiAgICAgd2lkdGg6MzAwcHg7CiAgICAg aGVpZ2h0OjQwMHB4OwogICAgIGZvbnQtZmFtaWx5OmFoZW07CisgICAgbGluZS1oZWlnaHQ6MTsK KyAgICBmb250LXNpemU6MTZweDsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiM5OTk5OTk7CiB9CiAK SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24g MTM1OTcwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwkod29y a2luZyBjb3B5KQpAQCAtMTc1MiwxMCArMTc1Miw2IEBAIGZhc3Qvd3JpdGluZy1tb2RlL3ZlcnRp Y2FsLXN1YnN0LWZvbnQtdmUKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4NzUxCiBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW5vbmV4aXN0ZW50 LWZpbGUuaHRtbAogCi0jIExheW91dFRlc3RzL2Zhc3QvdGFibGUvY3NzLXRhYmxlLW1heC1oZWln aHQuaHRtbCBmYWlsaW5nIG9uIFF0IExpbnV4Ci0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDM0NTMKLWZhc3QvdGFibGUvY3NzLXRhYmxlLW1heC1oZWlnaHQuaHRt bCBbIFRleHQgXQotCiAjID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKICMgZmFpbGluZyBzZWN1cml0 eSB0ZXN0cwogIyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PSAjCg== 176527 2012-11-28 11:12:12 -0800 2012-11-28 12:14:46 -0800 Patch bug-103453-20121129004402.patch text/plain 1958 pravind.2k4 SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNjAyOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI4ICBQcmF2aW4gRCAgPHByYXZp bmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2Nzcy10 YWJsZS1tYXgtaGVpZ2h0Lmh0bWwgZmFpbGluZyBvbiBRdCBMaW51eAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDUzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3RjYXNlIGZhaWx1cmUgd2Fz IGR1ZSB0byB0aGUgZGlmZmVyZW5jZSBpbiB0aGUgZGVmYXVsdCBsaW5lLWhlaWdodCB2YWx1ZQor ICAgICAgICB1c2VkIGJ5IFF0LWxpbnV4IHBvcnQgZnJvbSBvdGhlciBwb3J0cy4KKworICAgICAg ICAqIGZhc3QvdGFibGUvY3NzLXRhYmxlLW1heC1oZWlnaHQuaHRtbDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTExLTI4ICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgbGFuZCB1cGRhdGVkIENocm9t aXVtIHJlc3VsdHMgYWZ0ZXIgdHJhY2sgbGltaXRlciByZW1vdmFsLgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC90YWJsZS9jc3MtdGFibGUtbWF4LWhlaWdodC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvdGFibGUvY3NzLXRhYmxlLW1heC1oZWlnaHQuaHRtbAkocmV2aXNpb24g MTM2MDI0KQorKysgTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jc3MtdGFibGUtbWF4LWhlaWdodC5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC02LDcgKzYsNyBAQAogewogICAgIHdpZHRoOjMwMHB4Owog ICAgIGhlaWdodDo0MDBweDsKLSAgICBmb250LWZhbWlseTphaGVtOworICAgIGZvbnQ6MTZweC8x IEFoZW07CiAgICAgYmFja2dyb3VuZC1jb2xvcjojOTk5OTk5OwogfQogCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDEzNjAyNCkKKysrIExh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAg LTE3NDksMTAgKzE3NDksNiBAQCBmYXN0L3dyaXRpbmctbW9kZS92ZXJ0aWNhbC1zdWJzdC1mb250 LXZlCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODc1MQogZmFz dC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1ub25leGlzdGVudC1maWxlLmh0bWwKIAot IyBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2Nzcy10YWJsZS1tYXgtaGVpZ2h0Lmh0bWwgZmFpbGlu ZyBvbiBRdCBMaW51eAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzNDUzCi1mYXN0L3RhYmxlL2Nzcy10YWJsZS1tYXgtaGVpZ2h0Lmh0bWwgWyBUZXh0IF0KLQog IyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PSAjCiAjIGZhaWxpbmcgc2VjdXJpdHkgdGVzdHMKICMgPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0gIwo=