103438 2012-11-27 10:42:18 -0800 No need for ExceptionCode in HTMLMediaElement::load 2012-11-27 11:22:46 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino abarth darin eric.carlson feature-media-reviews jer.noble ojan qinmin webkit.review.bot oldest_to_newest 776959 0 dino 2012-11-27 10:42:18 -0800 The ExceptionCode& parameter is never used. The HTML5 spec indicates all errors in load() are communicated via error objects. http://dev.w3.org/html5/spec/media-elements.html#dom-media-load 776975 1 176301 dino 2012-11-27 10:52:29 -0800 Created attachment 176301 Patch 777012 2 dino 2012-11-27 11:22:46 -0800 Committed r135886: <http://trac.webkit.org/changeset/135886> 176301 2012-11-27 10:52:29 -0800 2012-11-27 11:03:49 -0800 Patch bug-103438-20121128055005.patch text/plain 3964 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMxYzg4NDA5YzQ4Y2U4 YTIxOGIyMGQ0MjgxODA3MmFiNjZjYzZmNC4uNzg0YTM1OWY1MDU0NzMwN2MxNDA5ZTQxNjNhNTEy MDlkZmYzZmI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTExLTI3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBObyBuZWVkIGZvciBFeGNlcHRp b25Db2RlIGluIEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDMzMTgsIHRoZXJlIGlzIG5vCisgICAgICAgIG5lZWQgZm9yIHRoZSBF eGNlcHRpb25Db2RlIHBhcmFtZXRlciBpbiBsb2FkKCkuIFRoZSBIVE1MNSBzcGVjIHNheXMKKyAg ICAgICAgdGhhdCBhbGwgZXJyb3JzIGluIGxvYWRpbmcgYXJlIGNvbW11bmljYXRlZCB2aWEgc3Rh dGUuCisgICAgICAgIGh0dHA6Ly9kZXYudzMub3JnL2h0bWw1L3NwZWMvbWVkaWEtZWxlbWVudHMu aHRtbCNkb20tbWVkaWEtbG9hZAorCisgICAgICAgIE9mIHRoZSAyOSB0ZXN0cyBleGVyY2lzaW5n IGxvYWQoKSwgbm9uZSBvZiB0aGVtIHdlcmUgZXhlcmNpc2luZworICAgICAgICBleGNlcHRpb25z IChvYnZpb3VzbHkpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWQpOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6cmVzdW1lKToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVs ZW1lbnQuaDoKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsOgorCisyMDEyLTEx LTI3ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKwogICAgICAgICBVbnJldmlld2Vk IGJ1aWxkIGZpeCBmb3IgcjEzNTg2Ni4KIAogICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBmZmYw N2JhZTIxMTY4YWY5NGUxOTU3NmRlMGVmZjEwODQ5NTg3NDEwLi5mZmE2OGRjZWVhZDBiNTllYTEx MjAyNzg2OGVkNjg4ZTA4ZDBlMTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHAKQEAgLTY3NiwxMCArNjc2LDggQEAgU3RyaW5nIEhUTUxNZWRpYUVsZW1lbnQ6OmNh blBsYXlUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IFN0cmluZyYga2V5U3kKICAg ICByZXR1cm4gY2FuUGxheTsKIH0KIAotdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpsb2FkKEV4Y2Vw dGlvbkNvZGUmIGVjKQordm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpsb2FkKCkKIHsKLSAgICBVTlVT RURfUEFSQU0oZWMpOwotCiAgICAgUmVmUHRyPEhUTUxNZWRpYUVsZW1lbnQ+IHByb3RlY3QodGhp cyk7IC8vIGxvYWRJbnRlcm5hbCBtYXkgcmVzdWx0IGluIGEgJ2JlZm9yZWxvYWQnIGV2ZW50LCB3 aGljaCBjYW4gbWFrZSBhcmJpdHJhcnkgRE9NIG11dGF0aW9ucy4KICAgICAKICAgICBMT0coTWVk aWEsICJIVE1MTWVkaWFFbGVtZW50Ojpsb2FkKCkiKTsKQEAgLTM4MTUsOCArMzgxMyw3IEBAIHZv aWQgSFRNTE1lZGlhRWxlbWVudDo6cmVzdW1lKCkKICAgICAgICAgLy8gbV9lcnJvciBpcyBvbmx5 IGxlZnQgYXQgTUVESUFfRVJSX0FCT1JURUQgd2hlbiB0aGUgZG9jdW1lbnQgYmVjb21lcyBpbmFj dGl2ZSAoaXQgaXMgc2V0IHRvCiAgICAgICAgIC8vICBNRURJQV9FUlJfQUJPUlRFRCB3aGlsZSB0 aGUgYWJvcnRFdmVudCBpcyBiZWluZyBzZW50LCBidXQgY2xlYXJlZCBpbW1lZGlhdGVseSBhZnRl cndhcmRzKS4KICAgICAgICAgLy8gVGhpcyBiZWhhdmlvciBpcyBub3Qgc3BlY2lmaWVkIGJ1dCBp dCBzZWVtcyBsaWtlIGEgc2Vuc2libGUgdGhpbmcgdG8gZG8uCi0gICAgICAgIEV4Y2VwdGlvbkNv ZGUgZWM7Ci0gICAgICAgIGxvYWQoZWMpOworICAgICAgICBsb2FkKCk7CiAgICAgfQogCiAgICAg aWYgKHJlbmRlcmVyKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4 IGM1MzEyOWQ2MjM0MWI2MmI1NDlkOTZkYmNmYjBmODMwN2JmZWZlOWQuLjM5NDExYzhmZTRhODFj OTQ5YzExZmFlN2MyMWE5MGIxZTdlYzdmMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oCkBAIC0xMzQsNyArMTM0LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0UHJlbG9h ZChjb25zdCBTdHJpbmcmKTsKIAogICAgIFBhc3NSZWZQdHI8VGltZVJhbmdlcz4gYnVmZmVyZWQo KSBjb25zdDsKLSAgICB2b2lkIGxvYWQoRXhjZXB0aW9uQ29kZSYpOworICAgIHZvaWQgbG9hZCgp OwogICAgIFN0cmluZyBjYW5QbGF5VHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBT dHJpbmcmIGtleVN5c3RlbSA9IFN0cmluZygpLCBjb25zdCBLVVJMJiA9IEtVUkwoKSkgY29uc3Q7 CiAKIC8vIHJlYWR5IHN0YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmlk bAppbmRleCBlY2UwZjUzNDg5ODc2NDhkODYyODIxM2JjZDc0YjkxYjczZTE1ZTNiLi4yZWNlNWFj YWE1YWRhMzI4NWVjMzg3OTM0MmZhODFiMjc5MDU4M2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5pZGwKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChD KSAyMDA3LCAyMDEwLCAyMDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENv cHlyaWdodCAoQykgMjAwNywgMjAxMCwgMjAxMSwgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTQzLDggKzQzLDcg QEAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0IG5ldHdvcmtTdGF0ZTsKIGF0dHJp YnV0ZSBET01TdHJpbmcgcHJlbG9hZDsKIAogcmVhZG9ubHkgYXR0cmlidXRlIFRpbWVSYW5nZXMg YnVmZmVyZWQ7Ci12b2lkIGxvYWQoKSAKLSAgICByYWlzZXMgKERPTUV4Y2VwdGlvbik7Cit2b2lk IGxvYWQoKTsKICNpZiBkZWZpbmVkKEVOQUJMRV9FTkNSWVBURURfTUVESUEpICYmIEVOQUJMRV9F TkNSWVBURURfTUVESUEKIERPTVN0cmluZyBjYW5QbGF5VHlwZShpbiBbT3B0aW9uYWw9RGVmYXVs dElzVW5kZWZpbmVkXSBET01TdHJpbmcgdHlwZSwgaW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVm aW5lZCwgVHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJlYXRVbmRlZmluZWRBcz1OdWxsU3RyaW5n XSBET01TdHJpbmcga2V5U3lzdGVtKTsKICNlbHNlCg==