103433 2012-11-27 09:58:51 -0800 [WK2] WebPageProxy::relatedPages() cannot assume that this page is known to process 2012-11-27 11:05:20 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap jberlin sam oldest_to_newest 776902 0 ap 2012-11-27 09:58:51 -0800 pages() returns a list of pages in WebProcess, so this page may or may not be among them - a client can use a reference to WebPageProxy after the page has closed. <rdar://problem/12619000> 776914 1 176291 ap 2012-11-27 10:04:02 -0800 Created attachment 176291 proposed fix 776949 2 ap 2012-11-27 10:37:19 -0800 Committed <http://trac.webkit.org/r135879>. 776976 3 sam 2012-11-27 10:53:09 -0800 Why not add an isClosed() check, and return null here? 776991 4 ap 2012-11-27 11:05:20 -0800 That doesn't seem to a be a direct enough check - isClosed() may or may not return true if WebProcess has crashed. 176291 2012-11-27 10:04:02 -0800 2012-11-27 10:20:27 -0800 proposed fix RelatedPagesCrash.txt text/plain 1650 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTg3MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFdlYlBhZ2VQcm94 eTo6cmVsYXRlZFBhZ2VzKCkgY2Fubm90IGFzc3VtZSB0aGF0IHRoaXMgcGFnZSBpcyBrbm93biB0 byBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDM0MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNjE5MDAwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHA6IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cmVsYXRlZFBhZ2VzKTogUmVtb3ZlZCBh biBpbmNvcnJlY3QKKyAgICAgICAgYXNzZXJ0aW9uLCBhbmQgbW9kaWZpZWQgY29kZSB0byBub3Qg cmVseSBvbiBpdHMgY29uZGl0aW9uIGJlaW5nIHRydWUuCisKIDIwMTItMTEtMjcgIE1pa2hhaWwg UG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VG TF1bUXRdW1dLMl0gVGlsZXMgbm90IGFsd2F5cyBwYWludGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMTM1NzMzKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5 NiwxMSArMjk2LDExIEBAIGJvb2wgV2ViUGFnZVByb3h5Ojppc1ZhbGlkKCkKIAogUGFzc1JlZlB0 cjxJbW11dGFibGVBcnJheT4gV2ViUGFnZVByb3h5OjpyZWxhdGVkUGFnZXMoKSBjb25zdAogewor ICAgIC8vIHBhZ2VzKCkgcmV0dXJucyBhIGxpc3Qgb2YgcGFnZXMgaW4gV2ViUHJvY2Vzcywgc28g dGhpcyBwYWdlIG1heSBvciBtYXkgbm90IGJlIGFtb25nIHRoZW0gLSBhIGNsaWVudCBjYW4gdXNl IGEgcmVmZXJlbmNlIHRvIFdlYlBhZ2VQcm94eSBhZnRlciB0aGUgcGFnZSBoYXMgY2xvc2VkLgog ICAgIFZlY3RvcjxXZWJQYWdlUHJveHkqPiBwYWdlcyA9IG1fcHJvY2Vzcy0+cGFnZXMoKTsKLSAg ICBBU1NFUlQocGFnZXMuY29udGFpbnModGhpcykpOwogCiAgICAgVmVjdG9yPFJlZlB0cjxBUElP YmplY3Q+ID4gcmVzdWx0OwotICAgIHJlc3VsdC5yZXNlcnZlQ2FwYWNpdHkocGFnZXMuc2l6ZSgp IC0gMSk7CisgICAgcmVzdWx0LnJlc2VydmVDYXBhY2l0eShwYWdlcy5zaXplKCkpOwogICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgcGFnZXMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgaWYgKHBh Z2VzW2ldICE9IHRoaXMpCiAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKHBhZ2VzW2ldKTsK