10343 2006-08-11 00:16:50 -0700 Windows portability fixes 2006-08-24 20:29:56 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC Windows XP RESOLVED DUPLICATE 10553 P2 Normal --- 1 kkowalczyk webkit-unassigned oldest_to_newest 52215 0 kkowalczyk 2006-08-11 00:16:50 -0700 1. CSSValueKeywords.in has empty lines which, they end up in CSSValueKeywords.gperf because makevalues script doesn't filter them out, this makes gperf fail and the build will fail because CSSValueKeywords.* are not properly generated Fix is to remove empty lines (as in attached patch) or fix makevalues script to filter them out. 2. ENCODING_PREFIX in build-generated-files.sh needs to be defined as "\" \"", otherwise it'll end up being nothing in DerivedSources.make and the followig line will fail: CharsetData.cpp : platform/make-charset-table.pl platform/character-sets.txt $(ENCODINGS_FILE) perl $^ $(ENCODINGS_PREFIX) > $@ A comment about that is in make-generated-sources.sh (but it's probably not used anymore). In general, this is very fragile so even a better fix would be good (one that adds some diagnostics to scripts - diagnosing build problems due to one of those scripts that auto-generate files failing isn't easy). Also, it would be nice if VS build would stop if pre-build event fails, because going on is usually pointless since it'll stop at some much later point with obscure error. Unfortuantely, I don't know the required VS magic (if one exists). 52216 1 9975 kkowalczyk 2006-08-11 00:17:43 -0700 Created attachment 9975 Fixes for the 2 problems 52255 2 9975 eric 2006-08-11 13:58:53 -0700 Comment on attachment 9975 Fixes for the 2 problems The second fix looks fine. The first fix really should be to fix the script and not make the data file harder to read. 52703 3 9975 darin 2006-08-15 21:17:28 -0700 Comment on attachment 9975 Fixes for the 2 problems I agree with Eric's comment. The fix for build-generated-files.sh is fine, but the fix for CSSValueKeywords.in should be in the script, not the source file. Since this one patch contains both, review- for now. 53479 4 kkowalczyk 2006-08-24 20:29:56 -0700 Patch in 10553 has this fix too. Trying to consolidate the changes into one bug. *** This bug has been marked as a duplicate of 10553 *** 9975 2006-08-11 00:17:43 -0700 2006-08-15 21:17:28 -0700 Fixes for the 2 problems win-fixes.txt text/plain 2383 kkowalczyk SW5kZXg6IGNzcy9DU1NWYWx1ZUtleXdvcmRzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNzcy9DU1NWYWx1 ZUtleXdvcmRzLmluCShyZXZpc2lvbiAxNTgzMCkKKysrIGNzcy9DU1NWYWx1ZUtleXdvcmRzLmlu CSh3b3JraW5nIGNvcHkpCkBAIC0zNDMsNyArMzQzLDYgQEAKIHRoaW4KIHVuZGVybGluZQogLXdl YmtpdC1ub3dyYXAKLQogIyBDU1MzIFZhbHVlcwogIyBDU1NfUFJPUF9CT1hfQUxJR04KIHN0cmV0 Y2gKQEAgLTM1MSwyNyArMzUwLDIyIEBACiBlbmQKICNjZW50ZXIKICNiYXNlbGluZQotCiAjIENT U19QUk9QX0JPWF9ESVJFQ1RJT04KICMgbm9ybWFsCiByZXZlcnNlCi0KICMgQ1NTX1BST1BfQk9Y X09SSUVOVAogaG9yaXpvbnRhbAogdmVydGljYWwKIGlubGluZS1heGlzCiBibG9jay1heGlzCi0K ICMgQ1NTX1BST1BfQk9YX1BBQ0sKICMgc3RhcnQKICMgZW5kCiAjIGNlbnRlcgogIyBqdXN0aWZ5 Ci0KICMgQ1NTX1BST1BfQk9YX0xJTkVTCiBzaW5nbGUKIG11bHRpcGxlCi0KICMgQ1NTX1BST1Bf TUFSUVVFRV9ESVJFQ1RJT04KIGZvcndhcmRzCiBiYWNrd2FyZHMKQEAgLTM4Miw4NiArMzc2LDcx IEBACiB1cAogZG93bgogIyBhdXRvCi0KICMgQ1NTX1BST1BfTUFSUVVFRV9TUEVFRAogc2xvdwog IyBub3JtYWwKIGZhc3QKLQogIyBDU1NfUFJPUF9NQVJRVUVFX1JFUEVUSVRJT04KIGluZmluaXRl Ci0KICMgQ1NTX1BST1BfTUFSUVVFRV9TVFlMRQogIyBub25lCiBzbGlkZQogIyBzY3JvbGwKIGFs dGVybmF0ZQogdW5mdXJsCi0KICMKICMgQ1NTX1BST1BfX0tIVE1MX1VTRVJfTU9ESUZZCiAjCiBy ZWFkLW9ubHkKIHJlYWQtd3JpdGUKIHJlYWQtd3JpdGUtcGxhaW50ZXh0LW9ubHkKLQogIwogIyBD U1NfUFJPUF9fS0hUTUxfVVNFUl9EUkFHCiAjCiBlbGVtZW50Ci0KICMKICMgQ1NTX1BST1BfX0tI VE1MX1VTRVJfU0VMRUNUCiAjCiBpZ25vcmUKLQogIwogIyBDU1NfUFJPUF9XSURUSC9NSU5fV0lE VEgvTUFYX1dJRFRICiAjCiBpbnRyaW5zaWMKIG1pbi1pbnRyaW5zaWMKLQogIwogIyBDU1NfUFJP UF9URVhUX09WRVJGTE9XCiAjCiBjbGlwCiBlbGxpcHNpcwotCiAjCiAjIENTU19QUk9QX19LSFRN TF9NQVJHSU5fQ09MTEFQU0UKICMKICMgY29sbGFwc2UKICMgc2VwYXJhdGUKIGRpc2NhcmQKLQog IwogIyBDU1NfUFJPUF9URVhUXypfQ09MT1IKICMKIGRvdC1kYXNoCiBkb3QtZG90LWRhc2gKIHdh dmUKLQogIwogIyBDU1NfUFJPUF9URVhUXypfTU9ERQogIwogY29udGludW91cwogc2tpcC13aGl0 ZS1zcGFjZQotCiAjCiAjIENTU19QUk9QX1dPUkRfQlJFQUsKICMKIGJyZWFrLXdvcmQKLQogIwog IyBDU1NfUFJPUF9fS0hUTUxfTkJTUF9NT0RFCiAjCiBzcGFjZQotCiAjCiAjIENTU19QUk9QX19L SFRNTF9MSU5FX0JSRUFLCiAjCiBhZnRlci13aGl0ZS1zcGFjZQotCiAjCiAjIENTU19QUk9QX19L SFRNTF9BUFBFQVJBTkNFCiAjCkBAIC00OTcsMjcgKzQ3NiwyMyBAQAogc2VhcmNoZmllbGQtY2xv c2UKIHRleHRmaWVsZAogdGV4dGFyZWEKLQogIwogIyBDU1NfUFJPUF9CT1JERVJfSU1BR0UKICMK ICMgc3RyZXRjaAogIyByZXBlYXQKIHJvdW5kCi0KICMKICMgQ1NTX1BST1BfQkFDS0dST1VORF9D TElQL09SSUdJTgogIwogYm9yZGVyCiBjb250ZW50CiBwYWRkaW5nCi0KICMKICMgQ1NTX1BST1Bf Qk9YX1NJWklORwogIwogYm9yZGVyLWJveAogY29udGVudC1ib3gKLQogIwogIyBDU1NfUFJPUF9f S0hUTUxfUlRMX09SREVSSU5HCiAjCkluZGV4OiBXZWJDb3JlLnZjcHJvai9XZWJDb3JlL2J1aWxk LWdlbmVyYXRlZC1maWxlcy5zaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlLnZjcHJvai9XZWJDb3Jl L2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaAkocmV2aXNpb24gMTU4MzApCisrKyBXZWJDb3JlLnZj cHJvai9XZWJDb3JlL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaAkod29ya2luZyBjb3B5KQpAQCAt MjEsNyArMjEsNyBAQAogCiBleHBvcnQgV2ViQ29yZT0iJHtTUkNST09UfSIKIGV4cG9ydCBFTkNP RElOR1NfRklMRT0iJHtXZWJDb3JlfS9wbGF0Zm9ybS93aW4vd2luLWVuY29kaW5ncy50eHQiOwot ZXhwb3J0IEVOQ09ESU5HU19QUkVGSVg9IiIKK2V4cG9ydCBFTkNPRElOR1NfUFJFRklYPSJcIiBc IiIKICMgRklYTUU6IFNob3VsZCBtYWtlIFhQYXRoIFN1cHBvcnQgY29uZmlndXJhYmxlIHNvbWVk YXkgb24gV2luMzIuCiBleHBvcnQgRkVBVFVSRV9ERUZJTkVTPSJYUEFUSF9TVVBQT1JUIgogbWFr ZSAtZiAiJFdlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSIgfHwgZXhpdCAxCg==