103412 2012-11-27 08:07:27 -0800 Calling .removeCue() for a cue that was never added should raise a NOT_FOUND_ERR 2012-11-28 10:56:43 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrack/removeCue.html InRadar P2 Normal --- 0 graouts webkit-unassigned eric.carlson feature-media-reviews ojan webkit-bug-importer webkit.review.bot oldest_to_newest 776755 0 graouts 2012-11-27 08:07:27 -0800 We are failing the Opera-submitted test at http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrack/removeCue.html due to failing to raising an INVALID_STATE_ERR exception instead of the expected NOT_FOUND_ERR exception when calling .removeCue() for a cue that was not added on a given track. The spec is quite clear on that, we're not doing the right thing (see http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#dom-texttrack-removecue). 776756 1 webkit-bug-importer 2012-11-27 08:07:53 -0800 <rdar://problem/12757953> 777924 2 176488 graouts 2012-11-28 08:19:07 -0800 Created attachment 176488 Patch 778071 3 176488 webkit.review.bot 2012-11-28 10:56:40 -0800 Comment on attachment 176488 Patch Clearing flags on attachment: 176488 Committed r136026: <http://trac.webkit.org/changeset/136026> 778072 4 webkit.review.bot 2012-11-28 10:56:43 -0800 All reviewed patches have been landed. Closing bug. 176488 2012-11-28 08:19:07 -0800 2012-11-28 10:56:39 -0800 Patch bug-103412-20121128171641.patch text/plain 4929 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzk2MmE1YmQ4ZTE4Mzhk OWM1OWYxMmYzM2I1YTQwOTQ4YjI1YjgyOS4uOGQxZjAwMmU3MTRjNzc5N2U0MTM3YzczOWVhNGJi NTllY2FlYzdkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTI4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbGluZyAucmVtb3Zl Q3VlKCkgZm9yIGEgY3VlIHRoYXQgd2FzIG5ldmVyIGFkZGVkIHNob3VsZCByYWlzZSBhIE5PVF9G T1VORF9FUlIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0aW5nIHRoZSAucmVtb3ZlQ3VlKCkgaW1wbGVtZW50YXRpb24gdG8gbWF0Y2ggdGhlIGxh dGVzdCBzcGVjLiBUaGlzIG1lYW5zIHdlIG5vdworICAgICAgICByYWlzZSBhIE5PVF9GT1VORF9F UlIgZXhjZXB0aW9uIHdoZW4gdHJ5aW5nIHRvIHJlbW92ZSBhIGN1ZSB0aGF0IHdhc24ndCBwcmVz ZW50IGluIHRoZQorICAgICAgICBjdWUgbGlzdCBpbnN0ZWFkIG9mIGEgSU5WQUxJRF9TVEFURV9F UlIgZXhjZXB0aW9uIGxpa2UgdGhlIHNwZWMgdXNlZCB0byBtYW5kYXRlLgorCisgICAgICAgICog aHRtbC90cmFjay9UZXh0VHJhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFRyYWNrOjpy ZW1vdmVDdWUpOgorCiAyMDEyLTExLTI4ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBh bnkxMDAubmV0PgogCiAgICAgICAgIFtUZXhtYXBdIFJFR1JFU1NJT04ocjEzNTYyMCkgUXRUZXN0 QnJvd3NlciBjcmFzaGVzIG9uIEdvb2dsZS1ncmF2aXR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2suY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFj ay9UZXh0VHJhY2suY3BwCmluZGV4IDk1YWIxOTA4MDVjYjk5MmUxZDAzZTA3YjA1N2VhNTQ1ZDJh YjYwNTIuLjZhNmU5MGJlNjM0NTY2MDUwMWY2YjUxOWY4YmM3NWE3YTNjZTc3YzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5jcHAKQEAgLTI1OSwyMCArMjU5LDE4IEBAIHZv aWQgVGV4dFRyYWNrOjpyZW1vdmVDdWUoVGV4dFRyYWNrQ3VlKiBjdWUsIEV4Y2VwdGlvbkNvZGUm IGVjKQogICAgIGlmICghY3VlKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyA0LjguMTAuMTIu NCBUZXh0IHRyYWNrIEFQSQorICAgIC8vIDQuOC4xMC4xMi41IFRleHQgdHJhY2sgQVBJCiAKICAg ICAvLyBUaGUgcmVtb3ZlQ3VlKGN1ZSkgbWV0aG9kIG9mIFRleHRUcmFjayBvYmplY3RzLCB3aGVu IGludm9rZWQsIG11c3QgcnVuIHRoZSBmb2xsb3dpbmcgc3RlcHM6CiAKLSAgICAvLyAxLiBJZiB0 aGUgZ2l2ZW4gY3VlIGlzIG5vdCBhc3NvY2lhdGVkIHdpdGggdGhlIG1ldGhvZCdzIFRleHRUcmFj ayAKLSAgICAvLyBvYmplY3QncyB0ZXh0IHRyYWNrLCB0aGVuIHRocm93IGFuIEludmFsaWRTdGF0 ZUVycm9yIGV4Y2VwdGlvbi4KKyAgICAvLyAxLiBJZiB0aGUgZ2l2ZW4gY3VlIGlzIG5vdCBjdXJy ZW50bHkgbGlzdGVkIGluIHRoZSBtZXRob2QncyBUZXh0VHJhY2sgCisgICAgLy8gb2JqZWN0J3Mg dGV4dCB0cmFjaydzIHRleHQgdHJhY2sgbGlzdCBvZiBjdWVzLCB0aGVuIHRocm93IGEgTm90Rm91 bmRFcnJvciBleGNlcHRpb24uCiAgICAgaWYgKGN1ZS0+dHJhY2soKSAhPSB0aGlzKSB7Ci0gICAg ICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CisgICAgICAgIGVjID0gTk9UX0ZPVU5EX0VSUjsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICAKLSAgICAvLyAyLiBJZiB0aGUgZ2l2ZW4gY3Vl IGlzIG5vdCBjdXJyZW50bHkgbGlzdGVkIGluIHRoZSBtZXRob2QncyBUZXh0VHJhY2sgCi0gICAg Ly8gb2JqZWN0J3MgdGV4dCB0cmFjaydzIHRleHQgdHJhY2sgbGlzdCBvZiBjdWVzLCB0aGVuIHRo cm93IGEgTm90Rm91bmRFcnJvciBleGNlcHRpb24uCi0gICAgLy8gMy4gUmVtb3ZlIGN1ZSBmcm9t IHRoZSBtZXRob2QncyBUZXh0VHJhY2sgb2JqZWN0J3MgdGV4dCB0cmFjaydzIHRleHQgdHJhY2sg bGlzdCBvZiBjdWVzLgorCisgICAgLy8gMi4gUmVtb3ZlIGN1ZSBmcm9tIHRoZSBtZXRob2QncyBU ZXh0VHJhY2sgb2JqZWN0J3MgdGV4dCB0cmFjaydzIHRleHQgdHJhY2sgbGlzdCBvZiBjdWVzLgog ICAgIGlmICghbV9jdWVzIHx8ICFtX2N1ZXMtPnJlbW92ZShjdWUpKSB7CiAgICAgICAgIGVjID0g SU5WQUxJRF9TVEFURV9FUlI7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5YmIxNDIwMWY5M2Ew NWJiYWU3NDg2ZjBkMTk2ODYyZGFkZGUyMWRjLi5iY2E4YzhjODFlM2RiMDg5MWZjOGRkYzRhYWFm YzFlM2VjNDIyMjU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMjggIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBDYWxsaW5nIC5yZW1vdmVDdWUo KSBmb3IgYSBjdWUgdGhhdCB3YXMgbmV2ZXIgYWRkZWQgc2hvdWxkIHJhaXNlIGEgTk9UX0ZPVU5E X0VSUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz NDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRpbmcgdGhlIC5yZW1vdmVDdWUoKSB0ZXN0IGNoZWNraW5nIG9uIHRoZSBleGNlcHRpb24gdG8g YmUgTk9UX0ZPVU5EX0VSUiBpbnN0ZWFkCisgICAgICAgIG9mIElOVkFMSURfU1RBVEVfRVJSLgor CisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stYWRkLXJlbW92ZS1jdWUtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLWFkZC1yZW1vdmUtY3VlLmh0bWw6CisKIDIw MTItMTEtMjggIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAg ICAgQWRkIGJhc2ljIGltcGxlbWVudGF0aW9uIGZvciBNZWRpYVN0cmVhbUF1ZGlvRGVzdGluYXRp b25Ob2RlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1hZGQtcmVt b3ZlLWN1ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1hZGQt cmVtb3ZlLWN1ZS1leHBlY3RlZC50eHQKaW5kZXggMjgyYzdiMDZiMzM4NGU1MDQwNjAwZDU4ZTQ0 ZmYzOTM3ZjQyZWY4NS4uMGY4OGFjNGExZTRhNzlmNmI1NmNiOGM4Y2E3ZWRhZTA3ZmNmMTg0OCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stYWRkLXJlbW92ZS1jdWUt ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWFkZC1yZW1v dmUtY3VlLWV4cGVjdGVkLnR4dApAQCAtNzAsNyArNzAsNyBAQCBFWFBFQ1RFRCAoY3Vlc1sxXS5z dGFydFRpbWUgPT0gJzMxJykgT0sKIEVYUEVDVEVEIChjdWVzWzJdLnN0YXJ0VGltZSA9PSAnMTIx JykgT0sKIAogKioqIFRyeSB0byByZW1vdmUgdGhlIGN1ZSBhZ2Fpbi4KLVRFU1QodGVzdFRyYWNr LnRyYWNrLnJlbW92ZUN1ZSh0ZXh0Q3VlKSkgVEhST1dTKERPTUV4Y2VwdGlvbi5JTlZBTElEX1NU QVRFX0VSUikgT0sKK1RFU1QodGVzdFRyYWNrLnRyYWNrLnJlbW92ZUN1ZSh0ZXh0Q3VlKSkgVEhS T1dTKERPTUV4Y2VwdGlvbi5OT1RfRk9VTkRfRVJSKSBPSwogCiAqKiogQWRkIGEgY3VlIGJlZm9y ZSBhbGwgdGhlIGV4aXN0aW5nIGN1ZXMuCiBSVU4odGVzdFRyYWNrLnRyYWNrLmFkZEN1ZShuZXcg VGV4dFRyYWNrQ3VlKDAsIDMxLCAnSSBhbSBmaXJzdCcpKSkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLWFkZC1yZW1vdmUtY3VlLmh0bWwgYi9MYXlvdXRUZXN0cy9t ZWRpYS90cmFjay90cmFjay1hZGQtcmVtb3ZlLWN1ZS5odG1sCmluZGV4IDBjOTQ2YzIxZGM0YTAx YjA2ZjBiYjA3MjdjYmExYTgwZjU1NWE4MmQuLmI0ODRlNzEyMDdjYmMxNmMxMGEwZTdiZjEyYTk1 OTNiYzNiMzZhYTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWFk ZC1yZW1vdmUtY3VlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stYWRk LXJlbW92ZS1jdWUuaHRtbApAQCAtODUsNyArODUsNyBAQAogICAgICAgICAgICAgICAgIHRlc3RF eHBlY3RlZCgiY3Vlc1syXS5zdGFydFRpbWUiLCAxMjEpOwogCiAgICAgICAgICAgICAgICAgY29u c29sZVdyaXRlKCI8YnI+KioqIFRyeSB0byByZW1vdmUgdGhlIGN1ZSBhZ2Fpbi4iKTsKLSAgICAg ICAgICAgICAgICB0ZXN0RXhjZXB0aW9uKCJ0ZXN0VHJhY2sudHJhY2sucmVtb3ZlQ3VlKHRleHRD dWUpIiwgIkRPTUV4Y2VwdGlvbi5JTlZBTElEX1NUQVRFX0VSUiIpOworICAgICAgICAgICAgICAg IHRlc3RFeGNlcHRpb24oInRlc3RUcmFjay50cmFjay5yZW1vdmVDdWUodGV4dEN1ZSkiLCAiRE9N RXhjZXB0aW9uLk5PVF9GT1VORF9FUlIiKTsKIAogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0 ZSgiPGJyPioqKiBBZGQgYSBjdWUgYmVmb3JlIGFsbCB0aGUgZXhpc3RpbmcgY3Vlcy4iKTsKICAg ICAgICAgICAgICAgICBydW4oInRlc3RUcmFjay50cmFjay5hZGRDdWUobmV3IFRleHRUcmFja0N1 ZSgwLCAzMSwgJ0kgYW0gZmlyc3QnKSkiKTsK