103410 2012-11-27 07:42:36 -0800 [Texmap] REGRESSION(r135620) QtTestBrowser crashes on Google-gravity. 2012-11-28 08:13:04 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno dongseong.hwang dongseong.hwang hausmann noam oldest_to_newest 776739 0 zeno 2012-11-27 07:42:36 -0800 To reproduce start "QtTestBrowser -graphicsbased" and visit the following page: http://mrdoob.com/projects/chromeexperiments/google-gravity/. The problem seems to be related to TextureMapper / GraphicsLayerTextureMapper creation. Either we end up having multiple root layers, or a root layer without a TextureMapper (possibly due to a race condition). I will investigate further and post my findings. 776744 1 hausmann 2012-11-27 07:48:12 -0800 Note to No'am and Huang: assert(textureMapper) in GraphicsLayerTextureMapper::updateBackingStore is what's failing after the change. 776770 2 zeno 2012-11-27 08:25:59 -0800 minimal example to reproduce the problem: <html><body> <div style="-webkit-transform: translateZ(0px);">hello</div> </body></html> 776773 3 176272 zeno 2012-11-27 08:28:07 -0800 Created attachment 176272 Backtrace 777430 4 dongseong.hwang 2012-11-27 18:00:53 -0800 After I read code again, I understand GraphicsLayerTextureMapper::updateBackingStore has a problem. GraphicsLayer::FlushCompositingState can be called by RenderLayerBacking. It means this method can be called before creating TextureMapper. So TextureMapperLayer::flushCompositingState() checks and if textureMapper does not exist, do nothing. void TextureMapperLayer::flushCompositingState(GraphicsLayerTextureMapper* graphicsLayer, TextureMapper* textureMapper, int options) { if (!textureMapper) return; ... } But GraphicsLayerTextureMapper::updateBackingStore expects textureMapper always exists. Bug 103366 can fix this bug, but I think it is right that this bug fixes hitting assertion and then reviews Bug 103366. If we change code like following code, this bug can be fixed. In the detail, we must keep m_needsDisplay until GraphicsLayerTextureMapper::prepareBackingStore() is completed, so m_needsDisplay should be removed in GraphicsLayerTextureMapper::didFlushCompositingState(). I'm glad anyone to fix it. If you want, I can do it of course. @@ -404,8 +410,6 @@ void GraphicsLayerTextureMapper::didFlushCompositingState() { updateBackingStore(); m_changeMask = 0; - m_needsDisplay = false; - m_needsDisplayRect = IntRect(); } void GraphicsLayerTextureMapper::didFlushCompositingStateRecursive() @@ -430,6 +434,10 @@ void GraphicsLayerTextureMapper::updateBackingStore() void GraphicsLayerTextureMapper::prepareBackingStore() { + TextureMapper* textureMapper = m_layer->textureMapper(); + if (!textureMapper) + return; + if (!shouldHaveBackingStore()) { m_backingStore.clear(); return; @@ -441,9 +449,6 @@ void GraphicsLayerTextureMapper::prepareBackingStore() if (dirtyRect.isEmpty()) return; - TextureMapper* textureMapper = m_layer->textureMapper(); - ASSERT(textureMapper); - if (!m_backingStore) m_backingStore = TextureMapperTiledBackingStore::create(); 777435 5 noam 2012-11-27 18:07:36 -0800 > I'm glad anyone to fix it. If you want, I can do it of course. Yes, if you could fix this before posting more refactor patches it would be great :) 777481 6 dongseong.hwang 2012-11-27 20:25:52 -0800 (In reply to comment #5) > > I'm glad anyone to fix it. If you want, I can do it of course. > Yes, if you could fix this before posting more refactor patches it would be great :) My explanation can not fix this bug yet. "QtTestBrowser -graphicsbased" can not draw minimal text in #c2. I'm also investigating why. 777496 7 176391 dongseong.hwang 2012-11-27 21:11:41 -0800 Created attachment 176391 Patch : GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set. 777497 8 176392 dongseong.hwang 2012-11-27 21:13:50 -0800 Created attachment 176392 Patch : TextureMapperLayerClientQt::setTextureMapper() must call flushCompositingStateForThisLayerOnly() of the root layer. 777545 9 176391 noam 2012-11-27 22:38:47 -0800 Comment on attachment 176391 Patch : GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set. View in context: https://bugs.webkit.org/attachment.cgi?id=176391&action=review LGTM with changelog rewordings. > Source/WebCore/ChangeLog:8 > + GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set. early returns until -> should return early before > Source/WebCore/ChangeLog:12 > + TextureMapperLayer::flushCompositingState() checks and early returns if returns early > Source/WebCore/ChangeLog:13 > + TextureMapper does not exist. does not exist -> was not created > Source/WebCore/ChangeLog:17 > + However, GraphicsLayerTextureMapper::updateBackingStore() expects that TextureMapper > + always exists. This patch makes updateBackingStore() early return like > + TextureMapperLayer::flushCompositingState(). updateBackingStore should also return early when TextureMapper was not created. 777546 10 176392 noam 2012-11-27 22:41:33 -0800 Comment on attachment 176392 Patch : TextureMapperLayerClientQt::setTextureMapper() must call flushCompositingStateForThisLayerOnly() of the root layer. View in context: https://bugs.webkit.org/attachment.cgi?id=176392&action=review LGTM with ChangeLog rewording. > Source/WebKit/qt/ChangeLog:16 > + Currently, PageClientQGraphicsWidget::setRootGraphicsLayer does not flush layer > + states of the root layer after setting TextureMapper while > + PageClientQWidget::setRootGraphicsLayer() flushes them of the root layer. If > + not flushing states, descendant layers can not reach the root layer. It means > + descendant layers can not reach the TextureMapper that the root layer has. > + This is already the behavior for PageClientQWidget, which should be the case for PageClientQGraphicsWidget as well. 777579 11 hausmann 2012-11-27 23:46:01 -0800 Thanks Huang and No'am! We're trying to cut a release of the Qt port and branch this weekend. I appreciate how quickly you responded. Thanks a lot! :) We can test the patches during the course of today also and land them with the suggested changes if they work, unless somebody is quicker :) 777628 12 zeno 2012-11-28 01:28:31 -0800 LGTM :-) I tried both patches, and they seem to reliably resolve the issue. Thank you very much for looking into it so quickly! 777639 13 176391 zeno 2012-11-28 01:46:55 -0800 Comment on attachment 176391 Patch : GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set. Committed r135986. 777640 14 176392 zeno 2012-11-28 01:47:22 -0800 Comment on attachment 176392 Patch : TextureMapperLayerClientQt::setTextureMapper() must call flushCompositingStateForThisLayerOnly() of the root layer. Committed r135987. 777641 15 zeno 2012-11-28 01:47:57 -0800 All reviewed patches have been landed. Closing bug. 777760 16 dongseong.hwang 2012-11-28 04:53:31 -0800 Thanks for review and manual patch and good advice!! 777921 17 noam 2012-11-28 08:13:04 -0800 > We're trying to cut a release of the Qt port and branch this weekend. I appreciate how quickly you responded. Thanks a lot! :) No problem Simon, let me know if anything in coordinated graphics is blocking your release and I'll respond as quickly as I can. 176272 2012-11-27 08:28:07 -0800 2012-11-27 08:28:07 -0800 Backtrace backtrace.txt text/plain 7060 zeno VGhyZWFkIDAgQ3Jhc2hlZDo6IERpc3BhdGNoIHF1ZXVlOiBjb20uYXBwbGUubWFpbi10aHJlYWQK MCAgIGxpYldlYkNvcmUuMS5keWxpYiAgICAgICAgICAgIAkweDAwMDAwMDAxMDA5ZTE3N2QgV2Vi Q29yZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnByZXBhcmVCYWNraW5nU3RvcmUoKSAr IDQ0NQoxICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAwMDEwMDllMTQx ZCBXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6ZGlkRmx1c2hDb21wb3NpdGlu Z1N0YXRlKCkgKyAyOQoyICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAw MDEwMDllMTRmOCBXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6ZGlkRmx1c2hD b21wb3NpdGluZ1N0YXRlUmVjdXJzaXZlKCkgKyAyNAozICAgbGliV2ViQ29yZS4xLmR5bGliICAg ICAgICAgICAgCTB4MDAwMDAwMDEwMDllMTUyMCBXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVy ZU1hcHBlcjo6ZGlkRmx1c2hDb21wb3NpdGluZ1N0YXRlUmVjdXJzaXZlKCkgKyA2NAo0ICAgbGli V2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAwMDEwMDllMTUyMCBXZWJDb3JlOjpH cmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6ZGlkRmx1c2hDb21wb3NpdGluZ1N0YXRlUmVjdXJz aXZlKCkgKyA2NAo1ICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAwMDEw MDllMTUyMCBXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6ZGlkRmx1c2hDb21w b3NpdGluZ1N0YXRlUmVjdXJzaXZlKCkgKyA2NAo2ICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAg ICAgICAgCTB4MDAwMDAwMDEwMDllMTUyMCBXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1h cHBlcjo6ZGlkRmx1c2hDb21wb3NpdGluZ1N0YXRlUmVjdXJzaXZlKCkgKyA2NAo3ICAgbGliV2Vi Q29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAwMDEwMDllMTUyMCBXZWJDb3JlOjpHcmFw aGljc0xheWVyVGV4dHVyZU1hcHBlcjo6ZGlkRmx1c2hDb21wb3NpdGluZ1N0YXRlUmVjdXJzaXZl KCkgKyA2NAo4ICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAwMDAwMDEwMTI0 ZjI5ZiBXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZsdXNoUGVuZGluZ0xheWVyQ2hh bmdlcyhib29sKSArIDIyMwo5ICAgbGliV2ViQ29yZS4xLmR5bGliICAgICAgICAgICAgCTB4MDAw MDAwMDEwMDhhZmFhMSBXZWJDb3JlOjpGcmFtZVZpZXc6OmZsdXNoQ29tcG9zaXRpbmdTdGF0ZUZv clRoaXNGcmFtZShXZWJDb3JlOjpGcmFtZSopICsgMjA5CjEwICBsaWJXZWJDb3JlLjEuZHlsaWIg ICAgICAgICAgICAJMHgwMDAwMDAwMTAwOGI1ZDlkIFdlYkNvcmU6OkZyYW1lVmlldzo6cGFpbnRD b250ZW50cyhXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQqLCBXZWJDb3JlOjpJbnRSZWN0IGNvbnN0 JikgKyAzMTcKMTEgIGxpYldlYktpdFdpZGdldHMuMS5keWxpYiAgICAgIAkweDAwMDAwMDAxMDAw NTZkMWMgUVdlYkZyYW1lUHJpdmF0ZTo6cmVuZGVyUmVsYXRpdmVDb29yZHMoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0KiwgUUZsYWdzPFFXZWJGcmFtZTo6UmVuZGVyTGF5ZXI+LCBRUmVnaW9uIGNv bnN0JikgKyAxMDg0CjEyICBsaWJXZWJLaXRXaWRnZXRzLjEuZHlsaWIgICAgICAJMHgwMDAwMDAw MTAwMDU5M2JkIFFXZWJGcmFtZTo6cmVuZGVyKFFQYWludGVyKiwgUVdlYkZyYW1lOjpSZW5kZXJM YXllciwgUVJlZ2lvbiBjb25zdCYpICsgMTA5CjEzICBsaWJXZWJLaXRXaWRnZXRzLjEuZHlsaWIg ICAgICAJMHgwMDAwMDAwMTAwMDUzYjZmIFFHcmFwaGljc1dlYlZpZXc6OnBhaW50KFFQYWludGVy KiwgUVN0eWxlT3B0aW9uR3JhcGhpY3NJdGVtIGNvbnN0KiwgUVdpZGdldCopICsgMzUxCjE0ICBR dFdpZGdldHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTA0MDViM2ZhIF9xX3BhaW50 SXRlbShRR3JhcGhpY3NJdGVtKiwgUVBhaW50ZXIqLCBRU3R5bGVPcHRpb25HcmFwaGljc0l0ZW0g Y29uc3QqLCBRV2lkZ2V0KiwgYm9vbCwgYm9vbCkgKyA1MjIKMTUgIFF0V2lkZ2V0cyAgICAgICAg ICAgICAgICAgICAgIAkweDAwMDAwMDAxMDQwNTk1NzUgUUdyYXBoaWNzU2NlbmVQcml2YXRlOjpk cmF3SXRlbUhlbHBlcihRR3JhcGhpY3NJdGVtKiwgUVBhaW50ZXIqLCBRU3R5bGVPcHRpb25HcmFw aGljc0l0ZW0gY29uc3QqLCBRV2lkZ2V0KiwgYm9vbCkgKyAxMDEKMTYgIFF0V2lkZ2V0cyAgICAg ICAgICAgICAgICAgICAgIAkweDAwMDAwMDAxMDQwNWM3MGEgUUdyYXBoaWNzU2NlbmVQcml2YXRl OjpkcmF3KFFHcmFwaGljc0l0ZW0qLCBRUGFpbnRlciosIFFUcmFuc2Zvcm0gY29uc3QqLCBRVHJh bnNmb3JtIGNvbnN0KiwgUVJlZ2lvbiosIFFXaWRnZXQqLCBkb3VibGUsIFFUcmFuc2Zvcm0gY29u c3QqLCBib29sLCBib29sKSArIDE0NjYKMTcgIFF0V2lkZ2V0cyAgICAgICAgICAgICAgICAgICAg IAkweDAwMDAwMDAxMDQwNWMwZDAgUUdyYXBoaWNzU2NlbmVQcml2YXRlOjpkcmF3U3VidHJlZVJl Y3Vyc2l2ZShRR3JhcGhpY3NJdGVtKiwgUVBhaW50ZXIqLCBRVHJhbnNmb3JtIGNvbnN0KiwgUVJl Z2lvbiosIFFXaWRnZXQqLCBkb3VibGUsIFFUcmFuc2Zvcm0gY29uc3QqKSArIDIwMzIKMTggIFF0 V2lkZ2V0cyAgICAgICAgICAgICAgICAgICAgIAkweDAwMDAwMDAxMDQwNWI4ODMgUUdyYXBoaWNz U2NlbmVQcml2YXRlOjpkcmF3SXRlbXMoUVBhaW50ZXIqLCBRVHJhbnNmb3JtIGNvbnN0KiwgUVJl Z2lvbiosIFFXaWRnZXQqKSArIDQxOQoxOSAgUXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAg CTB4MDAwMDAwMDEwNDA3YjhjYyBRR3JhcGhpY3NWaWV3OjpwYWludEV2ZW50KFFQYWludEV2ZW50 KikgKyAxNzI0CjIwICBRdFdpZGdldHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAz ZGNiYWNiIFFXaWRnZXQ6OmV2ZW50KFFFdmVudCopICsgMjE1NQoyMSAgUXRXaWRnZXRzICAgICAg ICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwM2VhODVlNyBRRnJhbWU6OmV2ZW50KFFFdmVudCop ICsgMTgzCjIyICBRdFdpZGdldHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAzZjIy ZGE1IFFBYnN0cmFjdFNjcm9sbEFyZWE6OnZpZXdwb3J0RXZlbnQoUUV2ZW50KikgKyA1MwoyMyAg UXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwNDA3OGU4NSBRR3JhcGhp Y3NWaWV3Ojp2aWV3cG9ydEV2ZW50KFFFdmVudCopICsgMTIyMQoyNCAgUXRXaWRnZXRzICAgICAg ICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwM2YyMzY1NSBRQWJzdHJhY3RTY3JvbGxBcmVhRmls dGVyOjpldmVudEZpbHRlcihRT2JqZWN0KiwgUUV2ZW50KikgKyAzNwoyNSAgUXRDb3JlICAgICAg ICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMzU4MjA1NyBRQ29yZUFwcGxpY2F0aW9uUHJp dmF0ZTo6c2VuZFRocm91Z2hPYmplY3RFdmVudEZpbHRlcnMoUU9iamVjdCosIFFFdmVudCopICsg MTk5CjI2ICBRdFdpZGdldHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAzZDk0ZDU5 IFFBcHBsaWNhdGlvblByaXZhdGU6Om5vdGlmeV9oZWxwZXIoUU9iamVjdCosIFFFdmVudCopICsg MjgxCjI3ICBRdFdpZGdldHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAzZDk2NDYw IFFBcHBsaWNhdGlvbjo6bm90aWZ5KFFPYmplY3QqLCBRRXZlbnQqKSArIDY0MAoyOCAgUXRDb3Jl ICAgICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMzU4MWQ0ZSBRQ29yZUFwcGxpY2F0 aW9uOjpub3RpZnlJbnRlcm5hbChRT2JqZWN0KiwgUUV2ZW50KikgKyAxMTAKMjkgIFF0V2lkZ2V0 cyAgICAgICAgICAgICAgICAgICAgIAkweDAwMDAwMDAxMDNkYzY4ZWIgUVdpZGdldFByaXZhdGU6 OmRyYXdXaWRnZXQoUVBhaW50RGV2aWNlKiwgUVJlZ2lvbiBjb25zdCYsIFFQb2ludCBjb25zdCYs IGludCwgUVBhaW50ZXIqLCBRV2lkZ2V0QmFja2luZ1N0b3JlKikgKyAxODAzCjMwICBRdFdpZGdl dHMgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAzZGEwNWM1IFFXaWRnZXRCYWNraW5n U3RvcmU6OnN5bmMoKSArIDM0NjEKMzEgIFF0V2lkZ2V0cyAgICAgICAgICAgICAgICAgICAgIAkw eDAwMDAwMDAxMDNkYmU3MjcgUVdpZGdldFByaXZhdGU6OnN5bmNCYWNraW5nU3RvcmUoKSArIDIx NQozMiAgUXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwM2RjYzBkYiBR V2lkZ2V0OjpldmVudChRRXZlbnQqKSArIDM3MDcKMzMgIFF0V2lkZ2V0cyAgICAgICAgICAgICAg ICAgICAgIAkweDAwMDAwMDAxMDNlYmMwYWMgUU1haW5XaW5kb3c6OmV2ZW50KFFFdmVudCopICsg MTU4MAozNCAgUXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwM2Q5NGQ2 ZSBRQXBwbGljYXRpb25Qcml2YXRlOjpub3RpZnlfaGVscGVyKFFPYmplY3QqLCBRRXZlbnQqKSAr IDMwMgozNSAgUXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwM2Q5NjQ2 MCBRQXBwbGljYXRpb246Om5vdGlmeShRT2JqZWN0KiwgUUV2ZW50KikgKyA2NDAKMzYgIFF0Q29y ZSAgICAgICAgICAgICAgICAgICAgICAgIAkweDAwMDAwMDAxMDM1ODI5MjQgUUNvcmVBcHBsaWNh dGlvblByaXZhdGU6OnNlbmRQb3N0ZWRFdmVudHMoUU9iamVjdCosIGludCwgUVRocmVhZERhdGEq KSArIDgwNAozNyAgUXRXaWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwNDA0 OTQ4MCBRR3JhcGhpY3NTY2VuZVByaXZhdGU6Ol9xX3Byb2Nlc3NEaXJ0eUl0ZW1zKCkgKyA1NjAK MzggIFF0V2lkZ2V0cyAgICAgICAgICAgICAgICAgICAgIAkweDAwMDAwMDAxMDQwNWVmMWMgUUdy YXBoaWNzU2NlbmU6OnF0X3N0YXRpY19tZXRhY2FsbChRT2JqZWN0KiwgUU1ldGFPYmplY3Q6OkNh bGwsIGludCwgdm9pZCoqKSArIDM4MAozOSAgUXRDb3JlICAgICAgICAgICAgICAgICAgICAgICAg CTB4MDAwMDAwMDEwMzVhODkxOCBRT2JqZWN0OjpldmVudChRRXZlbnQqKSArIDgwOAo0MCAgUXRX aWRnZXRzICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwNDA1NDZlMSBRR3JhcGhpY3NT Y2VuZTo6ZXZlbnQoUUV2ZW50KikgKyAyMzA1CjQxICBRdFdpZGdldHMgICAgICAgICAgICAgICAg ICAgICAJMHgwMDAwMDAwMTAzZDk0ZDZlIFFBcHBsaWNhdGlvblByaXZhdGU6Om5vdGlmeV9oZWxw ZXIoUU9iamVjdCosIFFFdmVudCopICsgMzAyCjQyICBRdFdpZGdldHMgICAgICAgICAgICAgICAg ICAgICAJMHgwMDAwMDAwMTAzZDk2NDYwIFFBcHBsaWNhdGlvbjo6bm90aWZ5KFFPYmplY3QqLCBR RXZlbnQqKSArIDY0MAo0MyAgUXRDb3JlICAgICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAw MDEwMzU4MjkyNCBRQ29yZUFwcGxpY2F0aW9uUHJpdmF0ZTo6c2VuZFBvc3RlZEV2ZW50cyhRT2Jq ZWN0KiwgaW50LCBRVGhyZWFkRGF0YSopICsgODA0CjQ0ICBRdEd1aSAgICAgICAgICAgICAgICAg ICAgICAgICAJMHgwMDAwMDAwMTAzOTA4OTIxIFFXaW5kb3dTeXN0ZW1JbnRlcmZhY2U6OnNlbmRX aW5kb3dTeXN0ZW1FdmVudHMoUUZsYWdzPFFFdmVudExvb3A6OlByb2Nlc3NFdmVudHNGbGFnPikg KyAxNwo0NSAgbGlicWNvY29hLmR5bGliICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwNmYxM2Uw NSBRQ29jb2FFdmVudERpc3BhdGNoZXJQcml2YXRlOjpwcm9jZXNzUG9zdGVkRXZlbnRzKCkgKyAx NDkKNDYgIGNvbS5hcHBsZS5Db3JlRm91bmRhdGlvbiAgICAgIAkweDAwMDA3ZmZmOGU0NTEwYzcg X19DRlJVTkxPT1BfSVNfQ0FMTElOR19PVVRfVE9fQU5fT0JTRVJWRVJfQ0FMTEJBQ0tfRlVOQ1RJ T05fXyArIDIzCjQ3ICBjb20uYXBwbGUuQ29yZUZvdW5kYXRpb24gICAgICAJMHgwMDAwN2ZmZjhl NDUxMDMxIF9fQ0ZSdW5Mb29wRG9PYnNlcnZlcnMgKyAzNjkKNDggIGNvbS5hcHBsZS5Db3JlRm91 bmRhdGlvbiAgICAgIAkweDAwMDA3ZmZmOGU0MmJkYmUgQ0ZSdW5Mb29wUnVuU3BlY2lmaWMgKyAy NzAKNDkgIGNvbS5hcHBsZS5ISVRvb2xib3ggICAgICAgICAgIAkweDAwMDA3ZmZmOGUwYjA3NzQg UnVuQ3VycmVudEV2ZW50TG9vcEluTW9kZSArIDIwOQo1MCAgY29tLmFwcGxlLkhJVG9vbGJveCAg ICAgICAgICAgCTB4MDAwMDdmZmY4ZTBiMDQ1NCBSZWNlaXZlTmV4dEV2ZW50Q29tbW9uICsgMTY2 CjUxICBjb20uYXBwbGUuSElUb29sYm94ICAgICAgICAgICAJMHgwMDAwN2ZmZjhlMGIwM2EzIEJs b2NrVW50aWxOZXh0RXZlbnRNYXRjaGluZ0xpc3RJbk1vZGUgKyA2Mgo1MiAgY29tLmFwcGxlLkFw cEtpdCAgICAgICAgICAgICAgCTB4MDAwMDdmZmY4YmIxMGZhMyBfRFBTTmV4dEV2ZW50ICsgNjg1 CjUzICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgICAgICAJMHgwMDAwN2ZmZjhiYjEwODYyIC1b TlNBcHBsaWNhdGlvbiBuZXh0RXZlbnRNYXRjaGluZ01hc2s6dW50aWxEYXRlOmluTW9kZTpkZXF1 ZXVlOl0gKyAxMjgKNTQgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAgICAgIAkweDAwMDA3ZmZm OGJiMDdjMDMgLVtOU0FwcGxpY2F0aW9uIHJ1bl0gKyA1MTcKNTUgIGxpYnFjb2NvYS5keWxpYiAg ICAgICAgICAgICAgIAkweDAwMDAwMDAxMDZmMTM0MzUgUUNvY29hRXZlbnREaXNwYXRjaGVyOjpw cm9jZXNzRXZlbnRzKFFGbGFnczxRRXZlbnRMb29wOjpQcm9jZXNzRXZlbnRzRmxhZz4pICsgMTIz Nwo1NiAgUXRDb3JlICAgICAgICAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMzU3ZjY2MyBR RXZlbnRMb29wOjpleGVjKFFGbGFnczxRRXZlbnRMb29wOjpQcm9jZXNzRXZlbnRzRmxhZz4pICsg MzU1CjU3ICBRdENvcmUgICAgICAgICAgICAgICAgICAgICAgICAJMHgwMDAwMDAwMTAzNTgyMmI1 IFFDb3JlQXBwbGljYXRpb246OmV4ZWMoKSArIDM1Nwo1OCAgUXRUZXN0QnJvd3NlciAgICAgICAg ICAgICAgICAgCTB4MDAwMDAwMDEwMDAxNjg4NCBtYWluICsgMTQ2MAo1OSAgUXRUZXN0QnJvd3Nl ciAgICAgICAgICAgICAgICAgCTB4MDAwMDAwMDEwMDAwYWI2NCBzdGFydCArIDUyCg== 176391 2012-11-27 21:11:41 -0800 2012-11-28 01:46:55 -0800 Patch : GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set. bug-103410-20121128140914.patch text/plain 3591 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNlYzc1NTA1Y2QwZjQ5 NGM4MTJlN2ViYTc4M2FjZTNjMDU2NjJiMi4uZTRkNDNkNDIxMjA4ZTgxZmU4OTdmNTkyZDE3OWFj ZDM5MjYwMTJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTExLTI3ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhtYXBd IFJFR1JFU1NJT04ocjEzNTYyMCkgUXRUZXN0QnJvd3NlciBjcmFzaGVzIG9uIEdvb2dsZS1ncmF2 aXR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz NDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3Jh cGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnVwZGF0ZUJhY2tpbmdTdG9yZSgpIGVhcmx5IHJldHVy bnMgdW50aWwgVGV4dHVyZU1hcHBlciBpcyBzZXQuCisKKyAgICAgICAgR3JhcGhpY3NMYXllcjo6 Rmx1c2hDb21wb3NpdGluZ1N0YXRlKCkgY2FuIGJlIGNhbGxlZCBieSBSZW5kZXJMYXllckJhY2tp bmcuIEl0CisgICAgICAgIG1lYW5zIHRoaXMgbWV0aG9kIGNhbiBiZSBjYWxsZWQgYmVmb3JlIGNy ZWF0aW5nIFRleHR1cmVNYXBwZXIuIFNvCisgICAgICAgIFRleHR1cmVNYXBwZXJMYXllcjo6Zmx1 c2hDb21wb3NpdGluZ1N0YXRlKCkgY2hlY2tzIGFuZCBlYXJseSByZXR1cm5zIGlmCisgICAgICAg IFRleHR1cmVNYXBwZXIgZG9lcyBub3QgZXhpc3QuCisKKyAgICAgICAgSG93ZXZlciwgR3JhcGhp Y3NMYXllclRleHR1cmVNYXBwZXI6OnVwZGF0ZUJhY2tpbmdTdG9yZSgpIGV4cGVjdHMgdGhhdCBU ZXh0dXJlTWFwcGVyCisgICAgICAgIGFsd2F5cyBleGlzdHMuIFRoaXMgcGF0Y2ggbWFrZXMgdXBk YXRlQmFja2luZ1N0b3JlKCkgZWFybHkgcmV0dXJuIGxpa2UKKyAgICAgICAgVGV4dHVyZU1hcHBl ckxheWVyOjpmbHVzaENvbXBvc2l0aW5nU3RhdGUoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldE5lZWRzRGlzcGxheSk6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0TmVlZHNEaXNwbGF5SW5S ZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpkaWRG bHVzaENvbXBvc2l0aW5nU3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXI6OnByZXBhcmVCYWNraW5nU3RvcmUpOgorCiAyMDEyLTExLTI3ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBDb21waWxlIHRpbWUgc2l6ZSBh c3NlcnRpb25zIGZvciBUcmVlU2NvcGUsIFNoYWRvd1Jvb3QgYW5kIEVsZW1lbnRBdHRyaWJ1dGVE YXRhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKaW5kZXggMWRm OWJiMDc5NTlmMDU2ZjA3MTkyYmVkN2I4NTdhYjM3MTViYzBlNy4uYjFlOWNiMTBkMWFlZTJjMWMz MDQ3YTJkOWJjYTg1ODg2NTc1NmM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1 cmVNYXBwZXIuY3BwCkBAIC05MCw2ICs5MCw5IEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVN YXBwZXI6OndpbGxCZURlc3Ryb3llZCgpCiAqLwogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1h cHBlcjo6c2V0TmVlZHNEaXNwbGF5KCkKIHsKKyAgICBpZiAoIW1faGFzT3duQmFja2luZ1N0b3Jl KQorICAgICAgICByZXR1cm47CisKICAgICBtX25lZWRzRGlzcGxheSA9IHRydWU7CiAgICAgbm90 aWZ5Q2hhbmdlKFRleHR1cmVNYXBwZXJMYXllcjo6RGlzcGxheUNoYW5nZSk7CiAgICAgYWRkUmVw YWludFJlY3QoRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgbV9zaXplKSk7CkBAIC0xMDcsNiArMTEw LDkgQEAgdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0Q29udGVudHNOZWVkc0Rp c3BsYXkoKQogKi8KIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldE5lZWRzRGlz cGxheUluUmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7CisgICAgaWYgKCFtX2hhc093bkJh Y2tpbmdTdG9yZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKG1fbmVlZHNEaXNwbGF5KQog ICAgICAgICByZXR1cm47CiAgICAgbV9uZWVkc0Rpc3BsYXlSZWN0LnVuaXRlKHJlY3QpOwpAQCAt NDA0LDggKzQxMCw2IEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OmRpZEZsdXNo Q29tcG9zaXRpbmdTdGF0ZSgpCiB7CiAgICAgdXBkYXRlQmFja2luZ1N0b3JlKCk7CiAgICAgbV9j aGFuZ2VNYXNrID0gMDsKLSAgICBtX25lZWRzRGlzcGxheSA9IGZhbHNlOwotICAgIG1fbmVlZHNE aXNwbGF5UmVjdCA9IEludFJlY3QoKTsKIH0KIAogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1h cHBlcjo6ZGlkRmx1c2hDb21wb3NpdGluZ1N0YXRlUmVjdXJzaXZlKCkKQEAgLTQzMCw2ICs0MzQs MTAgQEAgdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6dXBkYXRlQmFja2luZ1N0b3Jl KCkKIAogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6cHJlcGFyZUJhY2tpbmdTdG9y ZSgpCiB7CisgICAgVGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlciA9IG1fbGF5ZXItPnRleHR1 cmVNYXBwZXIoKTsKKyAgICBpZiAoIXRleHR1cmVNYXBwZXIpCisgICAgICAgIHJldHVybjsKKwog ICAgIGlmICghc2hvdWxkSGF2ZUJhY2tpbmdTdG9yZSgpKSB7CiAgICAgICAgIG1fYmFja2luZ1N0 b3JlLmNsZWFyKCk7CiAgICAgICAgIHJldHVybjsKQEAgLTQ0MSw5ICs0NDksNiBAQCB2b2lkIEdy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpwcmVwYXJlQmFja2luZ1N0b3JlKCkKICAgICBpZiAo ZGlydHlSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgVGV4dHVyZU1hcHBl ciogdGV4dHVyZU1hcHBlciA9IG1fbGF5ZXItPnRleHR1cmVNYXBwZXIoKTsKLSAgICBBU1NFUlQo dGV4dHVyZU1hcHBlcik7Ci0KICAgICBpZiAoIW1fYmFja2luZ1N0b3JlKQogICAgICAgICBtX2Jh Y2tpbmdTdG9yZSA9IFRleHR1cmVNYXBwZXJUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlKCk7CiAK 176392 2012-11-27 21:13:50 -0800 2012-11-28 01:47:22 -0800 Patch : TextureMapperLayerClientQt::setTextureMapper() must call flushCompositingStateForThisLayerOnly() of the root layer. bug-103410-20121128141123.patch text/plain 2426 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDdmMTAzZTc2MGNh YWUzMjYyODk4NGZkYzdmNzE0MDkyYjE0YjFmNTguLjJjYmY3MjQ5NWVjMmNlNWMxMjQ5YTI0MWE2 YzExMWU0ODExMGJjNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTItMTEt MjcgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAg W1RleG1hcF0gUkVHUkVTU0lPTihyMTM1NjIwKSBRdFRlc3RCcm93c2VyIGNyYXNoZXMgb24gR29v Z2xlLWdyYXZpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDM0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXh0dXJlTWFwcGVyTGF5ZXJDbGllbnRRdDo6c2V0VGV4dHVyZU1hcHBlcigpIG11c3Qg Y2FsbAorICAgICAgICBmbHVzaENvbXBvc2l0aW5nU3RhdGVGb3JUaGlzTGF5ZXJPbmx5KCkgb2Yg dGhlIHJvb3QgbGF5ZXIuCisKKyAgICAgICAgQ3VycmVudGx5LCBQYWdlQ2xpZW50UUdyYXBoaWNz V2lkZ2V0OjpzZXRSb290R3JhcGhpY3NMYXllciBkb2VzIG5vdCBmbHVzaCBsYXllcgorICAgICAg ICBzdGF0ZXMgb2YgdGhlIHJvb3QgbGF5ZXIgYWZ0ZXIgc2V0dGluZyBUZXh0dXJlTWFwcGVyIHdo aWxlCisgICAgICAgIFBhZ2VDbGllbnRRV2lkZ2V0OjpzZXRSb290R3JhcGhpY3NMYXllcigpIGZs dXNoZXMgdGhlbSBvZiB0aGUgcm9vdCBsYXllci4gIElmCisgICAgICAgIG5vdCBmbHVzaGluZyBz dGF0ZXMsIGRlc2NlbmRhbnQgbGF5ZXJzIGNhbiBub3QgcmVhY2ggdGhlIHJvb3QgbGF5ZXIuIEl0 IG1lYW5zCisgICAgICAgIGRlc2NlbmRhbnQgbGF5ZXJzIGNhbiBub3QgcmVhY2ggdGhlIFRleHR1 cmVNYXBwZXIgdGhhdCB0aGUgcm9vdCBsYXllciBoYXMuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9QYWdlQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxh eWVyQ2xpZW50UXQ6OnNldFRleHR1cmVNYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZUNs aWVudFFXaWRnZXQ6OnNldFJvb3RHcmFwaGljc0xheWVyKToKKwogMjAxMi0xMS0yNyAgSmFtZXMg U2ltb25zZW4gIDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ29uc29saWRhdGUg RnJhbWVMb2FkZXI6OmxvYWQoKSBpbnRvIG9uZSBmdW5jdGlvbiB0YWtpbmcgYSBGcmFtZUxvYWRS ZXF1ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VD bGllbnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRR dC5jcHAKaW5kZXggMzY5MzA3Y2JhZTcwZGFiYzFlNDI5MGU2MDE3YTJmMGI4NzZmMGU0NS4uZDJi MDkwYWYyYTM4NzAzMDc3ZmNhNTQwZmEwMjllZDFhZGVlOGJhOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcApAQCAtMTAwLDYgKzEwMCw3 IEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyQ2xpZW50UXQ6OnNldFRleHR1cmVNYXBwZXIoY29u c3QgUGFzc093blB0cjxUZXh0dXJlTWFwcGVyCiB7CiAgICAgbV9mcmFtZS0+ZC0+dGV4dHVyZU1h cHBlciA9IHRleHR1cmVNYXBwZXI7CiAgICAgbV9mcmFtZS0+ZC0+cm9vdFRleHR1cmVNYXBwZXJM YXllci0+c2V0VGV4dHVyZU1hcHBlcihtX2ZyYW1lLT5kLT50ZXh0dXJlTWFwcGVyLmdldCgpKTsK KyAgICBzeW5jUm9vdExheWVyKCk7CiB9CiAKIFRleHR1cmVNYXBwZXJMYXllckNsaWVudFF0Ojp+ VGV4dHVyZU1hcHBlckxheWVyQ2xpZW50UXQoKQpAQCAtMTIzLDcgKzEyNCw2IEBAIHZvaWQgUGFn ZUNsaWVudFFXaWRnZXQ6OnNldFJvb3RHcmFwaGljc0xheWVyKEdyYXBoaWNzTGF5ZXIqIGxheWVy KQogICAgIGlmIChsYXllcikgewogICAgICAgICBUZXh0dXJlTWFwcGVyTGF5ZXJDbGllbnQgPSBh ZG9wdFB0cihuZXcgVGV4dHVyZU1hcHBlckxheWVyQ2xpZW50UXQocGFnZS0+bWFpbkZyYW1lKCks IGxheWVyKSk7CiAgICAgICAgIFRleHR1cmVNYXBwZXJMYXllckNsaWVudC0+c2V0VGV4dHVyZU1h cHBlcihUZXh0dXJlTWFwcGVyOjpjcmVhdGUoKSk7Ci0gICAgICAgIFRleHR1cmVNYXBwZXJMYXll ckNsaWVudC0+c3luY1Jvb3RMYXllcigpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIFRl eHR1cmVNYXBwZXJMYXllckNsaWVudC5jbGVhcigpOwo=