103409 2012-11-27 07:23:44 -0800 Use render box background over border draw strategy in cases with background-image 2012-12-12 11:10:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 junov junov adamk dglazkov eric ojan senorblanco simon.fraser webkit.review.bot oldest_to_newest 776728 0 junov 2012-11-27 07:23:44 -0800 Use render box background over border draw strategy in cases with background-image 776735 1 176264 junov 2012-11-27 07:32:18 -0800 Created attachment 176264 Patch 776809 2 176264 simon.fraser 2012-11-27 08:49:40 -0800 Comment on attachment 176264 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176264&action=review > Source/WebCore/rendering/RenderBox.cpp:924 > + // If there is only one layer and no image, check whether the background color is opaque > + if (!fillLayer->next() && !fillLayer->hasImage()) { > + Color bgColor = style()->visitedDependentColor(CSSPropertyBackgroundColor); > + if (bgColor.isValid() && bgColor.alpha() == 255) > + return true; > + } What about an alpha image plus an opaque color? 776847 3 junov 2012-11-27 09:21:58 -0800 (In reply to comment #2) > > What about an alpha image plus an opaque color? That could lead to color bleeding of the background color at the anti-aliased edges of rounded corners, so we want to use the TransparencyLayer strategy in that case. 777437 4 176264 webkit.review.bot 2012-11-27 18:13:18 -0800 Comment on attachment 176264 Patch Attachment 176264 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15025186 New failing tests: fast/backgrounds/gradient-background-leakage-2.html 777446 5 176264 webkit.review.bot 2012-11-27 18:35:26 -0800 Comment on attachment 176264 Patch Attachment 176264 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15031059 New failing tests: fast/backgrounds/gradient-background-leakage-2.html 783934 6 177800 junov 2012-12-05 11:25:40 -0800 Created attachment 177800 Patch 789554 7 junov 2012-12-12 07:57:55 -0800 Review ping. 789618 8 177800 webkit.review.bot 2012-12-12 09:12:38 -0800 Comment on attachment 177800 Patch Clearing flags on attachment: 177800 Committed r137473: <http://trac.webkit.org/changeset/137473> 789619 9 webkit.review.bot 2012-12-12 09:12:42 -0800 All reviewed patches have been landed. Closing bug. 789642 10 adamk 2012-12-12 09:50:57 -0800 Is there any chance that this would cause image diffs where background-image is not involved? I'm seeing slight diffs in the calendar picker after this change: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-ru.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fweek-picker-appearance-step.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fmonth-picker-appearance-step.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fweek-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fmonth-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-step.html 789722 11 adamk 2012-12-12 11:10:47 -0800 Filed bug 104825 to track the image diffs in calendar-picker. 176264 2012-11-27 07:32:18 -0800 2012-12-05 11:25:37 -0800 Patch bug-103409-20121127102955.patch text/plain 4061 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTExLTI3ICBKdXN0aW4g Tm92b3NhZCAgPGp1bm92QGdvb2dsZS5jb20+CisKKyAgICAgICAgVXNlIHJlbmRlciBib3ggYmFj a2dyb3VuZCBvdmVyIGJvcmRlciBkcmF3IHN0cmF0ZWd5IGluIGNhc2VzIHdpdGggYmFja2dyb3Vu ZC1pbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzNDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIEJhY2tncm91bmRPdmVyQm9yZGVyQmxlZWRBdm9pZGFuY2UgbW9kZSB3YXMgbm90IGJlaW5n IHVzZWQgaW4KKyAgICAgICAgY2FzZXMgd2hlcmUgdGhlIGJhY2tncm91bmQgaXMgYW4gb3BhcXVl IGltYWdlLiBJdCB3YXMgYWxzbyBub3QKKyAgICAgICAgYmVpbmcgdXNlZCBpbiBjYXNlcyB3aXRo IG11bHRpcGxlIGxheWVycy4gVGhlIG11bHRpcGxlIGxheWVyCisgICAgICAgIGNhc2UgaXMgbm93 IHNhZmUgd2l0aCByZXNwZWN0IHRvIGNvbG9yIGJsZWVkaW5nIGlmIHRoZSB0b3AgbGF5ZXIKKyAg ICAgICAgaXMgb3BhcXVlLCB0aGFuayB0byB0aGUgcmVjZW50IGFkZGl0aW9uIG9mIGxheWVyIG9j Y2x1c2lvbiBjdWxsaW5nCisgICAgICAgIGluIHIxMzU2MjkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzOiB0ZXN0aW5nIGFscmVhZHkgY292ZXJlZCBieSAKKyAgICAgICAgZmFzdC9iYWNrZ3JvdW5k cy9iYWNrZ3JvdW5kLW9wYXF1ZS1pbWFnZXMtb3Zlci1jb2xvci5odG1sIAorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmRl dGVybWluZUJhY2tncm91bmRCbGVlZEF2b2lkYW5jZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCb3g6OmJhY2tncm91bmRIYXNPcGFxdWVUb3BMYXllcik6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJveC5oOgorICAgICAgICAoUmVuZGVyQm94KToKKwogMjAxMi0xMS0yNyAgQWxlYyBG bGV0dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBzdHVi IG91dCBJREJEYXRhYmFzZUJhY2tlbmRJbnRlcmZhY2U6OmNyZWF0ZVRyYW5zYWN0aW9uCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkocmV2aXNpb24gMTM1ODU5KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTgzMCw3ICs4MzAsNyBAQCBCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UgUmVuZGVyQm94Ojpk ZXRlCiAgICAgRmxvYXRTaXplIGNvbnRleHRTY2FsaW5nKHN0YXRpY19jYXN0PGZsb2F0PihjdG0u eFNjYWxlKCkpLCBzdGF0aWNfY2FzdDxmbG9hdD4oY3RtLnlTY2FsZSgpKSk7CiAgICAgaWYgKGJv cmRlck9ic2N1cmVzQmFja2dyb3VuZEVkZ2UoY29udGV4dFNjYWxpbmcpKQogICAgICAgICByZXR1 cm4gQmFja2dyb3VuZEJsZWVkU2hyaW5rQmFja2dyb3VuZDsKLSAgICBpZiAoIXN0eWxlLT5oYXNB cHBlYXJhbmNlKCkgJiYgYm9yZGVyT2JzY3VyZXNCYWNrZ3JvdW5kKCkgJiYgYmFja2dyb3VuZElz U2luZ2xlT3BhcXVlTGF5ZXIoKSkKKyAgICBpZiAoIXN0eWxlLT5oYXNBcHBlYXJhbmNlKCkgJiYg Ym9yZGVyT2JzY3VyZXNCYWNrZ3JvdW5kKCkgJiYgYmFja2dyb3VuZEhhc09wYXF1ZVRvcExheWVy KCkpCiAgICAgICAgIHJldHVybiBCYWNrZ3JvdW5kQmxlZWRCYWNrZ3JvdW5kT3ZlckJvcmRlcjsK IAogICAgIHJldHVybiBCYWNrZ3JvdW5kQmxlZWRVc2VUcmFuc3BhcmVuY3lMYXllcjsKQEAgLTkw MywyMSArOTAzLDI1IEBAIHZvaWQgUmVuZGVyQm94OjpwYWludEJhY2tncm91bmQoY29uc3QgUGEK ICAgICB9CiB9CiAKLWJvb2wgUmVuZGVyQm94OjpiYWNrZ3JvdW5kSXNTaW5nbGVPcGFxdWVMYXll cigpIGNvbnN0Citib29sIFJlbmRlckJveDo6YmFja2dyb3VuZEhhc09wYXF1ZVRvcExheWVyKCkg Y29uc3QKIHsKICAgICBjb25zdCBGaWxsTGF5ZXIqIGZpbGxMYXllciA9IHN0eWxlKCktPmJhY2tn cm91bmRMYXllcnMoKTsKLSAgICBpZiAoIWZpbGxMYXllciB8fCBmaWxsTGF5ZXItPm5leHQoKSB8 fCBmaWxsTGF5ZXItPmNsaXAoKSAhPSBCb3JkZXJGaWxsQm94IHx8IGZpbGxMYXllci0+Y29tcG9z aXRlKCkgIT0gQ29tcG9zaXRlU291cmNlT3ZlcikKKyAgICBpZiAoIWZpbGxMYXllciB8fCBmaWxs TGF5ZXItPmNsaXAoKSAhPSBCb3JkZXJGaWxsQm94KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICAvLyBDbGlwcGVkIHdpdGggbG9jYWwgc2Nyb2xsaW5nCiAgICAgaWYgKGhhc092ZXJmbG93 Q2xpcCgpICYmIGZpbGxMYXllci0+YXR0YWNobWVudCgpID09IExvY2FsQmFja2dyb3VuZEF0dGFj aG1lbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIENvbG9yIGJnQ29sb3IgPSBzdHls ZSgpLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpOwot ICAgIGlmIChiZ0NvbG9yLmlzVmFsaWQoKSAmJiBiZ0NvbG9yLmFscGhhKCkgPT0gMjU1KQorICAg IGlmIChmaWxsTGF5ZXItPmhhc09wYXF1ZUltYWdlKHRoaXMpICYmIGZpbGxMYXllci0+aGFzUmVw ZWF0WFkoKSAmJiBmaWxsTGF5ZXItPmltYWdlKCktPmNhblJlbmRlcih0aGlzLCBzdHlsZSgpLT5l ZmZlY3RpdmVab29tKCkpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAKLSAgICAvLyBGSVhN RTogcmV0dXJuIHRydWUgaWYgYSBiYWNrZ3JvdW5kIGltYWdlIGlzIHByZXNlbnQgYW5kIGlzIG9w YXF1ZQorCisgICAgLy8gSWYgdGhlcmUgaXMgb25seSBvbmUgbGF5ZXIgYW5kIG5vIGltYWdlLCBj aGVjayB3aGV0aGVyIHRoZSBiYWNrZ3JvdW5kIGNvbG9yIGlzIG9wYXF1ZQorICAgIGlmICghZmls bExheWVyLT5uZXh0KCkgJiYgIWZpbGxMYXllci0+aGFzSW1hZ2UoKSkgeworICAgICAgICBDb2xv ciBiZ0NvbG9yID0gc3R5bGUoKS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFj a2dyb3VuZENvbG9yKTsKKyAgICAgICAgaWYgKGJnQ29sb3IuaXNWYWxpZCgpICYmIGJnQ29sb3Iu YWxwaGEoKSA9PSAyNTUpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CiAKICAgICBy ZXR1cm4gZmFsc2U7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCShy ZXZpc2lvbiAxMzU4NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJ KHdvcmtpbmcgY29weSkKQEAgLTU3MCw3ICs1NzAsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBw YWludE1hc2tJbWFnZXMoY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgTGF5b3V0UmVjdCYpOwogCiAg ICAgQmFja2dyb3VuZEJsZWVkQXZvaWRhbmNlIGRldGVybWluZUJhY2tncm91bmRCbGVlZEF2b2lk YW5jZShHcmFwaGljc0NvbnRleHQqKSBjb25zdDsKLSAgICBib29sIGJhY2tncm91bmRJc1Npbmds ZU9wYXF1ZUxheWVyKCkgY29uc3Q7CisgICAgYm9vbCBiYWNrZ3JvdW5kSGFzT3BhcXVlVG9wTGF5 ZXIoKSBjb25zdDsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2b2lkIHBhaW50Q3VzdG9tSGln aGxpZ2h0KGNvbnN0IExheW91dFBvaW50JiwgY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29s IGJlaGluZFRleHQpOwo= 177800 2012-12-05 11:25:40 -0800 2012-12-12 09:12:38 -0800 Patch bug-103409-20121205142304.patch text/plain 5604 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjQzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTEyLTAzICBKdXN0aW4g Tm92b3NhZCAgPGp1bm92QGdvb2dsZS5jb20+CisKKyAgICAgICAgVXNlIHJlbmRlciBib3ggYmFj a2dyb3VuZCBvdmVyIGJvcmRlciBkcmF3IHN0cmF0ZWd5IGluIGNhc2VzIHdpdGggYmFja2dyb3Vu ZC1pbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzNDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIEJhY2tncm91bmRPdmVyQm9yZGVyQmxlZWRBdm9pZGFuY2UgbW9kZSB3YXMgbm90IGJlaW5n IHVzZWQgaW4KKyAgICAgICAgY2FzZXMgd2hlcmUgdGhlIGJhY2tncm91bmQgaXMgYW4gb3BhcXVl IGltYWdlLiBJdCB3YXMgYWxzbyBub3QKKyAgICAgICAgYmVpbmcgdXNlZCBpbiBjYXNlcyB3aXRo IG11bHRpcGxlIGxheWVycy4gVGhlIG11bHRpcGxlIGxheWVyCisgICAgICAgIGNhc2UgaXMgbm93 IHNhZmUgd2l0aCByZXNwZWN0IHRvIGNvbG9yIGJsZWVkaW5nIGlmIHRoZSB0b3AgbGF5ZXIKKyAg ICAgICAgaXMgb3BhcXVlLCB0aGFuayB0byB0aGUgcmVjZW50IGFkZGl0aW9uIG9mIGxheWVyIG9j Y2x1c2lvbiBjdWxsaW5nCisgICAgICAgIGluIHIxMzU2MjkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBUZXN0aW5nIGFscmVhZHkgY292ZXJlZCBieSB0aGUgZm9sbG93aW5nIHRlc3RzOgorICAg ICAgICBmYXN0L2JhY2tncm91bmRzL2JhY2tncm91bmQtb3BhcXVlLWltYWdlcy1vdmVyLWNvbG9y Lmh0bWwKKyAgICAgICAgZmFzdC9iYWNrZ3JvdW5kcy9ncmFkaWVudC1iYWNrZ3JvdW5kLWxlYWth Z2UtMi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckJveDo6ZGV0ZXJtaW5lQmFja2dyb3VuZEJsZWVkQXZvaWRhbmNlKToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6YmFja2dyb3VuZEhhc09wYXF1ZVRvcExheWVy KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgIChSZW5kZXJCb3gp OgorCiAyMDEyLTEyLTAzICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgW1NraWFdIERlZmVycmVkIFNrQ2FudmFzIHNhdmUoKQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlzaW9uIDEzNjI1NykKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04ODAsNyAr ODgwLDcgQEAgQmFja2dyb3VuZEJsZWVkQXZvaWRhbmNlIFJlbmRlckJveDo6ZGV0ZQogICAgIEZs b2F0U2l6ZSBjb250ZXh0U2NhbGluZyhzdGF0aWNfY2FzdDxmbG9hdD4oY3RtLnhTY2FsZSgpKSwg c3RhdGljX2Nhc3Q8ZmxvYXQ+KGN0bS55U2NhbGUoKSkpOwogICAgIGlmIChib3JkZXJPYnNjdXJl c0JhY2tncm91bmRFZGdlKGNvbnRleHRTY2FsaW5nKSkKICAgICAgICAgcmV0dXJuIEJhY2tncm91 bmRCbGVlZFNocmlua0JhY2tncm91bmQ7Ci0gICAgaWYgKCFzdHlsZS0+aGFzQXBwZWFyYW5jZSgp ICYmIGJvcmRlck9ic2N1cmVzQmFja2dyb3VuZCgpICYmIGJhY2tncm91bmRJc1NpbmdsZU9wYXF1 ZUxheWVyKCkpCisgICAgaWYgKCFzdHlsZS0+aGFzQXBwZWFyYW5jZSgpICYmIGJvcmRlck9ic2N1 cmVzQmFja2dyb3VuZCgpICYmIGJhY2tncm91bmRIYXNPcGFxdWVUb3BMYXllcigpKQogICAgICAg ICByZXR1cm4gQmFja2dyb3VuZEJsZWVkQmFja2dyb3VuZE92ZXJCb3JkZXI7CiAKICAgICByZXR1 cm4gQmFja2dyb3VuZEJsZWVkVXNlVHJhbnNwYXJlbmN5TGF5ZXI7CkBAIC05NTMsMjEgKzk1Mywy NSBAQCB2b2lkIFJlbmRlckJveDo6cGFpbnRCYWNrZ3JvdW5kKGNvbnN0IFBhCiAgICAgfQogfQog Ci1ib29sIFJlbmRlckJveDo6YmFja2dyb3VuZElzU2luZ2xlT3BhcXVlTGF5ZXIoKSBjb25zdAor Ym9vbCBSZW5kZXJCb3g6OmJhY2tncm91bmRIYXNPcGFxdWVUb3BMYXllcigpIGNvbnN0CiB7CiAg ICAgY29uc3QgRmlsbExheWVyKiBmaWxsTGF5ZXIgPSBzdHlsZSgpLT5iYWNrZ3JvdW5kTGF5ZXJz KCk7Ci0gICAgaWYgKCFmaWxsTGF5ZXIgfHwgZmlsbExheWVyLT5uZXh0KCkgfHwgZmlsbExheWVy LT5jbGlwKCkgIT0gQm9yZGVyRmlsbEJveCB8fCBmaWxsTGF5ZXItPmNvbXBvc2l0ZSgpICE9IENv bXBvc2l0ZVNvdXJjZU92ZXIpCisgICAgaWYgKCFmaWxsTGF5ZXIgfHwgZmlsbExheWVyLT5jbGlw KCkgIT0gQm9yZGVyRmlsbEJveCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgLy8gQ2xp cHBlZCB3aXRoIGxvY2FsIHNjcm9sbGluZwogICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBm aWxsTGF5ZXItPmF0dGFjaG1lbnQoKSA9PSBMb2NhbEJhY2tncm91bmRBdHRhY2htZW50KQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBDb2xvciBiZ0NvbG9yID0gc3R5bGUoKS0+dmlzaXRl ZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKLSAgICBpZiAoYmdD b2xvci5pc1ZhbGlkKCkgJiYgYmdDb2xvci5hbHBoYSgpID09IDI1NSkKKyAgICBpZiAoZmlsbExh eWVyLT5oYXNPcGFxdWVJbWFnZSh0aGlzKSAmJiBmaWxsTGF5ZXItPmhhc1JlcGVhdFhZKCkgJiYg ZmlsbExheWVyLT5pbWFnZSgpLT5jYW5SZW5kZXIodGhpcywgc3R5bGUoKS0+ZWZmZWN0aXZlWm9v bSgpKSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgCi0gICAgLy8gRklYTUU6IHJldHVybiB0 cnVlIGlmIGEgYmFja2dyb3VuZCBpbWFnZSBpcyBwcmVzZW50IGFuZCBpcyBvcGFxdWUKKworICAg IC8vIElmIHRoZXJlIGlzIG9ubHkgb25lIGxheWVyIGFuZCBubyBpbWFnZSwgY2hlY2sgd2hldGhl ciB0aGUgYmFja2dyb3VuZCBjb2xvciBpcyBvcGFxdWUKKyAgICBpZiAoIWZpbGxMYXllci0+bmV4 dCgpICYmICFmaWxsTGF5ZXItPmhhc0ltYWdlKCkpIHsKKyAgICAgICAgQ29sb3IgYmdDb2xvciA9 IHN0eWxlKCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xv cik7CisgICAgICAgIGlmIChiZ0NvbG9yLmlzVmFsaWQoKSAmJiBiZ0NvbG9yLmFscGhhKCkgPT0g MjU1KQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQogCiAgICAgcmV0dXJuIGZhbHNl OwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAkocmV2aXNpb24gMTM2 MjU3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCSh3b3JraW5nIGNv cHkpCkBAIC01ODAsNyArNTgwLDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgcGFpbnRNYXNrSW1h Z2VzKGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IExheW91dFJlY3QmKTsKIAogICAgIEJhY2tncm91 bmRCbGVlZEF2b2lkYW5jZSBkZXRlcm1pbmVCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UoR3JhcGhp Y3NDb250ZXh0KikgY29uc3Q7Ci0gICAgYm9vbCBiYWNrZ3JvdW5kSXNTaW5nbGVPcGFxdWVMYXll cigpIGNvbnN0OworICAgIGJvb2wgYmFja2dyb3VuZEhhc09wYXF1ZVRvcExheWVyKCkgY29uc3Q7 CiAKICNpZiBQTEFURk9STShNQUMpCiAgICAgdm9pZCBwYWludEN1c3RvbUhpZ2hsaWdodChjb25z dCBMYXlvdXRQb2ludCYsIGNvbnN0IEF0b21pY1N0cmluZyYgdHlwZSwgYm9vbCBiZWhpbmRUZXh0 KTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjQzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTAzICBKdXN0aW4gTm92b3Nh ZCAgPGp1bm92QGdvb2dsZS5jb20+CisKKyAgICAgICAgVXNlIHJlbmRlciBib3ggYmFja2dyb3Vu ZCBvdmVyIGJvcmRlciBkcmF3IHN0cmF0ZWd5IGluIGNhc2VzIHdpdGggYmFja2dyb3VuZC1pbWFn ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDA5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg aW1hZ2UgZmFpbHVyZSBleHBlY3RhdGlvbiBmb3IgCisgICAgICAgIGZhc3QvYmFja2dyb3VuZHMv Z3JhZGllbnQtYmFja2dyb3VuZC1sZWFrYWdlLTIuaHRtbCB3aGljaCBuZWVkcworICAgICAgICBu ZXcgYmFzZWxpbmVzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0 aW9uczoKKwogMjAxMi0xMi0wMyAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgpJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCShyZXZp c2lvbiAxMzYyNTcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0 YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMyLDYgKzIyMzIsOSBAQCBjcmJ1Zy5jb20vMTYy MjQ3ICBzdmcvdHJhbnNmb3Jtcy90ZXh0LXdpCiAKIGNyYnVnLmNvbS80Mzg5MCBbIFdpbiBdIGh0 dHAvdGVzdHMvbG9hZGluZy9iYXNpYy5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIAorIyBUZXN0IG5l ZWQgbmV3IGltYWdlIGJhc2VsaW5lcyB3aXRoIGZpeCBmb3Igd2Via2l0Lm9yZy9iLzEwMzQwOQor d2Via2l0Lm9yZy9iLzEwMzQwOSBmYXN0L2JhY2tncm91bmRzL2dyYWRpZW50LWJhY2tncm91bmQt bGVha2FnZS0yLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQorCiAjIFRoZSBmb2xsb3dp bmcgdGVzdHMgZmFpbCBvbiBhbGwgcGxhdGZvcm1zIGFuZCBuZWVkIGZ1cnRoZXIgaW52ZXN0aWdh dGlvbi4KICMgTWFueSBvZiB0aGVzZSBhcmUgc2tpcHBlZCBvbiB0aGUgTWFjIHBsYXRmb3JtCiB3 ZWJraXQub3JnL2IvNDU5OTEgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2UuYnJva2Vu Lmh0bWwgWyBGYWlsdXJlIF0K