103402 2012-11-27 05:10:38 -0800 Layout Test transitions/transition-shorthand-delay.html should usePauseAPI 2012-11-27 11:17:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen simon.fraser webkit.review.bot oldest_to_newest 776647 0 jussi.kukkonen 2012-11-27 05:10:38 -0800 The following layout test is flaky on Apple MountainLion and Lion but especially on EFL (both WK1 and WK2) transitions/transition-shorthand-delay.html I am able to trigger the failure, although not easily. Looks like a timing issue: -- FAIL - "left" property for "target" element at 0.5s expected: 125 but saw: 133.3804168701172 -- 776705 1 jussi.kukkonen 2012-11-27 06:31:28 -0800 I believe pause API works on transitions nowadays, using it should make this flakiness go away. 776712 2 176257 jussi.kukkonen 2012-11-27 06:43:14 -0800 Created attachment 176257 Patch 776717 3 176259 jussi.kukkonen 2012-11-27 06:48:38 -0800 Created attachment 176259 better Changelog 776718 4 jussi.kukkonen 2012-11-27 06:50:29 -0800 Simon, you added the PauseAPI (non)usage here originally, do you want to review this? 776808 5 176259 simon.fraser 2012-11-27 08:47:55 -0800 Comment on attachment 176259 better Changelog If this change doesn't cause assertions in debug, r=me. 776973 6 jussi.kukkonen 2012-11-27 10:50:44 -0800 (In reply to comment #5) > (From update of attachment 176259 [details]) > If this change doesn't cause assertions in debug, r=me. Debug works fine here. Oh, I'll send one more version to remove the flaky expectation from EFL TestExpectations, I assume that's not impolite after r+ -- since I could do it in an unreviewed commit anyway. 776979 7 176302 jussi.kukkonen 2012-11-27 10:53:43 -0800 Created attachment 176302 Remove flaky expectation from efl 777008 8 176302 webkit.review.bot 2012-11-27 11:17:16 -0800 Comment on attachment 176302 Remove flaky expectation from efl Clearing flags on attachment: 176302 Committed r135885: <http://trac.webkit.org/changeset/135885> 777009 9 webkit.review.bot 2012-11-27 11:17:19 -0800 All reviewed patches have been landed. Closing bug. 176257 2012-11-27 06:43:14 -0800 2012-11-27 06:48:34 -0800 Patch bug-103402-20121127164050.patch text/plain 1499 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODU3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjgxZjhmNjZmMjc3NTM2YjgxNDE1 NDNhNDc5YmRiYWQwNjk4Mzc5OC4uOTVlNWZhZjIxMWFhMTdjMWQ2ZWMwZmYwMDcwNmJlMGU0ZGQ0 NDY2NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTExLTI3ICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KIAorICAgICAgICBMYXlvdXQgVGVzdCB0cmFuc2l0 aW9ucy90cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sIHNob3VsZCB1c2VQYXVzZUFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDAyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF1c2VBUEkg d29ya3Mgd2l0aCB0cmFuc2l0aW9ucyBub3csIHVzaW5nIGl0IHNob3VsZCBmaXggdGhlIGZsYWtp bmVzcy4KKworICAgICAgICAqIHRyYW5zaXRpb25zL3RyYW5zaXRpb24tc2hvcnRoYW5kLWRlbGF5 Lmh0bWw6CisKKzIwMTItMTEtMjcgIEp1c3NpIEt1a2tvbmVuICA8anVzc2kua3Vra29uZW5AaW50 ZWwuY29tPgorCiAgICAgICAgIFtFRkxdIE1hcmsgdGVzdHMgZmxha3kKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzQwMwogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sIGIv TGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1zaG9ydGhhbmQtZGVsYXkuaHRtbApp bmRleCBjMzJhODU4YzBmNTZmMWMzMDY5YmFiZjYwY2M5MTJlMDEyNDY4ZmI0Li5kZjA5ODlkOWY2 NGZhN2RlNGU0ZWIzNTA4M2FlOGQ0NDliZWY0NmY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90 cmFuc2l0aW9ucy90cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sCisrKyBiL0xheW91dFRl c3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tc2hvcnRoYW5kLWRlbGF5Lmh0bWwKQEAgLTI4LDkg KzI4LDcgQEAKICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuY2xhc3NO YW1lID0gIm1vdmVkIjsKICAgICAgfQogCi0gICAgIC8vIFBhdXNlIEFQSSBpc24ndCBoYXBweSBw YXVzaW5nIGR1cmluZyBkZWxheSB5ZXQuCi0gICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTQ3NQotICAgICBydW5UcmFuc2l0aW9uVGVzdChleHBlY3RlZFZh bHVlcywgc2V0dXBUZXN0LCBkb250VXNlUGF1c2VBUEkpOworICAgICBydW5UcmFuc2l0aW9uVGVz dChleHBlY3RlZFZhbHVlcywgc2V0dXBUZXN0LCB1c2VQYXVzZUFQSSk7CiAgICA8L3NjcmlwdD4K IDwvaGVhZD4KIDxib2R5Pgo= 176259 2012-11-27 06:48:38 -0800 2012-11-27 10:53:38 -0800 better Changelog bug-103402-20121127164615.patch text/plain 1532 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODU3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjgxZjhmNjZmMjc3NTM2YjgxNDE1 NDNhNDc5YmRiYWQwNjk4Mzc5OC4uNWFlMThkZWVkOTAxZjY4ZDE4NDcxMmZkYjc2YzI2YWJiMGI1 YzgxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTExLTI3ICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KIAorICAgICAgICBMYXlvdXQgVGVzdCB0cmFuc2l0 aW9ucy90cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sIHNob3VsZCB1c2VQYXVzZUFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDAyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF1c2VBUEkg d29ya3Mgd2hlbiBwYXVzaW5nIGR1cmluZyBkZWxheSBpbiB0cmFuc2l0aW9ucyBub3csIHVzaW5n IGl0CisgICAgICAgIHNob3VsZCBmaXggdGhlIGZsYWtpbmVzcy4KKworICAgICAgICAqIHRyYW5z aXRpb25zL3RyYW5zaXRpb24tc2hvcnRoYW5kLWRlbGF5Lmh0bWw6CisKKzIwMTItMTEtMjcgIEp1 c3NpIEt1a2tvbmVuICA8anVzc2kua3Vra29uZW5AaW50ZWwuY29tPgorCiAgICAgICAgIFtFRkxd IE1hcmsgdGVzdHMgZmxha3kKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMzQwMwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90 cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sIGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMv dHJhbnNpdGlvbi1zaG9ydGhhbmQtZGVsYXkuaHRtbAppbmRleCBjMzJhODU4YzBmNTZmMWMzMDY5 YmFiZjYwY2M5MTJlMDEyNDY4ZmI0Li5kZjA5ODlkOWY2NGZhN2RlNGU0ZWIzNTA4M2FlOGQ0NDli ZWY0NmY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9uLXNo b3J0aGFuZC1kZWxheS5odG1sCisrKyBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRp b24tc2hvcnRoYW5kLWRlbGF5Lmh0bWwKQEAgLTI4LDkgKzI4LDcgQEAKICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuY2xhc3NOYW1lID0gIm1vdmVkIjsKICAgICAgfQog Ci0gICAgIC8vIFBhdXNlIEFQSSBpc24ndCBoYXBweSBwYXVzaW5nIGR1cmluZyBkZWxheSB5ZXQu Ci0gICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ3NQot ICAgICBydW5UcmFuc2l0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgc2V0dXBUZXN0LCBkb250VXNl UGF1c2VBUEkpOworICAgICBydW5UcmFuc2l0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgc2V0dXBU ZXN0LCB1c2VQYXVzZUFQSSk7CiAgICA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5Pgo= 176302 2012-11-27 10:53:43 -0800 2012-11-27 11:17:16 -0800 Remove flaky expectation from efl bug-103402-20121127205119.patch text/plain 2320 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGI1M2FlZDAxMWJhNzk0M2Q3YTRl OWNiZDJkYjAyYWI5NjFkOGUwYi4uMGE4ZWMzM2VhZWQ0YTAxNTRjNGRlOWNkMTAyZmJkMDM0MTVj ZTYxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI3ICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBMYXlvdXQgVGVzdCB0cmFuc2l0 aW9ucy90cmFuc2l0aW9uLXNob3J0aGFuZC1kZWxheS5odG1sIHNob3VsZCB1c2VQYXVzZUFQSQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDAyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIFBhdXNlQVBJIHdv cmtzIHdoZW4gcGF1c2luZyBkdXJpbmcgZGVsYXkgaW4gdHJhbnNpdGlvbnMgbm93LCB1c2luZyBp dAorICAgICAgICBzaG91bGQgZml4IHRoZSBmbGFraW5lc3MuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiB0cmFuc2l0aW9ucy90cmFuc2l0aW9u LXNob3J0aGFuZC1kZWxheS5odG1sOgorCiAyMDEyLTExLTI3ICBZYWVsIEFoYXJvbiAgPHlhZWwu YWhhcm9uQGludGVsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGdhcmRlbmluZy4gUmVtb3Zl IGZyb20gVGVzdEV4cGVjdGF0aW9ucyB0ZXN0cyB0aGF0IGFyZSBwYXNzaW5nLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkODk3YWE3MDVkODg5YWQ3OGYz MGJkMDE0ZTg2MjE1ZTczODUyZDgzLi5jMWIwYjA1Y2FlNTZlM2EyNTBhNzYxOTZiMWQ5ZDE4NGFh OThkYjNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAt NzIzLDggKzcyMyw2IEBAIHdlYmtpdC5vcmcvYi80OTE4MiBhbmltYXRpb25zL3N0b3AtYW5pbWF0 aW9uLW9uLXN1c3BlbmQuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xMDMz ODMgZmFzdC9jc3MvY291bnRlcnMvZWxlbWVudC1yZW1vdmFsLWNyYXNoLnhodG1sIFsgRmFpbHVy ZSBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzEwMzQwMiB0cmFuc2l0aW9ucy90cmFuc2l0aW9uLXNo b3J0aGFuZC1kZWxheS5odG1sIFsgRmFpbHVyZSBQYXNzIF0KLQogIy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8KICMgRkFJTElORyBURVNUUwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24t c2hvcnRoYW5kLWRlbGF5Lmh0bWwgYi9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9u LXNob3J0aGFuZC1kZWxheS5odG1sCmluZGV4IGMzMmE4NThjMGY1NmYxYzMwNjliYWJmNjBjYzkx MmUwMTI0NjhmYjQuLmRmMDk4OWQ5ZjY0ZmE3ZGU0ZTRlYjM1MDgzYWU4ZDQ0OWJlZjQ2ZjYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tc2hvcnRoYW5kLWRl bGF5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1zaG9ydGhh bmQtZGVsYXkuaHRtbApAQCAtMjgsOSArMjgsNyBAQAogICAgICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0YXJnZXQiKS5jbGFzc05hbWUgPSAibW92ZWQiOwogICAgICB9CiAKLSAgICAgLy8g UGF1c2UgQVBJIGlzbid0IGhhcHB5IHBhdXNpbmcgZHVyaW5nIGRlbGF5IHlldC4KLSAgICAgLy8g aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NDc1Ci0gICAgIHJ1blRy YW5zaXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzLCBzZXR1cFRlc3QsIGRvbnRVc2VQYXVzZUFQSSk7 CisgICAgIHJ1blRyYW5zaXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzLCBzZXR1cFRlc3QsIHVzZVBh dXNlQVBJKTsKICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+Cg==