103401 2012-11-27 05:01:04 -0800 Inline ImageFrame width() and height() 2012-11-28 00:07:45 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88424 1 noel.gordon noel.gordon bfulgham webkit.review.bot zan oldest_to_newest 776637 0 noel.gordon 2012-11-27 05:01:04 -0800 Per https://bugs.webkit.org/show_bug.cgi?id=88424#c38, we should inline ImageFrame width() and height(). 776650 1 176241 noel.gordon 2012-11-27 05:20:39 -0800 Created attachment 176241 Patch 777502 2 176241 bfulgham 2012-11-27 21:21:53 -0800 Comment on attachment 176241 Patch Looks great. r=me. 777503 3 176241 webkit.review.bot 2012-11-27 21:25:03 -0800 Comment on attachment 176241 Patch Clearing flags on attachment: 176241 Committed r135971: <http://trac.webkit.org/changeset/135971> 777504 4 webkit.review.bot 2012-11-27 21:25:05 -0800 All reviewed patches have been landed. Closing bug. 777576 5 176241 cdumez 2012-11-27 23:42:20 -0800 Comment on attachment 176241 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review > Source/WebCore/platform/image-decoders/ImageDecoder.h:199 > + return m_size.width(); Oh oh. Should be height, not width. This is causing a lot of failures. 777578 6 176241 bfulgham 2012-11-27 23:44:04 -0800 Comment on attachment 176241 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review >> Source/WebCore/platform/image-decoders/ImageDecoder.h:199 >> + return m_size.width(); > > Oh oh. Should be height, not width. This is causing a lot of failures. Doh! How did I miss this. :-( Mea culpa. 777588 7 zan 2012-11-28 00:07:45 -0800 (In reply to comment #5) > (From update of attachment 176241 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review > > > Source/WebCore/platform/image-decoders/ImageDecoder.h:199 > > + return m_size.width(); > > Oh oh. Should be height, not width. This is causing a lot of failures. Just to address this, it has been fixed in r135980. http://trac.webkit.org/changeset/135980 176241 2012-11-27 05:20:39 -0800 2012-11-27 23:44:04 -0800 Patch bug-103401-20121128001815.patch text/plain 3633 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JlOTg2YjBkYjUxMDdi NWM4OThlMmEzY2M0YjFmZmNkODZkNjE5ZC4uMGI0ZTQxZTg4Njc2ZTcwMzExYTJkMjFkODRhNjg1 YzE4NTM4ZWE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTI3ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBJbmxpbmUgSW1hZ2VG cmFtZSB3aWR0aCgpIGFuZCBoZWlnaHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSW5saW5lIEltYWdlRnJhbWUgd2lkdGgoKSBhbmQgaGVpZ2h0KCkg dG8gaW1wcm92ZSB0aGUgcGVyZm9ybWFuY2Ugb2YgSW1hZ2VGcmFtZQorICAgICAgICBmdW5jdGlv biBnZXRBZGRyKHgseSkgcGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODQyNCNjMzgKKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgbWFueSBleGlz dGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVj b2Rlci5jcHA6IFJlbW92ZSB3aWR0aCgpIGFuZCBoZWlnaHQoKSByb3V0aW5lcworICAgICAgICBz aW5jZSB0aGV5IG5vdyBpbmxpbmVkIGluIHRoZSBJbWFnZUZyYW1lIGNsYXNzIGRlZmluaXRpb24g aW4gSW1hZ2VEZWNvZGVyLmguCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1h Z2VEZWNvZGVyLmg6IEFkZCBpbmxpbmUgZGVmaW5pdGlvbnMgb2Ygd2lkdGgoKSBhbmQKKyAgICAg ICAgaGVpZ2h0KCkgZm9yIGFsbCBwb3J0cy4KKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VG cmFtZTo6d2lkdGgpOiBSZW1vdmUuCisgICAgICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lOjpoZWln aHQpOiBSZW1vdmUuCisKIDIwMTItMTEtMjYgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFu LmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBJbXBsZW1lbnQgdGhlIG1pbWV0eXBl IGljb24gbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggNGY2NTI3NTdmMzc0ODMyMDUyZTViMmM3 ZDhkNjdhZjIzZWM5YmMxOS4uZDcwODZiMDhhYTE3YTQyMjlmOWViZDU5NGI3YmQxYzk0YTlmODc3 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1h Z2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9JbWFnZURlY29kZXIuY3BwCkBAIC0yMjYsMTYgKzIyNiw2IEBAIHZvaWQgSW1hZ2VGcmFtZTo6 c2V0U3RhdHVzKEZyYW1lU3RhdHVzIHN0YXR1cykKICAgICBtX3N0YXR1cyA9IHN0YXR1czsKIH0K IAotaW50IEltYWdlRnJhbWU6OndpZHRoKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9zaXplLndp ZHRoKCk7Ci19Ci0KLWludCBJbWFnZUZyYW1lOjpoZWlnaHQoKSBjb25zdAotewotICAgIHJldHVy biBtX3NpemUuaGVpZ2h0KCk7Ci19Ci0KIHZvaWQgSW1hZ2VGcmFtZTo6cmVwb3J0TWVtb3J5VXNh Z2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uc3QKIHsKICAgICBNZW1v cnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBQbGF0Zm9ybU1lbW9yeVR5 cGVzOjpJbWFnZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9JbWFnZURlY29kZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL0ltYWdlRGVjb2Rlci5oCmluZGV4IGU0MmJiNzNkY2FlOTBhMzU4MWIyNTM2MGMyYTZj NTEyZWExNjZhNjcuLjEyYTFhNDg0YjBlZTJmMjVlZTU2NzYzNThjMmQ5ZjA5MzRiYWNhYTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVj b2Rlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdl RGVjb2Rlci5oCkBAIC0xODIsOCArMTgyLDIzIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgfQogCiAgICAgcHJpdmF0ZToKLSAgICAgICAgaW50IHdpZHRoKCkgY29uc3Q7Ci0gICAgICAg IGludCBoZWlnaHQoKSBjb25zdDsKKyAgICAgICAgaW50IHdpZHRoKCkgY29uc3QKKyAgICAgICAg eworI2lmIFVTRShTS0lBKQorICAgICAgICAgICAgcmV0dXJuIG1fYml0bWFwLmJpdG1hcCgpLndp ZHRoKCk7CisjZWxzZQorICAgICAgICAgICAgcmV0dXJuIG1fc2l6ZS53aWR0aCgpOworI2VuZGlm CisgICAgICAgIH0KKworICAgICAgICBpbnQgaGVpZ2h0KCkgY29uc3QKKyAgICAgICAgeworI2lm IFVTRShTS0lBKQorICAgICAgICAgICAgcmV0dXJuIG1fYml0bWFwLmJpdG1hcCgpLmhlaWdodCgp OworI2Vsc2UKKyAgICAgICAgICAgIHJldHVybiBtX3NpemUud2lkdGgoKTsKKyNlbmRpZgorICAg ICAgICB9CiAKICNpZiBVU0UoU0tJQSkKICAgICAgICAgTmF0aXZlSW1hZ2VTa2lhIG1fYml0bWFw OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tp YS9JbWFnZURlY29kZXJTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL3NraWEvSW1hZ2VEZWNvZGVyU2tpYS5jcHAKaW5kZXggYzdmMTU3OGVhZGFiMzllZGQ5 YjE4YzNkYzE3ZjA3MDI2NjY5NjEzMy4uYjIzODIxNmJmMjc1OWYyZTFhNWI4NTcxZGM2YmFiOTY2 ZDEwZjVmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2Rl cnMvc2tpYS9JbWFnZURlY29kZXJTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwCkBAIC0xMzgsMTYgKzEz OCw2IEBAIHZvaWQgSW1hZ2VGcmFtZTo6c2V0U3RhdHVzKEZyYW1lU3RhdHVzIHN0YXR1cykKICAg ICB9CiB9CiAKLWludCBJbWFnZUZyYW1lOjp3aWR0aCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1f Yml0bWFwLmJpdG1hcCgpLndpZHRoKCk7Ci19Ci0KLWludCBJbWFnZUZyYW1lOjpoZWlnaHQoKSBj b25zdAotewotICAgIHJldHVybiBtX2JpdG1hcC5iaXRtYXAoKS5oZWlnaHQoKTsKLX0KLQogdm9p ZCBJbWFnZUZyYW1lOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlP YmplY3RJbmZvKSBjb25zdAogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVj dEluZm8sIHRoaXMsIFBsYXRmb3JtTWVtb3J5VHlwZXM6OkltYWdlKTsK