103397 2012-11-27 04:38:08 -0800 [V8] Remove toWebCoreAtomicString() from bindings/v8/* 2013-05-02 11:49:51 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 103331 1 haraken haraken abarth andersca japhet webkit.review.bot oldest_to_newest 776616 0 haraken 2012-11-27 04:38:08 -0800 This is an incremental effort for fixing bug 103331. 776633 1 176238 haraken 2012-11-27 04:59:47 -0800 Created attachment 176238 Patch 776859 2 176238 abarth 2012-11-27 09:28:48 -0800 Comment on attachment 176238 Patch In these cases, it looks like the types are roughly v8::Handle<v8::String>, which means the try/catch block isn't needed. Perhaps we should have a more optimized code path when we know that IsString() is true? 777287 3 176238 haraken 2012-11-27 15:55:52 -0800 Comment on attachment 176238 Patch For now let me pause this work because it would require a bunch of efforts to complete it ( https://bugs.webkit.org/show_bug.cgi?id=103404#c4) 883867 4 andersca 2013-05-02 11:49:51 -0700 V8 is gone from WebKit. 176238 2012-11-27 04:59:47 -0800 2012-11-27 15:55:52 -0800 Patch bug-103397-20121127215724.patch text/plain 13799 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA0OTlkM2E3YzhkMjdm MGJjM2ZkOWJhYjIwYzRiNzVkZDdjY2Q4OC4uNmYwNDUwMTM1M2UxNWQ0YTM4OWEzNTdiMWQ2Y2I0 Y2ZkMmQ5ZGRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQ3IEBACiAyMDEyLTExLTI3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSB0 b1dlYkNvcmVBdG9taWNTdHJpbmcoKSBmcm9tIGJpbmRpbmdzL3Y4LyoKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzM5NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYW4gaW5jcmVtZW50YWwg ZWZmb3J0IGZvciBmaXhpbmcgYnVnIDEwMzMzMS4KKyAgICAgICAgVGhpcyBwYXRjaCBzbGlnaHRs eSBjaGFuZ2VzIHRoZSBjdXJyZW50IGJlaGF2aW9yIGZvciBlZGdlIGNhc2VzLgorCisgICAgICAg IGJlZm9yZToKKyAgICAgICAgICBmdW5jKHRvV2ViQ29yZUF0b21pY1N0cmluZyh2OFN0cmluZykp OworCisgICAgICAgIGFmdGVyOgorICAgICAgICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVT T1VSQ0UoVjhTdHJpbmdSZXNvdWNlPD4sIHN0cmluZywgdjhTdHJpbmcpOworICAgICAgICAgIGZ1 bmMoc3RyaW5nKTsKKworICAgICAgICBCZWZvcmUgdGhpcyBwYXRjaCwgZnVuYygpIGdldHMgY2Fs bGVkIGV2ZW4gaWYgdGhlIHN0cmluZyBjb252ZXJzaW9uIHRocm93cyBhbiBlcnJvci4KKyAgICAg ICAgQWZ0ZXIgdGhpcyBwYXRjaCwgZnVuYygpIGRvZXMgbm90IGdldCBjYWxsZWQgaWYgdGhlIHN0 cmluZyBjb252ZXJzaW9uIHRocm93cyBhbiBlcnJvci4KKyAgICAgICAgVGhlIG5ldyBiZWhhdmlv ciBpcyBhbiBleHBlY3RlZCBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4Q29s bGVjdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6Z2V0TmFtZWRQcm9wZXJ0eU9mQ29sbGVjdGlv bik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpnZXR0ZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdp bmRvd0N1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvdzo6bmFtZWRQcm9w ZXJ0eUdldHRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEFsbENvbGxl Y3Rpb25DdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhIVE1MQWxsQ29sbGVjdGlvbjo6 bmFtZWRQcm9wZXJ0eUdldHRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRN TENvbGxlY3Rpb25DdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhIVE1MQ29sbGVjdGlv bjo6bmFtZWRQcm9wZXJ0eUdldHRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4 SFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb25DdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 VjhIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbjo6bmFtZWRQcm9wZXJ0eUdldHRlcik6CisgICAg ICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlY4SFRNTEZvcm1FbGVtZW50OjpuYW1lZFByb3BlcnR5R2V0dGVyKToK KyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRnJhbWVTZXRFbGVtZW50Q3VzdG9t LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4SFRNTEZyYW1lU2V0RWxlbWVudDo6bmFtZWRQcm9w ZXJ0eUdldHRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTE9wdGlvbnND b2xsZWN0aW9uQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4SFRNTE9wdGlvbnNDb2xs ZWN0aW9uOjpuYW1lZFByb3BlcnR5R2V0dGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0 b20vVjhOb2RlTGlzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOE5vZGVMaXN0Ojpu YW1lZFByb3BlcnR5R2V0dGVyKToKKworMjAxMi0xMS0yNyAgS2VudGFybyBIYXJhICA8aGFyYWtl bkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4gUmVuYW1lZCBUUllDQVRDSCA9 PiBWOFRSWUNBVENILgogICAgICAgICAoSSBmb3Jnb3QgdG8gYXBwbHkgcmV2aWV3ZXIncyBjb21t ZW50IGluIGJ1ZyAxMDMzNTIgd2hlbiBsYW5kaW5nIHIxMzU4MTcuKQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rpb24uaCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oCmluZGV4IGY3MzlmNTBiYzYyYWZhYjg2NmQ3YmYy ZmY1MWUxM2M0ZmUzZDIwODIuLjc1ZWYxMGYzYzI0YmM5NDA1YzY4Mzg0Y2FiOTFhNzgwN2RiOGZm NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oCkBAIC02NSw3 ICs2NSw3IEBAIHRlbXBsYXRlPGNsYXNzIENvbGxlY3Rpb24sIGNsYXNzIEl0ZW1UeXBlPiBzdGF0 aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGdldE5hbWVkCiAgICAgQVNTRVJUKFY4RE9NV3JhcHBl cjo6bWF5YmVET01XcmFwcGVyKG9iamVjdCkpOwogICAgIEFTU0VSVChWOERPTVdyYXBwZXI6OmRv bVdyYXBwZXJUeXBlKG9iamVjdCkgIT0gJlY4Tm9kZTo6aW5mbyk7CiAgICAgQ29sbGVjdGlvbiog Y29sbGVjdGlvbiA9IHRvTmF0aXZlQ29sbGVjdGlvbjxDb2xsZWN0aW9uPihvYmplY3QpOwotICAg IEF0b21pY1N0cmluZyBwcm9wZXJ0eU5hbWUgPSB0b1dlYkNvcmVBdG9taWNTdHJpbmdXaXRoTnVs bENoZWNrKG5hbWUpOworICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJp bmdSZXNvdXJjZTxXaXRoTnVsbENoZWNrPiwgcHJvcGVydHlOYW1lLCBuYW1lKTsKICAgICByZXR1 cm4gZ2V0VjhPYmplY3Q8SXRlbVR5cGU+KGNvbGxlY3Rpb24tPm5hbWVkSXRlbShwcm9wZXJ0eU5h bWUpLCBjcmVhdGlvbkNvbnRleHQsIGlzb2xhdGUpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCmluZGV4IDQyNjg3NDAyNzkwODA3OTkw ZmE0M2RkNTNjM2RlOTA2MDBmNjU3YmMuLmE3NGYwMTA0MDZkZDY0OWMwYTE3MjJjODJlMmY5YTEz MjBjMDliZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2lu ZG93U2hlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93 U2hlbGwuY3BwCkBAIC00MjgsNyArNDI4LDcgQEAgdm9pZCBWOERPTVdpbmRvd1NoZWxsOjp1cGRh dGVEb2N1bWVudCgpCiBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGdldHRlcih2ODo6TG9j YWw8djg6OlN0cmluZz4gcHJvcGVydHksIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8pCiB7 CiAgICAgLy8gRklYTUU6IENvbnNpZGVyIHBhc3NpbmcgQXRvbWljU3RyaW5nSW1wbCBkaXJlY3Rs eS4KLSAgICBBdG9taWNTdHJpbmcgbmFtZSA9IHRvV2ViQ29yZUF0b21pY1N0cmluZyhwcm9wZXJ0 eSk7CisgICAgVjhUUllDQVRDSF9GT1JfVjhTVFJJTkdSRVNPVVJDRShWOFN0cmluZ1Jlc291cmNl PD4sIG5hbWUsIHByb3BlcnR5KTsKICAgICBIVE1MRG9jdW1lbnQqIGh0bWxEb2N1bWVudCA9IFY4 SFRNTERvY3VtZW50Ojp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsKICAgICBBU1NFUlQoaHRtbERv Y3VtZW50KTsKICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcmVzdWx0ID0gVjhIVE1MRG9jdW1l bnQ6OmdldE5hbWVkUHJvcGVydHkoaHRtbERvY3VtZW50LCBuYW1lLCBpbmZvLkhvbGRlcigpLCBp bmZvLkdldElzb2xhdGUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFN0cmluZ1Jlc291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0cmlu Z1Jlc291cmNlLmgKaW5kZXggNmI2YmU4Nzc2NTljYTI3MDE4Y2JhYjBhNjczYjYwN2M4ZmM4MWUz OS4uNTM5M2M1YTc4NTZjZjljYThlODQwYzc3ZmUxZjcyNGFjMWMzMWMyZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4U3RyaW5nUmVzb3VyY2UuaApAQCAtMTY1LDYgKzE2NSw3 IEBAIHB1YmxpYzoKICAgICBib29sIHByZXBhcmUoKTsKICAgICBvcGVyYXRvciBTdHJpbmcoKSB7 IHJldHVybiB0b1N0cmluZzxTdHJpbmc+KCk7IH0KICAgICBvcGVyYXRvciBBdG9taWNTdHJpbmco KSB7IHJldHVybiB0b1N0cmluZzxBdG9taWNTdHJpbmc+KCk7IH0KKyAgICBBdG9taWNTdHJpbmcg YXRvbWljU3RyaW5nKCkgeyByZXR1cm4gdG9TdHJpbmc8QXRvbWljU3RyaW5nPigpOyB9CiAKIHBy aXZhdGU6CiAgICAgYm9vbCBwcmVwYXJlQmFzZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAppbmRleCA4NGM2Njg1 MzJiZjg4ZjI1Yzg4NTIzYzU3Njk3MjAwOGYyZTY3Y2VjLi45MmE1NGJkY2VmMTk5NzZlNWJhYTQ2 Y2I4YTIxZDIxYTAyYTg2YTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKQEAgLTQ5Myw4ICs0OTMsOCBAQCB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XaW5kb3c6Om5hbWVkUHJvcGVydHlHZXR0ZXIodjg6 OkxvY2FsPHY4OjpTdHJpbmc+IG5hbQogICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKIAog ICAgIC8vIFNlYXJjaCBzdWItZnJhbWVzLgotICAgIEF0b21pY1N0cmluZyBwcm9wTmFtZSA9IHRv V2ViQ29yZUF0b21pY1N0cmluZyhuYW1lKTsKLSAgICBGcmFtZSogY2hpbGQgPSBmcmFtZS0+dHJl ZSgpLT5zY29wZWRDaGlsZChwcm9wTmFtZSk7CisgICAgVjhUUllDQVRDSF9GT1JfVjhTVFJJTkdS RVNPVVJDRShWOFN0cmluZ1Jlc291cmNlPD4sIHByb3BlcnR5TmFtZSwgbmFtZSk7CisgICAgRnJh bWUqIGNoaWxkID0gZnJhbWUtPnRyZWUoKS0+c2NvcGVkQ2hpbGQocHJvcGVydHlOYW1lKTsKICAg ICBpZiAoY2hpbGQpCiAgICAgICAgIHJldHVybiB0b1Y4KGNoaWxkLT5kb2N1bWVudCgpLT5kb21X aW5kb3coKSwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29sYXRlKCkpOwogCkBAIC01MDYsOCAr NTA2LDkgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RE9NV2luZG93OjpuYW1lZFByb3BlcnR5 R2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW0KICAgICBEb2N1bWVudCogZG9jID0gZnJh bWUtPmRvY3VtZW50KCk7CiAKICAgICBpZiAoZG9jICYmIGRvYy0+aXNIVE1MRG9jdW1lbnQoKSkg ewotICAgICAgICBpZiAoc3RhdGljX2Nhc3Q8SFRNTERvY3VtZW50Kj4oZG9jKS0+aGFzTmFtZWRJ dGVtKHByb3BOYW1lLmltcGwoKSkgfHwgZG9jLT5oYXNFbGVtZW50V2l0aElkKHByb3BOYW1lLmlt cGwoKSkpIHsKLSAgICAgICAgICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gaXRlbXMgPSBkb2Mt PndpbmRvd05hbWVkSXRlbXMocHJvcE5hbWUpOworICAgICAgICBBdG9taWNTdHJpbmdJbXBsKiBh dG9taWNTdHJpbmdJbXBsID0gcHJvcGVydHlOYW1lLmF0b21pY1N0cmluZygpLmltcGwoKTsKKyAg ICAgICAgaWYgKHN0YXRpY19jYXN0PEhUTUxEb2N1bWVudCo+KGRvYyktPmhhc05hbWVkSXRlbShh dG9taWNTdHJpbmdJbXBsKSB8fCBkb2MtPmhhc0VsZW1lbnRXaXRoSWQoYXRvbWljU3RyaW5nSW1w bCkpIHsKKyAgICAgICAgICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gaXRlbXMgPSBkb2MtPndp bmRvd05hbWVkSXRlbXMocHJvcGVydHlOYW1lLmF0b21pY1N0cmluZygpKTsKICAgICAgICAgICAg IGlmICghaXRlbXMtPmlzRW1wdHkoKSkgewogICAgICAgICAgICAgICAgIGlmIChpdGVtcy0+aGFz RXhhY3RseU9uZUl0ZW0oKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRvVjgoaXRlbXMt Pml0ZW0oMCksIGluZm8uSG9sZGVyKCksIGluZm8uR2V0SXNvbGF0ZSgpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxBbGxDb2xsZWN0aW9uQ3Vz dG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxBbGxDb2xs ZWN0aW9uQ3VzdG9tLmNwcAppbmRleCBlZTYwNzcyNmY1YzBhY2M1NDczNzE4ZmQxZDhkNjE2NTM4 NjI0NTVhLi43ZWU5NTQ3ZjgzYWRjNzE5MDlmMWY3NTdmNzMwNDRmYTQxOTM1NzkxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MQWxsQ29sbGVjdGlv bkN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRN TEFsbENvbGxlY3Rpb25DdXN0b20uY3BwCkBAIC04Miw3ICs4Miw4IEBAIHY4OjpIYW5kbGU8djg6 OlZhbHVlPiBWOEhUTUxBbGxDb2xsZWN0aW9uOjpuYW1lZFByb3BlcnR5R2V0dGVyKHY4OjpMb2Nh bDx2ODo6U3RyCiAgICAgICAgIHJldHVybiB2OFVuZGVmaW5lZCgpOwogCiAgICAgSFRNTEFsbENv bGxlY3Rpb24qIGltcCA9IFY4SFRNTEFsbENvbGxlY3Rpb246OnRvTmF0aXZlKGluZm8uSG9sZGVy KCkpOwotICAgIHJldHVybiBnZXROYW1lZEl0ZW1zKGltcCwgdG9XZWJDb3JlQXRvbWljU3RyaW5n KG5hbWUpLCBpbmZvLkhvbGRlcigpLCBpbmZvLkdldElzb2xhdGUoKSk7CisgICAgVjhUUllDQVRD SF9GT1JfVjhTVFJJTkdSRVNPVVJDRShWOFN0cmluZ1Jlc291cmNlPD4sIHByb3BlcnR5TmFtZSwg bmFtZSk7CisgICAgcmV0dXJuIGdldE5hbWVkSXRlbXMoaW1wLCBwcm9wZXJ0eU5hbWUsIGluZm8u SG9sZGVyKCksIGluZm8uR2V0SXNvbGF0ZSgpKTsKIH0KIAogdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IFY4SFRNTEFsbENvbGxlY3Rpb246Oml0ZW1DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBh cmdzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRN TENvbGxlY3Rpb25DdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4SFRNTENvbGxlY3Rpb25DdXN0b20uY3BwCmluZGV4IGJhZTI3OGFjNjhmNzJhODU2YTMxZDM1 NWI3OTYzZGQzYzkxMzE5Y2YuLmVjNTYyNTAxNWQ1N2U1YmFhNjVhNTdhZmUxYzc3ZDUxMGRkMTNj YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxD b2xsZWN0aW9uQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAKQEAgLTUxLDcgKzUxLDggQEAgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IFY4SFRNTENvbGxlY3Rpb246Om5hbWVkUHJvcGVydHlHZXR0ZXIodjg6Okxv Y2FsPHY4OjpTdHJpbmcKICAgICAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7CiAKICAgICBIVE1M Q29sbGVjdGlvbiogaW1wID0gVjhIVE1MQ29sbGVjdGlvbjo6dG9OYXRpdmUoaW5mby5Ib2xkZXIo KSk7Ci0gICAgTm9kZSogaXRlbSA9IGltcC0+bmFtZWRJdGVtKHRvV2ViQ29yZUF0b21pY1N0cmlu ZyhuYW1lKSk7CisgICAgVjhUUllDQVRDSF9GT1JfVjhTVFJJTkdSRVNPVVJDRShWOFN0cmluZ1Jl c291cmNlPD4sIHByb3BlcnR5TmFtZSwgbmFtZSk7CisgICAgTm9kZSogaXRlbSA9IGltcC0+bmFt ZWRJdGVtKHByb3BlcnR5TmFtZSk7CiAgICAgaWYgKCFpdGVtKQogICAgICAgICByZXR1cm4gdjhV bmRlZmluZWQoKTsKICAgICByZXR1cm4gdG9WOChpdGVtLCBpbmZvLkhvbGRlcigpLCBpbmZvLkdl dElzb2xhdGUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbkN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbkN1c3RvbS5j cHAKaW5kZXggNDBmMmZmOWQ4ZGMwNGRmMTllMWNlMGYxNWQ5ZTQ4Njc1YmJkODRmNC4uMGZkZGU4 ODdiYzU0NDk2MzdmMzY2NTk4MzY0ZGVlY2VkMjU0NTg2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb25DdXN0 b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxGb3Jt Q29udHJvbHNDb2xsZWN0aW9uQ3VzdG9tLmNwcApAQCAtNjMsNyArNjMsOCBAQCB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gVjhIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbjo6bmFtZWRQcm9wZXJ0eUdl dHRlcih2ODo6TG9jYQogICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKIAogICAgIEhUTUxG b3JtQ29udHJvbHNDb2xsZWN0aW9uKiBpbXAgPSBWOEhUTUxGb3JtQ29udHJvbHNDb2xsZWN0aW9u Ojp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsKLSAgICByZXR1cm4gZ2V0TmFtZWRJdGVtcyhpbXAs IHRvV2ViQ29yZUF0b21pY1N0cmluZyhuYW1lKSwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29s YXRlKCkpOworICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJpbmdSZXNv dXJjZTw+LCBwcm9wZXJ0eU5hbWUsIG5hbWUpOworICAgIHJldHVybiBnZXROYW1lZEl0ZW1zKGlt cCwgcHJvcGVydHlOYW1lLCBpbmZvLkhvbGRlcigpLCBpbmZvLkdldElzb2xhdGUoKSk7CiB9CiAK IHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxGb3JtQ29udHJvbHNDb2xsZWN0aW9uOjpuYW1l ZEl0ZW1DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxGb3JtRWxlbWVudEN1 c3RvbS5jcHAKaW5kZXggYWM5YjlhZmUyOGQwYTBmZmQxZTgyMGNkZDg5NWZiNGU3MzYxZjYyNy4u MzNlZGVhNmY1MDZiZGJhZDRkODk2Yzg2N2IwZDQyNmIwMzk0MWFhMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRm9ybUVsZW1l bnRDdXN0b20uY3BwCkBAIC01NSwxNCArNTUsMTQgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4 SFRNTEZvcm1FbGVtZW50OjpuYW1lZFByb3BlcnR5R2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW4K IHsKICAgICBJTkNfU1RBVFMoIkRPTS5IVE1MRm9ybUVsZW1lbnQuTmFtZWRQcm9wZXJ0eUdldHRl ciIpOwogICAgIEhUTUxGb3JtRWxlbWVudCogaW1wID0gVjhIVE1MRm9ybUVsZW1lbnQ6OnRvTmF0 aXZlKGluZm8uSG9sZGVyKCkpOwotICAgIEF0b21pY1N0cmluZyB2ID0gdG9XZWJDb3JlQXRvbWlj U3RyaW5nKG5hbWUpOworICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJp bmdSZXNvdXJjZTw+LCBwcm9wZXJ0eU5hbWUsIG5hbWUpOwogCiAgICAgLy8gQ2FsbCBnZXROYW1l ZEVsZW1lbnRzIHR3aWNlLCBmaXJzdCB0aW1lIGNoZWNrIGlmIGl0IGhhcyBhIHZhbHVlCiAgICAg Ly8gYW5kIGxldCBIVE1MRm9ybUVsZW1lbnQgdXBkYXRlIGl0cyBjYWNoZS4KICAgICAvLyBTZWUg aXNzdWU6IDg2NzQwNAogICAgIHsKICAgICAgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiA+IGVsZW1l bnRzOwotICAgICAgICBpbXAtPmdldE5hbWVkRWxlbWVudHModiwgZWxlbWVudHMpOworICAgICAg ICBpbXAtPmdldE5hbWVkRWxlbWVudHMocHJvcGVydHlOYW1lLCBlbGVtZW50cyk7CiAgICAgICAg IGlmIChlbGVtZW50cy5pc0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQo KTsKICAgICB9CkBAIC03MCw3ICs3MCw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxG b3JtRWxlbWVudDo6bmFtZWRQcm9wZXJ0eUdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluCiAgICAg Ly8gU2Vjb25kIGNhbGwgbWF5IHJldHVybiBkaWZmZXJlbnQgcmVzdWx0cyBmcm9tIHRoZSBmaXJz dCBjYWxsLAogICAgIC8vIGJ1dCBpZiB0aGUgZmlyc3QgdGhlIHNpemUgY2Fubm90IGJlIHplcm8u CiAgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiA+IGVsZW1lbnRzOwotICAgIGltcC0+Z2V0TmFtZWRF bGVtZW50cyh2LCBlbGVtZW50cyk7CisgICAgaW1wLT5nZXROYW1lZEVsZW1lbnRzKHByb3BlcnR5 TmFtZSwgZWxlbWVudHMpOwogICAgIEFTU0VSVCghZWxlbWVudHMuaXNFbXB0eSgpKTsKIAogICAg IGlmIChlbGVtZW50cy5zaXplKCkgPT0gMSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxGcmFtZVNldEVsZW1lbnRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZyYW1lU2V0RWxlbWVudEN1c3RvbS5j cHAKaW5kZXggZjhiZjM1NThmMzMxOTE3YjJlNTJlYzNlY2JmNzlkNzc2N2MzMzdhMy4uY2IyNGVl ZDdkYTk4NDFiMWVmMmU3NzBhMjFmZTUxZGE4YzQ2ZjlmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZyYW1lU2V0RWxlbWVudEN1c3RvbS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTEZyYW1lU2V0RWxl bWVudEN1c3RvbS5jcHAKQEAgLTQ4LDcgKzQ4LDggQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4 SFRNTEZyYW1lU2V0RWxlbWVudDo6bmFtZWRQcm9wZXJ0eUdldHRlcih2ODo6TG9jYWw8djg6OlMK IHsKICAgICBJTkNfU1RBVFMoIkRPTS5IVE1MRnJhbWVTZXRFbGVtZW50Lk5hbWVkUHJvcGVydHlH ZXR0ZXIiKTsKICAgICBIVE1MRnJhbWVTZXRFbGVtZW50KiBpbXAgPSBWOEhUTUxGcmFtZVNldEVs ZW1lbnQ6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpOwotICAgIE5vZGUqIGZyYW1lTm9kZSA9IGlt cC0+Y2hpbGRyZW4oKS0+bmFtZWRJdGVtKHRvV2ViQ29yZUF0b21pY1N0cmluZyhuYW1lKSk7Cisg ICAgVjhUUllDQVRDSF9GT1JfVjhTVFJJTkdSRVNPVVJDRShWOFN0cmluZ1Jlc291cmNlPD4sIHBy b3BlcnR5TmFtZSwgbmFtZSk7CisgICAgTm9kZSogZnJhbWVOb2RlID0gaW1wLT5jaGlsZHJlbigp LT5uYW1lZEl0ZW0ocHJvcGVydHlOYW1lKTsKICAgICBpZiAoIWZyYW1lTm9kZSkKICAgICAgICAg cmV0dXJuIHY4VW5kZWZpbmVkKCk7CiAgICAgaWYgKCFmcmFtZU5vZGUtPmhhc1RhZ05hbWUoSFRN TE5hbWVzOjpmcmFtZVRhZykpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhIVE1MT3B0aW9uc0NvbGxlY3Rpb25DdXN0b20uY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTE9wdGlvbnNDb2xsZWN0aW9uQ3VzdG9tLmNwcApp bmRleCBjOWNjMGZlYTJjNWQyMmFjMGJlNmJhZGQyZWFmZWYwZTg4YmU1OGVmLi5jOTcwM2NhOGJh YjFmMWRhMWZkNDczYmViMWFiZmVkOTE4MGU4OWE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MT3B0aW9uc0NvbGxlY3Rpb25DdXN0b20uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxPcHRpb25zQ29sbGVj dGlvbkN1c3RvbS5jcHAKQEAgLTY5LDcgKzY5LDggQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4 SFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpuYW1lZFByb3BlcnR5R2V0dGVyKHY4OjpMb2NhbDx2ODoK ICAgICAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7CiAKICAgICBIVE1MT3B0aW9uc0NvbGxlY3Rp b24qIGltcCA9IFY4SFRNTE9wdGlvbnNDb2xsZWN0aW9uOjp0b05hdGl2ZShpbmZvLkhvbGRlcigp KTsKLSAgICByZXR1cm4gZ2V0TmFtZWRJdGVtcyhpbXAsIHRvV2ViQ29yZUF0b21pY1N0cmluZyhu YW1lKSwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29sYXRlKCkpOworICAgIFY4VFJZQ0FUQ0hf Rk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJpbmdSZXNvdXJjZTw+LCBwcm9wZXJ0eU5hbWUsIG5h bWUpOworICAgIHJldHVybiBnZXROYW1lZEl0ZW1zKGltcCwgcHJvcGVydHlOYW1lLCBpbmZvLkhv bGRlcigpLCBpbmZvLkdldElzb2xhdGUoKSk7CiB9CiAKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBW OEhUTUxPcHRpb25zQ29sbGVjdGlvbjo6bmFtZWRJdGVtQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3Vt ZW50cyYgYXJncykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOE5vZGVMaXN0Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOE5vZGVMaXN0Q3VzdG9tLmNwcAppbmRleCBlZTJiMTVhYTFjNzliMzEzYzkwZWFkZGVmYjEy ZDExMjZmOThhOTBmLi43NTAwMWNiMDc4MjI5N2U1OWZlMzBlNWRkY2QzNWU3MzI3N2E4OTk5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb2RlTGlzdEN1 c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm9kZUxp c3RDdXN0b20uY3BwCkBAIC00NiwxNCArNDYsMTQgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4 Tm9kZUxpc3Q6Om5hbWVkUHJvcGVydHlHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUK IHsKICAgICBJTkNfU1RBVFMoIkRPTS5Ob2RlTGlzdC5OYW1lZFByb3BlcnR5R2V0dGVyIik7CiAg ICAgTm9kZUxpc3QqIGxpc3QgPSBWOE5vZGVMaXN0Ojp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsK LSAgICBBdG9taWNTdHJpbmcga2V5ID0gdG9XZWJDb3JlQXRvbWljU3RyaW5nKG5hbWUpOworICAg IFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJpbmdSZXNvdXJjZTw+LCBwcm9w ZXJ0eU5hbWUsIG5hbWUpOwogCiAgICAgLy8gTGVuZ3RoIHByb3BlcnR5IGNhbm5vdCBiZSBvdmVy cmlkZGVuLgogICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgQXRvbWljU3RyaW5nLCBsZW5n dGgsICgibGVuZ3RoIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwotICAg IGlmIChrZXkgPT0gbGVuZ3RoKQorICAgIGlmIChwcm9wZXJ0eU5hbWUuYXRvbWljU3RyaW5nKCkg PT0gbGVuZ3RoKQogICAgICAgICByZXR1cm4gdjhJbnRlZ2VyKGxpc3QtPmxlbmd0aCgpLCBpbmZv LkdldElzb2xhdGUoKSk7CiAKLSAgICBSZWZQdHI8Tm9kZT4gcmVzdWx0ID0gbGlzdC0+bmFtZWRJ dGVtKGtleSk7CisgICAgUmVmUHRyPE5vZGU+IHJlc3VsdCA9IGxpc3QtPm5hbWVkSXRlbShwcm9w ZXJ0eU5hbWUpOwogICAgIGlmICghcmVzdWx0KQogICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQo KTsKIAo=