103391 2012-11-27 04:23:18 -0800 [V8] Replace toWebCoreString()/toWebCoreAtomicString() in CodeGeneratorV8.pm with V8StringResource 2012-11-27 16:19:37 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103331 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 776604 0 haraken 2012-11-27 04:23:18 -0800 This is an incremental effort for fixing bug 103331. 776609 1 176230 haraken 2012-11-27 04:25:15 -0800 Created attachment 176230 Patch 777231 2 176230 webkit.review.bot 2012-11-27 14:30:34 -0800 Comment on attachment 176230 Patch Clearing flags on attachment: 176230 Committed r135922: <http://trac.webkit.org/changeset/135922> 777232 3 webkit.review.bot 2012-11-27 14:30:38 -0800 All reviewed patches have been landed. Closing bug. 777335 4 haraken 2012-11-27 16:19:37 -0800 By this change, all value conversions in generated code are already surrounded by TRYCATCH() blocks correctly. On the other hand, a huge amount of value conversions in custom bindings are missing TRYCATCH() blocks, which we want to fix at some point. 176230 2012-11-27 04:25:15 -0800 2012-11-27 14:30:34 -0800 Patch bug-103391-20121127212252.patch text/plain 7396 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA0OTlkM2E3YzhkMjdm MGJjM2ZkOWJhYjIwYzRiNzVkZDdjY2Q4OC4uMmFkODcxMmUyMjNiZGVmMGNmZjg3NzVmZDgyZmZh ZWZjNjkwOTdmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEyLTExLTI3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlcGxhY2Ug dG9XZWJDb3JlU3RyaW5nKCkvdG9XZWJDb3JlQXRvbWljU3RyaW5nKCkgaW4gQ29kZUdlbmVyYXRv clY4LnBtIHdpdGggVjhTdHJpbmdSZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhbiBpbmNyZW1lbnRhbCBlZmZvcnQgZm9yIGZp eGluZyBidWcgMTAzMzMxLgorICAgICAgICBJIGNvbmZpcm1lZCB0aGF0IHRoaXMgcGF0Y2ggY2F1 c2VzIG5vIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24KKyAgICAgICAgZm9yIHRoZSBtaWNybyBiZW5j aG1hcmtzIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRhY2htZW50LmNnaT9pZD0xNzYxNzgp LgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRl Tm9ybWFsQXR0clNldHRlcik6CisgICAgICAgIChHZW5lcmF0ZUV2ZW50TGlzdGVuZXJDYWxsYmFj ayk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdEV2ZW50VGFyZ2V0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRlc3RFdmVudFRhcmdldFY4SW50ZXJuYWw6OmFkZEV2 ZW50TGlzdGVuZXJDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpUZXN0RXZlbnRUYXJnZXRW OEludGVybmFsOjpyZW1vdmVFdmVudExpc3RlbmVyQ2FsbGJhY2spOgorICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGVz dE9ialY4SW50ZXJuYWw6OmFkZEV2ZW50TGlzdGVuZXJDYWxsYmFjayk6CisgICAgICAgIChXZWJD b3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6cmVtb3ZlRXZlbnRMaXN0ZW5lckNhbGxiYWNrKToKKwor MjAxMi0xMS0yNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgVW5yZXZpZXdlZC4gUmVuYW1lZCBUUllDQVRDSCA9PiBWOFRSWUNBVENILgogICAgICAgICAo SSBmb3Jnb3QgdG8gYXBwbHkgcmV2aWV3ZXIncyBjb21tZW50IGluIGJ1ZyAxMDMzNTIgd2hlbiBs YW5kaW5nIHIxMzU4MTcuKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDY2ZjcyNDJjMDA3ZjRhNTMyYzIxNjFhMWRlMTRi MGNlZjlmNDE2NzIuLmNiOGNmMjUwMTE4MzA3YmI5YWExMzBlMDFlZTg1OTkxNmZhMjM3MTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCkBAIC0xMjIyLDggKzEyMjIsOCBAQCBFTkQKICAgICAgICAgICAgIG15ICRuYW1lc3BhY2Ug PSAkY29kZUdlbmVyYXRvci0+TmFtZXNwYWNlRm9yQXR0cmlidXRlTmFtZSgkaW50ZXJmYWNlTmFt ZSwgJGNvbnRlbnRBdHRyaWJ1dGVOYW1lKTsKICAgICAgICAgICAgIEFkZFRvSW1wbEluY2x1ZGVz KCIke25hbWVzcGFjZX0uaCIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICBFbGVtZW50KiBpbXAgPSBWOEVsZW1lbnQ6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpO1xu Iik7Ci0gICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIEF0b21pY1N0cmlu ZyB2ID0gdG9XZWJDb3JlQXRvbWljU3RyaW5nV2l0aE51bGxDaGVjayh2YWx1ZSk7XG4iKTsKLSAg ICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgaW1wLT5zZXRBdHRyaWJ1dGUo JHtuYW1lc3BhY2V9Ojoke2NvbnRlbnRBdHRyaWJ1dGVOYW1lfUF0dHIsIHYpO1xuIik7CisgICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RS SU5HUkVTT1VSQ0VfVk9JRChWOFN0cmluZ1Jlc291cmNlPFdpdGhOdWxsQ2hlY2s+LCBzdHJpbmdS ZXNvdXJjZSwgdmFsdWUpO1xuIik7CisgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xz LCAiICAgIGltcC0+c2V0QXR0cmlidXRlKCR7bmFtZXNwYWNlfTo6JHtjb250ZW50QXR0cmlidXRl TmFtZX1BdHRyLCBzdHJpbmdSZXNvdXJjZSk7XG4iKTsKICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50RGVjbHMsICJ9XG5cbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNs cywgIiNlbmRpZiAvLyAke2NvbmRpdGlvbmFsU3RyaW5nfVxuXG4iKSBpZiAkY29uZGl0aW9uYWxT dHJpbmc7CiAgICAgICAgICAgICByZXR1cm47CkBAIC0xMzc0LDcgKzEzNzQsOCBAQCBzdGF0aWMg djg6OkhhbmRsZTx2ODo6VmFsdWU+ICR7ZnVuY3Rpb25OYW1lfUV2ZW50TGlzdGVuZXJDYWxsYmFj ayhjb25zdCB2ODo6QXJndQogICAgIElOQ19TVEFUUygiRE9NLiR7aW50ZXJmYWNlTmFtZX0uJHtm dW5jdGlvbk5hbWV9RXZlbnRMaXN0ZW5lcigpIik7CiAgICAgUmVmUHRyPEV2ZW50TGlzdGVuZXI+ IGxpc3RlbmVyID0gVjhET01XcmFwcGVyOjpnZXRFdmVudExpc3RlbmVyKGFyZ3NbMV0sIGZhbHNl LCBMaXN0ZW5lckZpbmQke2xvb2t1cFR5cGV9KTsKICAgICBpZiAobGlzdGVuZXIpIHsKLSAgICAg ICAgVjgke2ludGVyZmFjZU5hbWV9Ojp0b05hdGl2ZShhcmdzLkhvbGRlcigpKS0+JHtmdW5jdGlv bk5hbWV9RXZlbnRMaXN0ZW5lcih0b1dlYkNvcmVBdG9taWNTdHJpbmcoYXJnc1swXSksIGxpc3Rl bmVyJHtwYXNzUmVmUHRySGFuZGxpbmd9LCBhcmdzWzJdLT5Cb29sZWFuVmFsdWUoKSk7CisgICAg ICAgIFY4VFJZQ0FUQ0hfRk9SX1Y4U1RSSU5HUkVTT1VSQ0UoVjhTdHJpbmdSZXNvdXJjZTxXaXRo TnVsbENoZWNrPiwgc3RyaW5nUmVzb3VyY2UsIGFyZ3NbMF0pOworICAgICAgICBWOCR7aW50ZXJm YWNlTmFtZX06OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkpLT4ke2Z1bmN0aW9uTmFtZX1FdmVudExp c3RlbmVyKHN0cmluZ1Jlc291cmNlLCBsaXN0ZW5lciR7cGFzc1JlZlB0ckhhbmRsaW5nfSwgYXJn c1syXS0+Qm9vbGVhblZhbHVlKCkpOwogRU5ECiAgICAgaWYgKCRyZXF1aXJlc0hpZGRlbkRlcGVu ZGVuY3kpIHsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgPDxFTkQpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdEV2ZW50 VGFyZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRl c3RFdmVudFRhcmdldC5jcHAKaW5kZXggMWFmYzg3NjlhMDQzODA4N2FjZDI1NTBhZTkzNTM3ZWU0 YWFiMTdhOS4uNGNlYjI1ZTcxZWFkMjFkNGY0MDJhNmNkOTU2OGE2NTM0NzM3MTU0NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdEV2ZW50 VGFyZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgv VjhUZXN0RXZlbnRUYXJnZXQuY3BwCkBAIC02NSw3ICs2NSw4IEBAIHN0YXRpYyB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gYWRkRXZlbnRMaXN0ZW5lckNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMm IGFyZ3MpCiAgICAgSU5DX1NUQVRTKCJET00uVGVzdEV2ZW50VGFyZ2V0LmFkZEV2ZW50TGlzdGVu ZXIoKSIpOwogICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IFY4RE9NV3JhcHBl cjo6Z2V0RXZlbnRMaXN0ZW5lcihhcmdzWzFdLCBmYWxzZSwgTGlzdGVuZXJGaW5kT3JDcmVhdGUp OwogICAgIGlmIChsaXN0ZW5lcikgewotICAgICAgICBWOFRlc3RFdmVudFRhcmdldDo6dG9OYXRp dmUoYXJncy5Ib2xkZXIoKSktPmFkZEV2ZW50TGlzdGVuZXIodG9XZWJDb3JlQXRvbWljU3RyaW5n KGFyZ3NbMF0pLCBsaXN0ZW5lciwgYXJnc1syXS0+Qm9vbGVhblZhbHVlKCkpOworICAgICAgICBW OFRSWUNBVENIX0ZPUl9WOFNUUklOR1JFU09VUkNFKFY4U3RyaW5nUmVzb3VyY2U8V2l0aE51bGxD aGVjaz4sIHN0cmluZ1Jlc291cmNlLCBhcmdzWzBdKTsKKyAgICAgICAgVjhUZXN0RXZlbnRUYXJn ZXQ6OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkpLT5hZGRFdmVudExpc3RlbmVyKHN0cmluZ1Jlc291 cmNlLCBsaXN0ZW5lciwgYXJnc1syXS0+Qm9vbGVhblZhbHVlKCkpOwogICAgICAgICBjcmVhdGVI aWRkZW5EZXBlbmRlbmN5KGFyZ3MuSG9sZGVyKCksIGFyZ3NbMV0sIFY4VGVzdEV2ZW50VGFyZ2V0 OjpldmVudExpc3RlbmVyQ2FjaGVJbmRleCk7CiAgICAgfQogICAgIHJldHVybiB2OFVuZGVmaW5l ZCgpOwpAQCAtNzYsNyArNzcsOCBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlbW92 ZUV2ZW50TGlzdGVuZXJDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcgogICAgIElOQ19T VEFUUygiRE9NLlRlc3RFdmVudFRhcmdldC5yZW1vdmVFdmVudExpc3RlbmVyKCkiKTsKICAgICBS ZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlz dGVuZXIoYXJnc1sxXSwgZmFsc2UsIExpc3RlbmVyRmluZE9ubHkpOwogICAgIGlmIChsaXN0ZW5l cikgewotICAgICAgICBWOFRlc3RFdmVudFRhcmdldDo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSkt PnJlbW92ZUV2ZW50TGlzdGVuZXIodG9XZWJDb3JlQXRvbWljU3RyaW5nKGFyZ3NbMF0pLCBsaXN0 ZW5lci5nZXQoKSwgYXJnc1syXS0+Qm9vbGVhblZhbHVlKCkpOworICAgICAgICBWOFRSWUNBVENI X0ZPUl9WOFNUUklOR1JFU09VUkNFKFY4U3RyaW5nUmVzb3VyY2U8V2l0aE51bGxDaGVjaz4sIHN0 cmluZ1Jlc291cmNlLCBhcmdzWzBdKTsKKyAgICAgICAgVjhUZXN0RXZlbnRUYXJnZXQ6OnRvTmF0 aXZlKGFyZ3MuSG9sZGVyKCkpLT5yZW1vdmVFdmVudExpc3RlbmVyKHN0cmluZ1Jlc291cmNlLCBs aXN0ZW5lci5nZXQoKSwgYXJnc1syXS0+Qm9vbGVhblZhbHVlKCkpOwogICAgICAgICByZW1vdmVI aWRkZW5EZXBlbmRlbmN5KGFyZ3MuSG9sZGVyKCksIGFyZ3NbMV0sIFY4VGVzdEV2ZW50VGFyZ2V0 OjpldmVudExpc3RlbmVyQ2FjaGVJbmRleCk7CiAgICAgfQogICAgIHJldHVybiB2OFVuZGVmaW5l ZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4 L1Y4VGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgv VjhUZXN0T2JqLmNwcAppbmRleCA3NTZiMzA2NDUyYjg0M2I3Njc5ODkwNzIwN2QwZDQ3ZWU0YTU1 YmI5Li5iOGU2YjE1NTU1M2IzOThjNTBkMTlkOGU4OTA5OTgyMTA3M2Q3YzUxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNw cApAQCAtMTIwMyw3ICsxMjAzLDggQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBhZGRF dmVudExpc3RlbmVyQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICBJTkNf U1RBVFMoIkRPTS5UZXN0T2JqLmFkZEV2ZW50TGlzdGVuZXIoKSIpOwogICAgIFJlZlB0cjxFdmVu dExpc3RlbmVyPiBsaXN0ZW5lciA9IFY4RE9NV3JhcHBlcjo6Z2V0RXZlbnRMaXN0ZW5lcihhcmdz WzFdLCBmYWxzZSwgTGlzdGVuZXJGaW5kT3JDcmVhdGUpOwogICAgIGlmIChsaXN0ZW5lcikgewot ICAgICAgICBWOFRlc3RPYmo6OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkpLT5hZGRFdmVudExpc3Rl bmVyKHRvV2ViQ29yZUF0b21pY1N0cmluZyhhcmdzWzBdKSwgbGlzdGVuZXIsIGFyZ3NbMl0tPkJv b2xlYW5WYWx1ZSgpKTsKKyAgICAgICAgVjhUUllDQVRDSF9GT1JfVjhTVFJJTkdSRVNPVVJDRShW OFN0cmluZ1Jlc291cmNlPFdpdGhOdWxsQ2hlY2s+LCBzdHJpbmdSZXNvdXJjZSwgYXJnc1swXSk7 CisgICAgICAgIFY4VGVzdE9iajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSktPmFkZEV2ZW50TGlz dGVuZXIoc3RyaW5nUmVzb3VyY2UsIGxpc3RlbmVyLCBhcmdzWzJdLT5Cb29sZWFuVmFsdWUoKSk7 CiAgICAgICAgIGNyZWF0ZUhpZGRlbkRlcGVuZGVuY3koYXJncy5Ib2xkZXIoKSwgYXJnc1sxXSwg VjhUZXN0T2JqOjpldmVudExpc3RlbmVyQ2FjaGVJbmRleCk7CiAgICAgfQogICAgIHJldHVybiB2 OFVuZGVmaW5lZCgpOwpAQCAtMTIxNCw3ICsxMjE1LDggQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6 OlZhbHVlPiByZW1vdmVFdmVudExpc3RlbmVyQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYg YXIKICAgICBJTkNfU1RBVFMoIkRPTS5UZXN0T2JqLnJlbW92ZUV2ZW50TGlzdGVuZXIoKSIpOwog ICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lciA9IFY4RE9NV3JhcHBlcjo6Z2V0RXZl bnRMaXN0ZW5lcihhcmdzWzFdLCBmYWxzZSwgTGlzdGVuZXJGaW5kT25seSk7CiAgICAgaWYgKGxp c3RlbmVyKSB7Ci0gICAgICAgIFY4VGVzdE9iajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSktPnJl bW92ZUV2ZW50TGlzdGVuZXIodG9XZWJDb3JlQXRvbWljU3RyaW5nKGFyZ3NbMF0pLCBsaXN0ZW5l ci5nZXQoKSwgYXJnc1syXS0+Qm9vbGVhblZhbHVlKCkpOworICAgICAgICBWOFRSWUNBVENIX0ZP Ul9WOFNUUklOR1JFU09VUkNFKFY4U3RyaW5nUmVzb3VyY2U8V2l0aE51bGxDaGVjaz4sIHN0cmlu Z1Jlc291cmNlLCBhcmdzWzBdKTsKKyAgICAgICAgVjhUZXN0T2JqOjp0b05hdGl2ZShhcmdzLkhv bGRlcigpKS0+cmVtb3ZlRXZlbnRMaXN0ZW5lcihzdHJpbmdSZXNvdXJjZSwgbGlzdGVuZXIuZ2V0 KCksIGFyZ3NbMl0tPkJvb2xlYW5WYWx1ZSgpKTsKICAgICAgICAgcmVtb3ZlSGlkZGVuRGVwZW5k ZW5jeShhcmdzLkhvbGRlcigpLCBhcmdzWzFdLCBWOFRlc3RPYmo6OmV2ZW50TGlzdGVuZXJDYWNo ZUluZGV4KTsKICAgICB9CiAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7Cg==