103378 2012-11-27 01:28:47 -0800 [sh4] Fix compilation warnings in JavaScriptCore JIT for sh4 arch 2012-11-30 02:20:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P5 Trivial --- 0 jbriance webkit-unassigned fpizlo oliver webkit.review.bot oldest_to_newest 776473 0 jbriance 2012-11-27 01:28:47 -0800 Fix the following compilation warnings in JavaScriptCore JIT for sh4 arch: /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1796:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1810:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1824:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1845:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1898:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1933:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1967:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:2002:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] /local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:2043:21: warning: comparison between ‘enum JSC::MacroAssemblerSH4::ResultCondition’ and ‘enum JSC::MacroAssemblerSH4::RelationalCondition’ [-Wenum-compare] 776477 1 176197 jbriance 2012-11-27 01:35:45 -0800 Created attachment 176197 Remove warnings for sh4 arch in JavaScriptCore JIT 779959 2 176197 webkit.review.bot 2012-11-30 02:20:22 -0800 Comment on attachment 176197 Remove warnings for sh4 arch in JavaScriptCore JIT Clearing flags on attachment: 176197 Committed r136218: <http://trac.webkit.org/changeset/136218> 779960 3 webkit.review.bot 2012-11-30 02:20:25 -0800 All reviewed patches have been landed. Closing bug. 176197 2012-11-27 01:35:45 -0800 2012-11-30 02:20:22 -0800 Remove warnings for sh4 arch in JavaScriptCore JIT javascript_sh4_jit_warnings_fix.patch text/plain 3653 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM1ODM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTExLTI3ICBKdWxpZW4gQlJJQU5DRUFVICAgPGpicmlhbmNlYXVAbmRzLmNvbT4KKwor ICAgICAgICBbc2g0XSBGaXggY29tcGlsYXRpb24gd2FybmluZ3MgaW4gSmF2YVNjcmlwdENvcmUg SklUIGZvciBzaDQgYXJjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAzMzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaDoKKyAgICAgICAgKEpTQzo6 TWFjcm9Bc3NlbWJsZXJTSDQ6OmJyYW5jaFRlc3QzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyU0g0OjpicmFuY2hBZGQzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0 OjpicmFuY2hNdWwzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0OjpicmFuY2hT dWIzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0OjpicmFuY2hPcjMyKToKKwog MjAxMi0xMS0yNiAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAgICAg U3Vic3RpdHV0ZSAiYWxsU2VwYXJhdG9yczhCaXQiIGZvciAiYWxsU2VwZXJhdG9yczhCaXQiIGlu IEpTQzo6anNTcGxpY2VTdWJzdHJpbmdzV2l0aFNlcGFyYXRvcnMoKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkocmV2 aXNpb24gMTM1ODI5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlclNINC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzkzLDcgKzE3OTMsNyBAQCB2b2lkIG9y MzIoVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBzCiAKICAgICAgICAgbV9hc3NlbWJsZXIu dGVzdGxSZWdSZWcocmVnLCBtYXNrKTsKIAotICAgICAgICBpZiAoY29uZCA9PSBOb3RFcXVhbCkK KyAgICAgICAgaWYgKGNvbmQgPT0gTm9uWmVybykgLy8gTm90RXF1YWwKICAgICAgICAgICAgIHJl dHVybiBicmFuY2hGYWxzZSgpOwogICAgICAgICByZXR1cm4gYnJhbmNoVHJ1ZSgpOwogICAgIH0K QEAgLTE4MDcsNyArMTgwNyw3IEBAIHZvaWQgb3IzMihUcnVzdGVkSW1tMzIgaW1tLCBSZWdpc3Rl cklEIHMKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGVzdGxJbW0obWFzay5tX3ZhbHVlLCBy ZWcpOwogCi0gICAgICAgIGlmIChjb25kID09IE5vdEVxdWFsKQorICAgICAgICBpZiAoY29uZCA9 PSBOb25aZXJvKSAvLyBOb3RFcXVhbAogICAgICAgICAgICAgcmV0dXJuIGJyYW5jaEZhbHNlKCk7 CiAgICAgICAgIHJldHVybiBicmFuY2hUcnVlKCk7CiAgICAgfQpAQCAtMTgyMSw3ICsxODIxLDcg QEAgdm9pZCBvcjMyKFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgcwogICAgICAgICBlbHNl CiAgICAgICAgICAgICB0ZXN0SW1tKG1hc2subV92YWx1ZSwgYWRkcmVzcy5vZmZzZXQsIGFkZHJl c3MuYmFzZSk7CiAKLSAgICAgICAgaWYgKGNvbmQgPT0gTm90RXF1YWwpCisgICAgICAgIGlmIChj b25kID09IE5vblplcm8pIC8vIE5vdEVxdWFsCiAgICAgICAgICAgICByZXR1cm4gYnJhbmNoRmFs c2UoKTsKICAgICAgICAgcmV0dXJuIGJyYW5jaFRydWUoKTsKICAgICB9CkBAIC0xODQyLDcgKzE4 NDIsNyBAQCB2b2lkIG9yMzIoVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBzCiAKICAgICAg ICAgcmVsZWFzZVNjcmF0Y2goc2NyKTsKIAotICAgICAgICBpZiAoY29uZCA9PSBOb3RFcXVhbCkK KyAgICAgICAgaWYgKGNvbmQgPT0gTm9uWmVybykgLy8gTm90RXF1YWwKICAgICAgICAgICAgIHJl dHVybiBicmFuY2hGYWxzZSgpOwogICAgICAgICByZXR1cm4gYnJhbmNoVHJ1ZSgpOwogICAgIH0K QEAgLTE4OTUsNyArMTg5NSw3IEBAIHZvaWQgb3IzMihUcnVzdGVkSW1tMzIgaW1tLCBSZWdpc3Rl cklEIHMKICAgICAgICAgbV9hc3NlbWJsZXIuYWRkbFJlZ1JlZyhzcmMsIGRlc3QpOwogICAgICAg ICBjb21wYXJlMzIoMCwgZGVzdCwgRXF1YWwpOwogCi0gICAgICAgIGlmIChjb25kID09IE5vdEVx dWFsKQorICAgICAgICBpZiAoY29uZCA9PSBOb25aZXJvKSAvLyBOb3RFcXVhbAogICAgICAgICAg ICAgcmV0dXJuIGJyYW5jaEZhbHNlKCk7CiAgICAgICAgIHJldHVybiBicmFuY2hUcnVlKCk7CiAg ICAgfQpAQCAtMTkzMCw3ICsxOTMwLDcgQEAgdm9pZCBvcjMyKFRydXN0ZWRJbW0zMiBpbW0sIFJl Z2lzdGVySUQgcwogCiAgICAgICAgIGNvbXBhcmUzMigwLCBkZXN0LCBFcXVhbCk7CiAKLSAgICAg ICAgaWYgKGNvbmQgPT0gTm90RXF1YWwpCisgICAgICAgIGlmIChjb25kID09IE5vblplcm8pIC8v IE5vdEVxdWFsCiAgICAgICAgICAgICByZXR1cm4gYnJhbmNoRmFsc2UoKTsKICAgICAgICAgcmV0 dXJuIGJyYW5jaFRydWUoKTsKICAgICB9CkBAIC0xOTY0LDcgKzE5NjQsNyBAQCB2b2lkIG9yMzIo VHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBzCiAKICAgICAgICAgY29tcGFyZTMyKDAsIGRl c3QsIHN0YXRpY19jYXN0PFJlbGF0aW9uYWxDb25kaXRpb24+KGNvbmQpKTsKIAotICAgICAgICBp ZiAoY29uZCA9PSBOb3RFcXVhbCkKKyAgICAgICAgaWYgKGNvbmQgPT0gTm9uWmVybykgLy8gTm90 RXF1YWwKICAgICAgICAgICAgIHJldHVybiBicmFuY2hGYWxzZSgpOwogICAgICAgICByZXR1cm4g YnJhbmNoVHJ1ZSgpOwogICAgIH0KQEAgLTE5OTksNyArMTk5OSw3IEBAIHZvaWQgb3IzMihUcnVz dGVkSW1tMzIgaW1tLCBSZWdpc3RlcklEIHMKICAgICAgICAgc3ViMzIoc3JjLCBkZXN0KTsKICAg ICAgICAgY29tcGFyZTMyKDAsIGRlc3QsIHN0YXRpY19jYXN0PFJlbGF0aW9uYWxDb25kaXRpb24+ KGNvbmQpKTsKIAotICAgICAgICBpZiAoY29uZCA9PSBOb3RFcXVhbCkKKyAgICAgICAgaWYgKGNv bmQgPT0gTm9uWmVybykgLy8gTm90RXF1YWwKICAgICAgICAgICAgIHJldHVybiBicmFuY2hGYWxz ZSgpOwogICAgICAgICByZXR1cm4gYnJhbmNoVHJ1ZSgpOwogICAgIH0KQEAgLTIwNDAsNyArMjA0 MCw3IEBAIHZvaWQgb3IzMihUcnVzdGVkSW1tMzIgaW1tLCBSZWdpc3RlcklEIHMKICAgICAgICAg b3IzMihzcmMsIGRlc3QpOwogICAgICAgICBjb21wYXJlMzIoMCwgZGVzdCwgc3RhdGljX2Nhc3Q8 UmVsYXRpb25hbENvbmRpdGlvbj4oY29uZCkpOwogCi0gICAgICAgIGlmIChjb25kID09IE5vdEVx dWFsKQorICAgICAgICBpZiAoY29uZCA9PSBOb25aZXJvKSAvLyBOb3RFcXVhbAogICAgICAgICAg ICAgcmV0dXJuIGJyYW5jaEZhbHNlKCk7CiAgICAgICAgIHJldHVybiBicmFuY2hUcnVlKCk7CiAg ICAgfQo=