103376 2012-11-27 01:09:18 -0800 [V8] add contextForWorld helper function to ScriptController 2012-11-27 09:22:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 776459 0 dcarney 2012-11-27 01:09:18 -0800 [V8] add contextForWorld helper function to ScriptController 776461 1 176195 dcarney 2012-11-27 01:10:42 -0800 Created attachment 176195 Patch 776466 2 176195 haraken 2012-11-27 01:16:53 -0800 Comment on attachment 176195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176195&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:437 > +inline v8::Local<v8::Context> ScriptController::contextForWorld(DOMWrapperWorld* world) This could be in a header file. Maybe you couldn't write it in a header file due to some #include dependency problem ? 776475 3 dcarney 2012-11-27 01:31:46 -0800 (In reply to comment #2) > (From update of attachment 176195 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176195&action=review > > > Source/WebCore/bindings/v8/ScriptController.cpp:437 > > +inline v8::Local<v8::Context> ScriptController::contextForWorld(DOMWrapperWorld* world) > > This could be in a header file. Maybe you couldn't write it in a header file due to some #include dependency problem ? I will move it to the header, i just wanted all the uses of the function in the same spot as the function. 776476 4 haraken 2012-11-27 01:32:50 -0800 ok, if performance is not critical, it would make sense to put it in a cpp file as a static function. 776491 5 176201 dcarney 2012-11-27 01:50:23 -0800 Created attachment 176201 Patch 776492 6 176201 dcarney 2012-11-27 01:50:55 -0800 Comment on attachment 176201 Patch static inline version 776528 7 176201 webkit.review.bot 2012-11-27 02:28:52 -0800 Comment on attachment 176201 Patch Rejecting attachment 176201 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15016026 776588 8 176201 webkit.review.bot 2012-11-27 03:53:37 -0800 Comment on attachment 176201 Patch Clearing flags on attachment: 176201 Committed r135846: <http://trac.webkit.org/changeset/135846> 776589 9 webkit.review.bot 2012-11-27 03:53:41 -0800 All reviewed patches have been landed. Closing bug. 776848 10 176201 abarth 2012-11-27 09:22:33 -0800 Comment on attachment 176201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176201&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:437 > +static inline v8::Local<v8::Context> contextForWorld(ScriptController* scriptController, DOMWrapperWorld* world) Minor style nit: We usually put functions like this at the top of the file, just after the namespace WebCore. Also, my understanding is that static and inline are redundant here. 176195 2012-11-27 01:10:42 -0800 2012-11-27 01:50:17 -0800 Patch bug-103376-20121127100818.patch text/plain 3420 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ0MmY0ZmE4NmU2MzRi OThmNWU0NTk4MDE5M2M5MTViOGFiYTk3OS4uOGZjNjU1ZjI5YWRhZTAxMDM3NDQ3MTMzMGQ4ODQ5 MjYwNWY3OWIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI3ICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gYWRkIGNvbnRleHRG b3JXb3JsZCBoZWxwZXIgZnVuY3Rpb24gdG8gU2NyaXB0Q29udHJvbGxlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMzc2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNpbmcgc29tZSBjb21tb25s eSBvY2N1cmluZyBjb2RlIHdpdGggYW4gaW5saW5lIGZ1bmN0aW9uLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRy b2xsZXI6OmNvbnRleHRGb3JXb3JsZCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdl YkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmN1cnJlbnRXb3JsZENvbnRleHQpOgorICAgICAgICAo V2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6bWFpbldvcmxkQ29udGV4dCk6CisgICAgICAgICog YmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAoU2NyaXB0Q29udHJvbGxl cik6CisKIDIwMTItMTEtMjYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIDpyZWFkLW9ubHkgc2VsZWN0b3Igc2hvdWxkIG1hdGNoIHRvIGRhdGUvdGltZSBpbnB1 dCB0eXBlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29u dHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVy LmNwcAppbmRleCBmZWNkZTIxNTI5NmM0YjcyOWVlZjgyM2VmYjQzYjI5ZGNiY2MxNmJlLi5lMjAy NjliMjU0OTAwNzg5NGEyZmNkYjBhOGJmZWY1MzljNjM0YjUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtNDM0LDE1ICs0MzQsMjAg QEAgdm9pZCBTY3JpcHRDb250cm9sbGVyOjpmaW5pc2hlZFdpdGhFdmVudChFdmVudCogZXZlbnQp CiB7CiB9CiAKK2lubGluZSB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IFNjcmlwdENvbnRyb2xsZXI6 OmNvbnRleHRGb3JXb3JsZChET01XcmFwcGVyV29ybGQqIHdvcmxkKQoreworICAgIHJldHVybiB2 ODo6TG9jYWw8djg6OkNvbnRleHQ+OjpOZXcod2luZG93U2hlbGwod29ybGQpLT5jb250ZXh0KCkp OworfQorCiB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IFNjcmlwdENvbnRyb2xsZXI6OmN1cnJlbnRX b3JsZENvbnRleHQoKQogewogICAgIGlmICghdjg6OkNvbnRleHQ6OkluQ29udGV4dCgpKQotICAg ICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KHdpbmRvd1NoZWxsKG1haW5U aHJlYWROb3JtYWxXb3JsZCgpKS0+Y29udGV4dCgpKTsKKyAgICAgICAgcmV0dXJuIGNvbnRleHRG b3JXb3JsZChtYWluVGhyZWFkTm9ybWFsV29ybGQoKSk7CiAKICAgICB2ODo6SGFuZGxlPHY4OjpD b250ZXh0PiBjb250ZXh0ID0gdjg6OkNvbnRleHQ6OkdldEVudGVyZWQoKTsKICAgICBET01XcmFw cGVyV29ybGQqIGlzb2xhdGVkV29ybGQgPSBET01XcmFwcGVyV29ybGQ6Omlzb2xhdGVkKGNvbnRl eHQpOwogICAgIGlmICghaXNvbGF0ZWRXb3JsZCkKLSAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2 ODo6Q29udGV4dD46Ok5ldyh3aW5kb3dTaGVsbChtYWluVGhyZWFkTm9ybWFsV29ybGQoKSktPmNv bnRleHQoKSk7CisgICAgICAgIHJldHVybiBjb250ZXh0Rm9yV29ybGQobWFpblRocmVhZE5vcm1h bFdvcmxkKCkpOwogCiAgICAgRnJhbWUqIGZyYW1lID0gdG9GcmFtZUlmTm90RGV0YWNoZWQoY29u dGV4dCk7CiAgICAgaWYgKCFtX2ZyYW1lKQpAQCAtNDU1LDEyICs0NjAsMTIgQEAgdjg6OkxvY2Fs PHY4OjpDb250ZXh0PiBTY3JpcHRDb250cm9sbGVyOjpjdXJyZW50V29ybGRDb250ZXh0KCkKICAg ICBpZiAoaXNvbGF0ZWRXb3JsZC0+Y3JlYXRlZEZyb21Vbml0aWFsaXplZFdvcmxkKCkpCiAgICAg ICAgIHJldHVybiB2ODo6TG9jYWw8djg6OkNvbnRleHQ+KCk7CiAKLSAgICByZXR1cm4gdjg6Okxv Y2FsPHY4OjpDb250ZXh0Pjo6TmV3KHdpbmRvd1NoZWxsKGlzb2xhdGVkV29ybGQpLT5jb250ZXh0 KCkpOworICAgIHJldHVybiBjb250ZXh0Rm9yV29ybGQoaXNvbGF0ZWRXb3JsZCk7CiB9CiAKIHY4 OjpMb2NhbDx2ODo6Q29udGV4dD4gU2NyaXB0Q29udHJvbGxlcjo6bWFpbldvcmxkQ29udGV4dCgp CiB7Ci0gICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyh3aW5kb3dTaGVsbCht YWluVGhyZWFkTm9ybWFsV29ybGQoKSktPmNvbnRleHQoKSk7CisgICAgcmV0dXJuIGNvbnRleHRG b3JXb3JsZChtYWluVGhyZWFkTm9ybWFsV29ybGQoKSk7CiB9CiAKIHY4OjpMb2NhbDx2ODo6Q29u dGV4dD4gU2NyaXB0Q29udHJvbGxlcjo6bWFpbldvcmxkQ29udGV4dChGcmFtZSogZnJhbWUpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgKaW5kZXggODI4 NDUwNTA2ZmVkZGM2OWVmYWVkNTU1ZTkyNWRjYTcyNWMwZWY0MC4uOTk0ZjEwZGM4NTQ1NzBhNjlj ZDZiNGFkOTQxMDNkMjdjOTI2ODMwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdENvbnRyb2xsZXIuaApAQCAtMTk2LDYgKzE5Niw3IEBAIHByaXZhdGU6CiAgICAgdHlw ZWRlZiBIYXNoTWFwPGludCwgT3duUHRyPFY4RE9NV2luZG93U2hlbGw+ID4gSXNvbGF0ZWRXb3Js ZE1hcDsKIAogICAgIHZvaWQgY2xlYXJGb3JDbG9zZShib29sIGRlc3Ryb3lHbG9iYWwpOworICAg IHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dEZvcldvcmxkKERPTVdyYXBwZXJXb3JsZCop OwogCiAgICAgRnJhbWUqIG1fZnJhbWU7CiAgICAgY29uc3QgU3RyaW5nKiBtX3NvdXJjZVVSTDsK 176201 2012-11-27 01:50:23 -0800 2012-11-27 09:22:33 -0800 Patch bug-103376-20121127104759.patch text/plain 3261 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ0MmY0ZmE4NmU2MzRi OThmNWU0NTk4MDE5M2M5MTViOGFiYTk3OS4uYjdjZjllNjJjMTM5YWMxOTIzOTA3ZWU3MzAzODVm YzViNDc5MGY3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI3ICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gYWRkIGNvbnRleHRG b3JXb3JsZCBoZWxwZXIgZnVuY3Rpb24gdG8gU2NyaXB0Q29udHJvbGxlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMzc2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorCisgICAgICAgIFJlZHVjaW5nIHNvbWUgY29tbW9ubHkg b2NjdXJpbmcgY29kZSB3aXRoIGFuIGlubGluZSBmdW5jdGlvbi4KKworICAgICAgICBObyBuZXcg dGVzdHMuIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogYmluZGluZ3Mv djgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9s bGVyOjpjb250ZXh0Rm9yV29ybGQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJD b3JlOjpTY3JpcHRDb250cm9sbGVyOjpjdXJyZW50V29ybGRDb250ZXh0KToKKyAgICAgICAgKFdl YkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6Om1haW5Xb3JsZENvbnRleHQpOgorICAgICAgICAqIGJp bmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuaDoKKyAgICAgICAgKFNjcmlwdENvbnRyb2xsZXIp OgorCiAyMDEyLTExLTI2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICA6cmVhZC1vbmx5IHNlbGVjdG9yIHNob3VsZCBtYXRjaCB0byBkYXRlL3RpbWUgaW5wdXQg dHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5j cHAKaW5kZXggZmVjZGUyMTUyOTZjNGI3MjllZWY4MjNlZmI0M2IyOWRjYmNjMTZiZS4uZmNiMGFj YTE1OWU0MWIxNGE0YTJmMmEyODcxNzI3MTNmYTBiNjUwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTQzNCwxNSArNDM0LDIwIEBA IHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6ZmluaXNoZWRXaXRoRXZlbnQoRXZlbnQqIGV2ZW50KQog ewogfQogCitzdGF0aWMgaW5saW5lIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dEZvcldv cmxkKFNjcmlwdENvbnRyb2xsZXIqIHNjcmlwdENvbnRyb2xsZXIsIERPTVdyYXBwZXJXb3JsZCog d29ybGQpCit7CisgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyhzY3JpcHRD b250cm9sbGVyLT53aW5kb3dTaGVsbCh3b3JsZCktPmNvbnRleHQoKSk7Cit9CisKIHY4OjpMb2Nh bDx2ODo6Q29udGV4dD4gU2NyaXB0Q29udHJvbGxlcjo6Y3VycmVudFdvcmxkQ29udGV4dCgpCiB7 CiAgICAgaWYgKCF2ODo6Q29udGV4dDo6SW5Db250ZXh0KCkpCi0gICAgICAgIHJldHVybiB2ODo6 TG9jYWw8djg6OkNvbnRleHQ+OjpOZXcod2luZG93U2hlbGwobWFpblRocmVhZE5vcm1hbFdvcmxk KCkpLT5jb250ZXh0KCkpOworICAgICAgICByZXR1cm4gY29udGV4dEZvcldvcmxkKHRoaXMsIG1h aW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKIAogICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNv bnRleHQgPSB2ODo6Q29udGV4dDo6R2V0RW50ZXJlZCgpOwogICAgIERPTVdyYXBwZXJXb3JsZCog aXNvbGF0ZWRXb3JsZCA9IERPTVdyYXBwZXJXb3JsZDo6aXNvbGF0ZWQoY29udGV4dCk7CiAgICAg aWYgKCFpc29sYXRlZFdvcmxkKQotICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0 Pjo6TmV3KHdpbmRvd1NoZWxsKG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKS0+Y29udGV4dCgpKTsK KyAgICAgICAgcmV0dXJuIGNvbnRleHRGb3JXb3JsZCh0aGlzLCBtYWluVGhyZWFkTm9ybWFsV29y bGQoKSk7CiAKICAgICBGcmFtZSogZnJhbWUgPSB0b0ZyYW1lSWZOb3REZXRhY2hlZChjb250ZXh0 KTsKICAgICBpZiAoIW1fZnJhbWUpCkBAIC00NTUsMTIgKzQ2MCwxMiBAQCB2ODo6TG9jYWw8djg6 OkNvbnRleHQ+IFNjcmlwdENvbnRyb2xsZXI6OmN1cnJlbnRXb3JsZENvbnRleHQoKQogICAgIGlm IChpc29sYXRlZFdvcmxkLT5jcmVhdGVkRnJvbVVuaXRpYWxpemVkV29ybGQoKSkKICAgICAgICAg cmV0dXJuIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4oKTsKIAotICAgIHJldHVybiB2ODo6TG9jYWw8 djg6OkNvbnRleHQ+OjpOZXcod2luZG93U2hlbGwoaXNvbGF0ZWRXb3JsZCktPmNvbnRleHQoKSk7 CisgICAgcmV0dXJuIGNvbnRleHRGb3JXb3JsZCh0aGlzLCBpc29sYXRlZFdvcmxkKTsKIH0KIAog djg6OkxvY2FsPHY4OjpDb250ZXh0PiBTY3JpcHRDb250cm9sbGVyOjptYWluV29ybGRDb250ZXh0 KCkKIHsKLSAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KHdpbmRvd1NoZWxs KG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKS0+Y29udGV4dCgpKTsKKyAgICByZXR1cm4gY29udGV4 dEZvcldvcmxkKHRoaXMsIG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKIH0KIAogdjg6OkxvY2Fs PHY4OjpDb250ZXh0PiBTY3JpcHRDb250cm9sbGVyOjptYWluV29ybGRDb250ZXh0KEZyYW1lKiBm cmFtZSkKQEAgLTQ2OCw3ICs0NzMsNyBAQCB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IFNjcmlwdENv bnRyb2xsZXI6Om1haW5Xb3JsZENvbnRleHQoRnJhbWUqIGZyYW1lKQogICAgIGlmICghZnJhbWUp CiAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OkNvbnRleHQ+KCk7CiAKLSAgICByZXR1cm4g ZnJhbWUtPnNjcmlwdCgpLT5tYWluV29ybGRDb250ZXh0KCk7CisgICAgcmV0dXJuIGNvbnRleHRG b3JXb3JsZChmcmFtZS0+c2NyaXB0KCksIG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKIH0KIAog Ly8gQ3JlYXRlIGEgVjggb2JqZWN0IHdpdGggYW4gaW50ZXJjZXB0b3Igb2YgTlBPYmplY3RQcm9w ZXJ0eUdldHRlci4K