103370 2012-11-27 00:00:43 -0800 [Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag 2012-11-27 00:51:28 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103372 1 morrita morrita haraken ojan webkit.review.bot oldest_to_newest 776422 0 morrita 2012-11-27 00:00:43 -0800 DocumentFragment check is on a hot path and can be done by a node flag check. 776439 1 176191 morrita 2012-11-27 00:28:19 -0800 Created attachment 176191 Patch 776446 2 176191 haraken 2012-11-27 00:43:06 -0800 Comment on attachment 176191 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176191&action=review r+ing assuming that the perf impact on isShadowRoot()==true is acceptable. > Source/WebCore/ChangeLog:8 > + This chagne introduces Node::IsDocumentFragmentFlag so that we can Typo: change. 776450 3 morrita 2012-11-27 00:51:28 -0800 Committed r135833: <http://trac.webkit.org/changeset/135833> 176191 2012-11-27 00:28:19 -0800 2012-11-27 00:43:06 -0800 Patch bug-103370-20121127172556.patch text/plain 6347 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ0MmY0ZmE4NmU2MzRi OThmNWU0NTk4MDE5M2M5MTViOGFiYTk3OS4uMTY2ODdjYjYxNGZlN2U5YmNiMmM2NzQ1YTU2ZWNk MGMxODYwYzAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTExLTI3ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd IE5vZGVGbGFnczo6SXNTaGFkb3dSb290RmxhZyBzaG91bGQgYmUgTm9kZTo6SXNEb2N1bWVudEZy YWdtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDMzNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGNoYWduZSBpbnRyb2R1Y2VzIE5vZGU6OklzRG9jdW1lbnRGcmFnbWVudEZsYWcgc28gdGhh dCB3ZSBjYW4KKyAgICAgICAgaGF2ZSBmYXN0IE5vZGU6OmlzRG9jdW1lbnRGcmFnbWVudCgpLgor CisgICAgICAgIE5vdGUgdGhhdCBOb2RlOjppc1NoYWRvd1Jvb3QoKSBjYW4gYmVjb21lIHNsaWdo dGx5IHNsb3dlciB3aGVuIGl0CisgICAgICAgIHJldHVybnMgdHJ1ZSwgYnV0IHRoYXQgaXMgbWlu b3IgaW4gdGVybXMgb2YgdGhlIG51bWJlciBvZiBjYWxscyBhdCBydW50aW1lLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZG9tL0RvY3Vt ZW50RnJhZ21lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRGcmFnbWVudDo6Y3Jl YXRlKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnRGcmFnbWVudC5oOgorICAgICAgICAqIGRvbS9O b2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmRvY3VtZW50RnJhZ21lbnRJc1NoYWRv d1Jvb3QpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZG9tL05vZGUuaDoKKyAgICAg ICAgKE5vZGUpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6aXNEb2N1bWVudEZyYWdtZW50KToK KyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmlzU2hhZG93Um9vdCk6CisgICAgICAgIChXZWJDb3Jl OjpOb2RlOjpwYXJlbnROb2RlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OnBhcmVudE5vZGVH dWFyYW50ZWVkSG9zdEZyZWUpOgorICAgICAgICAqIGRvbS9TaGFkb3dSb290Lmg6CisKIDIwMTIt MTEtMjYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIDpyZWFk LW9ubHkgc2VsZWN0b3Igc2hvdWxkIG1hdGNoIHRvIGRhdGUvdGltZSBpbnB1dCB0eXBlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuY3BwCmluZGV4IGY3Y2ZhZGZjYzc5ZjMxZDUx NjYzZWFhYzA0MmIzNDVkYTczNGMxOWEuLjQ4YWYxMGZlMWVhN2QyZWFiZjIzYjhhZmM4MGEyNWNh YWUwMGJlYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudEZyYWdtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRGcmFnbWVudC5jcHAKQEAgLTQw LDcgKzQwLDcgQEAgRG9jdW1lbnRGcmFnbWVudDo6RG9jdW1lbnRGcmFnbWVudChEb2N1bWVudCog ZG9jdW1lbnQsIENvbnN0cnVjdGlvblR5cGUgY29uc3RydWMKIAogUGFzc1JlZlB0cjxEb2N1bWVu dEZyYWdtZW50PiBEb2N1bWVudEZyYWdtZW50OjpjcmVhdGUoRG9jdW1lbnQqIGRvY3VtZW50KQog ewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgRG9jdW1lbnRGcmFnbWVudChkb2N1bWVudCkpOwor ICAgIHJldHVybiBhZG9wdFJlZihuZXcgRG9jdW1lbnRGcmFnbWVudChkb2N1bWVudCwgTm9kZTo6 Q3JlYXRlRG9jdW1lbnRGcmFnbWVudCkpOwogfQogCiBTdHJpbmcgRG9jdW1lbnRGcmFnbWVudDo6 bm9kZU5hbWUoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 RnJhZ21lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudEZyYWdtZW50LmgKaW5kZXgg M2FmNWYxYjI4ZmFhMWJlYTgzZjc3NTBmZGQxZTdmZmYzN2VhMzRkMy4uODFhZWI4YWQ4OWE1Mzc4 NGFhYzdlYzM0Y2I1OWM5ZTBkM2RlOThkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50RnJhZ21lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRGcmFn bWVudC5oCkBAIC00Niw2ICs0Niw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBOb2RlVHlwZSBu b2RlVHlwZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxOb2RlPiBjbG9uZU5vZGUo Ym9vbCBkZWVwKTsKICAgICB2aXJ0dWFsIGJvb2wgY2hpbGRUeXBlQWxsb3dlZChOb2RlVHlwZSkg Y29uc3Q7CisgICAgdmlydHVhbCBib29sIGRvY3VtZW50RnJhZ21lbnRJc1NoYWRvd1Jvb3QoKSBj b25zdCBPVkVSUklERSB7IHJldHVybiBmYWxzZTsgfQogfTsKIAogfSAvL25hbWVzcGFjZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L05vZGUuY3BwCmluZGV4IDg1MDE0Yzk0ZmViNjEyODgwNTAwNzQyMDE0ZTRkMGNmYTlmOWVmZjQu LjZjM2E5Yjk5Y2IxYTYyMDk3MjNjZjZiZWE4MThkY2EyMjAyZDBiZDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5j cHAKQEAgLTk1NCw2ICs5NTQsMTIgQEAgYm9vbCBOb2RlOjppc01vdXNlRm9jdXNhYmxlKCkgY29u c3QKICAgICByZXR1cm4gaXNGb2N1c2FibGUoKTsKIH0KIAorYm9vbCBOb2RlOjpkb2N1bWVudEZy YWdtZW50SXNTaGFkb3dSb290KCkgY29uc3QKK3sKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICByZXR1cm4gZmFsc2U7Cit9CisKIE5vZGUqIE5vZGU6OmZvY3VzRGVsZWdhdGUoKQogewog ICAgIHJldHVybiB0aGlzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggOThjMTlmZDQ5NWQyNTE4N2QyODExNDE3 NDBhZTM4NjVmNmYxZjdjMy4uNTFiYTNiMjIxYTkyYjQzMWYzNmIyNDYzOTQ0MzZmYzk5MGRmOGQz OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5oCkBAIC0yMzMsOCArMjMzLDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IGJvb2wgaXNDaGFyYWN0ZXJEYXRhTm9kZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAg dmlydHVhbCBib29sIGlzRnJhbWVPd25lckVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsg fQogICAgIHZpcnR1YWwgYm9vbCBpc1BsdWdpbkVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBkb2N1bWVudEZyYWdtZW50SXNTaGFkb3dSb290KCkgY29u c3Q7CiAgICAgYm9vbCBpc0RvY3VtZW50Tm9kZSgpIGNvbnN0OwotICAgIGJvb2wgaXNTaGFkb3dS b290KCkgY29uc3QgeyByZXR1cm4gZ2V0RmxhZyhJc1NoYWRvd1Jvb3RGbGFnKTsgfQorICAgIGJv b2wgaXNEb2N1bWVudEZyYWdtZW50KCkgY29uc3QgeyByZXR1cm4gZ2V0RmxhZyhJc0RvY3VtZW50 RnJhZ21lbnRGbGFnKTsgfQorICAgIGJvb2wgaXNTaGFkb3dSb290KCkgY29uc3QgeyByZXR1cm4g aXNEb2N1bWVudEZyYWdtZW50KCkgJiYgZG9jdW1lbnRGcmFnbWVudElzU2hhZG93Um9vdCgpOyB9 CiAgICAgYm9vbCBpc0luc2VydGlvblBvaW50KCkgY29uc3QgeyByZXR1cm4gZ2V0RmxhZyhJc0lu c2VydGlvblBvaW50RmxhZyk7IH0KICAgICBib29sIGluTmFtZWRGbG93KCkgY29uc3QgeyByZXR1 cm4gZ2V0RmxhZyhJbk5hbWVkRmxvd0ZsYWcpOyB9CiAgICAgYm9vbCBoYXNDdXN0b21DYWxsYmFj a3MoKSBjb25zdCB7IHJldHVybiBnZXRGbGFnKEhhc0N1c3RvbUNhbGxiYWNrc0ZsYWcpOyB9CkBA IC02OTksNyArNzAxLDcgQEAgcHJpdmF0ZToKICAgICAgICAgSXNIb3ZlcmVkRmxhZyA9IDEgPDwg MTEsCiAgICAgICAgIEluQWN0aXZlQ2hhaW5GbGFnID0gMSA8PCAxMiwKICAgICAgICAgSGFzUmFy ZURhdGFGbGFnID0gMSA8PCAxMywKLSAgICAgICAgSXNTaGFkb3dSb290RmxhZyA9IDEgPDwgMTQs CisgICAgICAgIElzRG9jdW1lbnRGcmFnbWVudEZsYWcgPSAxIDw8IDE0LAogCiAgICAgICAgIC8v IFRoZXNlIGJpdHMgYXJlIHVzZWQgYnkgZGVyaXZlZCBjbGFzc2VzLCBwdWxsZWQgdXAgaGVyZSBz byB0aGV5IGNhbgogICAgICAgICAvLyBiZSBzdG9yZWQgaW4gdGhlIHNhbWUgbWVtb3J5IHdvcmQg YXMgdGhlIE5vZGUgYml0cyBhYm92ZS4KQEAgLTczOCw3ICs3NDAsOCBAQCBwcm90ZWN0ZWQ6CiAg ICAgICAgIENyZWF0ZVRleHQgPSBEZWZhdWx0Tm9kZUZsYWdzIHwgSXNUZXh0RmxhZywKICAgICAg ICAgQ3JlYXRlQ29udGFpbmVyID0gRGVmYXVsdE5vZGVGbGFncyB8IElzQ29udGFpbmVyRmxhZywg CiAgICAgICAgIENyZWF0ZUVsZW1lbnQgPSBDcmVhdGVDb250YWluZXIgfCBJc0VsZW1lbnRGbGFn LCAKLSAgICAgICAgQ3JlYXRlU2hhZG93Um9vdCA9IENyZWF0ZUNvbnRhaW5lciB8IElzU2hhZG93 Um9vdEZsYWcsCisgICAgICAgIENyZWF0ZVNoYWRvd1Jvb3QgPSBDcmVhdGVDb250YWluZXIgfCBJ c0RvY3VtZW50RnJhZ21lbnRGbGFnLAorICAgICAgICBDcmVhdGVEb2N1bWVudEZyYWdtZW50ID0g Q3JlYXRlQ29udGFpbmVyIHwgSXNEb2N1bWVudEZyYWdtZW50RmxhZywKICAgICAgICAgQ3JlYXRl U3R5bGVkRWxlbWVudCA9IENyZWF0ZUVsZW1lbnQgfCBJc1N0eWxlZEVsZW1lbnRGbGFnLCAKICAg ICAgICAgQ3JlYXRlSFRNTEVsZW1lbnQgPSBDcmVhdGVTdHlsZWRFbGVtZW50IHwgSXNIVE1MRmxh ZywgCiAgICAgICAgIENyZWF0ZUZyYW1lT3duZXJFbGVtZW50ID0gQ3JlYXRlSFRNTEVsZW1lbnQg fCBIYXNDdXN0b21DYWxsYmFja3NGbGFnLApAQCAtODU1LDcgKzg1OCw3IEBAIGlubGluZSB2b2lk IGFkZFN1YnJlc291cmNlVVJMKExpc3RIYXNoU2V0PEtVUkw+JiB1cmxzLCBjb25zdCBLVVJMJiB1 cmwpCiAKIGlubGluZSBDb250YWluZXJOb2RlKiBOb2RlOjpwYXJlbnROb2RlKCkgY29uc3QKIHsK LSAgICByZXR1cm4gZ2V0RmxhZyhJc1NoYWRvd1Jvb3RGbGFnKSA/IDAgOiBwYXJlbnQoKTsKKyAg ICByZXR1cm4gaXNTaGFkb3dSb290KCkgPyAwIDogcGFyZW50KCk7CiB9CiAKIGlubGluZSB2b2lk IE5vZGU6OnNldFBhcmVudE9ySG9zdE5vZGUoQ29udGFpbmVyTm9kZSogcGFyZW50KQpAQCAtODcw LDcgKzg3Myw3IEBAIGlubGluZSBDb250YWluZXJOb2RlKiBOb2RlOjpwYXJlbnRPckhvc3ROb2Rl KCkgY29uc3QKIAogaW5saW5lIENvbnRhaW5lck5vZGUqIE5vZGU6OnBhcmVudE5vZGVHdWFyYW50 ZWVkSG9zdEZyZWUoKSBjb25zdAogewotICAgIEFTU0VSVCghZ2V0RmxhZyhJc1NoYWRvd1Jvb3RG bGFnKSk7CisgICAgQVNTRVJUKCFpc1NoYWRvd1Jvb3QoKSk7CiAgICAgcmV0dXJuIHBhcmVudE9y SG9zdE5vZGUoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jv b3QuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKaW5kZXggMDY3NTQyN2VjNGMw OTJjYzYzZTVhODJlYzhkNWMzZjg5MGI2ZDhmOC4uYTU1ZDA2MjUxZWExNWYzMzEyMTM1YjY1ZGEz MzBjMjVkZjVmYjJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3Qu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oCkBAIC0xMTksNiArMTE5LDcg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8Tm9kZT4gY2xvbmVOb2RlKGJvb2wg ZGVlcCk7CiAgICAgdmlydHVhbCBib29sIGNoaWxkVHlwZUFsbG93ZWQoTm9kZVR5cGUpIGNvbnN0 OwogICAgIHZpcnR1YWwgdm9pZCBjaGlsZHJlbkNoYW5nZWQoYm9vbCBjaGFuZ2VkQnlQYXJzZXIs IE5vZGUqIGJlZm9yZUNoYW5nZSwgTm9kZSogYWZ0ZXJDaGFuZ2UsIGludCBjaGlsZENvdW50RGVs dGEpIE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBkb2N1bWVudEZyYWdtZW50SXNTaGFkb3dS b290KCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgdm9pZCBzZXRUeXBl KFNoYWRvd1Jvb3RUeXBlIHR5cGUpIHsgbV9pc0F1dGhvclNoYWRvd1Jvb3QgPSB0eXBlID09IEF1 dGhvclNoYWRvd1Jvb3Q7IH0KIAo=