103330 2012-11-26 17:14:05 -0800 [V8] Refactor WorkerScriptController 2012-11-26 17:51:11 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth webkit.review.bot oldest_to_newest 776104 0 haraken 2012-11-26 17:14:05 -0800 r135703 just moved methods from WorkerContextExecutionProxy to WorkerScriptController. We should refactor the methods as a follow-up. 776106 1 176120 haraken 2012-11-26 17:15:31 -0800 Created attachment 176120 Patch 776137 2 176120 webkit.review.bot 2012-11-26 17:51:08 -0800 Comment on attachment 176120 Patch Clearing flags on attachment: 176120 Committed r135792: <http://trac.webkit.org/changeset/135792> 776138 3 webkit.review.bot 2012-11-26 17:51:11 -0800 All reviewed patches have been landed. Closing bug. 176120 2012-11-26 17:15:31 -0800 2012-11-26 17:51:08 -0800 Patch bug-103330-20121127101308.patch text/plain 5564 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMyNWFiMjllOTUyMTY5 NWQwNDM4NzQyNzQxYzJlZGYzOWI1MTAzNC4uYzY2NTc1YTczNDE2NTU4MzJjODYwMjc0NzdlNGNi ODFiNjZhMDcwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTI2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlZmFjdG9y IFdvcmtlclNjcmlwdENvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzMzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIHIxMzU3MDMganVzdCBtb3ZlZCBtZXRob2RzIGZyb20gV29ya2VyQ29u dGV4dEV4ZWN1dGlvblByb3h5CisgICAgICAgIHRvIFdvcmtlclNjcmlwdENvbnRyb2xsZXIuIFdl IHNob3VsZCByZWZhY3RvciB0aGUgbWV0aG9kcyBhcyBhIGZvbGxvdy11cC4KKworICAgICAgICBO byB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvdjgv V29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJTY3Jp cHRDb250cm9sbGVyOjp+V29ya2VyU2NyaXB0Q29udHJvbGxlcik6CisgICAgICAgIChXZWJDb3Jl OjpXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpkaXNwb3NlQ29udGV4dCk6CisgICAgICAgIChXZWJD b3JlOjpXb3JrZXJTY3JpcHRDb250cm9sbGVyOjppbml0aWFsaXplQ29udGV4dElmTmVlZGVkKToK KyAgICAgICAgKFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKToKKyAg ICAgICAgKFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmRpc2FibGVFdmFsKToKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmg6CisgICAgICAgIChX b3JrZXJTY3JpcHRDb250cm9sbGVyKToKKwogMjAxMi0xMS0yNiAgQW5kcmVhcyBLbGluZyAgPGFr bGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuZGVyU3R5bGU6IE1vdmUgJ2xpc3Qtc3R5bGUt aW1hZ2UnIHRvIHJhcmUgaW5oZXJpdGVkIGRhdGEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCmluZGV4IDQxNTU0MzlhNTYy MTRjMWNmZWRiNTViZjI0ZmYzMTkxNTgzMmE5NGMuLjY3ODhjMjZiMDIxZTEzZmNhZDAyZjA5MGJm NzFhNmU0YzA4NDVjN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dv cmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC03OSwxOSArNzksMTkgQEAgV29ya2VyU2Ny aXB0Q29udHJvbGxlcjo6fldvcmtlclNjcmlwdENvbnRyb2xsZXIoKQogICAgIC8vIFNlZSBodHRw Oi8vd2Via2l0Lm9yZy9iLzgzMTA0I2MxNCBmb3Igd2h5IHRoaXMgaXMgaGVyZS4KICAgICBXZWJL aXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmRpZFN0b3BXb3JrZXJSdW5Mb29wKFdlYktpdDo6V2Vi V29ya2VyUnVuTG9vcCgmbV93b3JrZXJDb250ZXh0LT50aHJlYWQoKS0+cnVuTG9vcCgpKSk7CiAj ZW5kaWYKLSAgICBkaXNwb3NlKCk7CisgICAgZGlzcG9zZUNvbnRleHQoKTsKICAgICBWOFBlcklz b2xhdGVEYXRhOjpkaXNwb3NlKG1faXNvbGF0ZSk7CiAgICAgbV9pc29sYXRlLT5FeGl0KCk7CiAg ICAgbV9pc29sYXRlLT5EaXNwb3NlKCk7CiB9CiAKLXZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxl cjo6ZGlzcG9zZSgpCit2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmRpc3Bvc2VDb250ZXh0 KCkKIHsKICAgICBtX3BlckNvbnRleHREYXRhLmNsZWFyKCk7CiAgICAgbV9jb250ZXh0LmNsZWFy KCk7CiB9CiAKLWJvb2wgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUlmTmVlZGVk KCkKK2Jvb2wgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUNvbnRleHRJZk5lZWRl ZCgpCiB7CiAgICAgaWYgKCFtX2NvbnRleHQuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gdHJ1 ZTsKQEAgLTEwOCw3ICsxMDgsNyBAQCBib29sIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmluaXRp YWxpemVJZk5lZWRlZCgpCiAKICAgICBtX3BlckNvbnRleHREYXRhID0gVjhQZXJDb250ZXh0RGF0 YTo6Y3JlYXRlKG1fY29udGV4dC5nZXQoKSk7CiAgICAgaWYgKCFtX3BlckNvbnRleHREYXRhLT5p bml0KCkpIHsKLSAgICAgICAgZGlzcG9zZSgpOworICAgICAgICBkaXNwb3NlQ29udGV4dCgpOwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCkBAIC0xMjQsNyArMTI0LDcgQEAgYm9vbCBX b3JrZXJTY3JpcHRDb250cm9sbGVyOjppbml0aWFsaXplSWZOZWVkZWQoKQogICAgIHY4OjpIYW5k bGU8djg6OkZ1bmN0aW9uPiB3b3JrZXJDb250ZXh0Q29uc3RydWN0b3IgPSBtX3BlckNvbnRleHRE YXRhLT5jb25zdHJ1Y3RvckZvclR5cGUoY29udGV4dFR5cGUpOwogICAgIHY4OjpMb2NhbDx2ODo6 T2JqZWN0PiBqc1dvcmtlckNvbnRleHQgPSBWOE9iamVjdENvbnN0cnVjdG9yOjpuZXdJbnN0YW5j ZSh3b3JrZXJDb250ZXh0Q29uc3RydWN0b3IpOwogICAgIGlmIChqc1dvcmtlckNvbnRleHQuSXNF bXB0eSgpKSB7Ci0gICAgICAgIGRpc3Bvc2UoKTsKKyAgICAgICAgZGlzcG9zZUNvbnRleHQoKTsK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApAQCAtMTQzLDcgKzE0Myw3IEBAIFNjcmlw dFZhbHVlIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFN0cmluZyYgc2Ny aXB0LCBjb25zdCBTdHJpbmcmCiAKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CiAK LSAgICBpZiAoIWluaXRpYWxpemVJZk5lZWRlZCgpKQorICAgIGlmICghaW5pdGlhbGl6ZUNvbnRl eHRJZk5lZWRlZCgpKQogICAgICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKIAogICAgIGlmICgh bV9kaXNhYmxlRXZhbFBlbmRpbmcuaXNFbXB0eSgpKSB7CkBAIC0xODYsMTYgKzE4Niw2IEBAIFNj cmlwdFZhbHVlIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFN0cmluZyYg c2NyaXB0LCBjb25zdCBTdHJpbmcmCiAgICAgcmV0dXJuIFNjcmlwdFZhbHVlKHJlc3VsdCk7CiB9 CiAKLXZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6c2V0RXZhbEFsbG93ZWQoYm9vbCBlbmFi bGUsIGNvbnN0IFN0cmluZyYgZXJyb3JNZXNzYWdlKQotewotICAgIG1fZGlzYWJsZUV2YWxQZW5k aW5nID0gZW5hYmxlID8gU3RyaW5nKCkgOiBlcnJvck1lc3NhZ2U7Ci19Ci0KLXZvaWQgV29ya2Vy U2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYgc291cmNl Q29kZSkKLXsKLSAgICBldmFsdWF0ZShzb3VyY2VDb2RlLCAwKTsKLX0KLQogdm9pZCBXb3JrZXJT Y3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VD b2RlLCBTY3JpcHRWYWx1ZSogZXhjZXB0aW9uKQogewogICAgIGlmIChpc0V4ZWN1dGlvbkZvcmJp ZGRlbigpKQpAQCAtMjQ0LDcgKzIzNCw3IEBAIGJvb2wgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6 aXNFeGVjdXRpb25Gb3JiaWRkZW4oKSBjb25zdAogCiB2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xs ZXI6OmRpc2FibGVFdmFsKGNvbnN0IFN0cmluZyYgZXJyb3JNZXNzYWdlKQogewotICAgIHNldEV2 YWxBbGxvd2VkKGZhbHNlLCBlcnJvck1lc3NhZ2UpOworICAgIG1fZGlzYWJsZUV2YWxQZW5kaW5n ID0gZXJyb3JNZXNzYWdlOwogfQogCiB2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OnNldEV4 Y2VwdGlvbihjb25zdCBTY3JpcHRWYWx1ZSYgZXhjZXB0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5oIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxlci5oCmluZGV4IDA4YmQxNDVm YzJlY2RkZTc0NDkyZjdlNGQxNDVkODM0ZjIwZTE0ZjAuLmQwYTYyMTAwZGM0ZjBmNWRkYjU3YWMz NTdhNjU4ODdlN2FkOTdlM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmgKQEAgLTY3LDggKzY3LDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogCiAgICAgICAgIFdvcmtlckNvbnRleHQqIHdvcmtlckNvbnRleHQoKSB7IHJldHVy biBtX3dvcmtlckNvbnRleHQ7IH0KIAotICAgICAgICB2b2lkIGV2YWx1YXRlKGNvbnN0IFNjcmlw dFNvdXJjZUNvZGUmKTsKLSAgICAgICAgdm9pZCBldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VD b2RlJiwgU2NyaXB0VmFsdWUqIGV4Y2VwdGlvbik7CisgICAgICAgIHZvaWQgZXZhbHVhdGUoY29u c3QgU2NyaXB0U291cmNlQ29kZSYsIFNjcmlwdFZhbHVlKiA9IDApOwogCiAgICAgICAgIHZvaWQg c2V0RXhjZXB0aW9uKGNvbnN0IFNjcmlwdFZhbHVlJik7CiAKQEAgLTg3LDkgKzg2LDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgZGlzYWJsZUV2YWwoY29uc3QgU3RyaW5n Jik7CiAKLSAgICAgICAgLy8gQWxvdyB1c2Ugb2YgZXZhbCgpIGFuZCBpcyBlcXVpdmFsZW50cyBp biBzY3JpcHRzLgotICAgICAgICB2b2lkIHNldEV2YWxBbGxvd2VkKGJvb2wgZW5hYmxlLCBjb25z dCBTdHJpbmcmKTsKLQogICAgICAgICAvLyBSZXR1cm5zIFdvcmtlclNjcmlwdENvbnRyb2xsZXIg Zm9yIHRoZSBjdXJyZW50bHkgZXhlY3V0aW5nIGNvbnRleHQuIDAgd2lsbCBiZSByZXR1cm5lZCBp ZiB0aGUgY3VycmVudCBleGVjdXRpbmcgY29udGV4dCBpcyBub3QgdGhlIHdvcmtlciBjb250ZXh0 LgogICAgICAgICBzdGF0aWMgV29ya2VyU2NyaXB0Q29udHJvbGxlciogY29udHJvbGxlckZvckNv bnRleHQoKTsKIApAQCAtMTAwLDggKzk2LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAg ICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQoKSB7IHJldHVybiB2ODo6TG9jYWw8djg6 OkNvbnRleHQ+OjpOZXcobV9jb250ZXh0LmdldCgpKTsgfQogCiAgICAgcHJpdmF0ZToKLSAgICAg ICAgYm9vbCBpbml0aWFsaXplSWZOZWVkZWQoKTsKLSAgICAgICAgdm9pZCBkaXNwb3NlKCk7Cisg ICAgICAgIGJvb2wgaW5pdGlhbGl6ZUNvbnRleHRJZk5lZWRlZCgpOworICAgICAgICB2b2lkIGRp c3Bvc2VDb250ZXh0KCk7CiAKICAgICAgICAgV29ya2VyQ29udGV4dCogbV93b3JrZXJDb250ZXh0 OwogICAgICAgICB2ODo6SXNvbGF0ZSogbV9pc29sYXRlOwo=