103321 2012-11-26 16:51:42 -0800 New check for usesTileCacheLayer on Windows needed after r133056 2012-11-28 11:43:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 roger_fong webkit-unassigned rniwa roger_fong simon.fraser oldest_to_newest 776071 0 roger_fong 2012-11-26 16:51:42 -0800 After r133056 it no longer suffices to check use the existing usesTileCacheLayer method on Windows. The change resulted in 3 crashing tests: compositing/rotated-tiled-clamped compositing/rotated-tiled-preserve3d-clamped fast/events/tabindex-focus-blur-all We should add in platform specific method for Windows that returns false for this method. In addition, compositing/rotated-tiled-clamped compositing/rotated-tiled-preserve3d-clamped need to be removed from the Windows skip list and Windows specific results are needed since they were newly added tests with r133056. 776088 1 176115 roger_fong 2012-11-26 17:02:11 -0800 Created attachment 176115 patch 777063 2 rniwa 2012-11-27 11:57:35 -0800 This patch appears to have broken Mac builds: http://trac.webkit.org/changeset/135890 http://build.webkit.org/builders/Apple%20Lion%20Debug%20%28Build%29/builds/8405 #elif ^ /Volumes/Data/slave/lion-debug/build/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1055:21: error: no member named 'usesTileCacheLayer' in 'WebCore::PlatformCALayer' ASSERT(m_layer->usesTileCacheLayer()); ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ /Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug/usr/local/include/wtf/Assertions.h:247:8: note: expanded from macro 'ASSERT' (!(assertion) ? \ ^ /Volumes/Data/slave/lion-debug/build/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1607:19: error: no member named 'usesTileCacheLayer' in 'WebCore::PlatformCALayer' if (!m_layer->usesTileCacheLayer()) ~~~~~~~ ^ 777074 3 rniwa 2012-11-27 12:01:49 -0800 Build fix landed in http://trac.webkit.org/changeset/135895. 176115 2012-11-26 17:02:11 -0800 2012-11-26 18:09:31 -0800 patch tile_patch.txt text/plain 7071 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTc4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTI2ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2luZG93cyBzcGVjaWZpYyBp bXBsZW1lbnRhdGlvbiBvZiB1c2VzVGlsZUNhY2hlTGF5ZXIgbmVlZGVkIGFmdGVyIHIxMzMwNTYu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMzMjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBy MTMzMDU2IGl0IG5vIGxvbmdlciBzdWZmaWNlcyB0byB1c2UgdGhlIGV4aXN0aW5nIHVzZXNUaWxl Q2FjaGVMYXllciBtZXRob2Qgb24gV2luZG93cy4KKyAgICAgICAgVGhlIGNoYW5nZSByZXN1bHRl ZCBpbiAzIGNyYXNoaW5nIHRlc3RzOgorICAgICAgICBjb21wb3NpdGluZy9yb3RhdGVkLXRpbGVk LWNsYW1wZWQKKyAgICAgICAgY29tcG9zaXRpbmcvcm90YXRlZC10aWxlZC1wcmVzZXJ2ZTNkLWNs YW1wZWQKKyAgICAgICAgZmFzdC9ldmVudHMvdGFiaW5kZXgtZm9jdXMtYmx1ci1hbGwKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL1BsYXRmb3JtQ0FMYXllci5oOgorICAgICAgICAo V2ViQ29yZTo6UGxhdGZvcm1DQUxheWVyOjp1c2VzVGlsZUNhY2hlTGF5ZXIpOgorICAgICAgICAo UGxhdGZvcm1DQUxheWVyKTogCisgICAgICAgIEFkZGluZyBpbiBwbGF0Zm9ybSBzcGVjaWZpYyBt ZXRob2QgZm9yIFdpbmRvd3MgdGhhdCByZXR1cm5zIGZhbHNlIGZvciB0aGlzIG1ldGhvZC4KKwog MjAxMi0xMS0yNiAgSmFtZXMgU2ltb25zZW4gIDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ29uc29saWRhdGUgRnJhbWVMb2FkZXI6OmxvYWQoKSBpbnRvIG9uZSBmdW5jdGlvbiB0 YWtpbmcgYSBGcmFtZUxvYWRSZXF1ZXN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9QbGF0Zm9ybUNBTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBTGF5ZXIuaAkocmV2aXNpb24gMTM1NzY1 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvUGxhdGZvcm1DQUxheWVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTgwLDcgKzgwLDExIEBAIHB1YmxpYzoKICAgICAKICAgICBQ bGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKCkgY29uc3Q7CiAKKyNpZiBQTEFURk9STShXSU4p CisgICAgYm9vbCB1c2VzVGlsZUNhY2hlTGF5ZXIoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQor I2VsaWYKICAgICBib29sIHVzZXNUaWxlQ2FjaGVMYXllcigpIGNvbnN0IHsgcmV0dXJuIG1fbGF5 ZXJUeXBlID09IExheWVyVHlwZVBhZ2VUaWxlQ2FjaGVMYXllciB8fCBtX2xheWVyVHlwZSA9PSBM YXllclR5cGVUaWxlQ2FjaGVMYXllcjsgfQorI2VuZGlmCiAKICAgICBQbGF0Zm9ybUNBTGF5ZXIq IHJvb3RMYXllcigpIGNvbnN0OwogICAgIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTM1Nzg2KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIw MTItMTEtMjYgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KKworICAgICAgICBX aW5kb3dzIHNwZWNpZmljIGltcGxlbWVudGF0aW9uIG9mIHVzZXNUaWxlQ2FjaGVMYXllciBuZWVk ZWQgYWZ0ZXIgcjEzMzA1Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMzMyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFmdGVyIHIxMzMwNTYgaXQgbm8gbG9uZ2VyIHN1ZmZpY2VzIHRvIHVzZSB0aGUg ZXhpc3RpbmcgdXNlc1RpbGVDYWNoZUxheWVyIG1ldGhvZCBvbiBXaW5kb3dzLgorICAgICAgICBU aGUgY2hhbmdlIHJlc3VsdGVkIGluIDMgY3Jhc2hpbmcgdGVzdHM6CisgICAgICAgIGNvbXBvc2l0 aW5nL3JvdGF0ZWQtdGlsZWQtY2xhbXBlZAorICAgICAgICBjb21wb3NpdGluZy9yb3RhdGVkLXRp bGVkLXByZXNlcnZlM2QtY2xhbXBlZAorICAgICAgICBmYXN0L2V2ZW50cy90YWJpbmRleC1mb2N1 cy1ibHVyLWFsbAorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnM6IAor ICAgICAgICBSZW1vdmUgdGhlIHRlc3RzIGJlbG93IGZyb20gdGhlIFdpbmRvd3Mgc2tpcCBsaXN0 LiAKKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9jb21wb3NpdGluZy90aWxpbmcvcm90YXRlZC10 aWxlZC1jbGFtcGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vd2lu L2NvbXBvc2l0aW5nL3RpbGluZy9yb3RhdGVkLXRpbGVkLXByZXNlcnZlM2QtY2xhbXBlZC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICBBZGQgV2luZG93cyBzcGVjaWZpYyByZXN1bHRzIGZv ciB0ZXN0cyBhZGRlZCBpbiByMTMzMDU2LgorCiAyMDEyLTExLTI2ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gU2tpcHBpbmcgc29tZSBj b21wb3NpdGluZy90aWxpbmcgdGVzdHMgb24gV2luZG93cyBiZWNhdXNlIHRpbGVkIGJhY2tpbmcg aXMgbm90IHN1cHBvcnRlZC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhw ZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhw ZWN0YXRpb25zCShyZXZpc2lvbiAxMzU3ODMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v VGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjQzOCw3ICsyNDM4LDMgQEAgZmFz dC9jc3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vZ2V0QwogIyBBQ0NFTEVSQVRFRF9PVkVS RkxPV19TQ1JPTExJTkcgaXMgZGlzYWJsZWQgb24gV2luZG93cwogY29tcG9zaXRpbmcvb3ZlcmZs b3cvc2Nyb2xsaW5nLXdpdGhvdXQtcGFpbnRpbmcuaHRtbAogY29tcG9zaXRpbmcvb3ZlcmZsb3cv dXBkYXRpbmctc2Nyb2xsaW5nLWNvbnRlbnQuaHRtbAotCi0jIFNraXAgc29tZSBjb21wb3NpdGlu Zy90aWxpbmcgdGVzdHMgYWZ0ZXIgcjEzMzA1NgotY29tcG9zaXRpbmcvdGlsaW5nL3JvdGF0ZWQt dGlsZWQtcHJlc2VydmUzZC1jbGFtcGVkLmh0bWwKLWNvbXBvc2l0aW5nL3RpbGluZy9yb3RhdGVk LXRpbGVkLWNsYW1wZWQuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2NvbXBv c2l0aW5nL3RpbGluZy9yb3RhdGVkLXRpbGVkLWNsYW1wZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9jb21wb3NpdGluZy90aWxpbmcvcm90YXRl ZC10aWxlZC1jbGFtcGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL3dpbi9jb21wb3NpdGluZy90aWxpbmcvcm90YXRlZC10aWxlZC1jbGFtcGVkLWV4 cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM3IEBACisoR3JhcGhpY3NMYXll cgorICAoYm91bmRzIDgwMC4wMCA2MDAuMDApCisgICh2aXNpYmxlIHJlY3QgMC4wMCwgMC4wMCA4 MDAuMDAgeCA2MDAuMDApCisgIChjaGlsZHJlbiAxCisgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAg IChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgICAgICh2aXNpYmxlIHJlY3QgMC4wMCwgMC4wMCA4 MDAuMDAgeCA2MDAuMDApCisgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAoR3JhcGhpY3NMYXll cgorICAgICAgICAgIChwb3NpdGlvbiA1OC4wMCA1MC4wMCkKKyAgICAgICAgICAoYm91bmRzIDUw Mi4wMCAzMDIuMDApCisgICAgICAgICAgKHZpc2libGUgcmVjdCAwLjAwLCAwLjAwIDUwMi4wMCB4 IDMwMi4wMCkKKyAgICAgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAgICAgKEdyYXBoaWNzTGF5 ZXIKKyAgICAgICAgICAgICAgKHBvc2l0aW9uIDEuMDAgMS4wMCkKKyAgICAgICAgICAgICAgKGJv dW5kcyA1MDAuMDAgMzAwLjAwKQorICAgICAgICAgICAgICAoY2hpbGRyZW5UcmFuc2Zvcm0gWzEu MDAgMC4wMCAwLjAwIDAuMDBdIFswLjAwIDEuMDAgMC4wMCAwLjAwXSBbMC4wMCAwLjAwIDEuMDAg LTAuMDBdIFswLjAwIDAuMDAgMC4wMCAxLjAwXSkKKyAgICAgICAgICAgICAgKHZpc2libGUgcmVj dCAwLjAwLCAwLjAwIDUwMC4wMCB4IDMwMC4wMCkKKyAgICAgICAgICAgICAgKGNoaWxkcmVuIDEK KyAgICAgICAgICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgICAgICAgICAgKHBvc2l0 aW9uIC0xMjUwLjAwIDAuMDApCisgICAgICAgICAgICAgICAgICAoYW5jaG9yIDAuNTQgMC41MCkK KyAgICAgICAgICAgICAgICAgIChib3VuZHMgMjgwMC4wMCAzMDAuMDApCisgICAgICAgICAgICAg ICAgICAodXNpbmdUaWxlZExheWVyIDEpCisgICAgICAgICAgICAgICAgICAoZHJhd3NDb250ZW50 IDEpCisgICAgICAgICAgICAgICAgICAodHJhbnNmb3JtIFswLjE3IDAuMDAgLTAuOTggMC4wMF0g WzAuMDAgMS4wMCAwLjAwIDAuMDBdIFswLjk4IDAuMDAgMC4xNyAwLjAwXSBbMC4wMCAwLjAwIDAu MDAgMS4wMF0pCisgICAgICAgICAgICAgICAgICAodmlzaWJsZSByZWN0IDAuMDAsIDAuMDAgMjgw MC4wMCB4IDMwMC4wMCkKKyAgICAgICAgICAgICAgICApCisgICAgICAgICAgICAgICkKKyAgICAg ICAgICAgICkKKyAgICAgICAgICApCisgICAgICAgICkKKyAgICAgICkKKyAgICApCisgICkKKykK KwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2NvbXBvc2l0aW5nL3RpbGluZy9yb3Rh dGVkLXRpbGVkLXByZXNlcnZlM2QtY2xhbXBlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2NvbXBvc2l0aW5nL3RpbGluZy9yb3RhdGVkLXRpbGVk LXByZXNlcnZlM2QtY2xhbXBlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS93aW4vY29tcG9zaXRpbmcvdGlsaW5nL3JvdGF0ZWQtdGlsZWQtcHJlc2Vy dmUzZC1jbGFtcGVkLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQ0IEBA CisoR3JhcGhpY3NMYXllcgorICAoYm91bmRzIDgwMC4wMCA2MDAuMDApCisgICh2aXNpYmxlIHJl Y3QgMC4wMCwgMC4wMCA4MDAuMDAgeCA2MDAuMDApCisgIChjaGlsZHJlbiAxCisgICAgKEdyYXBo aWNzTGF5ZXIKKyAgICAgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgICAgICh2aXNpYmxlIHJl Y3QgMC4wMCwgMC4wMCA4MDAuMDAgeCA2MDAuMDApCisgICAgICAoY2hpbGRyZW4gMQorICAgICAg ICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiA1OC4wMCA1MC4wMCkKKyAgICAg ICAgICAoYm91bmRzIDUwMi4wMCAzMDIuMDApCisgICAgICAgICAgKHZpc2libGUgcmVjdCAwLjAw LCAwLjAwIDUwMi4wMCB4IDMwMi4wMCkKKyAgICAgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAg ICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAgICAgKHBvc2l0aW9uIDEuMDAgMS4wMCkKKyAg ICAgICAgICAgICAgKGJvdW5kcyA1MDAuMDAgMzAwLjAwKQorICAgICAgICAgICAgICAoY2hpbGRy ZW5UcmFuc2Zvcm0gWzEuMDAgMC4wMCAwLjAwIDAuMDBdIFswLjAwIDEuMDAgMC4wMCAwLjAwXSBb MC4wMCAwLjAwIDEuMDAgLTAuMDBdIFswLjAwIDAuMDAgMC4wMCAxLjAwXSkKKyAgICAgICAgICAg ICAgKHZpc2libGUgcmVjdCAwLjAwLCAwLjAwIDUwMC4wMCB4IDMwMC4wMCkKKyAgICAgICAgICAg ICAgKGNoaWxkcmVuIDEKKyAgICAgICAgICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAg ICAgICAgICAgKGJvdW5kcyA1MDAuMDAgMC4wMCkKKyAgICAgICAgICAgICAgICAgIChwcmVzZXJ2 ZXMzRCAxKQorICAgICAgICAgICAgICAgICAgKHZpc2libGUgcmVjdCAwLjAwLCAwLjAwIDAuMDAg eCAwLjAwKQorICAgICAgICAgICAgICAgICAgKGNoaWxkcmVuIDEKKyAgICAgICAgICAgICAgICAg ICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAgICAgICAgICAgICAocG9zaXRpb24gLTEyNTAu MDAgMC4wMCkKKyAgICAgICAgICAgICAgICAgICAgICAoYW5jaG9yIDAuNTQgMC41MCkKKyAgICAg ICAgICAgICAgICAgICAgICAoYm91bmRzIDI4MDAuMDAgMzAwLjAwKQorICAgICAgICAgICAgICAg ICAgICAgICh1c2luZ1RpbGVkTGF5ZXIgMSkKKyAgICAgICAgICAgICAgICAgICAgICAoZHJhd3ND b250ZW50IDEpCisgICAgICAgICAgICAgICAgICAgICAgKHRyYW5zZm9ybSBbMC4xNyAwLjAwIC0w Ljk4IDAuMDBdIFswLjAwIDEuMDAgMC4wMCAwLjAwXSBbMC45OCAwLjAwIDAuMTcgMC4wMF0gWzAu MDAgMC4wMCAwLjAwIDEuMDBdKQorICAgICAgICAgICAgICAgICAgICAgICh2aXNpYmxlIHJlY3Qg MC4wMCwgMC4wMCAyODAwLjAwIHggMzAwLjAwKQorICAgICAgICAgICAgICAgICAgICApCisgICAg ICAgICAgICAgICAgICApCisgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgICApCisgICAg ICAgICAgICApCisgICAgICAgICAgKQorICAgICAgICApCisgICAgICApCisgICAgKQorICApCisp CisK