103318 2012-11-26 16:32:52 -0800 Don't throw an exception if user gesture is required for load 2012-11-27 09:54:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned dino webkit.review.bot oldest_to_newest 776048 0 qinmin 2012-11-26 16:32:52 -0800 Don't throw an exception if user gesture is required for load 776061 1 176109 qinmin 2012-11-26 16:42:17 -0800 Created attachment 176109 Patch 776873 2 176109 webkit.review.bot 2012-11-27 09:40:11 -0800 Comment on attachment 176109 Patch Clearing flags on attachment: 176109 Committed r135866: <http://trac.webkit.org/changeset/135866> 776874 3 webkit.review.bot 2012-11-27 09:40:14 -0800 All reviewed patches have been landed. Closing bug. 776881 4 dino 2012-11-27 09:45:43 -0800 Source/WebCore/html/HTMLMediaElement.cpp:679:44: error: unused parameter 'ec' 776894 5 dino 2012-11-27 09:54:21 -0800 This broke the Apple builds. Fixed in r135869. This would have been detected by the EWS - please make sure to submit the patches for review there. 176109 2012-11-26 16:42:17 -0800 2012-11-27 09:40:10 -0800 Patch bug-103318-20121126163955.patch text/plain 4140 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI5NTdlYTI3MDU2Nzhi MDM5YjNlYzE1YTRmN2I4ODU5NDkwNGE0NC4uMDUyNjRjNzU3N2NiYzg1ZWY4ZGQ4NTQ1ZjExZDM5 OGRiOTliMmFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTI2ICBNaW4g UWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCB0aHJvdyBhbiBleGNl cHRpb24gaWYgdXNlciBnZXN0dXJlIGlzIHJlcXVpcmVkIGZvciBsb2FkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMzMTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBuZWVkIHRvIHRo cm93IGFuIGV4Y2VwdGlvbiBpZiBtZWRpYSBsb2FkIHJlcXVpcmVzIHVzZXIgZ2VzdHVyZS4KKyAg ICAgICAgU2luY2UgY2hyb21lIGRvZXMgbm90IHJlbmRlciB0aGUgcG9zdGVyIGFuZCBtZWRpYSBj b250cm9sIGFmdGVyIGFuIGV4Y2VwdGlvbiBpcyB0aHJvd24sIHRocm93aW5nIGFuIGV4Y2VwdGlv biBtYXkgYnJlYWsgYSBsb3Qgb2Ygc2l0ZXMgb24gYW5kcm9pZC4KKyAgICAgICAgQ2hhbmdlIGEg Y3VycmVudCB0ZXN0IHRvIG1hdGNoIHRoZSBuZXcgYmVoYXZpb3I6IG1lZGlhL3ZpZGVvLWxvYWQt cmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWQpOgorCiAy MDEyLTExLTI2ICBUYW1hcyBDemVuZSAgPHRjemVuZUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAg ICAgT3BlbkNMIHZlcnNpb24gb2YgU291cmNlQWxwaGEsIFNvdXJjZUdyYXBoaWNzIGFuZCBGRVR1 cmJ1bGVuY2UgZmlsdGVyIGVmZmVjdHMgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcAppbmRleCAwMjdkZDIxZDkxYjcxMzE3ZTI2MTNlODFjMDNlODFlOGM5M2U1YTA2Li5i MmYwZWY3MmM1ZGMyNDI5YmZjMmVjMzdmZmU2YzkxM2NlMWY0ZjkzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTY4MiwxMCArNjgyLDggQEAgdm9pZCBIVE1M TWVkaWFFbGVtZW50Ojpsb2FkKEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIAogICAgIExPRyhNZWRp YSwgIkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWQoKSIpOwogICAgIAotICAgIGlmICh1c2VyR2VzdHVy ZVJlcXVpcmVkRm9yTG9hZCgpICYmICFTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdl c3R1cmUoKSkgewotICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJSOworICAgIGlmICh1c2Vy R2VzdHVyZVJlcXVpcmVkRm9yTG9hZCgpICYmICFTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlc3R1cmUoKSkKICAgICAgICAgcmV0dXJuOwotICAgIH0KICAgICAKICAgICBtX2xvYWRJ bml0aWF0ZWRCeVVzZXJHZXN0dXJlID0gU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJH ZXN0dXJlKCk7CiAgICAgaWYgKG1fbG9hZEluaXRpYXRlZEJ5VXNlckdlc3R1cmUpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MWZhZDM4MDI2YTE0OWZiNWNmOTgxOWI0ZWVmNzJhMDVjNDhmZTM1Mi4uY2FmOTliYWE4ODg2MWYz MDVmZWZjMTE4Mzk2NTBlODU0ZjA4ODM3NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEx LTI2ICBNaW4gUWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCB0aHJv dyBhbiBleGNlcHRpb24gaWYgdXNlciBnZXN0dXJlIGlzIHJlcXVpcmVkIGZvciBsb2FkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMzMTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0aGF0IGV4 Y2VwdGlvbiBpcyBub3QgdGhyb3duIGFuZCBtZXRhZGF0YSBpcyBub3QgbG9hZGVkIGlmIG1lZGlh IGxvYWQgcmVxdWlyZXMgdXNlciBnZXN0dXJlLgorCisgICAgICAgICogbWVkaWEvdmlkZW8tbG9h ZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvdmlk ZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sOgorCiAyMDEyLTExLTI2ICBUaGlhZ28g TWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgogCiAgICAgICAgIElt cG9ydCBtb3JlIENTUyBEZXZpY2UgQWRhcHRhdGlvbiBsYXlvdXQgdGVzdHMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWxvYWQtcmVxdWlyZS11c2VyLWdlc3R1cmUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVy ZS1leHBlY3RlZC50eHQKaW5kZXggM2FhMTg0MmIzMTNhMzRiNjBlNmNjYzYwZTc1MGEzMzQyYjlm YzdhZi4uYmYyMDU3ZTA4YzRhZjY0YWVkNjhkZjUyYWM3YWFiOGRkNjdlYjRmZSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXIt Z2VzdHVyZS1leHBlY3RlZC50eHQKQEAgLTIsOCArMiw3IEBAIFRlc3QgdGhhdCB2aWRlby5sb2Fk KCkgc2hvdWxkIG5vdCBjYXVzZSBtZWRpYSBsb2FkaW5nIHdoZW4gdXNlciBnZXN0dXJlIGlzIHJl cXVpCiAKICogU2V0dGluZyB2aWRlby5zcmMsIG5vIGRhdGEgc2hvdWxkIGxvYWQuCiAKLSogQ2Fs bGluZyB2aWRlby5sb2FkKCkuIEl0IHNob3VsZCB0aHJvdyBhbiBleGNlcHRpb24sIGFuZCBubyBk YXRhIHNob3VsZCBsb2FkLgotVEVTVCh2aWRlby5sb2FkKCkpIFRIUk9XUyhET01FeGNlcHRpb24u SU5WQUxJRF9TVEFURV9FUlIpIE9LCisqIENhbGxpbmcgdmlkZW8ubG9hZCgpIHNob3VsZCBub3Qg bG9hZCBhbnkgZGF0YS4KIAogRU5EIE9GIFRFU1QKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sIGIvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sCmluZGV4IDgxYzViOWM3 OGJhZDJhZGExZjA0ZDdlZDQ2ZTU2ZjQ4Mzg5YTdjMzEuLjgzODg5NzBjNDg3N2QyNGRiZTllZGVj N2YxNDhkYmZhZmUxMzlmNTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWxv YWQtcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRl by1sb2FkLXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwKQEAgLTMxLDggKzMxLDggQEAKICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgc3RhdGUgPSAi bG9hZCI7Ci0gICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIqIENhbGxpbmcgdmlkZW8ubG9h ZCgpLiBJdCBzaG91bGQgdGhyb3cgYW4gZXhjZXB0aW9uLCBhbmQgbm8gZGF0YSBzaG91bGQgbG9h ZC4iKTsKLSAgICAgICAgICAgICAgICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby5sb2FkKCkiLCAiRE9N RXhjZXB0aW9uLklOVkFMSURfU1RBVEVfRVJSIik7CisgICAgICAgICAgICAgICAgY29uc29sZVdy aXRlKCIqIENhbGxpbmcgdmlkZW8ubG9hZCgpIHNob3VsZCBub3QgbG9hZCBhbnkgZGF0YS4iKTsK KyAgICAgICAgICAgICAgICB2aWRlby5sb2FkKCk7CiAgICAgICAgICAgICAgICAgc2V0VGltZW91 dChjaGVja0xvYWQsIDI1MCk7CiAgICAgICAgICAgICB9CiAK