103315 2012-11-26 16:18:18 -0800 HTMLFontElement font size parsing should directly handle 8 bit strings 2012-11-28 15:33:44 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff abarth dglazkov ojan webkit.review.bot oldest_to_newest 776021 0 msaboff 2012-11-26 16:18:18 -0800 parseFontSize() in HTMLFontElement.cpp up converts 8 bit strings in order to parse the font size. 8 bit strings should be handled directly. 776039 1 176106 msaboff 2012-11-26 16:23:38 -0800 Created attachment 176106 Patch 776251 2 176106 webkit.review.bot 2012-11-26 20:28:07 -0800 Comment on attachment 176106 Patch Attachment 176106 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15010022 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 777953 3 abarth 2012-11-28 08:58:05 -0800 > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This seems likely to be a flaky test. 777961 4 abarth 2012-11-28 09:03:59 -0800 I tried this patch locally and this test passed for me. We should probably mark it as flaky in TestExpectations. 778413 5 msaboff 2012-11-28 15:33:44 -0800 Committed r136068: <http://trac.webkit.org/changeset/136068> 176106 2012-11-26 16:23:38 -0800 2012-11-28 14:31:24 -0800 Patch 103315.patch text/plain 2652 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTc4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTI2ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxGb250RWxlbWVudCBm b250IHNpemUgcGFyc2luZyBzaG91bGQgZGlyZWN0bHkgaGFuZGxlIDggYml0IHN0cmluZ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzMxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwbGl0IHBhcnNl Rm9udFNpemUoKSBpbnRvIGEgdGVtcGxhdGVkIGZ1bmN0aW9uIGJhc2VkIG9uIGNoYXJhY3RlciB0 eXBlIGFuZCBhIHdyYXBwZXIgdGhhdCBkZXRlcm1pbmVzCisgICAgICAgIGEgc3RyaW5nJ3MgYml0 bmVzcyBiZWZvcmUgY2FsbGluZyB0aGUgdGVtcGxhdGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGh0bWwvSFRNTEZvbnRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhcnNlRm9udFNpemUpOgorCiAyMDEyLTEx LTI2ICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBD b25zb2xpZGF0ZSBGcmFtZUxvYWRlcjo6bG9hZCgpIGludG8gb25lIGZ1bmN0aW9uIHRha2luZyBh IEZyYW1lTG9hZFJlcXVlc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvbnRFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb250RWxlbWVu dC5jcHAJKHJldmlzaW9uIDEzNTY0MCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvbnRF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsMTMgKzUxLDE0IEBAIFBhc3NSZWZQdHI8 SFRNTEZvbnRFbGVtZW50PiBIVE1MRm9udEVsZW0KIH0KIAogLy8gaHR0cDovL3d3dy53aGF0d2cu b3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2UvcmVuZGVyaW5nLmh0bWwj Zm9udHMtYW5kLWNvbG9ycwotc3RhdGljIGJvb2wgcGFyc2VGb250U2l6ZShjb25zdCBTdHJpbmcm IGlucHV0LCBpbnQmIHNpemUpCit0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KK3N0 YXRpYyBib29sIHBhcnNlRm9udFNpemUoY29uc3QgQ2hhcmFjdGVyVHlwZSogY2hhcmFjdGVycywg dW5zaWduZWQgbGVuZ3RoLCBpbnQmIHNpemUpCiB7CiAKICAgICAvLyBTdGVwIDEKICAgICAvLyBT dGVwIDIKLSAgICBjb25zdCBVQ2hhciogcG9zaXRpb24gPSBpbnB1dC5jaGFyYWN0ZXJzKCk7Ci0g ICAgY29uc3QgVUNoYXIqIGVuZCA9IHBvc2l0aW9uICsgaW5wdXQubGVuZ3RoKCk7CisgICAgY29u c3QgQ2hhcmFjdGVyVHlwZSogcG9zaXRpb24gPSBjaGFyYWN0ZXJzOworICAgIGNvbnN0IENoYXJh Y3RlclR5cGUqIGVuZCA9IGNoYXJhY3RlcnMgKyBsZW5ndGg7CiAKICAgICAvLyBTdGVwIDMKICAg ICB3aGlsZSAocG9zaXRpb24gPCBlbmQpIHsKQEAgLTEwNiw3ICsxMDcsMTIgQEAgc3RhdGljIGJv b2wgcGFyc2VGb250U2l6ZShjb25zdCBTdHJpbmcmIAogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICAvLyBTdGVwIDgKLSAgICBpbnQgdmFsdWUgPSBjaGFyYWN0ZXJzVG9JbnRTdHJpY3QoZGln aXRzLmNoYXJhY3RlcnMoKSwgZGlnaXRzLmxlbmd0aCgpKTsKKyAgICBpbnQgdmFsdWU7CisKKyAg ICBpZiAoZGlnaXRzLmlzOEJpdCgpKQorICAgICAgICB2YWx1ZSA9IGNoYXJhY3RlcnNUb0ludFN0 cmljdChkaWdpdHMuY2hhcmFjdGVyczgoKSwgZGlnaXRzLmxlbmd0aCgpKTsKKyAgICBlbHNlCisg ICAgICAgIHZhbHVlID0gY2hhcmFjdGVyc1RvSW50U3RyaWN0KGRpZ2l0cy5jaGFyYWN0ZXJzMTYo KSwgZGlnaXRzLmxlbmd0aCgpKTsKIAogICAgIC8vIFN0ZXAgOQogICAgIGlmIChtb2RlID09IFJl bGF0aXZlUGx1cykKQEAgLTEyNiw2ICsxMzIsMTcgQEAgc3RhdGljIGJvb2wgcGFyc2VGb250U2l6 ZShjb25zdCBTdHJpbmcmIAogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgYm9vbCBwYXJz ZUZvbnRTaXplKGNvbnN0IFN0cmluZyYgaW5wdXQsIGludCYgc2l6ZSkKK3sKKyAgICBpZiAoaW5w dXQuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoaW5wdXQuaXM4 Qml0KCkpCisgICAgICAgIHJldHVybiBwYXJzZUZvbnRTaXplKGlucHV0LmNoYXJhY3RlcnM4KCks IGlucHV0Lmxlbmd0aCgpLCBzaXplKTsKKworICAgIHJldHVybiBwYXJzZUZvbnRTaXplKGlucHV0 LmNoYXJhY3RlcnMxNigpLCBpbnB1dC5sZW5ndGgoKSwgc2l6ZSk7Cit9CisKIGJvb2wgSFRNTEZv bnRFbGVtZW50Ojpjc3NWYWx1ZUZyb21Gb250U2l6ZU51bWJlcihjb25zdCBTdHJpbmcmIHMsIGlu dCYgc2l6ZSkKIHsKICAgICBpbnQgbnVtID0gMDsK