103288 2012-11-26 13:45:57 -0800 Ensure that plugins are initialized before using handleEditingCommand/isEditingCommandEnabled/shouldAllowScripting 2012-11-26 18:03:15 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca ap enrica mitz rniwa sam oldest_to_newest 775844 0 thorton 2012-11-26 13:45:57 -0800 Other PluginView methods that use m_plugin null-check m_plugin and check that the plugin has finished initializing before using it. These three should do the same thing. 775917 1 176076 thorton 2012-11-26 14:46:07 -0800 Created attachment 176076 patch 776158 2 thorton 2012-11-26 18:03:07 -0800 http://trac.webkit.org/changeset/135797 176076 2012-11-26 14:46:07 -0800 2012-11-26 16:31:22 -0800 patch 0006-Ensure-that-plugins-are-initialized-before-using-han.patch text/plain 2905 thorton RnJvbSAwNmQ2OTA5ODk3MTM4YjEwZDEyMjA5YTY4ZDM5NGQzZjQzM2NhYTYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gSG9ydG9uIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CkRhdGU6IFdlZCwgMjEgTm92IDIwMTIgMDY6MzA6NTkgLTA4MDAKU3ViamVjdDogW1BBVENIIDA2 LzExXSBFbnN1cmUgdGhhdCBwbHVnaW5zIGFyZSBpbml0aWFsaXplZCBiZWZvcmUgdXNpbmcKIGhh bmRsZUVkaXRpbmdDb21tYW5kL2lzRWRpdGluZ0NvbW1hbmRFbmFibGVkL3Nob3VsZEFsbG93U2Ny aXB0aW5nCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMjg4CgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCk90aGVyIFBsdWdpblZpZXcgbWV0aG9kcyB0aGF0 IHVzZSBtX3BsdWdpbiBudWxsLWNoZWNrIG1fcGx1Z2luIGFuZCBjaGVjawp0aGF0IHRoZSBwbHVn aW4gaGFzIGZpbmlzaGVkIGluaXRpYWxpemluZyBiZWZvcmUgdXNpbmcgaXQuIFRoZXNlIHRocmVl CnNob3VsZCBkbyB0aGUgc2FtZSB0aGluZy4KCiogV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZp ZXcuY3BwOgooV2ViS2l0OjpQbHVnaW5WaWV3OjpoYW5kbGVFZGl0aW5nQ29tbWFuZCk6CihXZWJL aXQ6OlBsdWdpblZpZXc6OmlzRWRpdGluZ0NvbW1hbmRFbmFibGVkKToKKFdlYktpdDo6UGx1Z2lu Vmlldzo6c2hvdWxkQWxsb3dTY3JpcHRpbmcpOgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwIHwgICAgOSArKysrKysr KysKIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA3OTVh ZTQ5Li5iMThiM2Q2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTItMTEtMjEgIFRp bSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKKyAgICAgICAgRW5zdXJlIHRo YXQgcGx1Z2lucyBhcmUgaW5pdGlhbGl6ZWQgYmVmb3JlIHVzaW5nIGhhbmRsZUVkaXRpbmdDb21t YW5kL2lzRWRpdGluZ0NvbW1hbmRFbmFibGVkL3Nob3VsZEFsbG93U2NyaXB0aW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMyODgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdGhlciBQbHVnaW5WaWV3 IG1ldGhvZHMgdGhhdCB1c2UgbV9wbHVnaW4gbnVsbC1jaGVjayBtX3BsdWdpbiBhbmQgY2hlY2sK KyAgICAgICAgdGhhdCB0aGUgcGx1Z2luIGhhcyBmaW5pc2hlZCBpbml0aWFsaXppbmcgYmVmb3Jl IHVzaW5nIGl0LiBUaGVzZSB0aHJlZQorICAgICAgICBzaG91bGQgZG8gdGhlIHNhbWUgdGhpbmcu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAg IChXZWJLaXQ6OlBsdWdpblZpZXc6OmhhbmRsZUVkaXRpbmdDb21tYW5kKToKKyAgICAgICAgKFdl YktpdDo6UGx1Z2luVmlldzo6aXNFZGl0aW5nQ29tbWFuZEVuYWJsZWQpOgorICAgICAgICAoV2Vi S2l0OjpQbHVnaW5WaWV3OjpzaG91bGRBbGxvd1NjcmlwdGluZyk6CisKKzIwMTItMTEtMjEgIFRp bSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgUERGUGx1Z2lu OiBTdXBwb3J0IFBERiBmb3JtIGVkaXRpbmcgaW4gPGlmcmFtZT5zCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMyODcKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzEwMzI2OTE3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuY3BwCmluZGV4IDM4MjQ1YmYuLjA1MGRlYzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTc3NywxNiArNzc3 LDI1IEBAIHZvaWQgUGx1Z2luVmlldzo6aGFuZGxlRXZlbnQoRXZlbnQqIGV2ZW50KQogICAgIAog Ym9vbCBQbHVnaW5WaWV3OjpoYW5kbGVFZGl0aW5nQ29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1h bmROYW1lLCBjb25zdCBTdHJpbmcmIGFyZ3VtZW50KQogeworICAgIGlmICghbV9pc0luaXRpYWxp emVkIHx8ICFtX3BsdWdpbikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgcmV0dXJuIG1f cGx1Z2luLT5oYW5kbGVFZGl0aW5nQ29tbWFuZChjb21tYW5kTmFtZSwgYXJndW1lbnQpOwogfQog ICAgIAogYm9vbCBQbHVnaW5WaWV3Ojppc0VkaXRpbmdDb21tYW5kRW5hYmxlZChjb25zdCBTdHJp bmcmIGNvbW1hbmROYW1lKQogeworICAgIGlmICghbV9pc0luaXRpYWxpemVkIHx8ICFtX3BsdWdp bikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgcmV0dXJuIG1fcGx1Z2luLT5pc0VkaXRp bmdDb21tYW5kRW5hYmxlZChjb21tYW5kTmFtZSk7CiB9CiAKIGJvb2wgUGx1Z2luVmlldzo6c2hv dWxkQWxsb3dTY3JpcHRpbmcoKQogeworICAgIGlmICghbV9pc0luaXRpYWxpemVkIHx8ICFtX3Bs dWdpbikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgcmV0dXJuIG1fcGx1Z2luLT5zaG91 bGRBbGxvd1NjcmlwdGluZygpOwogfQogCi0tIAoxLjcuOS42IChBcHBsZSBHaXQtMzEuMSkKCg==