10328 2006-08-09 16:07:30 -0700 REGRESSION: frame leak reported by buildbot 2006-10-21 18:58:15 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Major --- 1 mrowe darin alice.barraclough mjs oldest_to_newest 52141 0 mrowe 2006-08-09 16:07:30 -0700 For the last few days, the leak slave on the buildbot has been reporting many leaks: 1972 total leaks found! 124 Node 11 RenderObject 1 Frame 39 KJS::Node The `leaks' output from the build slave is available at <http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/2270/> 51534 1 darin 2006-10-21 18:16:02 -0700 I decided to use this bug report to represent the latest leak. It's from EditorClient. Attaching a patch. 51535 2 11178 darin 2006-10-21 18:18:10 -0700 Created attachment 11178 patch (EditorClient can't retain WebView, or we get a reference cycle) 51520 3 11178 andersca 2006-10-21 18:45:04 -0700 Comment on attachment 11178 patch (EditorClient can't retain WebView, or we get a reference cycle) r=me 51428 4 darin 2006-10-21 18:58:15 -0700 Committed revision 17199. 11178 2006-10-21 18:18:10 -0700 2006-10-21 18:45:04 -0700 patch (EditorClient can't retain WebView, or we get a reference cycle) EditorClientWorldLeakPatch.txt text/plain 3578 darin SW5kZXg6IFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQkocmV2aXNpb24g MTcxOTYpCisrKyBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50Lm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOCwyOCArMzgsMjIgQEAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwog CiBXZWJFZGl0b3JDbGllbnQ6OldlYkVkaXRvckNsaWVudCgpCi0gICAgOiBtX3dlYlZpZXcoTlVM TCkgCisgICAgOiBtX3dlYlZpZXcobmlsKSAKIHsKIH0KIAogV2ViRWRpdG9yQ2xpZW50OjpXZWJF ZGl0b3JDbGllbnQoV2ViVmlldyogd2ViVmlldykKICAgICA6IG1fd2ViVmlldyh3ZWJWaWV3KSAK IHsKLSAgICBbbV93ZWJWaWV3IHJldGFpbl07CiB9CiAKIFdlYkVkaXRvckNsaWVudDo6fldlYkVk aXRvckNsaWVudCgpCiB7Ci0gICAgW21fd2ViVmlldyByZWxlYXNlXTsKIH0KIAogdm9pZCBXZWJF ZGl0b3JDbGllbnQ6OnNldFdlYlZpZXcoV2ViVmlldyogd2ViVmlldykKIHsgCi0gICAgaWYgKG1f d2ViVmlldyAhPSB3ZWJWaWV3KSB7Ci0gICAgICAgIFttX3dlYlZpZXcgcmVsZWFzZV07Ci0gICAg ICAgIG1fd2ViVmlldyA9IHdlYlZpZXc7IAotICAgICAgICBbbV93ZWJWaWV3IHJldGFpbl07Ci0g ICAgfQorICAgIG1fd2ViVmlldyA9IHdlYlZpZXc7IAogfQogCiBib29sIFdlYkVkaXRvckNsaWVu dDo6c2hvdWxkRGVsZXRlUmFuZ2UoUmFuZ2UqIHJhbmdlKQpJbmRleDogV2ViS2l0L1dlYkNvcmVT dXBwb3J0L1dlYkZyYW1lQnJpZGdlLm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L1dlYkNvcmVTdXBw b3J0L1dlYkZyYW1lQnJpZGdlLm0JKHJldmlzaW9uIDE3MTk2KQorKysgV2ViS2l0L1dlYkNvcmVT dXBwb3J0L1dlYkZyYW1lQnJpZGdlLm0JKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDcgQEAK ICNpbXBvcnQgPFdlYkNvcmUvV2ViTG9hZGVyLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYlN1YnJl c291cmNlTG9hZGVyLmg+CiAjaW1wb3J0IDxXZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaD4KKyNpbXBv cnQgPHd0Zi9SZWZQdHIuaD4KIAogLy8gRm9yIGNvbXBhdGliaWxpdHkgb25seSB3aXRoIG9sZCBT UEkuIAogQGludGVyZmFjZSBOU09iamVjdCAoT2xkV2ViUGx1Z2luKQpAQCAtMTE3LDMyICsxMTgs MzMgQEAgTlNTdHJpbmcgKldlYlBsdWdpbkNvbnRhaW5lcktleSA9ICAgQCJXZQogICAgIHJldHVy biBbKFdlYlBhZ2VCcmlkZ2UgKilbc2VsZiBwYWdlXSB3ZWJWaWV3XTsKIH0KIAotLSAoaWQpaW5p dE1haW5GcmFtZVdpdGhQYWdlOihXZWJQYWdlQnJpZGdlICopcGFnZSBmcmFtZU5hbWU6KE5TU3Ry aW5nICopbmFtZSB2aWV3OihXZWJGcmFtZVZpZXcgKil2aWV3CistICh2b2lkKWZpbmlzaEluaXRp YWxpemluZ1dpdGhGcmFtZU5hbWU6KE5TU3RyaW5nICopbmFtZSB2aWV3OihXZWJGcmFtZVZpZXcg Kil2aWV3CiB7Ci0gICAgc2VsZiA9IFtzdXBlciBpbml0TWFpbkZyYW1lV2l0aFBhZ2U6cGFnZSB3 aXRoRWRpdG9yQ2xpZW50Om5ldyBXZWJFZGl0b3JDbGllbnQoW3BhZ2Ugd2ViVmlld10pXTsKLSAg ICBfZnJhbWUgPSBbW1dlYkZyYW1lIGFsbG9jXSBfaW5pdFdpdGhXZWJGcmFtZVZpZXc6dmlldyB3 ZWJWaWV3OltzZWxmIHdlYlZpZXddIGJyaWRnZTpzZWxmXTsKKyAgICBXZWJWaWV3ICp3ZWJWaWV3 ID0gW3NlbGYgd2ViVmlld107CiAKKyAgICBfZnJhbWUgPSBbW1dlYkZyYW1lIGFsbG9jXSBfaW5p dFdpdGhXZWJGcmFtZVZpZXc6dmlldyB3ZWJWaWV3OndlYlZpZXcgYnJpZGdlOnNlbGZdOwogICAg ICsrV2ViQnJpZGdlQ291bnQ7CiAKICAgICBbc2VsZiBzZXROYW1lOm5hbWVdOwotICAgIFtzZWxm IGluaXRpYWxpemVTZXR0aW5nczpbW3NlbGYgd2ViVmlld10gX3NldHRpbmdzXV07Ci0gICAgW3Nl bGYgc2V0VGV4dFNpemVNdWx0aXBsaWVyOltbc2VsZiB3ZWJWaWV3XSB0ZXh0U2l6ZU11bHRpcGxp ZXJdXTsKKyAgICBbc2VsZiBpbml0aWFsaXplU2V0dGluZ3M6W3dlYlZpZXcgX3NldHRpbmdzXV07 CisgICAgW3NlbGYgc2V0VGV4dFNpemVNdWx0aXBsaWVyOlt3ZWJWaWV3IHRleHRTaXplTXVsdGlw bGllcl1dOworfQogCistIChpZClpbml0TWFpbkZyYW1lV2l0aFBhZ2U6KFdlYlBhZ2VCcmlkZ2Ug KilwYWdlIGZyYW1lTmFtZTooTlNTdHJpbmcgKiluYW1lIHZpZXc6KFdlYkZyYW1lVmlldyAqKXZp ZXcKK3sKKyAgICAvLyBGSVhNRTogTmVlZCB0byBjbGVhciB0aGUgV2ViVmlldyBwb2ludGVyIGlu IFdlYkVkaXRvckNsaWVudCB3aGVuIHRoZSBXZWJWaWV3IGlzIGRlYWxsb2NhdGVkLgorICAgIHNl bGYgPSBbc3VwZXIgaW5pdE1haW5GcmFtZVdpdGhQYWdlOnBhZ2Ugd2l0aEVkaXRvckNsaWVudDpu ZXcgV2ViRWRpdG9yQ2xpZW50KFtwYWdlIHdlYlZpZXddKV07CisgICAgW3NlbGYgZmluaXNoSW5p dGlhbGl6aW5nV2l0aEZyYW1lTmFtZTpuYW1lIHZpZXc6dmlld107CiAgICAgcmV0dXJuIHNlbGY7 CiB9CiAKIC0gKGlkKWluaXRTdWJmcmFtZVdpdGhPd25lckVsZW1lbnQ6KFdlYkNvcmVFbGVtZW50 ICopb3duZXJFbGVtZW50IGZyYW1lTmFtZTooTlNTdHJpbmcgKiluYW1lIHZpZXc6KFdlYkZyYW1l VmlldyAqKXZpZXcKIHsKLSAgICBXZWJFZGl0b3JDbGllbnQqIGVkaXRvckNsaWVudCA9IG5ldyBX ZWJFZGl0b3JDbGllbnQoKTsKLSAgICBzZWxmID0gW3N1cGVyIGluaXRTdWJmcmFtZVdpdGhPd25l ckVsZW1lbnQ6b3duZXJFbGVtZW50IHdpdGhFZGl0b3JDbGllbnQ6ZWRpdG9yQ2xpZW50XTsKLSAg ICBfZnJhbWUgPSBbW1dlYkZyYW1lIGFsbG9jXSBfaW5pdFdpdGhXZWJGcmFtZVZpZXc6dmlldyB3 ZWJWaWV3OltzZWxmIHdlYlZpZXddIGJyaWRnZTpzZWxmXTsKKyAgICBSZWZQdHI8V2ViRWRpdG9y Q2xpZW50PiBlZGl0b3JDbGllbnQgPSBuZXcgV2ViRWRpdG9yQ2xpZW50OworICAgIHNlbGYgPSBb c3VwZXIgaW5pdFN1YmZyYW1lV2l0aE93bmVyRWxlbWVudDpvd25lckVsZW1lbnQgd2l0aEVkaXRv ckNsaWVudDplZGl0b3JDbGllbnQuZ2V0KCldOworICAgIC8vIEZJWE1FOiBOZWVkIHRvIGNsZWFy IHRoZSBXZWJWaWV3IHBvaW50ZXIgaW4gV2ViRWRpdG9yQ2xpZW50IHdoZW4gdGhlIFdlYlZpZXcg aXMgZGVhbGxvY2F0ZWQuCiAgICAgZWRpdG9yQ2xpZW50LT5zZXRXZWJWaWV3KFtzZWxmIHdlYlZp ZXddKTsKLSAgICArK1dlYkJyaWRnZUNvdW50OwotCi0gICAgW3NlbGYgc2V0TmFtZTpuYW1lXTsK LSAgICBbc2VsZiBpbml0aWFsaXplU2V0dGluZ3M6W1tzZWxmIHdlYlZpZXddIF9zZXR0aW5nc11d OwotICAgIFtzZWxmIHNldFRleHRTaXplTXVsdGlwbGllcjpbW3NlbGYgd2ViVmlld10gdGV4dFNp emVNdWx0aXBsaWVyXV07Ci0KKyAgICBbc2VsZiBmaW5pc2hJbml0aWFsaXppbmdXaXRoRnJhbWVO YW1lOm5hbWUgdmlldzp2aWV3XTsKICAgICByZXR1cm4gc2VsZjsKIH0KIAo=