103273 2012-11-26 10:29:03 -0800 [Cairo] Surface should not be destroyed before its usage 2012-11-26 15:21:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafael.lobo rafael.lobo bfulgham kenneth noam webkit.review.bot oldest_to_newest 775626 0 rafael.lobo 2012-11-26 10:29:03 -0800 [Cairo] Surface should not be destroyed before its usage 775629 1 176029 rafael.lobo 2012-11-26 10:31:18 -0800 Created attachment 176029 Patch 775663 2 176029 bfulgham 2012-11-26 10:53:29 -0800 Comment on attachment 176029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176029&action=review Great catch. r=me. > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:-363 > - cairo_surface_destroy(surface); Wow! I'm surprised this ever worked. 775664 3 176029 rafael.lobo 2012-11-26 10:54:38 -0800 Comment on attachment 176029 Patch Me too. :-) 775691 4 176029 webkit.review.bot 2012-11-26 11:12:48 -0800 Comment on attachment 176029 Patch Clearing flags on attachment: 176029 Committed r135742: <http://trac.webkit.org/changeset/135742> 775692 5 webkit.review.bot 2012-11-26 11:12:51 -0800 All reviewed patches have been landed. Closing bug. 775954 6 176029 kenneth 2012-11-26 15:17:18 -0800 Comment on attachment 176029 Patch Nice 775955 7 kenneth 2012-11-26 15:17:51 -0800 Btw, did this solve any reproducible bugs? 775963 8 rafael.lobo 2012-11-26 15:21:24 -0800 (In reply to comment #7) > Btw, did this solve any reproducible bugs? I wish, but I couldn't observe anything. I'm focusing on the scale < 1.0 bug right now and stumbled right into this. 176029 2012-11-26 10:31:18 -0800 2012-11-26 15:17:18 -0800 Patch bug-103273-20121126152902.patch text/plain 2060 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg2NDM4NTU4ODllZDNi NzI3MjlkZjJhNDJhNGZkMGEwMWVhOWNhOC4uNWU0ZTUwZmFmYzcyN2I1NjZhNmYxMDY2Y2I1YmU0 YzMxZWU5Mzk5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTI2ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW0NhaXJv XSBTdXJmYWNlIHNob3VsZCBub3QgYmUgZGVzdHJveWVkIGJlZm9yZSBpdHMgdXNhZ2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzI3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0 dXJlTWFwcGVyR0w6OmRyYXdSZXBhaW50Q291bnRlcik6IFRoZXJlJ3Mgc29tZSBjYWxscyB0byBn ZXQKKyAgICAgICAgdGhlIGJpdHMgYW5kIHN0cmlkZSBmcm9tIHN1cmZhY2UgcmlnaHQgYWZ0ZXIg aXRzIGRlc3RydWN0aW9ucy4gSXQgc2hvdWxkCisgICAgICAgIGJlIHBvc3Rwb25lZCB0byBhdm9p ZCBhbm5veWluZyBidWdzLgorCiAyMDEyLTExLTI2ICBKYWUgSHl1biBQYXJrICA8amFlLnBhcmtA Y29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBhc3NpZ25tZW50IGlu IFRleHR1cmVNYXBwZXJMYXllcjo6Zmx1c2hDb21wb3NpdGluZ1N0YXRlU2VsZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcAppbmRleCA1NzE2NTRjMDU4YWNmOTA0ZTBlYWIxY2IyYzAyNTNlZTYyYjBmZmNl Li5kMDJhODk4NDlhNzY5MTIzNjUwODliOTliZGVkMjBhY2Y3NTJkZDA4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcApAQCAtMzYwLDcgKzM2MCw2IEBAIHZvaWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3 UmVwYWludENvdW50ZXIoaW50IHZhbHVlLCBpbnQgcG9pbnRTaXplLCBjb25zdCBGbG9hdFBvCiAK ICAgICBjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0 ZShDQUlST19GT1JNQVRfQVJHQjMyLCB3aWR0aCwgaGVpZ2h0KTsKICAgICBjYWlyb190KiBjciA9 IGNhaXJvX2NyZWF0ZShzdXJmYWNlKTsKLSAgICBjYWlyb19zdXJmYWNlX2Rlc3Ryb3koc3VyZmFj ZSk7CiAKICAgICBjYWlyb19zZXRfc291cmNlX3JnYihjciwgMCwgMCwgMSk7IC8vIFNpbmNlIHdl IHdvbid0IHN3YXAgUitCIGZvciBzcGVlZCwgdGhpcyB3aWxsIHBhaW50IHJlZC4KICAgICBjYWly b19yZWN0YW5nbGUoY3IsIDAsIDAsIHdpZHRoLCBoZWlnaHQpOwpAQCAtMzgyLDYgKzM4MSw3IEBA IHZvaWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3UmVwYWludENvdW50ZXIoaW50IHZhbHVlLCBpbnQg cG9pbnRTaXplLCBjb25zdCBGbG9hdFBvCiAgICAgc3RhdGljX2Nhc3Q8Qml0bWFwVGV4dHVyZUdM Kj4odGV4dHVyZS5nZXQoKSktPnVwZGF0ZUNvbnRlbnRzTm9Td2l6emxlKGJpdHMsIHNvdXJjZVJl Y3QsIEludFBvaW50Ojp6ZXJvKCksIHN0cmlkZSk7CiAgICAgZHJhd1RleHR1cmUoKnRleHR1cmUs IHRhcmdldFJlY3QsIG1vZGVsVmlld01hdHJpeCwgMS4wZiwgMCwgQWxsRWRnZXMpOwogCisgICAg Y2Fpcm9fc3VyZmFjZV9kZXN0cm95KHN1cmZhY2UpOwogICAgIGNhaXJvX2Rlc3Ryb3koY3IpOwog CiAjZWxzZQo=