103260 2012-11-26 08:32:45 -0800 [Qt] Implement the mimetype icon methods 2012-11-27 03:16:38 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen hausmann noam webkit.review.bot oldest_to_newest 775502 0 allan.jensen 2012-11-26 08:32:45 -0800 IconQt.cpp has an empty implementation of finding a icon for the given filenames. Using QMimeDatabase it should be simple now to lookup and return appropiate icons. 775507 1 176007 allan.jensen 2012-11-26 08:36:30 -0800 Created attachment 176007 Patch 775511 2 allan.jensen 2012-11-26 08:38:31 -0800 I think this will be tested indirectly by many of the tests using the file INPUT element. To test manually, you can use bugs.webkit.org and see the icon when attaching files. 776559 3 allan.jensen 2012-11-27 03:16:38 -0800 Committed r135842: <http://trac.webkit.org/changeset/135842> 176007 2012-11-26 08:36:30 -0800 2012-11-26 12:29:28 -0800 Patch bug-103260-20121126173341.patch text/plain 3903 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRhMjYzNTA4Yjk2YmNm ZmUwNTU5NjZhOWJiNTUwMzFkZTQ3MGY4NC4uNDUzZDljMWU1MzJhYjJhZTgzOTIxMWQ5MDI0MmIx Nzk5MzljMTY5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI2ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gSW1wbGVtZW50IHRoZSBtaW1ldHlwZSBpY29uIG1ldGhvZHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzI2MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5o OgorICAgICAgICAoSWNvbik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSWNvblF0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okljb246OmNyZWF0ZUljb25Gb3JGaWxlcyk6CisgICAg ICAgIChXZWJDb3JlOjpJY29uOjpwYWludCk6CisKIDIwMTItMTEtMjYgIFplbm8gQWxiaXNzZXIg IDx6ZW5vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXaW5dIGJ1aWxkZml4IGFmdGVyIHIx MzU3MDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JY29u LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JY29uLmgKaW5kZXggYjcwM2M3 MTQxOTA1ZTA3ZjBhZmFhMjNlMDdjZTM5ZjA1OWRjYmY0Ni4uNzgxYTA4Y2IyZTYzOTgwZjkyOWVi MjRjZmNhYjcwMGFjYTk3OTcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvSWNvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lj b24uaApAQCAtMzIsNyArMzIsNyBAQCBPQkpDX0NMQVNTIE5TSW1hZ2U7CiAjZWxpZiBQTEFURk9S TShXSU4pCiB0eXBlZGVmIHN0cnVjdCBISUNPTl9fKiBISUNPTjsKICNlbGlmIFBMQVRGT1JNKFFU KQotI2luY2x1ZGUgPFFJbWFnZT4KKyNpbmNsdWRlIDxRSWNvbj4KICNlbGlmIFBMQVRGT1JNKEdU SykKIHR5cGVkZWYgc3RydWN0IF9HZGtQaXhidWYgR2RrUGl4YnVmOwogI2VsaWYgUExBVEZPUk0o RUZMKQpAQCAtNzAsNyArNzAsNyBAQCBwcml2YXRlOgogICAgIEhJQ09OIG1faEljb247CiAjZWxp ZiBQTEFURk9STShRVCkKICAgICBJY29uKCk7Ci0gICAgUUltYWdlIG1faW1hZ2U7CisgICAgUUlj b24gbV9pY29uOwogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIEljb24oKTsKICAgICBHZGtQaXhi dWYqIG1faWNvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ljb25RdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JY29u UXQuY3BwCmluZGV4IGFkYzNiZGJkZDM3MGYwNmRiNWVhMDViZDA0ZDJiYWIwOTFjMmVmMWEuLjk1 ZWI0MThmNjUyODdjMzczNjNjOWNhOTExYzMwMzIxMjFmZjMzMzIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ljb25RdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSWNvblF0LmNwcApAQCAtMjMsNyArMjMsOSBAQAog CiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgorI2lu Y2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgor I2luY2x1ZGUgPFFNaW1lRGF0YWJhc2U+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTM3LDE2ICszOSw1MSBAQCBJY29uOjp+SWNvbigp CiB9CiAKIC8vIEZJWE1FOiBNb3ZlIHRoZSBjb2RlIHRvIENocm9tZUNsaWVudDo6aWNvbkZvckZp bGVzKCkuCi1QYXNzUmVmUHRyPEljb24+IEljb246OmNyZWF0ZUljb25Gb3JGaWxlcyhjb25zdCBW ZWN0b3I8U3RyaW5nPiYpCitQYXNzUmVmUHRyPEljb24+IEljb246OmNyZWF0ZUljb25Gb3JGaWxl cyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgZmlsZW5hbWVzKQogewotICAgIC8vIEZJWE1FOiBTaG91 bGQgdXNlIFFNaW1lVHlwZSBpbiBRdCA1LgotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0 dXJuIDA7CisgICAgaWYgKGZpbGVuYW1lcy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiAwOwor CisgICAgU3RyaW5nIG1pbWVUeXBlTmFtZSA9IE1JTUVUeXBlUmVnaXN0cnk6OmdldE1JTUVUeXBl Rm9yUGF0aChmaWxlbmFtZXNbMF0pOworICAgIFFNaW1lVHlwZSBtaW1lVHlwZSA9IFFNaW1lRGF0 YWJhc2UoKS5taW1lVHlwZUZvck5hbWUobWltZVR5cGVOYW1lKTsKKworICAgIFFTdHJpbmcgaWNv bk5hbWUgPSBtaW1lVHlwZS5pY29uTmFtZSgpOworICAgIFFTdHJpbmcgZ2VuZXJpY0ljb25OYW1l ID0gbWltZVR5cGUuZ2VuZXJpY0ljb25OYW1lKCk7CisKKyAgICAvLyBXZSB0cnkgdG8gbWF0Y2gg b25lIG9mIHRocmVlIGNhc2VzOgorICAgIC8vIDEuIEFsbCB0aGUgZmlsZXMgaGF2ZSB0aGUgc2Ft ZSB0eXBlLgorICAgIC8vIDIuIEFsbCB0aGUgZmlsZXMgYXJlIG9mIHRoZSBzYW1lIGdlbmVyaWMg dHlwZS4KKyAgICAvLyAzLiBUaGUgZmlsZXMgYXJlIG5vdCBldmVuIG9mIHRoZSBzYW1lIGdlbmVy aWMgdHlwZS4KKyAgICBjb25zdCBpbnQgY291bnQgPSBmaWxlbmFtZXMuc2l6ZSgpOworICAgIGZv ciAoaW50IGkgPSAxOyBpIDwgY291bnQ7ICsraSkgeworICAgICAgICBtaW1lVHlwZU5hbWUgPSBN SU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvclBhdGgoZmlsZW5hbWVzW2ldKTsKKyAgICAg ICAgbWltZVR5cGUgPSBRTWltZURhdGFiYXNlKCkubWltZVR5cGVGb3JOYW1lKG1pbWVUeXBlTmFt ZSk7CisgICAgICAgIGlmIChpY29uTmFtZSAhPSBtaW1lVHlwZS5pY29uTmFtZSgpKQorICAgICAg ICAgICAgaWNvbk5hbWUuY2xlYXIoKTsKKyAgICAgICAgaWYgKGdlbmVyaWNJY29uTmFtZSAhPSBt aW1lVHlwZS5nZW5lcmljSWNvbk5hbWUoKSkgeworICAgICAgICAgICAgZ2VuZXJpY0ljb25OYW1l LmNsZWFyKCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgIH0KKworICAgIC8v IEZJWE1FOiBCeSBkZWZhdWx0LCBvbmx5IFgxMSB3aWxsIHN1cHBvcnQgdGhlbWVkIGljb25zLgor ICAgIFJlZlB0cjxJY29uPiBpY29uID0gYWRvcHRSZWYobmV3IEljb24pOworICAgIGlmICghaWNv bk5hbWUuaXNFbXB0eSgpKQorICAgICAgICBpY29uLT5tX2ljb24gPSBRSWNvbjo6ZnJvbVRoZW1l KGljb25OYW1lLCBRSWNvbjo6ZnJvbVRoZW1lKGdlbmVyaWNJY29uTmFtZSkpOworICAgIGVsc2Ug aWYgKCFnZW5lcmljSWNvbk5hbWUuaXNFbXB0eSgpKQorICAgICAgICBpY29uLT5tX2ljb24gPSBR SWNvbjo6ZnJvbVRoZW1lKGdlbmVyaWNJY29uTmFtZSk7CisKKyAgICBpZiAoaWNvbi0+bV9pY29u LmlzTnVsbCgpKQorICAgICAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gaWNvbi5yZWxlYXNlKCk7 CiB9CiAKLXZvaWQgSWNvbjo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYp Cit2b2lkIEljb246OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVj dCYgcmVjdCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmIChtX2ljb24uaXNOdWxs KCkpCisgICAgICAgIHJldHVybjsKKworICAgIG1faWNvbi5wYWludChjb250ZXh0LT5wbGF0Zm9y bUNvbnRleHQoKSwgcmVjdCk7CiB9CiAKIH0K