103254 2012-11-26 07:07:40 -0800 Web Inspector: make ASSERTION FAILED: foundPropertiesCount == object->size() more useful 2012-12-03 13:06:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman prybin apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 775453 0 pfeldman 2012-11-26 07:07:40 -0800 Adding dump of the JSON object would further improve the assertion value. 779583 1 prybin 2012-11-29 16:40:29 -0800 Pavel, please note that CodeGeneratorInspector.py has hardcoded variable VALIDATOR_IFDEF_NAME. This could be changed to use in release build mode. 779602 2 176850 prybin 2012-11-29 17:05:21 -0800 Created attachment 176850 Patch 779675 3 176850 yurys 2012-11-29 17:52:52 -0800 Comment on attachment 176850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176850&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:1342 > + validator_writer.newline(" FATAL(\"Unexpected properties in object: %s\\n\", object->toJSONString().ascii().data());\n") Now it will crash in release build too which is bad. 779693 4 prybin 2012-11-29 18:08:38 -0800 > Now it will crash in release build too which is bad. This code doesn't work in release build. 779722 5 yurys 2012-11-29 18:28:16 -0800 (In reply to comment #4) > > Now it will crash in release build too which is bad. > > This code doesn't work in release build. Oh, I see it is hidden behind #if !ASSERT_DISABLED 780143 6 prybin 2012-11-30 08:45:02 -0800 Pavel, I guess the patch is at your service, ready for landing. 780645 7 176850 buildbot 2012-11-30 22:03:53 -0800 Comment on attachment 176850 Patch Attachment 176850 did not pass win-ews (win): Output: http://queues.webkit.org/results/15062675 780775 8 177113 prybin 2012-12-01 14:59:26 -0800 Created attachment 177113 Patch 780780 9 prybin 2012-12-01 15:33:33 -0800 I guess the new patch fixes win build (linker .def file didn't list required function symbol). Let's give it another try. 781661 10 177113 webkit.review.bot 2012-12-03 11:04:00 -0800 Comment on attachment 177113 Patch Rejecting attachment 177113 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Updating OpenSource From http://git.chromium.org/external/Webkit e9e6020..1db1bee HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at 1db1bee680414c2b5d10e6b820eb7c7e89858e47 but expected e9e60209430c81c71b136baf1b1e72d6bac0da3a ! e9e6020..1db1bee master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15133007 781796 11 177113 webkit.review.bot 2012-12-03 13:06:22 -0800 Comment on attachment 177113 Patch Clearing flags on attachment: 177113 Committed r136431: <http://trac.webkit.org/changeset/136431> 781797 12 webkit.review.bot 2012-12-03 13:06:27 -0800 All reviewed patches have been landed. Closing bug. 176850 2012-11-29 17:05:21 -0800 2012-12-01 14:59:21 -0800 Patch bug-103254-20121130050253.patch text/plain 2076 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjhkZTdkOTIxMWU3YjYw MTZiODUyMWQ4ZDRiMjk4MWNlYmQwZGU2OS4uNDQ2MWFiYTAyOWFiN2FiNWM5MWRmNjU2MGYyNGNk NzNmODg3NjIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTI5ICBQZXRl ciBSeWJpbiAgPHByeWJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog bWFrZSBBU1NFUlRJT04gRkFJTEVEOiBmb3VuZFByb3BlcnRpZXNDb3VudCA9PSBvYmplY3QtPnNp emUoKSBtb3JlIHVzZWZ1bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAzMjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXNzZXJ0IGNvZGUgZ2VuZXJhdGlvbiBpcyBzbGlnaHRseSBjaGFuZ2VkIHNvIHRo YXQgaXQgZHVtcGVkIEpTT04gb2JqZWN0IHRleHQgYmVmb3JlIGNyYXNoaW5nLgorCisgICAgICAg ICogaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHk6CisKIDIwMTItMTEtMjkgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtX ZWJLaXQyXSBFbWJlZCB0aGUgSFRUUCBhdXRoZW50aWNhdGlvbiBkaWFsb2cgaW50byB0aGUgV2Vi VmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJ bnNwZWN0b3IucHkgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3Bl Y3Rvci5weQppbmRleCA4MTcxMWZmNTQxN2I2OWEwZmU2YTU5ZWU0M2UyOGJhZTY3NjIwZDM2Li5l NzA4ZDllNGQ5OGFjYjFjNmFhNWNhNmM1YTAwYjFlMTJjN2FhOTMzIDEwMDc1NQotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5weQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5weQpAQCAtMTMzOCw3 ICsxMzM4LDkgQEAgY2xhc3MgVHlwZUJpbmRpbmdzOgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHZhbGlkYXRvcl93cml0ZXIubmV3bGluZSgiICAgIH1cbiIpCiAKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIGNsb3NlZF9maWVsZF9zZXQ6Ci0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsaWRhdG9yX3dyaXRlci5u ZXdsaW5lKCIgICAgQVNTRVJUKGZvdW5kUHJvcGVydGllc0NvdW50ID09IG9iamVjdC0+c2l6ZSgp KTtcbiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsaWRhdG9y X3dyaXRlci5uZXdsaW5lKCIgICAgaWYgKGZvdW5kUHJvcGVydGllc0NvdW50ICE9IG9iamVjdC0+ c2l6ZSgpKSB7XG4iKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZh bGlkYXRvcl93cml0ZXIubmV3bGluZSgiICAgICAgRkFUQUwoXCJVbmV4cGVjdGVkIHByb3BlcnRp ZXMgaW4gb2JqZWN0OiAlc1xcblwiLCBvYmplY3QtPnRvSlNPTlN0cmluZygpLmFzY2lpKCkuZGF0 YSgpKTtcbiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsaWRh dG9yX3dyaXRlci5uZXdsaW5lKCIgICAgfVxuIikKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHZhbGlkYXRvcl93cml0ZXIubmV3bGluZSgifVxuIikKIAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaWYgZG9tYWluX2d1YXJkOgpAQCAtMjU2NCw2ICsyNTY2 LDcgQEAgJHt0eXBlQnVpbGRlcnN9CiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKIAogI2luY2x1ZGUg Ikluc3BlY3RvclR5cGVCdWlsZGVyLmgiCisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK 177113 2012-12-01 14:59:26 -0800 2012-12-03 13:06:22 -0800 Patch bug-103254-20121202025655.patch text/plain 3434 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NTA0MmQxYTZlYzBjYjliNDE0MTljOTgyMzhjZjIwN2U4NGMyZjNiLi4wYzc1Mjk2OTcxMTQ1YTVh ZWZjZDY1YWRiMmVkYTBkMmRmZjdlYTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0xMi0wMSAgUGV0ZXIgUnliaW4gIDxwcnliaW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1ha2UgQVNTRVJUSU9OIEZBSUxFRDogZm91bmRQ cm9wZXJ0aWVzQ291bnQgPT0gb2JqZWN0LT5zaXplKCkgbW9yZSB1c2VmdWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzI1NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pc3Npbmcgc3ltYm9sIFdURlJl cG9ydEZhdGFsRXJyb3IgaXMgYWRkZWQgdG8gdGhlIGxpbmtlciBsaXN0LgorCisgICAgICAgICog SmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmRlZjoK KwogMjAxMi0xMS0yOSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAg ICAgICBTcGVjdWxhdGl2ZSBXaW5kb3dzIGJ1aWxkIGZpeCBhZnRlciByMTM2MDg2LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGI4ZGU3ZDkyMTFlN2I2MDE2Yjg1MjFkOGQ0YjI5ODFjZWJkMGRlNjkuLmQxODM1MGUy ZmVmZjNiYTVhZTIxOWQyZjc0ZjA3OGYzY2YzYzVhYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxMi0xMi0wMSAgUGV0ZXIgUnliaW4gIDxwcnliaW5AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFdlYiBJbnNwZWN0b3I6IG1ha2UgQVNTRVJUSU9OIEZBSUxFRDogZm91bmRQcm9wZXJ0 aWVzQ291bnQgPT0gb2JqZWN0LT5zaXplKCkgbW9yZSB1c2VmdWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzI1NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzc2VydCBjb2RlIGdlbmVyYXRpb24gaXMg c2xpZ2h0bHkgY2hhbmdlZCBzbyB0aGF0IGl0IGR1bXBlZCBKU09OIG9iamVjdCB0ZXh0IGJlZm9y ZSBjcmFzaGluZy4KKworICAgICAgICAqIGluc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9y LnB5OgorCiAyMDEyLTExLTI5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBbV2ViS2l0Ml0gRW1iZWQgdGhlIEhUVFAgYXV0aGVudGljYXRp b24gZGlhbG9nIGludG8gdGhlIFdlYlZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu ZGVmIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKaW5kZXggNDIyYWFjNDY0NThkZDM2MzdlNWRjNDU1 ZDVhZDE3YmQxNTNmNGZjMS4uYjk1ZTFiODhmZTUxMmEyYzJjMDIwMTg2MTExYWIyOWMwMjgxYzEw MyAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJv ai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS5kZWYKQEAgLTQzNiw0ICs0MzYsNSBAQCBFWFBPUlRTCiAgICAgV1RGUmVwb3J0QXNzZXJ0aW9u RmFpbHVyZVdpdGhNZXNzYWdlCiAgICAgV1RGUmVwb3J0QmFja3RyYWNlCiAgICAgV1RGUmVwb3J0 RXJyb3IKKyAgICBXVEZSZXBvcnRGYXRhbEVycm9yCiAgICAgV1RGU2V0Q3Jhc2hIb29rCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5w eSBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5Cmlu ZGV4IDgxNzExZmY1NDE3YjY5YTBmZTZhNTllZTQzZTI4YmFlNjc2MjBkMzYuLmU3MDhkOWU0ZDk4 YWNiMWM2YWE1Y2E2YzVhMDBiMWUxMmM3YWE5MzMgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5CisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5CkBAIC0xMzM4LDcgKzEzMzgsOSBA QCBjbGFzcyBUeXBlQmluZGluZ3M6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdmFsaWRhdG9yX3dyaXRlci5uZXdsaW5lKCIgICAgfVxuIikKIAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaWYgY2xvc2VkX2ZpZWxkX3NldDoKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWxpZGF0b3Jfd3JpdGVyLm5ld2xpbmUoIiAg ICBBU1NFUlQoZm91bmRQcm9wZXJ0aWVzQ291bnQgPT0gb2JqZWN0LT5zaXplKCkpO1xuIikKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWxpZGF0b3Jfd3JpdGVyLm5l d2xpbmUoIiAgICBpZiAoZm91bmRQcm9wZXJ0aWVzQ291bnQgIT0gb2JqZWN0LT5zaXplKCkpIHtc biIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsaWRhdG9yX3dy aXRlci5uZXdsaW5lKCIgICAgICBGQVRBTChcIlVuZXhwZWN0ZWQgcHJvcGVydGllcyBpbiBvYmpl Y3Q6ICVzXFxuXCIsIG9iamVjdC0+dG9KU09OU3RyaW5nKCkuYXNjaWkoKS5kYXRhKCkpO1xuIikK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWxpZGF0b3Jfd3JpdGVy Lm5ld2xpbmUoIiAgICB9XG4iKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dmFsaWRhdG9yX3dyaXRlci5uZXdsaW5lKCJ9XG4iKQogCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpZiBkb21haW5fZ3VhcmQ6CkBAIC0yNTY0LDYgKzI1NjYsNyBAQCAke3R5 cGVCdWlsZGVyc30KICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogCiAjaW5jbHVkZSAiSW5zcGVjdG9y VHlwZUJ1aWxkZXIuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAo=