103234 2012-11-26 03:02:20 -0800 [X11] Allow empty plugin name and description during scan plugin 2012-11-27 03:42:38 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ky0.choi ky0.choi abecsi cmarcelo gyuyoung.kim hausmann kbalazs kenneth menard webkit.review.bot oldest_to_newest 775308 0 ky0.choi 2012-11-26 03:02:20 -0800 Empty entries should be allowed when split the output string of scan plugin because the plugin name and the description can be empty string. "\n\napplication/testplugin\n" 775309 1 175955 ky0.choi 2012-11-26 03:07:11 -0800 Created attachment 175955 Patch 776464 2 kbalazs 2012-11-27 01:14:02 -0800 Looks good. 776469 3 175955 cdumez 2012-11-27 01:21:31 -0800 Comment on attachment 175955 Patch LGTM. 776581 4 175955 webkit.review.bot 2012-11-27 03:42:33 -0800 Comment on attachment 175955 Patch Clearing flags on attachment: 175955 Committed r135845: <http://trac.webkit.org/changeset/135845> 776582 5 webkit.review.bot 2012-11-27 03:42:38 -0800 All reviewed patches have been landed. Closing bug. 175955 2012-11-26 03:07:11 -0800 2012-11-27 03:42:32 -0800 Patch diff text/plain 2283 ky0.choi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZDdlNzQ4Li40ZGIyOTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTEtMjYgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW1gxMV0gQWxsb3cgZW1wdHkgcGx1Z2luIG5hbWUgYW5kIGRlc2NyaXB0aW9uIGR1 cmluZyBzY2FuIHBsdWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAzMjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRW1wdHkgZW50cmllcyBzaG91bGQgYmUgYWxsb3dlZCB3aGVuIHNwbGl0IHRoZSBv dXRwdXQgc3RyaW5nIG9mIHNjYW4gcGx1Z2luCisgICAgICAgIGJlY2F1c2UgdGhlIHBsdWdpbiBu YW1lIGFuZCB0aGUgZGVzY3JpcHRpb24gY2FuIGJlIGVtcHR5IHN0cmluZy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdpblByb2Nlc3NQcm94eVF0LmNwcDoKKyAgICAgICAg KFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1Z2luKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwOgorICAgICAgICAo V2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OnNjYW5QbHVnaW4pOgorCiAyMDEyLTExLTI2ICBI dWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJFR1JF U1NJT04oMTM0MTQyKTogQVNTRVJUKCFtX3NpemUuaXNaZXJvKCkpIGhpdHMgaW4gQ29vcmRpbmF0 ZWRCYWNraW5nU3RvcmU6OnBhaW50VG9UZXh0dXJlTWFwcGVyKCkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9xdC9QbHVnaW5Qcm9jZXNzUHJveHlRdC5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9xdC9QbHVnaW5Qcm9jZXNzUHJveHlR dC5jcHAKaW5kZXggNjc5YzYzMy4uOGI0ZTM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvcXQvUGx1Z2luUHJvY2Vzc1Byb3h5UXQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdpblByb2Nlc3NQcm94eVF0LmNwcApA QCAtMjA3LDcgKzIwNyw3IEBAIGJvb2wgUGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1Z2luKGNv bnN0IFN0cmluZyYgcGx1Z2luUGF0aCwgUmF3UGx1Z2luTWV0YURhdGEmCiAKICAgICAgICAgU3Ry aW5nIG91dHB1dChyZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4ob3V0cHV0Qnl0ZXMuY29u c3REYXRhKCkpLCBvdXRwdXRCeXRlcy5zaXplKCkgLyBzaXplb2YoVUNoYXIpKTsKICAgICAgICAg VmVjdG9yPFN0cmluZz4gbGluZXM7Ci0gICAgICAgIG91dHB1dC5zcGxpdChVQ2hhcignXG4nKSwg bGluZXMpOworICAgICAgICBvdXRwdXQuc3BsaXQoVUNoYXIoJ1xuJyksIHRydWUsIGxpbmVzKTsK ICAgICAgICAgQVNTRVJUKGxpbmVzLnNpemUoKSA9PSAzKTsKIAogICAgICAgICByZXN1bHQubmFt ZS5zd2FwKGxpbmVzWzBdKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Q bHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCmluZGV4IGQy NGMzOTEuLjczMGRhZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcApAQCAtOTYs NyArOTYsNyBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbihjb25zdCBTdHJp bmcmIHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRhJgogICAgIGZyZWUoc3RkT3V0KTsKIAog ICAgIFZlY3RvcjxTdHJpbmc+IGxpbmVzOwotICAgIHN0ZE91dFN0cmluZy5zcGxpdChVQ2hhcign XG4nKSwgbGluZXMpOworICAgIHN0ZE91dFN0cmluZy5zcGxpdChVQ2hhcignXG4nKSwgdHJ1ZSwg bGluZXMpOwogCiAgICAgaWYgKGxpbmVzLnNpemUoKSA8IDMpCiAgICAgICAgIHJldHVybiBmYWxz ZTsK