103211 2012-11-25 20:01:11 -0800 [Refactoring] Some Node::isDescendant call can be replaced with Node::contains() 2012-11-26 02:22:43 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita dbates ojan webkit.review.bot oldest_to_newest 775101 0 morrita 2012-11-25 20:01:11 -0800 There are some obvious duplications. 775106 1 175917 morrita 2012-11-25 20:15:25 -0800 Created attachment 175917 Patch 775109 2 175917 dbates 2012-11-25 20:22:20 -0800 Comment on attachment 175917 Patch r=me 775279 3 175917 webkit.review.bot 2012-11-26 02:22:39 -0800 Comment on attachment 175917 Patch Clearing flags on attachment: 175917 Committed r135695: <http://trac.webkit.org/changeset/135695> 775280 4 webkit.review.bot 2012-11-26 02:22:43 -0800 All reviewed patches have been landed. Closing bug. 175917 2012-11-25 20:15:25 -0800 2012-11-26 02:22:39 -0800 Patch bug-103211-20121126131304.patch text/plain 2285 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM4NTc1MjIwZWQwNzc2 ZGMyZWIzNThkZjY2MWJlMGMzY2I2N2Q5MC4uMjdmZTllZDEwMWVhMmUyNzc1NGZhNzk3ZjY3MjBm ZjRhZGYyMjBkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTI1ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd IFNvbWUgTm9kZTo6aXNEZXNjZW5kYW50IGNhbGxzIGNhbiBiZSByZXBsYWNlZCB3aXRoIE5vZGU6 OmNvbnRhaW5zKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMzIxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEEgY291cGxlIG9mIGNhbGwgc2l0ZXMgb2YgaXNEZXNjZW5kYW50KCkgZG9lcyBzYW1lIGFz IE5vZGU6OmNvbnRhaW5zKCkuCisgICAgICAgIFRoaXMgY2hhbmdlIHJlcGxhY2VzIHRoZXNlIGxv Y2F0aW9ucyB3aXRoIE5vZGU6OmNvbnRhaW5zKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjaGVja0FjY2VwdENoaWxkKToKKyAgICAgICAgKiBkb20vUmFuZ2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmFuZ2U6OnN1cnJvdW5kQ29udGVudHMpOgorCiAyMDEyLTExLTI1ICBL ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZWZhY3RvcmluZzog TW92ZSB0aGUgY29udGVudCBvZiBIVE1MSW5wdXRFbGVtZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCB0 byBUZXh0RmllbGRJbnB1dFR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCAyYWQzMmU3M2E1MjhjZDdi YWVkMjY0ODc4YmQ0NjE0YzVlMzAxMjIwLi5kZTdmYjkyNTRlMmViOWUyODA0MTZhOWEyYmU1ZTNl NGMwNGE3Njc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0xMTkzLDcgKzExOTMsNyBAQCBzdGF0aWMg dm9pZCBjaGVja0FjY2VwdENoaWxkKE5vZGUqIG5ld1BhcmVudCwgTm9kZSogbmV3Q2hpbGQsIEV4 Y2VwdGlvbkNvZGUmIGVjKQogICAgIC8vIEhJRVJBUkNIWV9SRVFVRVNUX0VSUjogUmFpc2VkIGlm IHRoaXMgbm9kZSBpcyBvZiBhIHR5cGUgdGhhdCBkb2VzIG5vdCBhbGxvdyBjaGlsZHJlbiBvZiB0 aGUgdHlwZSBvZiB0aGUKICAgICAvLyBuZXdDaGlsZCBub2RlLCBvciBpZiB0aGUgbm9kZSB0byBh cHBlbmQgaXMgb25lIG9mIHRoaXMgbm9kZSdzIGFuY2VzdG9ycy4KIAotICAgIGlmIChuZXdDaGls ZCA9PSBuZXdQYXJlbnQgfHwgbmV3UGFyZW50LT5pc0Rlc2NlbmRhbnRPZihuZXdDaGlsZCkpIHsK KyAgICBpZiAobmV3Q2hpbGQtPmNvbnRhaW5zKG5ld1BhcmVudCkpIHsKICAgICAgICAgZWMgPSBI SUVSQVJDSFlfUkVRVUVTVF9FUlI7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vUmFuZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1Jhbmdl LmNwcAppbmRleCBjNzFmYTFjZDk1ZWNhY2EzZDJjYTEwZjAzNTcxNzAxYWMzNDZmMGE2Li5jYzA2 ODQ1ODNlZDc3ZmMyZTg0YThmMTkzZTFkNzc5OTIwOTMzZDk5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vUmFuZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9SYW5nZS5jcHAK QEAgLTE0NDcsNyArMTQ0Nyw3IEBAIHZvaWQgUmFuZ2U6OnN1cnJvdW5kQ29udGVudHMoUGFzc1Jl ZlB0cjxOb2RlPiBwYXNzTmV3UGFyZW50LCBFeGNlcHRpb25Db2RlJiBlYykKICAgICAgICAgcmV0 dXJuOwogICAgIH0KICAgICAKLSAgICBpZiAobV9zdGFydC5jb250YWluZXIoKSA9PSBuZXdQYXJl bnQgfHwgbV9zdGFydC5jb250YWluZXIoKS0+aXNEZXNjZW5kYW50T2YobmV3UGFyZW50LmdldCgp KSkgeworICAgIGlmIChuZXdQYXJlbnQtPmNvbnRhaW5zKG1fc3RhcnQuY29udGFpbmVyKCkpKSB7 CiAgICAgICAgIGVjID0gSElFUkFSQ0hZX1JFUVVFU1RfRVJSOwogICAgICAgICByZXR1cm47CiAg ICAgfQo=