103199 2012-11-25 09:46:15 -0800 [BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes 2012-11-26 08:33:21 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos japhet webkit.review.bot oldest_to_newest 775000 0 staikos 2012-11-25 09:46:15 -0800 The cookie jar is making some bad assumptions about when it will be called, accessing document/frame/page/etc for apparently no good reason. Delete all this code. 775001 1 175885 staikos 2012-11-25 09:56:33 -0800 Created attachment 175885 Patch to delete a lot of the code and start unforking 775481 2 175885 yong.li.webkit 2012-11-26 07:54:25 -0800 Comment on attachment 175885 Patch to delete a lot of the code and start unforking r+ 775504 3 175885 webkit.review.bot 2012-11-26 08:33:18 -0800 Comment on attachment 175885 Patch to delete a lot of the code and start unforking Clearing flags on attachment: 175885 Committed r135729: <http://trac.webkit.org/changeset/135729> 775505 4 webkit.review.bot 2012-11-26 08:33:21 -0800 All reviewed patches have been landed. Closing bug. 175885 2012-11-25 09:56:33 -0800 2012-11-26 08:33:17 -0800 Patch to delete a lot of the code and start unforking 103199.patch text/plain 2572 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTY2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTI1ICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIGEgbG90IG9mIHVubmVjZXNzYXJ5IGFuZCBpbmNvcnJlY3QgY29kZSBjYXVzaW5nIGNyYXNo ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE5 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aXMgdGhlIGZpcnN0IGJpZyBzdGVwIHRvIHVuZm9ya2luZyB0aGlzIGNvZGUuICBJdCdzIHZlcnkg Y2xvc2UgdG8KKyAgICAgICAgd2hlcmUgaXQgbmVlZHMgdG8gYmUgbm93LCBidXQgdGhlIGZpcnN0 IHN0ZXAgaXMgdG8gZ2V0IHJpZCBvZiB0aGUKKyAgICAgICAgY3Jhc2hlcyBieSBkZWxldGluZyBj b2RlIHRoYXQgaXNuJ3QgbmVlZGVkIGFuZCBtYWtlcyBiYWQgYXNzdW1wdGlvbnMKKyAgICAgICAg YWJvdXQgb2JqZWN0IGxpZmV0aW1lLiAgQ3Jhc2hlcyB3ZXJlIGZvdW5kIGJ5IGF1dG9tYXRpb24g d2l0aG91dAorICAgICAgICB0ZXN0IGNhc2Ugb3IgcmVwcm9kdWN0aW9uIHN0ZXBzLgorCisgICAg ICAgICogbG9hZGVyL2JsYWNrYmVycnkvQ29va2llSmFyQmxhY2tCZXJyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjb29raWVzKTogZGVsZXRlIG1vc3QgY29kZQorICAgICAgICAoV2ViQ29yZTo6 c2V0Q29va2llcyk6IGRlbGV0ZSBtb3N0IGNvZGUKKwogMjAxMi0xMS0yNCAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSByZW5kZXJlciBjb25zdHJ1Y3Rp b24gbGVzcyBnZW5lcmljCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvYmxhY2tiZXJyeS9D b29raWVKYXJCbGFja0JlcnJ5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvYmxhY2tiZXJyeS9Db29raWVKYXJCbGFja0JlcnJ5LmNwcAkocmV2aXNpb24gMTM1NjY4KQor KysgU291cmNlL1dlYkNvcmUvbG9hZGVyL2JsYWNrYmVycnkvQ29va2llSmFyQmxhY2tCZXJyeS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDM4ICszOSwxNSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIFN0cmluZyBjb29raWVzKERvY3VtZW50IGNvbnN0KiBkb2N1bWVudCwgS1VSTCBjb25zdCYg dXJsKQogewotICAgIEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50LT5mcmFtZSgpOwotICAgIFBhZ2Uq IHBhZ2UgPSBmcmFtZSA/IGZyYW1lLT5wYWdlKCkgOiAwOwotCi0gICAgaWYgKCFwYWdlKQotICAg ICAgICByZXR1cm4gU3RyaW5nKCk7Ci0KLSAgICBpZiAoIShmcmFtZSAmJiBmcmFtZS0+bG9hZGVy KCkgJiYgZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSkpCi0gICAgICAgIHJldHVybiBTdHJpbmco KTsKLQotICAgIGlmICghc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4o ZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPmNvb2tpZXNFbmFibGVkKCkpCi0gICAgICAgIHJl dHVybiBTdHJpbmcoKTsKLQotICAgIEFTU0VSVChkb2N1bWVudCAmJiB1cmwgPT0gZG9jdW1lbnQt PmNvb2tpZVVSTCgpKTsKICAgICAvLyAnSHR0cE9ubHknIGNvb2tpZXMgc2hvdWxkIG5vIGJlIGFj Y2Vzc2libGUgZnJvbSBzY3JpcHRzLCBzbyB3ZSBmaWx0ZXIgdGhlbSBvdXQgaGVyZQogICAgIHJl dHVybiBjb29raWVNYW5hZ2VyKCkuZ2V0Q29va2llKHVybCwgTm9IdHRwT25seUNvb2tpZSk7CiB9 CiAKIHZvaWQgc2V0Q29va2llcyhEb2N1bWVudCogZG9jdW1lbnQsIEtVUkwgY29uc3QmIHVybCwg U3RyaW5nIGNvbnN0JiB2YWx1ZSkKIHsKLSAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudC0+ZnJh bWUoKTsKLSAgICBQYWdlKiBwYWdlID0gZnJhbWUgPyBmcmFtZS0+cGFnZSgpIDogMDsKLQotICAg IGlmICghcGFnZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKCEoZnJhbWUgJiYgZnJhbWUt PmxvYWRlcigpICYmIGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkpKQotICAgICAgICByZXR1cm47 Ci0KLSAgICBpZiAoIXN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeSo+KGZy YW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkpLT5jb29raWVzRW5hYmxlZCgpKQorICAgIGlmICghZG9j dW1lbnQtPnNldHRpbmdzKCktPmNvb2tpZUVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgQVNTRVJUKGRvY3VtZW50ICYmIHVybCA9PSBkb2N1bWVudC0+Y29va2llVVJMKCkpOwogICAg IGNvb2tpZU1hbmFnZXIoKS5zZXRDb29raWVzKHVybCwgdmFsdWUsIE5vSHR0cE9ubHlDb29raWUp OwogfQogCg==