103194 2012-11-24 18:39:05 -0800 [GTK] Broken build with undefined references to shm_open / shm_unlink 2013-09-09 05:16:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned cgarcia dbates dominique-webkit.org mrobinson webkit.review.bot oldest_to_newest 774922 0 kalevlember 2012-11-24 18:39:05 -0800 Building webkitgtk-1.11.2 for rawhide (Fedora 19): CXXLD Programs/WebKitPluginProcess /usr/bin/ld: Source/WebKit2/Platform/unix/Programs_WebKitPluginProcess-SharedMemoryUnix.o: undefined reference to symbol 'shm_unlink@@GLIBC_2.2.5' /usr/bin/ld: note: 'shm_unlink@@GLIBC_2.2.5' is defined in DSO /usr/lib64/librt.so.1 so try adding it to the linker command line /usr/lib64/librt.so.1: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status 774924 1 175871 kalevlember 2012-11-24 18:42:13 -0800 Created attachment 175871 Patch 774985 2 175871 mrobinson 2012-11-25 08:45:22 -0800 Comment on attachment 175871 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175871&action=review > configure.ac:1128 > + save_LIBS="$LIBS" > + AC_SEARCH_LIBS([shm_open], [rt], [SHM_LIBS="-lrt"]) > + AC_SUBST(SHM_LIBS) > + LIBS="$save_LIBS" What's going on here with save_LIBS? 774993 3 kalevlember 2012-11-25 09:00:29 -0800 AC_CHECK_LIB and AC_SEARCH_LIBS write the result to the LIBS variable and I didn't want to clobber the contents of the variable here. I'm using save_LIBS to restore the original LIBS after calling AC_SEARCH_LIBS(). Perhaps it doesn't make much of a difference right here and right now, but it can avoid surprises in the future. I guess the macros were written with small build systems in mind where only one LIBS variable is sufficient; in webkitgtk with several libraries and executables produced, it seems better to avoid using the global LIBS variable. For what it's worth, cairo does the same thing with save_LIBS: http://cgit.freedesktop.org/cairo/tree/configure.ac#n796 774996 4 kalevlember 2012-11-25 09:04:40 -0800 Or would it be better to do something like this? (untested) save_LIBS="$LIBS" LIBS='' AC_SEARCH_LIBS([shm_open], [rt]) SHM_LIBS="$LIBS" AC_SUBST(SHM_LIBS) LIBS="$save_LIBS" 775529 5 mrobinson 2012-11-26 09:01:26 -0800 My preference is that we use this work-around for all instances of AC_SEARCH_LIBS or none of them. So far we haven't had an issue with it. Perhaps we can avoid it here and just be careful not to use a variable named LIBS? Let me know if I'm misunderstanding you. 775538 6 176015 kalevlember 2012-11-26 09:11:41 -0800 Created attachment 176015 Patch v2 Fair enough, uploaded a new version with the save_LIBS workaround removed. I agree, should be fine as long as we avoid using LIBS. 775539 7 176015 mrobinson 2012-11-26 09:13:03 -0800 Comment on attachment 176015 Patch v2 Thanks for fixing this! 775610 8 176015 webkit.review.bot 2012-11-26 10:14:02 -0800 Comment on attachment 176015 Patch v2 Rejecting attachment 176015 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ls/Scripts/update-webkit line 108. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 hile loading dependencies of All.gyp while trying to load All.gyp Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 512 at Tools/Scripts/update-webkit-chromium line 96. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' No such file or directory at Tools/Scripts/update-webkit line 108. Full output: http://queues.webkit.org/results/14986694 775861 9 176015 mrobinson 2012-11-26 14:00:55 -0800 Comment on attachment 176015 Patch v2 Clearing flags on attachment: 176015 Committed r135761: <http://trac.webkit.org/changeset/135761> 775862 10 mrobinson 2012-11-26 14:00:58 -0800 All reviewed patches have been landed. Closing bug. 926657 11 berto 2013-09-09 05:16:10 -0700 *** Bug 104118 has been marked as a duplicate of this bug. *** 175871 2012-11-24 18:42:13 -0800 2012-11-26 09:11:41 -0800 Patch 0001-GTK-Explicitly-link-against-librt.patch text/plain 2912 kalevlember RnJvbSBkZjQzNjQzOTVkOGY2OWNiZjhlOGU0NzNhNTlkYjRkNTNlMTJhMTJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAyNSBOb3YgMjAxMiAwMzoyNjo0MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFtH VEtdIEV4cGxpY2l0bHkgbGluayBhZ2FpbnN0IGxpYnJ0CgpGaXhlcyBicm9rZW4gYnVpbGQgd2l0 aCB1bmRlZmluZWQgcmVmZXJlbmNlcyB0byBzaG1fb3BlbiAvIHNobV91bmxpbmsKc3ltYm9scy4g U2hhcmVkTWVtb3J5VW5peC5jcHAgdXNlcyB0aGVzZSBzbyB3ZSBuZWVkIHRvIGxpbmsgd2l0aCAt bHJ0LgotLS0KIENoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysr CiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICB8IDEyICsrKysrKysrKysrKwogU291cmNl L1dlYktpdDIvR05VbWFrZWZpbGUuYW0gfCAgMSArCiBjb25maWd1cmUuYWMgICAgICAgICAgICAg ICAgICB8ICA5ICsrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDU0N2RkZjUuLmFkNWIzODIg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMi0xMS0yNCAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgorCisgICAg ICAgIFtHVEtdIEV4cGxpY2l0bHkgbGluayBhZ2FpbnN0IGxpYnJ0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMxOTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBicm9rZW4gYnVpbGQgd2l0aCB1 bmRlZmluZWQgcmVmZXJlbmNlcyB0byBzaG1fb3BlbiAvIHNobV91bmxpbmsKKyAgICAgICAgc3lt Ym9scy4gU2hhcmVkTWVtb3J5VW5peC5jcHAgdXNlcyB0aGVzZSBzbyB3ZSBuZWVkIHRvIGxpbmsg d2l0aCAtbHJ0LgorCisgICAgICAgICogY29uZmlndXJlLmFjOgorCiAyMDEyLTExLTIzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NTUzMgQmFja2dyb3Vu ZHMgYW5kIEJvcmRlcnNdIEltcGxlbWVudCBuZXcgQ1NTMyBiYWNrZ3JvdW5kLXBvc2l0aW9uIHBh cnNpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2E4MGM4Mi4uOTdiYTUxYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTExLTI0ICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJlckBnbWFpbC5j b20+CisKKyAgICAgICAgW0dUS10gRXhwbGljaXRseSBsaW5rIGFnYWluc3QgbGlicnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE5NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGJyb2tlbiBi dWlsZCB3aXRoIHVuZGVmaW5lZCByZWZlcmVuY2VzIHRvIHNobV9vcGVuIC8gc2htX3VubGluawor ICAgICAgICBzeW1ib2xzLiBTaGFyZWRNZW1vcnlVbml4LmNwcCB1c2VzIHRoZXNlIHNvIHdlIG5l ZWQgdG8gbGluayB3aXRoIC1scnQuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAx Mi0xMS0yNCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNv bT4KIAogICAgICAgICBbRUZMXVtXSzJdIENoZWNrIGVycm9ycyBpbiBFd2tWaWV3IGNhbGxiYWNr cyB1c2FnZSBhdCBjb21waWxlIHRpbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0dOVW1h a2VmaWxlLmFtIGIvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KaW5kZXggOWEwMmJiZC4u Yzc3NTk5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KKysrIGIv U291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KQEAgLTU3Miw2ICs1NzIsNyBAQCBQcm9ncmFt c19XZWJLaXRQbHVnaW5Qcm9jZXNzX0xEQUREICs9IFwKIAkkKFBBTkdPX0xJQlMpIFwKIAkkKFBO R19MSUJTKSBcCiAJJChTSExXQVBJX0xJQlMpIFwKKwkkKFNITV9MSUJTKSBcCiAJJChTUUxJVEUz X0xJQlMpIFwKIAkkKFVOSUNPREVfTElCUykgXAogCSQoWFJFTkRFUl9MSUJTKSBcCmRpZmYgLS1n aXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggNGUxZjBlOC4uMWZhOTlmMCAx MDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtMTExOCw2ICsx MTE4LDE1IEBAIGlmIHRlc3QgIiRlbmFibGVfd2Via2l0MiIgPSAieWVzIjsgdGhlbgogICAgaWYg dGVzdCAiJGhhdmVfZ3RrX3VuaXhfcHJpbnRpbmciID0gInllcyI7IHRoZW4KICAgICAgICBBQ19E RUZJTkUoW0hBVkVfR1RLX1VOSVhfUFJJTlRJTkddLCBbMV0sIFtEZWZpbmUgaWYgR1RLKyBVTklY IFByaW50aW5nIGlzIGF2YWlsYWJsZV0pCiAgICBmaQorCisgICAjIE9uIHNvbWUgTGludXgvVW5p eCBwbGF0Zm9ybXMsIHNobV8qIG1heSBvbmx5IGJlIGF2YWlsYWJsZSBpZiBsaW5raW5nCisgICAj IGFnYWluc3QgbGlicnQKKyAgIGlmIHRlc3QgIiRvc193aW4zMiIgPSAibm8iOyB0aGVuCisgICAg ICAgc2F2ZV9MSUJTPSIkTElCUyIKKyAgICAgICBBQ19TRUFSQ0hfTElCUyhbc2htX29wZW5dLCBb cnRdLCBbU0hNX0xJQlM9Ii1scnQiXSkKKyAgICAgICBBQ19TVUJTVChTSE1fTElCUykKKyAgICAg ICBMSUJTPSIkc2F2ZV9MSUJTIgorICAgZmkKIGZpCiAKICMgUGx1Z2luIFByb2Nlc3MKLS0gCjEu OC4wCgo= 176015 2012-11-26 09:11:41 -0800 2012-11-26 14:00:55 -0800 Patch v2 0001-GTK-Explicitly-link-against-librt.patch text/plain 2906 kalevlember RnJvbSAzYzQ5OWFhMmE3MGIwNmI0MGE2NGZiNTY5OTYyMmZmNDU4ZTRlZTBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAyNSBOb3YgMjAxMiAwMzoyNjo0MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFtH VEtdIEV4cGxpY2l0bHkgbGluayBhZ2FpbnN0IGxpYnJ0CgpGaXhlcyBicm9rZW4gYnVpbGQgd2l0 aCB1bmRlZmluZWQgcmVmZXJlbmNlcyB0byBzaG1fb3BlbiAvIHNobV91bmxpbmsKc3ltYm9scy4g U2hhcmVkTWVtb3J5VW5peC5jcHAgdXNlcyB0aGVzZSBzbyB3ZSBuZWVkIHRvIGxpbmsgd2l0aCAt bHJ0LgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE5NAotLS0K IENoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgICAgICB8IDEyICsrKysrKysrKysrKwogU291cmNlL1dlYktpdDIv R05VbWFrZWZpbGUuYW0gfCAgMSArCiBjb25maWd1cmUuYWMgICAgICAgICAgICAgICAgICB8ICA3 ICsrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1NDdkZGY1Li5hZDViMzgyIDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMjQg IEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXSBF eHBsaWNpdGx5IGxpbmsgYWdhaW5zdCBsaWJydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYnJva2VuIGJ1aWxkIHdpdGggdW5kZWZpbmVkIHJl ZmVyZW5jZXMgdG8gc2htX29wZW4gLyBzaG1fdW5saW5rCisgICAgICAgIHN5bWJvbHMuIFNoYXJl ZE1lbW9yeVVuaXguY3BwIHVzZXMgdGhlc2Ugc28gd2UgbmVlZCB0byBsaW5rIHdpdGggLWxydC4K KworICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAxMi0xMS0yMyAgQWxleGlzIE1lbmFyZCAg PGFsZXhpc0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtDU1MzIEJhY2tncm91bmRzIGFuZCBCb3Jk ZXJzXSBJbXBsZW1lbnQgbmV3IENTUzMgYmFja2dyb3VuZC1wb3NpdGlvbiBwYXJzaW5nLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCmluZGV4IGNhODBjODIuLjk3YmE1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMi0xMS0yNCAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgorCisgICAg ICAgIFtHVEtdIEV4cGxpY2l0bHkgbGluayBhZ2FpbnN0IGxpYnJ0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMxOTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBicm9rZW4gYnVpbGQgd2l0aCB1 bmRlZmluZWQgcmVmZXJlbmNlcyB0byBzaG1fb3BlbiAvIHNobV91bmxpbmsKKyAgICAgICAgc3lt Ym9scy4gU2hhcmVkTWVtb3J5VW5peC5jcHAgdXNlcyB0aGVzZSBzbyB3ZSBuZWVkIHRvIGxpbmsg d2l0aCAtbHJ0LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTItMTEtMjQgIE1p a2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAg ICAgW0VGTF1bV0syXSBDaGVjayBlcnJvcnMgaW4gRXdrVmlldyBjYWxsYmFja3MgdXNhZ2UgYXQg Y29tcGlsZSB0aW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbSBi L1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCmluZGV4IDlhMDJiYmQuLmM3NzU5OTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJL aXQyL0dOVW1ha2VmaWxlLmFtCkBAIC01NzIsNiArNTcyLDcgQEAgUHJvZ3JhbXNfV2ViS2l0UGx1 Z2luUHJvY2Vzc19MREFERCArPSBcCiAJJChQQU5HT19MSUJTKSBcCiAJJChQTkdfTElCUykgXAog CSQoU0hMV0FQSV9MSUJTKSBcCisJJChTSE1fTElCUykgXAogCSQoU1FMSVRFM19MSUJTKSBcCiAJ JChVTklDT0RFX0xJQlMpIFwKIAkkKFhSRU5ERVJfTElCUykgXApkaWZmIC0tZ2l0IGEvY29uZmln dXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDRlMWYwZTguLjk3OTgwZTQgMTAwNjQ0Ci0tLSBh L2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTExMTgsNiArMTExOCwxMyBAQCBp ZiB0ZXN0ICIkZW5hYmxlX3dlYmtpdDIiID0gInllcyI7IHRoZW4KICAgIGlmIHRlc3QgIiRoYXZl X2d0a191bml4X3ByaW50aW5nIiA9ICJ5ZXMiOyB0aGVuCiAgICAgICAgQUNfREVGSU5FKFtIQVZF X0dUS19VTklYX1BSSU5USU5HXSwgWzFdLCBbRGVmaW5lIGlmIEdUSysgVU5JWCBQcmludGluZyBp cyBhdmFpbGFibGVdKQogICAgZmkKKworICAgIyBPbiBzb21lIExpbnV4L1VuaXggcGxhdGZvcm1z LCBzaG1fKiBtYXkgb25seSBiZSBhdmFpbGFibGUgaWYgbGlua2luZworICAgIyBhZ2FpbnN0IGxp YnJ0CisgICBpZiB0ZXN0ICIkb3Nfd2luMzIiID0gIm5vIjsgdGhlbgorICAgICAgIEFDX1NFQVJD SF9MSUJTKFtzaG1fb3Blbl0sIFtydF0sIFtTSE1fTElCUz0iLWxydCJdKQorICAgICAgIEFDX1NV QlNUKFNITV9MSUJTKQorICAgZmkKIGZpCiAKICMgUGx1Z2luIFByb2Nlc3MKLS0gCjEuOC4wCgo=