103192 2012-11-24 15:55:45 -0800 [EFL] Refactor RenderThemeEfl::paintThemePart() 2012-11-24 18:53:09 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 774896 0 cdumez 2012-11-24 15:55:45 -0800 RenderThemeEfl::paintThemePart() could benefit from some refactoring: - Some C'ism should be removed - RTL code could be moved to its own method - evas_render() should be called instead of evas_render_updates() to avoid creating uselessly update rects. 774897 1 175868 cdumez 2012-11-24 16:01:22 -0800 Created attachment 175868 Patch 774925 2 175868 webkit.review.bot 2012-11-24 18:53:05 -0800 Comment on attachment 175868 Patch Clearing flags on attachment: 175868 Committed r135663: <http://trac.webkit.org/changeset/135663> 774926 3 webkit.review.bot 2012-11-24 18:53:09 -0800 All reviewed patches have been landed. Closing bug. 175868 2012-11-24 16:01:22 -0800 2012-11-24 18:53:05 -0800 Patch 103192_paintThemePart.patch text/plain 6316 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOWMwZTYwLi5jY2U1MjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTItMTEtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXSBSZWZhY3RvciBSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVt ZVBhcnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzMTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVmYWN0b3IgUmVuZGVyVGhlbWVFZmw6OnBhaW50VGhlbWVQYXJ0KCkgc28gdGhhdDoKKyAgICAg ICAgLSBTb21lIEMnaXNtIGlzIHJlbW92ZWQKKyAgICAgICAgLSBSVEwgcmVsYXRlZCBjb2RlIGlz IG1vdmVkIHRvIGFwcGx5RWRqZVJUTFN0YXRlKCkKKyAgICAgICAgLSBldmFzX3JlbmRlcigpIGlz IGNhbGxlZCBpbnN0ZWFkIG9mIGV2YXNfcmVuZGVyX3VwZGF0ZXMoKQorICAgICAgICAgIHRvIGF2 b2lkIGNyZWF0aW5nIHVzZWxlc3NseSB1cGRhdGUgcmVjdHMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UgZm9yIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU aGVtZUVmbDo6YXBwbHlFZGplUlRMU3RhdGUpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVtZVBhcnQpOgorICAgICAgICAqIHBs YXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oOgorICAgICAgICAoUmVuZGVyVGhlbWVFZmwpOgor CisyMDEyLTExLTI0ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5j b20+CisKICAgICAgICAgW0VGTF0gUmVmYWN0b3IgUmVuZGVyVGhlbWVFZmw6OmdldFRoZW1lUGFy dEZyb21DYWNoZSgpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDMxODYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Jl bmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVt ZUVmbC5jcHAKaW5kZXggZWJmNmM0Ni4uZGI0MWNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0zMTMsMzYgKzMxMywxNyBAQCB2b2lk IFJlbmRlclRoZW1lRWZsOjphcHBseUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiBvYmpl Y3QsIENvbnRyb2xTdGF0ZXMgcwogICAgIH0KIH0KIAotYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFp bnRUaGVtZVBhcnQoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFBh aW50SW5mbyYgaW5mbywgY29uc3QgSW50UmVjdCYgcmVjdCkKK3ZvaWQgUmVuZGVyVGhlbWVFZmw6 OmFwcGx5RWRqZVJUTFN0YXRlKEV2YXNfT2JqZWN0KiBlZGplLCBSZW5kZXJPYmplY3QqIG9iamVj dCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgSW50UmVjdCYgcmVjdCkKIHsKLSAgICBsb2FkVGhlbWVJ Zk5lZWRlZCgpOwotICAgIF9BU1NFUlRfT05fUkVMRUFTRV9SRVRVUk5fVkFMKGVkamUoKSwgZmFs c2UsICJDb3VsZCBub3QgcGFpbnQgbmF0aXZlIEhUTUwgcGFydCBkdWUgdG8gbWlzc2luZyB0aGVt ZS4iKTsKLQotICAgIFRoZW1lUGFydENhY2hlRW50cnkqIGVudHJ5OwotICAgIEVpbmFfTGlzdCog dXBkYXRlczsKLSAgICBjYWlyb190KiBjYWlybzsKLQotICAgIGVudHJ5ID0gZ2V0VGhlbWVQYXJ0 RnJvbUNhY2hlKHR5cGUsIHJlY3Quc2l6ZSgpKTsKLSAgICBpZiAoIWVudHJ5KQotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0KLSAgICBhcHBseUVkamVTdGF0ZUZyb21Gb3JtKGVudHJ5LT5lZGplKCks IGNvbnRyb2xTdGF0ZXNGb3JSZW5kZXJlcihvYmplY3QpKTsKLQotICAgIGNhaXJvID0gaW5mby5j b250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKTsKLSAgICBBU1NFUlQoY2Fpcm8pOwotCi0g ICAgLy8gQ3VycmVudGx5LCBvbmx5IHNsaWRlcnMgbmVlZHMgdGhpcyBtZXNzYWdlOyBpZiBvdGhl ciB3aWRnZXQgZXZlciBuZWVkcyBzcGVjaWFsCi0gICAgLy8gdHJlYXRtZW50LCBtb3ZlIHRoZW0g dG8gc3BlY2lhbCBmdW5jdGlvbnMuCiAgICAgaWYgKHR5cGUgPT0gU2xpZGVyVmVydGljYWwgfHwg dHlwZSA9PSBTbGlkZXJIb3Jpem9udGFsKSB7CiAgICAgICAgIGlmICghb2JqZWN0LT5pc1NsaWRl cigpKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7IC8vIHByb2JhYmx5IGhhdmUgLXdlYmtpdC1h cHBlYXJhbmNlOiBzbGlkZXIuLgorICAgICAgICAgICAgcmV0dXJuOyAvLyBwcm9iYWJseSBoYXZl IC13ZWJraXQtYXBwZWFyYW5jZTogc2xpZGVyLi4KIAogICAgICAgICBSZW5kZXJTbGlkZXIqIHJl bmRlclNsaWRlciA9IHRvUmVuZGVyU2xpZGVyKG9iamVjdCk7CiAgICAgICAgIEhUTUxJbnB1dEVs ZW1lbnQqIGlucHV0ID0gcmVuZGVyU2xpZGVyLT5ub2RlKCktPnRvSW5wdXRFbGVtZW50KCk7CiAg ICAgICAgIGRvdWJsZSB2YWx1ZVJhbmdlID0gaW5wdXQtPm1heGltdW0oKSAtIGlucHV0LT5taW5p bXVtKCk7CiAKLSAgICAgICAgT3duQXJyYXlQdHI8Y2hhcj4gYnVmZmVyID0gYWRvcHRBcnJheVB0 cihuZXcgY2hhcltzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZG91Ymxl KV0pOwotICAgICAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtc2cgPSBuZXcoYnVmZmVyLmdl dCgpKSBFZGplX01lc3NhZ2VfRmxvYXRfU2V0OworICAgICAgICBPd25QdHI8RWRqZV9NZXNzYWdl X0Zsb2F0X1NldD4gbXNnID0gYWRvcHRQdHIoc3RhdGljX2Nhc3Q8RWRqZV9NZXNzYWdlX0Zsb2F0 X1NldCo+KG9wZXJhdG9yIG5ldyAoc2l6ZW9mKEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6 ZW9mKGRvdWJsZSkpKSk7CiAgICAgICAgIG1zZy0+Y291bnQgPSAyOwogCiAgICAgICAgIC8vIFRo ZSBmaXJzdCBwYXJhbWV0ZXIgb2YgdGhlIG1lc3NhZ2UgZGVjaWRlcyBpZiB0aGUgcHJvZ3Jlc3Mg YmFyCkBAIC0zNTUsNyArMzM2LDcgQEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVtZVBh cnQoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFAKICAgICAgICAg ICAgIG1zZy0+dmFsWzBdID0gMDsKIAogICAgICAgICBtc2ctPnZhbFsxXSA9IChpbnB1dC0+dmFs dWVBc051bWJlcigpIC0gaW5wdXQtPm1pbmltdW0oKSkgLyB2YWx1ZVJhbmdlOwotICAgICAgICBl ZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPmVkamUoKSwgRURKRV9NRVNTQUdFX0ZMT0FU X1NFVCwgMCwgbXNnKTsKKyAgICAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9zZW5kKGVkamUsIEVE SkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAsIG1zZy5nZXQoKSk7CiAjaWYgRU5BQkxFKFBST0dSRVNT X0VMRU1FTlQpCiAgICAgfSBlbHNlIGlmICh0eXBlID09IFByb2dyZXNzQmFyKSB7CiAgICAgICAg IFJlbmRlclByb2dyZXNzKiByZW5kZXJQcm9ncmVzcyA9IHRvUmVuZGVyUHJvZ3Jlc3Mob2JqZWN0 KTsKQEAgLTM2Myw4ICszNDQsNyBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFy dChSZW5kZXJPYmplY3QqIG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogICAgICAgICBp bnQgbWF4ID0gcmVjdC53aWR0aCgpOwogICAgICAgICBkb3VibGUgdmFsdWUgPSByZW5kZXJQcm9n cmVzcy0+cG9zaXRpb24oKTsKIAotICAgICAgICBPd25BcnJheVB0cjxjaGFyPiBidWZmZXIgPSBh ZG9wdEFycmF5UHRyKG5ldyBjaGFyW3NpemVvZihFZGplX01lc3NhZ2VfRmxvYXRfU2V0KSArIHNp emVvZihkb3VibGUpXSk7Ci0gICAgICAgIEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqIG1zZyA9IG5l dyhidWZmZXIuZ2V0KCkpIEVkamVfTWVzc2FnZV9GbG9hdF9TZXQ7CisgICAgICAgIE93blB0cjxF ZGplX01lc3NhZ2VfRmxvYXRfU2V0PiBtc2cgPSBhZG9wdFB0cihzdGF0aWNfY2FzdDxFZGplX01l c3NhZ2VfRmxvYXRfU2V0Kj4ob3BlcmF0b3IgbmV3IChzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0 X1NldCkgKyBzaXplb2YoZG91YmxlKSkpKTsKICAgICAgICAgbXNnLT5jb3VudCA9IDI7CiAKICAg ICAgICAgaWYgKG9iamVjdC0+c3R5bGUoKS0+ZGlyZWN0aW9uKCkgPT0gUlRMKQpAQCAtMzcyLDE0 ICszNTIsMzEgQEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVtZVBhcnQoUmVuZGVyT2Jq ZWN0KiBvYmplY3QsIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFAKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgbXNnLT52YWxbMF0gPSAwOwogICAgICAgICBtc2ctPnZhbFsxXSA9IHZhbHVlOwotICAg ICAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPmVkamUoKSwgRURKRV9NRVNTQUdF X0ZMT0FUX1NFVCwgMCwgbXNnKTsKKyAgICAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9zZW5kKGVk amUsIEVESkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAsIG1zZy5nZXQoKSk7CisjZWxzZQorICAgICAg ICBVTlVTRURfUEFSQU0ocmVjdCk7CiAjZW5kaWYKICAgICB9Cit9CisKK2Jvb2wgUmVuZGVyVGhl bWVFZmw6OnBhaW50VGhlbWVQYXJ0KFJlbmRlck9iamVjdCogb2JqZWN0LCBGb3JtVHlwZSB0eXBl LCBjb25zdCBQYWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCit7CisgICAgbG9h ZFRoZW1lSWZOZWVkZWQoKTsKKyAgICBfQVNTRVJUX09OX1JFTEVBU0VfUkVUVVJOX1ZBTChlZGpl KCksIGZhbHNlLCAiQ291bGQgbm90IHBhaW50IG5hdGl2ZSBIVE1MIHBhcnQgZHVlIHRvIG1pc3Np bmcgdGhlbWUuIik7CisKKyAgICBUaGVtZVBhcnRDYWNoZUVudHJ5KiBlbnRyeSA9IGdldFRoZW1l UGFydEZyb21DYWNoZSh0eXBlLCByZWN0LnNpemUoKSk7CisgICAgaWYgKCFlbnRyeSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworCisgICAgYXBwbHlFZGplU3RhdGVGcm9tRm9ybShlbnRyeS0+ZWRq ZSgpLCBjb250cm9sU3RhdGVzRm9yUmVuZGVyZXIob2JqZWN0KSk7CisgICAgYXBwbHlFZGplUlRM U3RhdGUoZW50cnktPmVkamUoKSwgb2JqZWN0LCB0eXBlLCByZWN0KTsKIAogICAgIGVkamVfb2Jq ZWN0X2NhbGNfZm9yY2UoZW50cnktPmVkamUoKSk7CiAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9z aWduYWxfcHJvY2VzcyhlbnRyeS0+ZWRqZSgpKTsKLSAgICB1cGRhdGVzID0gZXZhc19yZW5kZXJf dXBkYXRlcyhlY29yZV9ldmFzX2dldChlbnRyeS0+Y2FudmFzKCkpKTsKLSAgICBldmFzX3JlbmRl cl91cGRhdGVzX2ZyZWUodXBkYXRlcyk7CisgICAgZXZhc19yZW5kZXIoZWNvcmVfZXZhc19nZXQo ZW50cnktPmNhbnZhcygpKSk7CisKKyAgICBjYWlyb190KiBjYWlybyA9IGluZm8uY29udGV4dC0+ cGxhdGZvcm1Db250ZXh0KCktPmNyKCk7CisgICAgQVNTRVJUKGNhaXJvKTsKIAogICAgIGNhaXJv X3NhdmUoY2Fpcm8pOwogICAgIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjYWlybywgZW50cnkt PnN1cmZhY2UoKSwgcmVjdC54KCksIHJlY3QueSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKaW5kZXggNDUzMjk5ZS4uMzY0N2JjMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTIzMCw2ICsyMzAs NyBAQCBwcml2YXRlOgogICAgIHZvaWQgYXBwbHlQYXJ0RGVzY3JpcHRpb25zRnJvbShjb25zdCBT dHJpbmcmIHRoZW1lUGF0aCk7CiAKICAgICB2b2lkIGFwcGx5RWRqZVN0YXRlRnJvbUZvcm0oRXZh c19PYmplY3QqLCBDb250cm9sU3RhdGVzKTsKKyAgICB2b2lkIGFwcGx5RWRqZVJUTFN0YXRlKEV2 YXNfT2JqZWN0KiwgUmVuZGVyT2JqZWN0KiwgRm9ybVR5cGUsIGNvbnN0IEludFJlY3QmKTsKICAg ICBib29sIHBhaW50VGhlbWVQYXJ0KFJlbmRlck9iamVjdCosIEZvcm1UeXBlLCBjb25zdCBQYWlu dEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKICNpZiBFTkFCTEUoVklERU8pCg==