103190 2012-11-24 15:53:00 -0800 [BlackBerry] Find-on-page keeps stale pointer 2012-11-24 20:14:18 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 774894 0 andchen 2012-11-24 15:53:00 -0800 It keeps stale pointer of frame. If the frame is unloaded, searching on that frame would cause segmentation fault. 774901 1 175869 andchen 2012-11-24 17:12:46 -0800 Created attachment 175869 Patch 774903 2 175869 rwlbuis 2012-11-24 17:19:21 -0800 Comment on attachment 175869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175869&action=review LGTM. > Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:251 > + for (size_t i = 0; i < m_deferredScopingWork.size(); i++) { pre-increment is more efficient. 774927 3 175869 webkit.review.bot 2012-11-24 19:03:36 -0800 Comment on attachment 175869 Patch Rejecting attachment 175869 from commit-queue. New failing tests: svg/W3C-SVG-1.1/animate-elem-78-t.svg Full output: http://queues.webkit.org/results/14984154 774928 4 175869 webkit.review.bot 2012-11-24 20:14:14 -0800 Comment on attachment 175869 Patch Clearing flags on attachment: 175869 Committed r135664: <http://trac.webkit.org/changeset/135664> 774929 5 webkit.review.bot 2012-11-24 20:14:18 -0800 All reviewed patches have been landed. Closing bug. 175869 2012-11-24 17:12:46 -0800 2012-11-24 20:14:14 -0800 Patch bug-103190-20121124201027.patch text/plain 2257 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwYTc3MmIwOWExNzFmNDljYmVjMjYyOGU4YzIwYjlkNDJhZjk4Yzc0Li44YzA5MmMyYmJh NmFiNDkyNTEwZTkzZDYxZDk2ODIzYTAyYzc1ZmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yNCAgQW5keSBDaGVuICA8YW5kY2hlbkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGaW5kLW9uLXBhZ2Uga2VlcHMgc3RhbGUg cG9pbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzMTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RmluZCBvbiBwYWdlOiBwZW5kaW5nU2NvcGluZ0VmZm9ydCBzdG9yZXMgc3RhbGUgcG9pbnRlciB3 aGVuIGZyYW1lcyB1bmxvYWQsCisgICAgICAgIHdlIG5lZWQgdG8gY2FuY2VsIHRob3NlIHNjb3Bp bmcgZWZmb3J0cy4KKyAgICAgICAgUFIgMjUwODA3LgorCisgICAgICAgIEludGVybmFsbHkgcmV2 aWV3ZWQgYnkgWW9uZ3hpbiBEYWkgYW5kIE1pa2UgRmVudG9uLgorCisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcDoKKyAgICAgICAgKEluUGFnZVNlYXJjaE1h bmFnZXI6OkRlZmVycmVkU2NvcGVTdHJpbmdNYXRjaGVzKToKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6SW5QYWdlU2VhcmNoTWFuYWdlcjo6ZnJhbWVVbmxvYWRlZCk6CisKIDIwMTItMTEt MjQgIEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnld IFRleHQgbm90IHNlbGVjdGVkIHdoZW4gaW5wdXQgZmllbGQgZm9jdXNlZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFn ZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5QYWdlU2Vh cmNoTWFuYWdlci5jcHAKaW5kZXggYjI0ZmRhM2E2OGRjOTlmNDQxMmU1YTMxNWNhYWRhNzFiODg3 NWUxZi4uZTY3M2IxYTBjNjIwZDNiNGJkY2I2M2NlYzlkYWJhMDBlN2RkZTVmMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFu YWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5Q YWdlU2VhcmNoTWFuYWdlci5jcHAKQEAgLTUzLDYgKzUzLDcgQEAgcHVibGljOgogICAgIH0KIAog cHJpdmF0ZToKKyAgICBmcmllbmQgY2xhc3MgSW5QYWdlU2VhcmNoTWFuYWdlcjsKICAgICB2b2lk IGRvVGltZW91dChUaW1lcjxEZWZlcnJlZFNjb3BlU3RyaW5nTWF0Y2hlcz4qKQogICAgIHsKICAg ICAgICAgbV9zZWFyY2hNYW5hZ2VyLT5jYWxsU2NvcGVTdHJpbmdNYXRjaGVzKHRoaXMsIG1fc2Nv cGluZ0ZyYW1lLCBtX3NlYXJjaFRleHQsIG1fcmVzZXQsIG1fbG9jYXRlQWN0aXZlTWF0Y2hPbmx5 KTsKQEAgLTI0Nyw2ICsyNDgsMTMgQEAgdm9pZCBJblBhZ2VTZWFyY2hNYW5hZ2VyOjpzZXRBY3Rp dmVNYXRjaEFuZE1hcmtlcihQYXNzUmVmUHRyPFJhbmdlPiByYW5nZSkKIAogdm9pZCBJblBhZ2VT ZWFyY2hNYW5hZ2VyOjpmcmFtZVVubG9hZGVkKGNvbnN0IEZyYW1lKiBmcmFtZSkKIHsKKyAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZGVmZXJyZWRTY29waW5nV29yay5zaXplKCk7IGkrKykg eworICAgICAgICBpZiAobV9kZWZlcnJlZFNjb3BpbmdXb3JrW2ldLT5tX3Njb3BpbmdGcmFtZSA9 PSBmcmFtZSkgeworICAgICAgICAgICAgLy8gQ2xlYXIgcGVuZGluZyBzY29waW5nIGVmZm9ydHMg aW4gY2FzZSBvZiBkYW5nbGluZyBwb2ludGVyLgorICAgICAgICAgICAgY2FuY2VsUGVuZGluZ1Nj b3BpbmdFZmZvcnQoKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgfQogICAg IGlmICghbV9hY3RpdmVNYXRjaCkgewogICAgICAgICBpZiAobV93ZWJQYWdlLT5tYWluRnJhbWUo KSA9PSBmcmFtZSAmJiBtX2FjdGl2ZVNlYXJjaFN0cmluZy5sZW5ndGgoKSkKICAgICAgICAgICAg IG1fYWN0aXZlU2VhcmNoU3RyaW5nID0gU3RyaW5nKCk7Cg==