103189 2012-11-24 14:45:48 -0800 [EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse() 2012-11-25 11:19:58 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103186 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 774888 0 cdumez 2012-11-24 14:45:48 -0800 ThemePartCacheEntry::reuse() does not currently check if the size and type changed before doing processing. This may lead to useless processing in case one of those (size or type) did not change. 774889 1 175866 cdumez 2012-11-24 14:55:50 -0800 Created attachment 175866 Patch 774890 2 175867 cdumez 2012-11-24 14:59:10 -0800 Created attachment 175867 Patch 774893 3 175867 mikhail.pozdnyakov 2012-11-24 15:08:06 -0800 Comment on attachment 175867 Patch LGTM 774933 4 175867 webkit.review.bot 2012-11-24 20:39:52 -0800 Comment on attachment 175867 Patch Rejecting attachment 175867 from commit-queue. New failing tests: svg/W3C-SVG-1.1/animate-elem-78-t.svg Full output: http://queues.webkit.org/results/14982191 774953 5 175867 cdumez 2012-11-25 00:48:38 -0800 Comment on attachment 175867 Patch This patch cannot affect chromium so it must be a false warning. Requesting cq? again. 775013 6 175867 webkit.review.bot 2012-11-25 11:19:53 -0800 Comment on attachment 175867 Patch Clearing flags on attachment: 175867 Committed r135673: <http://trac.webkit.org/changeset/135673> 775014 7 webkit.review.bot 2012-11-25 11:19:58 -0800 All reviewed patches have been landed. Closing bug. 175866 2012-11-24 14:55:50 -0800 2012-11-24 14:59:10 -0800 Patch 103189_theme_reuse.patch text/plain 2509 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOWMwZTYwLi4yMjNjNjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTItMTEtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXSBSZWZhY3RvciBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0 Q2FjaGVFbnRyeTo6cmV1c2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAzMTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hlY2sgaWYgdGhlIGVudHJ5IHNpemUgYW5kIHR5cGUgY2hhbmdlZCBpbgor ICAgICAgICBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0Q2FjaGVFbnRyeTo6cmV1c2UoKSB0byBh dm9pZAorICAgICAgICB1c2VsZXNzIHByb2Nlc3NpbmcgaWYgb25lIG9mIHRoZW0gZGlkIG5vdCBj aGFuZ2UuCisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgY2FsbCB0byBjYWlyb19zdXJmYWNlX2Zp bmlzaCgpIHNpbmNlCisgICAgICAgIHdlIGFyZSB1c2luZyBhIHNtYXJ0IHBvaW50ZXIgZm9yIHRo ZSBzdXJmYWNlLgorCisgICAgICAgIFJlc2l6ZSB0aGUgZWRnZSBvYmplY3QgKmFmdGVyKiBsb2Fk aW5nIGl0cyBjb250ZW50CisgICAgICAgIGZyb20gdGhlIHRoZW1lIGZpbGUgYXMgaXQgc2VlbXMg bW9yZSBsb2dpY2FsIHRoaXMKKyAgICAgICAgd2F5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVF Zmw6OlRoZW1lUGFydENhY2hlRW50cnk6OnJldXNlKToKKworMjAxMi0xMS0yNCAgQ2hyaXN0b3Bo ZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCiAgICAgICAgIFtFRkxdIFJl ZmFjdG9yIFJlbmRlclRoZW1lRWZsOjpnZXRUaGVtZVBhcnRGcm9tQ2FjaGUoKQogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTg2CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IGViZjZjNDYu LmY0MjkyNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJU aGVtZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1l RWZsLmNwcApAQCAtMjE2LDkgKzIxNiwxNSBAQCB2b2lkIFJlbmRlclRoZW1lRWZsOjpUaGVtZVBh cnRDYWNoZUVudHJ5OjpyZXVzZShjb25zdCBTdHJpbmcmIHRoZW1lUGF0aCwgRm9ybVR5cAogewog ICAgIEFTU0VSVCghdGhlbWVQYXRoLmlzRW1wdHkoKSk7CiAKLSAgICBpZiAoIW5ld1NpemUuaXNF bXB0eSgpKSB7Ci0gICAgICAgIGNhaXJvX3N1cmZhY2VfZmluaXNoKHN1cmZhY2UoKSk7CisgICAg aWYgKHR5cGUgIT0gbmV3VHlwZSkgeworICAgICAgICB0eXBlID0gbmV3VHlwZTsKKyAgICAgICAg aWYgKCFzZXRTb3VyY2VHcm91cEZvckVkamVPYmplY3QoZWRqZSgpLCB0aGVtZVBhdGgsIHRvRWRq ZUdyb3VwKG5ld1R5cGUpKSkgeworICAgICAgICAgICAgdHlwZSA9IEZvcm1UeXBlTGFzdDsgLy8g SW52YWxpZGF0ZS4KKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0KIAorICAg IGlmIChzaXplICE9IG5ld1NpemUpIHsKICAgICAgICAgc2l6ZSA9IG5ld1NpemU7CiAgICAgICAg IGVjb3JlX2V2YXNfcmVzaXplKGNhbnZhcygpLCBuZXdTaXplLndpZHRoKCksIG5ld1NpemUuaGVp Z2h0KCkpOwogICAgICAgICBldmFzX29iamVjdF9yZXNpemUoZWRqZSgpLCBuZXdTaXplLndpZHRo KCksIG5ld1NpemUuaGVpZ2h0KCkpOwpAQCAtMjI5LDEzICsyMzUsNiBAQCB2b2lkIFJlbmRlclRo ZW1lRWZsOjpUaGVtZVBhcnRDYWNoZUVudHJ5OjpyZXVzZShjb25zdCBTdHJpbmcmIHRoZW1lUGF0 aCwgRm9ybVR5cAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQotCi0gICAg aWYgKCFzZXRTb3VyY2VHcm91cEZvckVkamVPYmplY3QoZWRqZSgpLCB0aGVtZVBhdGgsIHRvRWRq ZUdyb3VwKG5ld1R5cGUpKSkgewotICAgICAgICB0eXBlID0gRm9ybVR5cGVMYXN0OyAvLyBJbnZh bGlkYXRlLgotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgdHlwZSA9IG5ld1R5cGU7CiB9 CiAKIFJlbmRlclRoZW1lRWZsOjpUaGVtZVBhcnRDYWNoZUVudHJ5KiBSZW5kZXJUaGVtZUVmbDo6 Z2V0VGhlbWVQYXJ0RnJvbUNhY2hlKEZvcm1UeXBlIHR5cGUsIGNvbnN0IEludFNpemUmIHNpemUp Cg== 175867 2012-11-24 14:59:10 -0800 2012-11-25 11:19:53 -0800 Patch 103189_theme_reuse.patch text/plain 3305 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOWMwZTYwLi5mMTI4Zjk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzAg QEAKIDIwMTItMTEtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXSBSZWZhY3RvciBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0 Q2FjaGVFbnRyeTo6cmV1c2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAzMTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hlY2sgaWYgdGhlIGVudHJ5IHNpemUgYW5kIHR5cGUgY2hhbmdlZCBpbgor ICAgICAgICBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0Q2FjaGVFbnRyeTo6cmV1c2UoKSB0byBh dm9pZAorICAgICAgICB1c2VsZXNzIHByb2Nlc3NpbmcgaWYgb25lIG9mIHRoZW0gZGlkIG5vdCBj aGFuZ2UuCisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgY2FsbCB0byBjYWlyb19zdXJmYWNlX2Zp bmlzaCgpIHNpbmNlCisgICAgICAgIHdlIGFyZSB1c2luZyBhIHNtYXJ0IHBvaW50ZXIgZm9yIHRo ZSBzdXJmYWNlLgorCisgICAgICAgIFJlc2l6ZSB0aGUgZWRnZSBvYmplY3QgKmFmdGVyKiBsb2Fk aW5nIGl0cyBjb250ZW50CisgICAgICAgIGZyb20gdGhlIHRoZW1lIGZpbGUgYXMgaXQgc2VlbXMg bW9yZSBsb2dpY2FsIHRoaXMKKyAgICAgICAgd2F5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVF Zmw6OlRoZW1lUGFydENhY2hlRW50cnk6OnJldXNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuaDoKKyAgICAgICAgKFRoZW1lUGFydENhY2hlRW50cnkpOgorCisyMDEy LTExLTI0ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisK ICAgICAgICAgW0VGTF0gUmVmYWN0b3IgUmVuZGVyVGhlbWVFZmw6OmdldFRoZW1lUGFydEZyb21D YWNoZSgpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDMxODYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRo ZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5j cHAKaW5kZXggZWJmNmM0Ni4uZjQyOTI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0yMTYsOSArMjE2LDE1IEBAIHZvaWQgUmVuZGVy VGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnk6OnJldXNlKGNvbnN0IFN0cmluZyYgdGhlbWVQ YXRoLCBGb3JtVHlwCiB7CiAgICAgQVNTRVJUKCF0aGVtZVBhdGguaXNFbXB0eSgpKTsKIAotICAg IGlmICghbmV3U2l6ZS5pc0VtcHR5KCkpIHsKLSAgICAgICAgY2Fpcm9fc3VyZmFjZV9maW5pc2go c3VyZmFjZSgpKTsKKyAgICBpZiAodHlwZSAhPSBuZXdUeXBlKSB7CisgICAgICAgIHR5cGUgPSBu ZXdUeXBlOworICAgICAgICBpZiAoIXNldFNvdXJjZUdyb3VwRm9yRWRqZU9iamVjdChlZGplKCks IHRoZW1lUGF0aCwgdG9FZGplR3JvdXAobmV3VHlwZSkpKSB7CisgICAgICAgICAgICB0eXBlID0g Rm9ybVR5cGVMYXN0OyAvLyBJbnZhbGlkYXRlLgorICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CisgICAgfQogCisgICAgaWYgKHNpemUgIT0gbmV3U2l6ZSkgewogICAgICAgICBzaXplID0g bmV3U2l6ZTsKICAgICAgICAgZWNvcmVfZXZhc19yZXNpemUoY2FudmFzKCksIG5ld1NpemUud2lk dGgoKSwgbmV3U2l6ZS5oZWlnaHQoKSk7CiAgICAgICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZShlZGpl KCksIG5ld1NpemUud2lkdGgoKSwgbmV3U2l6ZS5oZWlnaHQoKSk7CkBAIC0yMjksMTMgKzIzNSw2 IEBAIHZvaWQgUmVuZGVyVGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnk6OnJldXNlKGNvbnN0 IFN0cmluZyYgdGhlbWVQYXRoLCBGb3JtVHlwCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IH0KICAgICB9Ci0KLSAgICBpZiAoIXNldFNvdXJjZUdyb3VwRm9yRWRqZU9iamVjdChlZGplKCks IHRoZW1lUGF0aCwgdG9FZGplR3JvdXAobmV3VHlwZSkpKSB7Ci0gICAgICAgIHR5cGUgPSBGb3Jt VHlwZUxhc3Q7IC8vIEludmFsaWRhdGUuCi0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICB0 eXBlID0gbmV3VHlwZTsKIH0KIAogUmVuZGVyVGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnkq IFJlbmRlclRoZW1lRWZsOjpnZXRUaGVtZVBhcnRGcm9tQ2FjaGUoRm9ybVR5cGUgdHlwZSwgY29u c3QgSW50U2l6ZSYgc2l6ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9SZW5kZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRo ZW1lRWZsLmgKaW5kZXggNDUzMjk5ZS4uNDZlYzI4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTI2NSw3ICsyNjUsNyBAQCBwcml2YXRlOgog CiAgICAgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkgewogICAgICAgICBzdGF0aWMgUGFzc093 blB0cjxSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0Q2FjaGVFbnRyeT4gY3JlYXRlKGNvbnN0IFN0 cmluZyYgdGhlbWVQYXRoLCBGb3JtVHlwZSwgY29uc3QgSW50U2l6ZSYpOwotICAgICAgICB2b2lk IHJldXNlKGNvbnN0IFN0cmluZyYgdGhlbWVQYXRoLCBGb3JtVHlwZSwgY29uc3QgSW50U2l6ZSYg PSBJbnRTaXplKCkpOworICAgICAgICB2b2lkIHJldXNlKGNvbnN0IFN0cmluZyYgdGhlbWVQYXRo LCBGb3JtVHlwZSwgY29uc3QgSW50U2l6ZSYpOwogCiAgICAgICAgIEFMV0FZU19JTkxJTkUgRWNv cmVfRXZhcyogY2FudmFzKCkgeyByZXR1cm4gbV9jYW52YXMuZ2V0KCk7IH0KICAgICAgICAgQUxX QVlTX0lOTElORSBFdmFzX09iamVjdCogZWRqZSgpIHsgcmV0dXJuIG1fZWRqZS5nZXQoKTsgfQo=