103184 2012-11-24 11:32:25 -0800 Put computed style 'font-family' values in the CSSValuePool. 2014-08-19 16:13:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 103196 103218 1 kling kling cmarcelo kling macpherson menard ojan ossy webkit.review.bot oldest_to_newest 774865 0 kling 2012-11-24 11:32:25 -0800 They're already cached in the parsing stage so there's no sense in constructing new objects when exposing them through CSSComputedStyleDeclaration. 774868 1 175862 kling 2012-11-24 11:39:47 -0800 Created attachment 175862 Patch 774874 2 175862 webkit.review.bot 2012-11-24 12:32:12 -0800 Comment on attachment 175862 Patch Clearing flags on attachment: 175862 Committed r135656: <http://trac.webkit.org/changeset/135656> 774875 3 webkit.review.bot 2012-11-24 12:32:15 -0800 All reviewed patches have been landed. Closing bug. 774952 4 ossy 2012-11-25 00:39:56 -0800 (In reply to comment #2) > (From update of attachment 175862 [details]) > Clearing flags on attachment: 175862 > > Committed r135656: <http://trac.webkit.org/changeset/135656> It made 2 tests crash on Qt, see https://bugs.webkit.org/show_bug.cgi?id=103196 for details. 775185 5 webkit.review.bot 2012-11-25 23:40:59 -0800 Re-opened since this is blocked by bug 103218 1030141 6 kling 2014-08-19 16:13:12 -0700 This is not a valid optimization, since compute style values are exposed in CSSOM. 175862 2012-11-24 11:39:47 -0800 2012-11-24 12:32:12 -0800 Patch bug-103184.diff text/plain 2554 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODZjNjMwLi4yNjQwYzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTEtMjQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFB1dCBjb21wdXRlZCBzdHlsZSAnZm9udC1mYW1pbHknIHZhbHVlcyBpbiB0aGUgQ1NTVmFs dWVQb29sLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMDMxODQ+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIENTU1ZhbHVlUG9vbDo6 Y3JlYXRlRm9udEZhbWlseVZhbHVlKCkgd2hlbiBoYW5kaW5nIG91dCAnZm9udC1mYW1pbHknIHZh bHVlcyBmcm9tIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi4KKyAgICAgICAgVGhpcyBhdm9p ZHMgY3JlYXRpbmcgZXh0cmEgQ1NTUHJpbWl0aXZlVmFsdWUgb2JqZWN0cyBzaW5jZSB3ZSBhbHJl YWR5IGhhdmUgdGhlc2UgaW4gdGhlIHBvb2wgZnJvbSBwYXJzaW5nLgorICAgICAgICBBbHNvIGFk ZGVkIGEgbWF4IGNhcGFjaXR5IHRvIHRoZSBmb250LWZhbWlseSBjYWNoZSAodXNpbmcgcmFuZG9t IGV2aWN0aW9uLikKKworICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6dmFsdWVGb3JGYW1pbHkpOgorICAgICAgICAqIGNzcy9D U1NWYWx1ZVBvb2wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWVQb29sOjpjcmVhdGVG b250RmFtaWx5VmFsdWUpOgorCiAyMDEyLTExLTIzICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxv dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdG9yIG92ZXJs YXkgaXMgYWx3YXlzIHVwZGF0ZWQgd2hlbiBpbnNwZWN0b3IgaXMgb3BlbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCBiMTI3 YWE5Li44MmM4Zjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcApAQCAtMTIwOSw3ICsxMjA5LDcgQEAgc3RhdGljIFBhc3NSZWZQ dHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHZhbHVlRm9yRmFtaWx5KGNvbnN0IEF0b21pY1N0cmluZyYg ZmFtaWx5KQogewogICAgIGlmIChpbnQgZmFtaWx5SWRlbnRpZmllciA9IGlkZW50aWZpZXJGb3JG YW1pbHkoZmFtaWx5KSkKICAgICAgICAgcmV0dXJuIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlkZW50 aWZpZXJWYWx1ZShmYW1pbHlJZGVudGlmaWVyKTsKLSAgICByZXR1cm4gY3NzVmFsdWVQb29sKCku Y3JlYXRlVmFsdWUoZmFtaWx5LnN0cmluZygpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1NUUklO Ryk7CisgICAgcmV0dXJuIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUZvbnRGYW1pbHlWYWx1ZShmYW1p bHkuc3RyaW5nKCkpOwogfQogCiBzdGF0aWMgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gcmVuZGVyVGV4 dERlY29yYXRpb25GbGFnc1RvQ1NTVmFsdWUoaW50IHRleHREZWNvcmF0aW9uKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTVmFsdWVQb29sLmNwcAppbmRleCBjMTY4OTkxLi4wNjM2Yjk1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTVmFsdWVQb29sLmNwcApAQCAtMTEzLDYgKzExMywxMCBAQCBQYXNzUmVmUHRyPENTU1By aW1pdGl2ZVZhbHVlPiBDU1NWYWx1ZVBvb2w6OmNyZWF0ZVZhbHVlKGRvdWJsZSB2YWx1ZSwgQ1NT UHJpbWl0aQogCiBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBDU1NWYWx1ZVBvb2w6OmNy ZWF0ZUZvbnRGYW1pbHlWYWx1ZShjb25zdCBTdHJpbmcmIGZhbWlseU5hbWUpCiB7CisgICAgY29u c3QgaW50IG1heGltdW1Gb250RmFtaWx5Q2FjaGVTaXplID0gMTI4OworICAgIGlmIChtX2ZvbnRG YW1pbHlWYWx1ZUNhY2hlLnNpemUoKSA+PSBtYXhpbXVtRm9udEZhbWlseUNhY2hlU2l6ZSkKKyAg ICAgICAgbV9mb250RmFtaWx5VmFsdWVDYWNoZS5yZW1vdmUobV9mb250RmFtaWx5VmFsdWVDYWNo ZS5iZWdpbigpKTsKKwogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4mIHZhbHVlID0gbV9m b250RmFtaWx5VmFsdWVDYWNoZS5hZGQoZmFtaWx5TmFtZSwgMCkuaXRlcmF0b3ItPnZhbHVlOwog ICAgIGlmICghdmFsdWUpCiAgICAgICAgIHZhbHVlID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0 ZShmYW1pbHlOYW1lLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1NUUklORyk7Cg==